From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B1698A04BB; Tue, 6 Oct 2020 14:57:35 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BFCD91B686; Tue, 6 Oct 2020 14:57:33 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 4D0091B679 for ; Tue, 6 Oct 2020 14:57:32 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 096Ctjno002580; Tue, 6 Oct 2020 05:57:30 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0220; bh=fXiQsXjyjludPO1dTrcljZMGmDXfv9F3MVr28pl9RXY=; b=D29/QaQ1TR0ToZu8cAz7v+v6U2Ca5yrABVGSsPCNVMmkiGKYySQ3uqGQvL6qKHNCOkyZ tzDR9VyRmPsn1MkA2t2NWvuz7AL3vSHsuPmGQYSjuQQVAjdTK0sqX8zU5plamseDQPZ6 bBIzAxP7fbgsYM9s05Ui4M4Vbvj5hAtCHzpzue0cQA92Ea+GR91blupNPzqfP51uu54b LqVEWlP0xygszfOPNW1DAvKOj3tWOFzhCrrGEH9ykX9QuxzTDkG2wBEeru3olL3UW4ge sY+plVjEkK9rddgJDUtlD/Hd1Mt7brE3HSsqv0uw3KvvBYwGi5CSuuGbh8W/1ifFOvkd ug== Received: from sc-exch01.marvell.com ([199.233.58.181]) by mx0a-0016f401.pphosted.com with ESMTP id 33xpnpryuy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Tue, 06 Oct 2020 05:57:30 -0700 Received: from SC-EXCH03.marvell.com (10.93.176.83) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 6 Oct 2020 05:57:29 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.101) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Tue, 6 Oct 2020 05:57:29 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IOC+JmfR10uCvrkb3iY3IIf6X6JpkHXI2r5qNTqNRe9MOWajNrQJRCJdjD6GwLIiStuIn9qhJXtwnyLONH/uE+qpAPf1huoCbqtDeoN1L10OV+kolO9l75HHWuu61SAxtigFnY8i31DcfO7qhzXu2kvkscG0IQjXHurFzIkhk0ZgDvPBOvyhqlKR+XfbhgGUgfXcRHtzQEKd5L7iXmFAu9r/tPmGiZl5G5t8s4ubH04aI5iCBgDSfVh3LnQ0n7VjuFScMq0UMoe0q4bN5kPQeMEuVa1WXlyh+exrxIoRWXwU+SNIk1NkljghYIbHYc2GW78ZCba624QMLbaijzSemg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fXiQsXjyjludPO1dTrcljZMGmDXfv9F3MVr28pl9RXY=; b=BQ+fXWt1fPaa7a2Pr3hbY9EL/LPpSqth1bWko4OTNMISnU3DnIKgIBa5U0F74d8nXkHly6W+O4tdIxn1fBRTVZezVwjsFyFgKdjPvf+vtItQqgmj8Oxc1bzHE1wxuVS7Gmi0M4L/ry4yeT7ITd562au4AV/KuIXHndO8kY+aZc2bc3W+dICA+FLv581yfwkKX5PAkHzjMOu1jE7nlqCzCLbYvwTQf4LfJi5i8Twg8DQVBIGpwup4i6VBoRS+5CZzWWXzGkklnS+DQhJLl6XBlh7nL9nhie3nR9gBtPtKoRGVlDVCueY3JnxatAH7mTdjjUVmWF+6+M6Z6UeMpgbNzA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fXiQsXjyjludPO1dTrcljZMGmDXfv9F3MVr28pl9RXY=; b=hexg/S/iLuyGVnGugEem4m8c4UUTSv8FfPRP0EApK43v/xc7iszSPp7WP4ZuKPKHcsGK+DP6lJCzV8c2TaiT8QxyBlzxaYT0o4wVSzbCJ+8SRaFa4xmvJLOTRQfcM4bo700IsfjqpSGVzaz7L40Z+k4Sc4D5hFARDmRvgCSr1SI= Received: from DM5PR1801MB1884.namprd18.prod.outlook.com (2603:10b6:4:65::20) by DM6PR18MB3555.namprd18.prod.outlook.com (2603:10b6:5:2a2::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3433.35; Tue, 6 Oct 2020 12:57:28 +0000 Received: from DM5PR1801MB1884.namprd18.prod.outlook.com ([fe80::4413:c1f2:14ef:33a3]) by DM5PR1801MB1884.namprd18.prod.outlook.com ([fe80::4413:c1f2:14ef:33a3%7]) with mapi id 15.20.3455.021; Tue, 6 Oct 2020 12:57:27 +0000 From: Ankur Dwivedi To: "Gujjar, Abhinandan S" , "dev@dpdk.org" CC: Jerin Jacob Kollanukkaran , Anoob Joseph Thread-Topic: [PATCH v2 2/3] test/event_crypto_adapter: fix function arguments Thread-Index: AQHWkw2VqfIBtmuQI0SU/li80lQ8X6mKbuCAgAAq6tA= Date: Tue, 6 Oct 2020 12:57:27 +0000 Message-ID: References: <20200908091534.24305-1-adwivedi@marvell.com> <20200925072841.17578-1-adwivedi@marvell.com> <20200925072841.17578-3-adwivedi@marvell.com> In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=marvell.com; x-originating-ip: [47.15.1.112] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 5c28282e-1d7a-4e1b-1543-08d869f76108 x-ms-traffictypediagnostic: DM6PR18MB3555: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6430; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: GcwElSVDQbSc2cgUZnpcdiuq+8Sk9AFBfN6QffCLCKjCjEnvua+kJTdtAqK3GfKHjnU7/uAJOjT5RYaa/x4GRLkB3q0UgKXpklthcGEvtL2ehUSzj4Y63Nab0BDCjT58ykHgWN8E0klDrNlkdRUS3NTB6tGGmzEOj/vhJJS1OjEtLsAWauVaTNBqSHFtG2a7NQ4qPzmoU0xAS6H60bSlgmafuhJkUaJbhfVDN8bxsIGjdrRO67qn1Z5iF203av0ehLwnFw6WTymc6c9HkKcmDe3iVp2BuAyIyEIAtJc6O3RJW2fakSaO9ekvsr1d2Sz3RiOY8l1cdOHgoGwPg8b0aA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM5PR1801MB1884.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(366004)(346002)(136003)(39860400002)(396003)(7696005)(9686003)(478600001)(76116006)(8676002)(26005)(8936002)(4326008)(83380400001)(107886003)(316002)(2906002)(5660300002)(33656002)(55016002)(71200400001)(110136005)(54906003)(66446008)(64756008)(53546011)(86362001)(52536014)(6506007)(66476007)(186003)(66946007)(66556008); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: snXzCqHj9Gjb4KarLpwo4uGbvduX7t7nN8RtEnTptZEM2VaUYi5giK+qplEqz1yzSb+8HIJ3n4IryW4b0H+VwubDqfNJEY01tjM77oHY3q/4eSAMmiSvLS1h9WWKVVBndpWtKzyDvN+jKslfa7NHDlbzTuJlHgwmdEcD2hJs8CsJI3V82hL+1ReSVCVPk7gSoe5i9F4qMjq9aM4Q0OhKpD0EoS7ouQFxsjg0+945USMRcWgzfTCTS29Jo1wZt7EUnDDcqXuqOlsH8esogTfmq8I2aeK3qNJWwTLAtxWc/RoUMb4wN6jz/HQlgWUDUestEPxoTr2EPk2ieO/1W3tbV6lm/C+e+6wHZ0e0ArBwGeR6ToVznO0bj8bDYLqLtwS0lwwyScEAmJ9IMEIjbZNwlLZ+WUio7qT5Ac4+5rUfVdqcJTeibkU8BtJZMvEi3FVhjO/60kNI5yqZEnV6oSx1UdrxN1ik0292qeDZTTrPYbxawuJeaOwqLl7EQB3P1pV46ieJYodfAX/4aSu2qLeB7Lhyh3akaxAvmto4sRAd7i8PHFJ2JrStR3o1PxrW7ostvwDfARedUd0QGbRStyjWI9pLG4RsYQ5FAfpWvN/7lna8RSncrVNHmrPC6tFl2zoLnm0fMXZHNLOf3A6YEU7GVw== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR1801MB1884.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 5c28282e-1d7a-4e1b-1543-08d869f76108 X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Oct 2020 12:57:27.6574 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: OOAqMVMPwfW05LQdHiW7Yrn+SBJeem7mCmE/Ux6OLO5cLwPTKB9Lip2qcMTI6gPhfA1QDJyUdXjlWreDH+G2TQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR18MB3555 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235, 18.0.687 definitions=2020-10-06_05:2020-10-06, 2020-10-06 signatures=0 Subject: Re: [dpdk-dev] [PATCH v2 2/3] test/event_crypto_adapter: fix function arguments X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Abhinandan, Please see my comments inline. Thanks Ankur >-----Original Message----- >From: Gujjar, Abhinandan S >Sent: Tuesday, October 6, 2020 3:52 PM >To: Ankur Dwivedi ; dev@dpdk.org >Cc: Jerin Jacob Kollanukkaran ; Anoob Joseph > >Subject: [EXT] RE: [PATCH v2 2/3] test/event_crypto_adapter: fix function >arguments > >External Email > >---------------------------------------------------------------------- >Hi Ankur, > >Overall, it looks good. >You have missed out fixing caps args in one place line #299 of >test_sessionless_with_op_forward_mode(). [Ankur] I will fix this in v3. > >> -----Original Message----- >> From: Ankur Dwivedi >> Sent: Friday, September 25, 2020 12:59 PM >> To: dev@dpdk.org >> Cc: Gujjar, Abhinandan S ; >> jerinj@marvell.com; anoobj@marvell.com; Ankur Dwivedi >> >> Subject: [PATCH v2 2/3] test/event_crypto_adapter: fix function >> arguments >> >> The arguments passed to rte_event_crypto_adapter_caps_get() and >> rte_event_crypto_adapter_create() are incorrect. >> >> In the rte_event_crypto_adapter_caps_get(), event device id should be >> the first argument and cryptodev id should be the second argument. >> In the rte_event_crypto_adapter_create(), the event device id should >> be the second argument. >> >> Signed-off-by: Ankur Dwivedi >> --- >> app/test/test_event_crypto_adapter.c | 18 +++++++++--------- >> 1 file changed, 9 insertions(+), 9 deletions(-) >> >> diff --git a/app/test/test_event_crypto_adapter.c >> b/app/test/test_event_crypto_adapter.c >> index 3c64742b3..572ef9c27 100644 >> --- a/app/test/test_event_crypto_adapter.c >> +++ b/app/test/test_event_crypto_adapter.c >> @@ -209,8 +209,8 @@ test_op_forward_mode(uint8_t session_less) >> &cipher_xform, >> params.session_priv_mpool); >> TEST_ASSERT_SUCCESS(ret, "Failed to init session\n"); >> >> - ret =3D >> rte_event_crypto_adapter_caps_get(TEST_ADAPTER_ID, >> - evdev, &cap); >> + ret =3D rte_event_crypto_adapter_caps_get(evdev, >> TEST_CDEV_ID, >> + &cap); >> TEST_ASSERT_SUCCESS(ret, "Failed to get adapter >capabilities\n"); >> >> if (cap & >> RTE_EVENT_CRYPTO_ADAPTER_CAP_SESSION_PRIVATE_DATA) { @@ -321,7 >> +321,7 @@ test_session_with_op_forward_mode(void) >> uint32_t cap; >> int ret; >> >> - ret =3D rte_event_crypto_adapter_caps_get(TEST_ADAPTER_ID, >> evdev, &cap); >> + ret =3D rte_event_crypto_adapter_caps_get(evdev, TEST_CDEV_ID, >> &cap); >> TEST_ASSERT_SUCCESS(ret, "Failed to get adapter capabilities\n"); >> >> if (!(cap & >> RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_FWD) && @@ - >> 410,8 +410,8 @@ test_op_new_mode(uint8_t session_less) >> params.session_mpool); >> TEST_ASSERT_NOT_NULL(sess, "Session creation failed\n"); >> >> - ret =3D >> rte_event_crypto_adapter_caps_get(TEST_ADAPTER_ID, >> - evdev, &cap); >> + ret =3D rte_event_crypto_adapter_caps_get(evdev, >> TEST_CDEV_ID, >> + &cap); >> TEST_ASSERT_SUCCESS(ret, "Failed to get adapter >capabilities\n"); >> >> if (cap & >> RTE_EVENT_CRYPTO_ADAPTER_CAP_SESSION_PRIVATE_DATA) { @@ -460,7 >> +460,7 @@ test_sessionless_with_op_new_mode(void) >> uint32_t cap; >> int ret; >> >> - ret =3D rte_event_crypto_adapter_caps_get(TEST_ADAPTER_ID, >> evdev, &cap); >> + ret =3D rte_event_crypto_adapter_caps_get(evdev, TEST_CDEV_ID, >> &cap); >> TEST_ASSERT_SUCCESS(ret, "Failed to get adapter capabilities\n"); >> >> if (!(cap & >> RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_FWD) && @@ - >> 486,7 +486,7 @@ test_session_with_op_new_mode(void) >> uint32_t cap; >> int ret; >> >> - ret =3D rte_event_crypto_adapter_caps_get(TEST_ADAPTER_ID, >> evdev, &cap); >> + ret =3D rte_event_crypto_adapter_caps_get(evdev, TEST_CDEV_ID, >> &cap); >> TEST_ASSERT_SUCCESS(ret, "Failed to get adapter capabilities\n"); >> >> if (!(cap & >> RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_FWD) && @@ - >> 706,7 +706,7 @@ test_crypto_adapter_create(void) >> >> /* Create adapter with default port creation callback */ >> ret =3D rte_event_crypto_adapter_create(TEST_ADAPTER_ID, >> - TEST_CDEV_ID, >> + evdev, >> &conf, 0); >> TEST_ASSERT_SUCCESS(ret, "Failed to create event crypto adapter\n"); >> >> @@ -719,7 +719,7 @@ test_crypto_adapter_qp_add_del(void) >> uint32_t cap; >> int ret; >> >> - ret =3D rte_event_crypto_adapter_caps_get(TEST_ADAPTER_ID, >> evdev, &cap); >> + ret =3D rte_event_crypto_adapter_caps_get(evdev, TEST_CDEV_ID, >> &cap); >> TEST_ASSERT_SUCCESS(ret, "Failed to get adapter capabilities\n"); >> >> if (cap & >> RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_QP_EV_BIND) { >> -- >> 2.28.0