From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A8D41A04C8; Fri, 18 Sep 2020 16:34:52 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 80E0D1DA2B; Fri, 18 Sep 2020 16:34:51 +0200 (CEST) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 460B11DA06 for ; Fri, 18 Sep 2020 16:34:50 +0200 (CEST) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.42/8.16.0.42) with SMTP id 08IEUk9m012609; Fri, 18 Sep 2020 07:34:49 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0220; bh=Ez8VsLY/VwXmJXdqypNEk6Ar67YpmpIvc9DgH3jy4SI=; b=I9XZD2pij5/mZuDhG6A9B+1ga76ijfKikouV/ZpkvGObTIoltss69gallAmT16Ae7QdY qkuBsiJUVnApSCKdLN1LPhFLXpGWGwHodF6iuz7HGw2YeuUIUysjcFsyhpwLAQd6H+7t sUiDfDfpkkXhJIJNml+6VOoWc+pOJOKClQeQrPx1+k1t3wF/+GuNsaapQHvDZcpnWDdS tC7TmIJ7329UQF1XY5cg1iEVuPMkacRKDhxiVb7a0jEEQG7h/Hwq8j8ytaMUUG6iUDPJ pjWFluVRly35SKErn8lJ/+/j/6V+sYW+lRAsmAruUMDuJ+F5xw4djpHdDw2E800uLtqb 4Q== Received: from sc-exch03.marvell.com ([199.233.58.183]) by mx0a-0016f401.pphosted.com with ESMTP id 33m73mvuxp-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Fri, 18 Sep 2020 07:34:49 -0700 Received: from SC-EXCH01.marvell.com (10.93.176.81) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Fri, 18 Sep 2020 07:34:48 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.103) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Fri, 18 Sep 2020 07:34:47 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=I4IIvAfBntVUCOTzsPgRv7TuBOB6rF+R4TbtXJcifKCsonTDQJrc3NtHXpeqFoedjbezi4ZNGOHXFowj3xS7eGuWg7AsTNJg0q0Y2oIuamx75OLvaRiTNzOOPloAOT6NMEKVCjBWtO+qNBhkKeCUFyUAw+UAlgzKWZRSgfrqjLDkZw9BJeSiL+U0k8seXkN30Q+G8NlYWQbDVKc8/9UXZX0991q2XRBnaSeY9NP8KpxcbxRNJ+WXC4Z2w6T09fpes9jMmXoiETgQRHFO9sx9zwm79QF8Z6CrPeJFXiHSW/rP84Kg7fV/Er5OHUAbNLwE9YfFdij7rY1Utht4HpTVUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ez8VsLY/VwXmJXdqypNEk6Ar67YpmpIvc9DgH3jy4SI=; b=S8Z69YIQOxZY2LYdzVU7+LyunEnV0+oIRQ15nEH7iBIzzoPMeLvRuixbCof9LYkhGeM7LnMcTxsHpdgzK86mPfLh/T5e81ZAvCDy0d+FYN+Ock0ODpC0Rp+QIJ55QGjosYjTu/zaioE/lWADcO9QyesfsWSQaBYQEf9xEosQQTgZa4YkVkPS+NR7rEnu8UFf7eb02qgTKsLqdpNJLIOG7G2PRlLQ8Sk1sysmd8RK/NicVp8hS2VwB9qrDj3Wplos0AVPxLShq2fZJ8FPYMfo/0A0rCrocSNa5FKQsnpGjP5+aUdIiEUMD55kBzXNYHyN4IWb2lFT6B3s0ctADzJ6Qg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Ez8VsLY/VwXmJXdqypNEk6Ar67YpmpIvc9DgH3jy4SI=; b=WduQZgp301mAAeQIUUqtcel2JcUbDuKuJdEEqtjRP8V+f3oDPRe1Ec6EEhAtxfhYw6agFyna2Yb4r3GzWMrXT5VKTec8gY3B9vz/GwrpprbjJCSGhc0LxK0s2joY8iGTV4z0ol042rQfqmvCnY8fmjUCMBFGpisXcY54loUG+zQ= Received: from DM5PR1801MB1884.namprd18.prod.outlook.com (2603:10b6:4:65::20) by DM6PR18MB2395.namprd18.prod.outlook.com (2603:10b6:5:15d::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.15; Fri, 18 Sep 2020 14:34:47 +0000 Received: from DM5PR1801MB1884.namprd18.prod.outlook.com ([fe80::a57b:7214:a81b:3ed7]) by DM5PR1801MB1884.namprd18.prod.outlook.com ([fe80::a57b:7214:a81b:3ed7%6]) with mapi id 15.20.3391.014; Fri, 18 Sep 2020 14:34:46 +0000 From: Ankur Dwivedi To: "Gujjar, Abhinandan S" , "dev@dpdk.org" CC: Jerin Jacob Kollanukkaran , Anoob Joseph Thread-Topic: [PATCH 1/3] test/event_crypto_adapter: return error with unsupported mode Thread-Index: AQHWhcCt9/oUPrlD5EGZV5j4/IdhRKljETmAgAr44YCAAHdJUA== Date: Fri, 18 Sep 2020 14:34:46 +0000 Message-ID: References: <20200908091534.24305-1-adwivedi@marvell.com> <20200908091534.24305-2-adwivedi@marvell.com> In-Reply-To: Accept-Language: en-IN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=marvell.com; x-originating-ip: [47.15.27.212] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 4c7aa110-59fe-41e8-3695-08d85bdffde8 x-ms-traffictypediagnostic: DM6PR18MB2395: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: DYoJpc1qwobwJm7bCG8SMro32+TlXZ5dUHuaWs3qihMuz+p7ehKQvYdkGnln3+luj6lRGIVVnsvaq2UClIK6Ov+dU54UJohNBiA+CCSZhDLMWOrjIW+qMxskmMNOiA7tCmGDwbodDarnjvGI0Cvlrot8DjJWsraTWlRa3ji6tSRtv0jvmjTCSP20gFAJhP0DtAAf6yjjmMmxrx97anRRK8oolKs1uoL1K0YB7/Oxdv1StOp/xVsjJMH/pnyuHLj9O3KEwmCfy56XgK5vR01KsNcUfZTHBxUrR/OaSj+tFmjtyZ9Tyr/jPPQBDqhuiFov x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM5PR1801MB1884.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(396003)(376002)(39860400002)(136003)(366004)(9686003)(26005)(110136005)(54906003)(186003)(52536014)(316002)(8676002)(71200400001)(8936002)(5660300002)(478600001)(2906002)(55016002)(66446008)(64756008)(66556008)(66476007)(66946007)(76116006)(86362001)(33656002)(6506007)(53546011)(7696005)(107886003)(4326008)(83380400001); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: I43cFM/cSeQGNGOPOXz4EEYd0lrb0aqrAfu33GpLZ35OkXrhTXzwXDI1JKSGMF8MPrEK9RPD2ItjUu4Ho8R/1VSHLdd83359CY8PI9SaOjl/b/a8+BzhwMZZs1GWkEQhR12OFkJdShwsDLPC+WRZ582CfAmJT7B1S40pmiJVQp/V1HUPEZGjN8brodK6Yx6pRmVOl08p9dAQa/NXyqUWHWKRtnsM5QVa/iITaGNaz1GxDsjns/a6ktNYcARDBWFhsoPum0aur23ATnE4Fv2mPuUoIqL5eR6E1ZKjtKADy4bGTAxLutkLJ7LR9QG14KDz9OAWStsuWVYmjDARuPgL0ueJSRGuVaErbS7/3+BIK1IOeXZjcfppo+OC5wLfbSqaechBJX4SE+ghPVZQEqa6zBC/pyt3yYU16hQbLK4xrHW2k9cyP9nlhCiDFXUuL2HhymTJKhOSt82o7qdOXUDAqQvTQtJ8WnizypHWuhPvO47kUCq+dYQvr0m+SBNwTlS/dVVmY8ivA+RRhBXQUMKMw5SixalS8fgUfwUe8lxAhVP/SkIYbpu2OLrAMN7aNYV40eiWVzHw20Qnheu++ESI3BksMI6G0ji6TBmyJT6In5nbhMXQXP/LI++9ogZk3VzDt0Gl+4hExPplY8eFepREJA== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR1801MB1884.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4c7aa110-59fe-41e8-3695-08d85bdffde8 X-MS-Exchange-CrossTenant-originalarrivaltime: 18 Sep 2020 14:34:46.6764 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: YriUSyvnvJYhUKlnuLUAjaFFyu3g4sILnuTN54aV0dnuK38YKArqhfUMRSLytL8ChPCQvyh5jGt1W8MdHyykow== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR18MB2395 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.235, 18.0.687 definitions=2020-09-18_14:2020-09-16, 2020-09-18 signatures=0 Subject: Re: [dpdk-dev] [PATCH 1/3] test/event_crypto_adapter: return error with unsupported mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Abhinandan, Please see my comments inline. Thanks Ankur >-----Original Message----- >From: Gujjar, Abhinandan S >Sent: Friday, September 18, 2020 12:41 PM >To: Ankur Dwivedi ; dev@dpdk.org >Cc: Jerin Jacob Kollanukkaran ; Anoob Joseph > >Subject: [EXT] RE: [PATCH 1/3] test/event_crypto_adapter: return error wit= h >unsupported mode > >External Email > >---------------------------------------------------------------------- >Hi Ankur, > >This patch requires minor change. Please find the comment inline. > >> -----Original Message----- >> From: Gujjar, Abhinandan S >> Sent: Friday, September 11, 2020 1:07 PM >> To: Ankur Dwivedi ; dev@dpdk.org >> Cc: jerinj@marvell.com; anoobj@marvell.com >> Subject: RE: [PATCH 1/3] test/event_crypto_adapter: return error with >> unsupported mode >> >> Acked-by: abhinandan.gujjar@intel.com (For series) >> >> > -----Original Message----- >> > From: Ankur Dwivedi >> > Sent: Tuesday, September 8, 2020 2:46 PM >> > To: dev@dpdk.org >> > Cc: Gujjar, Abhinandan S ; >> > jerinj@marvell.com; anoobj@marvell.com; Ankur Dwivedi >> > >> > Subject: [PATCH 1/3] test/event_crypto_adapter: return error with >> > unsupported mode >> > >> > The capability of a event device should be checked before creating a >> > event crypto adapter in a particular mode. The test case returns >> > error if the mode is not supported. >> > >> > Signed-off-by: Ankur Dwivedi >> > --- >> > app/test/test_event_crypto_adapter.c | 30 >> > ++++++++++++++++++---------- >> > 1 file changed, 20 insertions(+), 10 deletions(-) >> > >> > diff --git a/app/test/test_event_crypto_adapter.c >> > b/app/test/test_event_crypto_adapter.c >> > index 8d42462d8..930c2a9bc 100644 >> > --- a/app/test/test_event_crypto_adapter.c >> > +++ b/app/test/test_event_crypto_adapter.c >> > @@ -750,15 +750,23 @@ configure_event_crypto_adapter(enum >> > rte_event_crypto_adapter_mode mode) >> > uint32_t cap; >> > int ret; >> > >> > + ret =3D rte_event_crypto_adapter_caps_get(evdev, TEST_CDEV_ID, >> > &cap); >> > + TEST_ASSERT_SUCCESS(ret, "Failed to get adapter capabilities\n"); >> > + >> > + if ((mode =3D=3D RTE_EVENT_CRYPTO_ADAPTER_OP_FORWARD) && >> > + !(cap & >> > RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_FWD)) >> > + return -ENOTSUP; >> > + >> > + if ((mode =3D=3D RTE_EVENT_CRYPTO_ADAPTER_OP_NEW) && >> > + !(cap & >> > RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_OP_NEW)) >> > + return -ENOTSUP; >> > + >SW adapter does not have *_INTERNAL_PORT_* caps. Just noticed test was >failing here. >Could you please bypass this check for "event_sw" and repost the patch? [Ankur] I was thinking of handling this by reading rte_eventdevs[evdev].dat= a->name. If the name matches event_sw0(which is the default device name), I will byp= ass if checks. Can the event_sw device name be anything else? Or, if there is a better way of handling this please let me know. > >> > /* Create adapter with default port creation callback */ >> > ret =3D rte_event_crypto_adapter_create(TEST_ADAPTER_ID, >> > - TEST_CDEV_ID, >> > + evdev, >> > &conf, mode); >> > TEST_ASSERT_SUCCESS(ret, "Failed to create event crypto >> adapter\n"); >> > >> > - ret =3D rte_event_crypto_adapter_caps_get(TEST_ADAPTER_ID, >> > evdev, &cap); >> > - TEST_ASSERT_SUCCESS(ret, "Failed to get adapter capabilities\n"); >> > - >> > if (cap & >> > RTE_EVENT_CRYPTO_ADAPTER_CAP_INTERNAL_PORT_QP_EV_BIND) { >> > ret =3D >> > rte_event_crypto_adapter_queue_pair_add(TEST_ADAPTER_ID, >> > TEST_CDEV_ID, TEST_CDEV_QP_ID, >> > &response_info); @@ -813,6 +821,8 @@ test_crypto_adapter_conf(enum >> > rte_event_crypto_adapter_mode mode) >> > TEST_ASSERT(ret >=3D 0, "Failed to link queue %d " >> > "port=3D%u\n", qid, >> > params.crypto_event_port_id); >> > + } else { >> > + return ret; >> > } >> > crypto_adapter_setup_done =3D 1; >> > } >> > @@ -845,24 +855,24 @@ static int >> > test_crypto_adapter_conf_op_forward_mode(void) >> > { >> > enum rte_event_crypto_adapter_mode mode; >> > + int ret; >> > >> > mode =3D RTE_EVENT_CRYPTO_ADAPTER_OP_FORWARD; >> > - TEST_ASSERT_SUCCESS(test_crypto_adapter_conf(mode), >> > - "Failed to config crypto adapter"); >> > + ret =3D test_crypto_adapter_conf(mode); >> > >> > - return TEST_SUCCESS; >> > + return ret; >> > } >> > >> > static int >> > test_crypto_adapter_conf_op_new_mode(void) >> > { >> > enum rte_event_crypto_adapter_mode mode; >> > + int ret; >> > >> > mode =3D RTE_EVENT_CRYPTO_ADAPTER_OP_NEW; >> > - TEST_ASSERT_SUCCESS(test_crypto_adapter_conf(mode), >> > - "Failed to config crypto adapter"); >> > + ret =3D test_crypto_adapter_conf(mode); >> > >> > - return TEST_SUCCESS; >> > + return ret; >> > } >> > >> > >> > -- >> > 2.28.0