From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id F067FA052A; Wed, 23 Dec 2020 10:30:06 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id BAAC7CAC4; Wed, 23 Dec 2020 10:29:45 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 8118CCAB9 for ; Wed, 23 Dec 2020 10:29:44 +0100 (CET) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 0BN9AhbQ031914 for ; Wed, 23 Dec 2020 01:29:43 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0220; bh=sz39YJYFkJdUMz2KOrMr0B7huw/jijkV4sMXohLEcMY=; b=MeYXNg99ss3LuHRwS04a22JDqPpacBMPTRv0IVZOoxvqDFoJuM9HKdMUidu/kYXL31C2 6jXRrIJBqv4cBEOw4V7/s4HhIUwzWG6NXoyQ3p4h3G9nAN0oHw4t8CGE2AvPppy9U03b 5PGoRxsDXEfZ/QP9jPx/EiI79daRJQ8xt9spURLtWH2dq0BHsNaRsNj9KURj3D+RFfsb Mnbo87F7foUnfuHqZPQczTMmnYuurZ+YlcikeIcp24nFQx5N/FnqA34BJA+SviA4tdm7 qqpSHEgXsxzqXGhwuWaSOwfC5+/TscLGfQTmJdgF4E0uoOR8OK2cjDoX3NOwGfuK2YdI +Q== Received: from sc-exch02.marvell.com ([199.233.58.182]) by mx0b-0016f401.pphosted.com with ESMTP id 35k0hx5mc9-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT) for ; Wed, 23 Dec 2020 01:29:42 -0800 Received: from DC5-EXCH01.marvell.com (10.69.176.38) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 23 Dec 2020 01:29:41 -0800 Received: from SC-EXCH01.marvell.com (10.93.176.81) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 23 Dec 2020 01:29:40 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.171) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Wed, 23 Dec 2020 01:29:39 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Iq1aldXpY1WdMN2goMr/2cyILOzJROX1NUE0yY3hw5jcwYffFX0dRwfoEw/E1pchMccsdIqFnpFPnRi4vcF3HF7xar0fPXkRDJo4NSCe3yLr1XWxMggePMJtcPb6ST23mJH3YZ0Xc5TlBp7Pq54A4RPI7c3MTEdoEkww78dUwZ5t3KSKPII8DnNi0qZI3Ip4G6ypv+MG//vZk2lZegrYpP+MUwiU+PTfIQanu7CaD6o0Bj5xBYR5CyTi2yI3ZLeSTrwVCIyVoeny5mSj0BuIsyNkfPvSAj2Bxmv+yjGxQaJhNT47znnVEz5l7BOx4xz7fPD+Rz9nqzrjI8xXQBBiDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sz39YJYFkJdUMz2KOrMr0B7huw/jijkV4sMXohLEcMY=; b=Oe/vgkeyyMQgPumSTEvXLg+pYBNikn+4a783jtqXX+Dh69ZDJWf36lOwljUXryfoPV9SV4XcTzxGW52xbM6SOVkZS9opCmR9avoytiaCymvZifSqoKbECuzvslEEgCah23lyCujsh3iPq6WotdRoxwpd/uoDu32XMlfKAURPEtkcJlgdDn0L6eJ+DoIa1QGVKAfHzpZvUDPe4czUqfYLaC2JAxCrz8vtWzy/THIbkG4Vham83vAFJ8ygoGMpL1CUZ5bbQGNM7jQkdV30MfJbJ6JrCNy5QdgtlXHfQMfWJ2Wv6vCo6JIYBxL7z2heuTtyZCIT8wtRyTz0mx+3ircpNw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=sz39YJYFkJdUMz2KOrMr0B7huw/jijkV4sMXohLEcMY=; b=ErORa4uTkFPlVedSKBOoD/JPJQmRIl6TImnoLlQ/uGe0bFJkKOHxmJ0LDP2CWNr/mV3s0DGaK9tFcJa1lOuOGGRaORoWw6sbSta1yvAhBhTM5KGZlhePxpqAc9u7Qc+HfKZ3aPqBJdeEZa40ZH+mxSFJjb2D8mg7dvzhVQei7s4= Received: from DM5PR1801MB2058.namprd18.prod.outlook.com (2603:10b6:4:67::31) by DM6PR18MB2795.namprd18.prod.outlook.com (2603:10b6:5:172::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3700.27; Wed, 23 Dec 2020 09:29:39 +0000 Received: from DM5PR1801MB2058.namprd18.prod.outlook.com ([fe80::303b:5c79:93c7:b432]) by DM5PR1801MB2058.namprd18.prod.outlook.com ([fe80::303b:5c79:93c7:b432%7]) with mapi id 15.20.3676.033; Wed, 23 Dec 2020 09:29:39 +0000 From: Michael Shamis To: Liron Himi , Jerin Jacob Kollanukkaran CC: "dev@dpdk.org" , Liron Himi Thread-Topic: [dpdk-dev] [PATCH v1 34/38] net/mvpp2: consider ptype in cksum info Thread-Index: AQHWyJU+AFW2Ut8AYU2fSLLMpJXRcaoEiwAQ Date: Wed, 23 Dec 2020 09:29:38 +0000 Message-ID: References: <20201202101212.4717-1-lironh@marvell.com> <20201202101212.4717-35-lironh@marvell.com> In-Reply-To: <20201202101212.4717-35-lironh@marvell.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [83.130.154.133] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: dc726339-c6b4-438c-6584-08d8a7254542 x-ms-traffictypediagnostic: DM6PR18MB2795: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2000; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: gOsgMPF2yEQMFzHW5fu3bWoJ1TVngQ3UpFbLAKtZeDiiVP4pfer+2N3nyLozylgGN7eeTzfmhP+znF2ePsDbzWAtf59epJ0eGS8EvtbJYUtgneGLERQURBbdWUfkefXEsfnJXkyNwHsmmrf8+AYbBoPB2TstQQ32uwm9uOg7r4RzX3wb3lCbhcYwUzauNczgO1VgwJmdoeKRCDs/o2MW2M/nlony094HI03Yr4H6faQlETfQ6BSLA4NCSFTJsY7GKJBifn7tdsAgTGIKEnvf9HsSA5SNTsANIoja809eLEyC3fYrPZeeam6TgkoQ0go+onvFk/CN/09CeHBO8+SCZGSdmiw58JKhzUFHooQlTZkZrsoBXSM46nmwHn4txIViMvZZ8+qJLqc2gaWFmXZTyw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM5PR1801MB2058.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(396003)(39860400002)(346002)(376002)(366004)(7696005)(26005)(54906003)(2906002)(8676002)(478600001)(186003)(9686003)(5660300002)(55016002)(83380400001)(4326008)(107886003)(8936002)(66946007)(86362001)(64756008)(66556008)(53546011)(66476007)(6636002)(6506007)(52536014)(33656002)(76116006)(110136005)(71200400001)(66446008)(316002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?5aDwDjy3MO6HT42d9fjjRHdVobi25XeNLbfkSx3EYk/VPfITArLvixa4JhAC?= =?us-ascii?Q?5Q7dgWLGCpRCsNKHfM0FdL85EBUIHnmdkVaa3qo+bu+ruHLMbS1k9hYxiyK5?= =?us-ascii?Q?ICh1g/YF50o1F2O6yp5/dIHKbvKAtPc4tEz3GCugru40k/XXMpp2G3gYy0KL?= =?us-ascii?Q?Uu8Rf71ztCwm7cBvdmKqAJdv+jGvxI7l1eZVSTGZN37JS80Qni1823aUIOU4?= =?us-ascii?Q?wVVdSYAocNCXwV3OqabfsQ48mlqQFRucStV8CEDk8w3bE3IQCGnXojK78/ku?= =?us-ascii?Q?XeiesidOVRpx/d4v5ORHr1kQRh3ijxVDrDKr2UbOAAan9jSR42F7vWeIe8mK?= =?us-ascii?Q?E2MlaV8FQAgPWpl6VUH5jn7QJnRJgQP2DxMxHLs3m1YSGiaaXjoDdtTdJ+5z?= =?us-ascii?Q?JgDz6qZBTHhFz8BlpZRBUXQXXPJQitwQ6o8dVu3+qv9v5di4YG4eo9BxCPCB?= =?us-ascii?Q?F2NGuMyCVEohdWGUAH1Yqz7uWpIt0D38eiaZrIlYIgWk4SAZnhUe9HDfxgP+?= =?us-ascii?Q?qzEiKCG+0l5+OdWV7aqNDDITd36eFGDsm9f/JxrK7vVHQedqguG+1htg6h0r?= =?us-ascii?Q?UI3ONFskwW0PERVhB0Z6QL/np84ztrhEpyIHy25RgnvAGC33gXpy0uVVkWZT?= =?us-ascii?Q?/2MaojdoZim4viErMcDD0a272H5+BwxdTUKongkXHv8/Xa8imFADFudux81c?= =?us-ascii?Q?NP05P2g0PY/kAv8oLJcDj9WTSUE6BF4vZEdNRxqmqeC1xGcIk6vv5tjJLvVM?= =?us-ascii?Q?q3hUBs5TSI/QKcAd+gf+IK7MxSTIk5HeYcFMp9zmKUs0SvyKBgFlEOtdlAav?= =?us-ascii?Q?L7N0FDjwfKnJxIWR/keZkE93/uZ8mo4pUn9i/dgjGIRJNY6KlUIUXLC0oLhP?= =?us-ascii?Q?sdj7tEnFLLbHepg2bmb4v/G2BuSlfwbq+hx2Kj6+7CffoWsOiwz3GjBJ7tUA?= =?us-ascii?Q?SabNlW1l8CrZalC/rl9WcUZZG0WS/iz1Q581R5z0kMA=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR1801MB2058.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: dc726339-c6b4-438c-6584-08d8a7254542 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Dec 2020 09:29:38.9693 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: utkfLOcCOGCWB9GFg9G/K0IyrQODeko71nklz8Qsq/VaSGeAx7bnwYT2V/2LC4uaJM5STBfKzuAgeCvImORPbw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR18MB2795 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.343, 18.0.737 definitions=2020-12-23_04:2020-12-21, 2020-12-23 signatures=0 Subject: Re: [dpdk-dev] [PATCH v1 34/38] net/mvpp2: consider ptype in cksum info X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Reviewed-by: Michael Shamis -----Original Message----- From: dev On Behalf Of lironh@marvell.com Sent: Wednesday, December 2, 2020 12:12 PM To: Jerin Jacob Kollanukkaran Cc: dev@dpdk.org; Liron Himi Subject: [dpdk-dev] [PATCH v1 34/38] net/mvpp2: consider ptype in cksum inf= o From: Liron Himi provide checksum information based on the ptype. Signed-off-by: Liron Himi Reviewed-by: Liron Himi --- drivers/net/mvpp2/mrvl_ethdev.c | 34 +++++++++++++++++++-------------- 1 file changed, 20 insertions(+), 14 deletions(-) diff --git a/drivers/net/mvpp2/mrvl_ethdev.c b/drivers/net/mvpp2/mrvl_ethde= v.c index fe5fd90ef..cb792300b 100644 --- a/drivers/net/mvpp2/mrvl_ethdev.c +++ b/drivers/net/mvpp2/mrvl_ethdev.c @@ -2622,23 +2622,27 @@ mrvl_desc_to_packet_type_and_offset(struct pp2_ppio= _desc *desc, * Mbuf offload flags. */ static inline uint64_t -mrvl_desc_to_ol_flags(struct pp2_ppio_desc *desc) +mrvl_desc_to_ol_flags(struct pp2_ppio_desc *desc, uint64_t packet_type) { - uint64_t flags; + uint64_t flags =3D 0; enum pp2_inq_desc_status status; =20 - status =3D pp2_ppio_inq_desc_get_l3_pkt_error(desc); - if (unlikely(status !=3D PP2_DESC_ERR_OK)) - flags =3D PKT_RX_IP_CKSUM_BAD; - else - flags =3D PKT_RX_IP_CKSUM_GOOD; - - status =3D pp2_ppio_inq_desc_get_l4_pkt_error(desc); - if (unlikely(status !=3D PP2_DESC_ERR_OK)) - flags |=3D PKT_RX_L4_CKSUM_BAD; - else - flags |=3D PKT_RX_L4_CKSUM_GOOD; + if (RTE_ETH_IS_IPV4_HDR(packet_type)) { + status =3D pp2_ppio_inq_desc_get_l3_pkt_error(desc); + if (unlikely(status !=3D PP2_DESC_ERR_OK)) + flags |=3D PKT_RX_IP_CKSUM_BAD; + else + flags |=3D PKT_RX_IP_CKSUM_GOOD; + } =20 + if (((packet_type & RTE_PTYPE_L4_UDP) =3D=3D RTE_PTYPE_L4_UDP) || + ((packet_type & RTE_PTYPE_L4_TCP) =3D=3D RTE_PTYPE_L4_TCP)) { + status =3D pp2_ppio_inq_desc_get_l4_pkt_error(desc); + if (unlikely(status !=3D PP2_DESC_ERR_OK)) + flags |=3D PKT_RX_L4_CKSUM_BAD; + else + flags |=3D PKT_RX_L4_CKSUM_GOOD; + } return flags; } =20 @@ -2731,7 +2735,9 @@ mrvl_rx_pkt_burst(void *rxq, struct rte_mbuf **rx_pkt= s, uint16_t nb_pkts) =20 mbuf->udata64 =3D q->port_id; if (likely(q->cksum_enabled)) - mbuf->ol_flags =3D mrvl_desc_to_ol_flags(&descs[i]); + mbuf->ol_flags =3D + mrvl_desc_to_ol_flags(&descs[i], + mbuf->packet_type); =20 rx_pkts[rx_done++] =3D mbuf; q->bytes_recv +=3D mbuf->pkt_len; -- 2.28.0