From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A6DBBA052A; Wed, 23 Dec 2020 10:30:54 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 78861CA87; Wed, 23 Dec 2020 10:30:53 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id F0B5ECA86 for ; Wed, 23 Dec 2020 10:30:51 +0100 (CET) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 0BN9UoCr002442 for ; Wed, 23 Dec 2020 01:30:50 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0220; bh=gGju9HiysnVLd6UzHvJXY3QqSwahDs8KKS7sItrAjZ4=; b=GaHpldtwXucPhWh70sjQg26m5GU4Zk0xH45zyxLLACiPL8JdE+jv+i5T0J5ykcS+Qc2L 0Tuf/aH55WzGRrYGQJpATjezJH12wYMH2COEpZngCb0laWqfatFFPF04a71gaPtv1TsP 9bEuvwn+RcHKwBibs9wvqnN28IcFvuBubDBVAdylDZsnVieCuXRLcQkoybKVUC3b7PTg tSHwA1lcbILKLZ0jEj/eamzJQkmjUmGYYrDBVHNpwTj9kSeVcLmVr3soq4MgkMUnJd/7 p2pjGsnNN9Dz0AAki6nKH/Yf66XYWPnIsOxDadXLU8AQKREgucl/lUro2u8ntZ/H/bv5 og== Received: from sc-exch01.marvell.com ([199.233.58.181]) by mx0b-0016f401.pphosted.com with ESMTP id 35k0hx5mex-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT) for ; Wed, 23 Dec 2020 01:30:50 -0800 Received: from SC-EXCH04.marvell.com (10.93.176.84) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 23 Dec 2020 01:30:48 -0800 Received: from SC-EXCH02.marvell.com (10.93.176.82) by SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 23 Dec 2020 01:30:48 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.173) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Wed, 23 Dec 2020 01:30:48 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fXoXjE/GYlX5lpWbepvXT4w8blKolXpOmWTJ+z46uINw+JOuFRdkiMyi6e1An0ARNsiRyzKwiljO024iYzgoYx/tN82MAEjHC/fbQ9KVOllea3y7vktNRSE0gQ0qmf2lRHOhtp2gzOwW+P4hgkGnou3LvX0W6Puz6oQpZkLqd9Yvby96FDTrhaVoEN6ArcpvWYyvs3E5e0J8mNlqC9Acj7RclZtIVFPSKM7GzWIEJW6FQkr0BOKpue+drwbtDRbjk/AwiBsF9qbUHOEbGSffW4DRp4wNZlC8aBl41MTN8Vxf3bVwDgzLemhBXcc7P6SJwx6cAjxmD47hKR2aS+acxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gGju9HiysnVLd6UzHvJXY3QqSwahDs8KKS7sItrAjZ4=; b=ZPYzAdzpwx9eTC/Jmoazb0/VMaV3HIp/uXFif3eTLQApku9BA2WgQbCKBRZyqp7xmspKTtKcaLs3JYE7BvFNdkgt1BEMeyH+/3JqNLIfrz/OZB9BMPUzZ1lewVzdPo7jEybQaCkerXEgnRuC5QtneDBEOShHeFAIdWvs+ToMFNYfDlJps0F67k4ZUn6uVYu44r9XnZOl4U/ORRgQbIewie+ErgL6QTO0LpGSsz1wvKaBrD/Q3TuBoui2JorQZ71jhSIMVxbhzVMIoxN/G5rHJS2yX35VjJcjlkOaFKyLcDu+5ALPD5WZElm8L29rnUFwET6WheJ2WdFuyfrgRNOL/A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gGju9HiysnVLd6UzHvJXY3QqSwahDs8KKS7sItrAjZ4=; b=hY+JETlKAuvcITZtkqh3i3rZOWY6Pn3yAlSJJjmxb4ujKnEHwsVZRi5bx9aQ3V/JtkdtSPSiUacYZiQF6k9qMKXso1jOatPriKm+twRELwIdZH3qE/+OOzcCCx2y0HUjD55Dh/tQJ7DhL9LAhtS3Y6Z5nMZnS4nKVPBLQ6kstsQ= Received: from DM5PR1801MB2058.namprd18.prod.outlook.com (2603:10b6:4:67::31) by DM6PR18MB2795.namprd18.prod.outlook.com (2603:10b6:5:172::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3700.27; Wed, 23 Dec 2020 09:30:47 +0000 Received: from DM5PR1801MB2058.namprd18.prod.outlook.com ([fe80::303b:5c79:93c7:b432]) by DM5PR1801MB2058.namprd18.prod.outlook.com ([fe80::303b:5c79:93c7:b432%7]) with mapi id 15.20.3676.033; Wed, 23 Dec 2020 09:30:47 +0000 From: Michael Shamis To: Liron Himi , Jerin Jacob Kollanukkaran CC: "dev@dpdk.org" , Dana Vardi , Liron Himi Thread-Topic: [dpdk-dev] [PATCH v1 33/38] net/mvpp2: change dsa_mode naming Thread-Index: AQHWyJUw3zUHRgAUqU+xJwK03s3MN6oEi0ww Date: Wed, 23 Dec 2020 09:30:46 +0000 Message-ID: References: <20201202101212.4717-1-lironh@marvell.com> <20201202101212.4717-34-lironh@marvell.com> In-Reply-To: <20201202101212.4717-34-lironh@marvell.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [83.130.154.133] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 4ec6f5eb-2e45-4879-7df7-08d8a7256dc8 x-ms-traffictypediagnostic: DM6PR18MB2795: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:361; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: h3vZfSxDQuFD34wOmzgYWuGfMCvF2+QMlrrMIv4VMc/MCaxK5wOr0wBdOOF1beXJsnxC5bvc83Xi9AFjy7H3UQoSOX+ngDU6dA/aa2zOs+xaI14wgSXIKusuh+CYowtiFiGeHMgWr8N9RJBwLXhJ0TZRUdQKPpm0A3KvoEFaghVUd4i5JvBg/VtWCeGCEYRqlqGwA94vRg3SXjGf7NNTThsd9zolqnh9x+TBGeQkz7gKWbM0rzGAyjMSTrHXpAH4M+omxmOK8iYAmXOIjIWQu68UMYHX0M0eL1UJ+CJAPV/ctP1k9Ezb1rjq4Qo6beBQopOMZKlq/LiiYM6iD6xtn11Y0viK1P6iZXVfeC8O7DwcSXAM32AICqEFZJry+DF6xsL5bHKT62zn11t25PNNkw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM5PR1801MB2058.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(396003)(39860400002)(346002)(376002)(366004)(7696005)(26005)(54906003)(2906002)(8676002)(478600001)(186003)(9686003)(5660300002)(55016002)(83380400001)(4326008)(107886003)(8936002)(66946007)(86362001)(64756008)(66556008)(53546011)(66476007)(6636002)(6506007)(52536014)(33656002)(76116006)(110136005)(71200400001)(66446008)(316002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?sMjVdeweOVKsulg5IhkEL+1h2xHlS7UvhzSwBPZObvd2bBLVIVqM4BNfH2lD?= =?us-ascii?Q?YFocV0Rvu7JOHRfil5mg2OI7Y9oPQm3cLQCl5PqhhfoAMwa6G7bRwxGs4n+e?= =?us-ascii?Q?0Q41Yw4ffDOdGgF4LXI/tZXZz7h37KI2ey1n/OxZZv0O6WTSPu1X4Dp5H1RD?= =?us-ascii?Q?1iUhHDf7faX3p6tsgXGLTM2CguvFQ5/qIcOwW0BSQlhzLpJmAc3SOi5/LPOb?= =?us-ascii?Q?4BL44uyo9Zb0lMcX4iZeEuEDyhEVgpS+SR/E6Hk830j0T5SPxRzeimNnpHBY?= =?us-ascii?Q?TKpZMDNlG9rJ1On4EETVMTCIrOq9wBDxAX3LhwvVJynCmjXymkcfseyRhYCR?= =?us-ascii?Q?w4mj1wnpYOwQ0pluMu5zSqZ0RxqLIaRZoNgFbLfh8ypJ1spIfqi4rh62Mcc5?= =?us-ascii?Q?HNy1cuV7Xd77P3Td8akPp8lKZYxr4flKHlVpL8zVDYu2l6zVYHsBBapoA5K3?= =?us-ascii?Q?ZjvaeoXU5WlPQ+0StmmnMh4s3hSVPSDLqki9LAaD4H72JovVEi9jTRIYLpqk?= =?us-ascii?Q?ED+JJrswZPIZuqbLVYmzCQOcfvIEPfA8zW7M9DtI7rkpESrC4SMKHE2pLYSe?= =?us-ascii?Q?6qRsKUPz4gGFwYes8UfyFrHMqmxSbyJmhOEDomgFgUwhqMDSZ6/6F+V1xbxG?= =?us-ascii?Q?bn6D6phVjz5WPlZHHMsmwEPXLzrX7Sg/TgeHCMkYYgI1qSeCWfUv/cdLaGpf?= =?us-ascii?Q?9oD8LKh/0jNPqhOzS2Q/FgfH70iqDMowC8ixe/hK+zO9HRsYMAtdRo8A9ml6?= =?us-ascii?Q?1qIpkTdDuAj6Pfaso2aX+ER2Ea2Lh7sVqmyzf48Kefn+4iuPl2QsKp9qIfj3?= =?us-ascii?Q?N+iHc6iAq0oGzhLIDd3HaK+s6fVqJ15eys2KRUsOPE9nDhuLluLFqrjCvWl7?= =?us-ascii?Q?r15IjURLsjfeWzveJ84LyLAuccfTQeYfq8o/SdzapZZM+aocOKDwpjKPRP6X?= =?us-ascii?Q?lBzljyHn7zOAZ0tAe2Q/coTQW/SFDJk+SE2oVbCC5I8=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR1801MB2058.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4ec6f5eb-2e45-4879-7df7-08d8a7256dc8 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Dec 2020 09:30:46.8970 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: VKgRfxHPjfRQMICyvyddERWAwxAwg/bkNB8G2jFKLZkIUXga+EI0foptSS9SLyOsohA2RRY9CwAz7mkiusdLWQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR18MB2795 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.343, 18.0.737 definitions=2020-12-23_04:2020-12-21, 2020-12-23 signatures=0 Subject: Re: [dpdk-dev] [PATCH v1 33/38] net/mvpp2: change dsa_mode naming X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Reviewed-by: Michael Shamis -----Original Message----- From: dev On Behalf Of lironh@marvell.com Sent: Wednesday, December 2, 2020 12:12 PM To: Jerin Jacob Kollanukkaran Cc: dev@dpdk.org; Dana Vardi ; Liron Himi Subject: [dpdk-dev] [PATCH v1 33/38] net/mvpp2: change dsa_mode naming From: Dana Vardi change 'dsa_mode' to 'start_hdr' in config file Signed-off-by: Dana Vardi Reviewed-by: Liron Himi --- drivers/net/mvpp2/mrvl_qos.c | 29 +++++++++++++++++++---------- 1 file changed, 19 insertions(+), 10 deletions(-) diff --git a/drivers/net/mvpp2/mrvl_qos.c b/drivers/net/mvpp2/mrvl_qos.c in= dex 23a014ade..c7bd8825c 100644 --- a/drivers/net/mvpp2/mrvl_qos.c +++ b/drivers/net/mvpp2/mrvl_qos.c @@ -20,9 +20,10 @@ /* Parsing tokens. Defined conveniently, so that any correction is easy. *= / #define MRVL_TOK_DEFAULT "default" #define MRVL_TOK_DSA_MODE "dsa_mode" -#define MRVL_TOK_DSA_MODE_NONE "none" -#define MRVL_TOK_DSA_MODE_DSA "dsa" -#define MRVL_TOK_DSA_MODE_EXT_DSA "ext_dsa" +#define MRVL_TOK_START_HDR "start_hdr" +#define MRVL_TOK_START_HDR_NONE "none" +#define MRVL_TOK_START_HDR_DSA "dsa" +#define MRVL_TOK_START_HDR_EXT_DSA "ext_dsa" #define MRVL_TOK_DEFAULT_TC "default_tc" #define MRVL_TOK_DSCP "dscp" #define MRVL_TOK_MAPPING_PRIORITY "mapping_priority" @@ -722,25 +723,33 @@ mrvl_get_cfg(const char *key __rte_unused, const char= *path, void *extra_args) continue; } =20 + /* MRVL_TOK_START_HDR replaces MRVL_TOK_DSA_MODE parameter. + * MRVL_TOK_DSA_MODE will be supported for backward + * compatibillity. + */ entry =3D rte_cfgfile_get_entry(file, sec_name, + MRVL_TOK_START_HDR); + /* if start_hsr is missing, check if dsa_mode exist instead */ + if (entry =3D=3D NULL) + entry =3D rte_cfgfile_get_entry(file, sec_name, MRVL_TOK_DSA_MODE); if (entry) { - if (!strncmp(entry, MRVL_TOK_DSA_MODE_NONE, - sizeof(MRVL_TOK_DSA_MODE_NONE))) + if (!strncmp(entry, MRVL_TOK_START_HDR_NONE, + sizeof(MRVL_TOK_START_HDR_NONE))) (*cfg)->port[n].eth_start_hdr =3D PP2_PPIO_HDR_ETH; - else if (!strncmp(entry, MRVL_TOK_DSA_MODE_DSA, - sizeof(MRVL_TOK_DSA_MODE_DSA))) + else if (!strncmp(entry, MRVL_TOK_START_HDR_DSA, + sizeof(MRVL_TOK_START_HDR_DSA))) (*cfg)->port[n].eth_start_hdr =3D PP2_PPIO_HDR_ETH_DSA; - else if (!strncmp(entry, MRVL_TOK_DSA_MODE_EXT_DSA, - sizeof(MRVL_TOK_DSA_MODE_EXT_DSA))) { + else if (!strncmp(entry, MRVL_TOK_START_HDR_EXT_DSA, + sizeof(MRVL_TOK_START_HDR_EXT_DSA))) { (*cfg)->port[n].eth_start_hdr =3D PP2_PPIO_HDR_ETH_EXT_DSA; } else { MRVL_LOG(ERR, "Error in parsing %s value (%s)!\n", - MRVL_TOK_DSA_MODE, entry); + MRVL_TOK_START_HDR, entry); return -1; } } else { -- 2.28.0