From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1E354A052A; Wed, 23 Dec 2020 10:28:52 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 34AF1CAC4; Wed, 23 Dec 2020 10:28:36 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 5FE43CA9E for ; Wed, 23 Dec 2020 10:28:34 +0100 (CET) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 0BN9BYjY032318 for ; Wed, 23 Dec 2020 01:28:32 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0220; bh=i3LYL4Fm/JZpnuvqQBrJCZKmxHtPJTeI262VAMtHo/k=; b=WsU3Vw1w6/WtgitrPIXovWW5XFfSEkU7gcdGqd215+g9NAPqvIuP4sSWXNC6fCDtbGbL x8a2wkLJz5Jec2Wjxgu/IpBuJt8V4ocL2OVNFenszjc6YRLuc7aEJ6hCOvnak1iPahhl fe520r/v1Q+ZOq7rss4d7e247dE4ispTuIbn3/MgB8yZtGAFTSm34bOzG4b2g/cQLPbO 4JtnLZXtX4p4XjqVLivfpQ+m+XCUv+D1p7/y23iPzu7gHa0Fe2SHsH8UAZxc3G6s1fS3 kVSDUEIGgjvegXWoLoAcibmngUlbBpNKcfdfKHgLeI/4zoktdEwoc2eEiut1GzJSyb7F ZA== Received: from sc-exch02.marvell.com ([199.233.58.182]) by mx0b-0016f401.pphosted.com with ESMTP id 35k0hx5mag-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT) for ; Wed, 23 Dec 2020 01:28:32 -0800 Received: from DC5-EXCH02.marvell.com (10.69.176.39) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 23 Dec 2020 01:28:30 -0800 Received: from SC-EXCH01.marvell.com (10.93.176.81) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 23 Dec 2020 01:28:30 -0800 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.177) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Wed, 23 Dec 2020 01:28:29 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MvvyEotQElp/Xzq+uE1Bo8Ng+8ToPqdWLIsx/w/K1At6DOZMLKESpaWFg+xxuSYpFyspBXS+Nq0icjzMouPNeZpMHs73ImfxpgJnI3mQNUvHlL8uh7kCCkxpXkpAtgBMWyrVYuTiZTkgf5edafyR8V5I6SCruexKgbeK6C+EGoAzOVgY4X8QDrpdpOcGBIr/9VBD8dbRE/Y4WsZgcEf/ZKxJdsV1FYxL+sIJyjCzl7ZfdTQTq8SZr4mmh0msJvtz+c0VyrfFk30Sh3Tp/sUEos3JiBY0oXSn3pvZZzf+83NwSBRjB7rjazqVi3ikhBQ4qsUAnfkNMlRkZ+yorpnsHg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=i3LYL4Fm/JZpnuvqQBrJCZKmxHtPJTeI262VAMtHo/k=; b=SWO68WZizRJU/9v38YLawA4jn+164YHsVvD5ISQR8L6XN2FIMHMkVIufFV6ABCbhC/nN1kwpHGubbPLGY9ULF2Pm9QLX9TMlroNZGmRvPaTaFy5z1guKleI71CFpM3uk9qsch996Qc6c4Y5MkIoIo/dfs85sWz7Y/5RrCdvuZifphOmlAJ/6h3+Uya0aT7uHMj2Pe1ATw+itvEuWQ39cmocsIQTg8rPvYMzTTEbOMDLd2SJC0CkgbsvhU2T7AVIG2HjUlOcOLkMYzH/jLuOAy+bSqHKwfcTUfJNLNcLP4AcFvRQuaZDov2DaFTa3l6PR13hC3opJm8GtKQgVAxS6fg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=i3LYL4Fm/JZpnuvqQBrJCZKmxHtPJTeI262VAMtHo/k=; b=uBE+d/MFncTMTKYawDKDKeYWefLq/tS3cSBKfe0Swm7V4ZX7VkrvLCy+RJ4CRb973FbtFxdFGAbk2qyO+aXNkPheOi4EuRIPKuf5GKNLCDXfIqKN1nDVdeAP0o12OMZduOrX8dYuHE5TvV4EkbRuCxVyz+PfulTHpbKxMp0ottE= Received: from DM5PR1801MB2058.namprd18.prod.outlook.com (2603:10b6:4:67::31) by DM6PR18MB2889.namprd18.prod.outlook.com (2603:10b6:5:163::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3676.33; Wed, 23 Dec 2020 09:28:28 +0000 Received: from DM5PR1801MB2058.namprd18.prod.outlook.com ([fe80::303b:5c79:93c7:b432]) by DM5PR1801MB2058.namprd18.prod.outlook.com ([fe80::303b:5c79:93c7:b432%7]) with mapi id 15.20.3676.033; Wed, 23 Dec 2020 09:28:28 +0000 From: Michael Shamis To: Liron Himi , Jerin Jacob Kollanukkaran CC: "dev@dpdk.org" , Dana Vardi , Liron Himi Thread-Topic: [dpdk-dev] [PATCH v1 37/38] net/mvpp2: update qos defaults parameter name Thread-Index: AQHWyJVkD8WFdSsL+E+1rROZNoEZB6oEiriA Date: Wed, 23 Dec 2020 09:28:28 +0000 Message-ID: References: <20201202101212.4717-1-lironh@marvell.com> <20201202101212.4717-38-lironh@marvell.com> In-Reply-To: <20201202101212.4717-38-lironh@marvell.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [83.130.154.133] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 615beffe-29e7-423d-f50f-08d8a7251b34 x-ms-traffictypediagnostic: DM6PR18MB2889: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1824; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: sENMRNiXszGyTbYDGd2UVinqdz03WQtiJF/xB6jvMq/IAyCI99mUtkgh4yrj1uTNuNAv9ujwsY0gkcRWp0tL/nf0dthVb98EYTrAh9TbQ4C0a8dteuWnS83iOtlj8ubYFXLBgDBrQssdxoGknWALbr1VvDGOzxt9THKiTDNkxxK0LVsVBiO4Mcaw7qf1Jle6GD9LIS9Ya/SEGstuOWzaqx6imkJNDm02nO8aSCSAYCSX7NM8BOf/xLaHQmesdMY0EouA5GE7Z6cI/us/zjSQmPDuO9+gs7dx4XO2qb5dpi/fz5Bm7SfmlrBtPLiPS7Mng5sBn+z8ZfKnruXxblr7oKrh29PcZZY95pBZjK06VOy8zL1vyz4UAgNd6xt2S/+fGk10RKzedv2rzyu9hpImzQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM5PR1801MB2058.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(396003)(376002)(346002)(136003)(366004)(26005)(6636002)(54906003)(5660300002)(33656002)(478600001)(107886003)(52536014)(186003)(71200400001)(8936002)(66556008)(15650500001)(6506007)(66476007)(66446008)(83380400001)(7696005)(53546011)(76116006)(2906002)(66946007)(9686003)(64756008)(55016002)(316002)(86362001)(110136005)(4326008); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?Y7cErtBxnSKpmyXAj6BXJVKScV7OgFr2C0ppuaI3ZZbwBsRC9dV92T2+AYG7?= =?us-ascii?Q?kbrpktfbc9MVQn5Sh5tA9ODrLt65biW0ti0Tf88aGpFbxxnNNm3SkpOBRZUS?= =?us-ascii?Q?WB9JZ0vSB3DFU+kKNyJ9GNz5a0q7ZW3sw+Q2dAi8dz35J5xzbkxIedbO18tq?= =?us-ascii?Q?cOX5LT11bQ4dXq/LF+QCTNNhmZXwk0iuSEXlqssev2zZN8SrAN0bicmeLQaK?= =?us-ascii?Q?NwIaweKuOBAvbMieYvKdgF++kbRDVSk7OvqXhpkPEgVhGAyV8VPPiKlcEiHS?= =?us-ascii?Q?TTR4ePLJcATeAsfxpOUV04WzN5EMNYigMQxS/EjLNvkMCVXZmGjQVPX0yRlf?= =?us-ascii?Q?XUirp1fPCJ9Z3eON8HPvi6hjWfnb7SMdWwilZ/NMqMbFPtPrdEpNsGltPi54?= =?us-ascii?Q?XsyKvoXJykXKx7YkQd5R8daZG6AM+Py5gBr+17KfwJNSVZWTxzuseU5FTNd0?= =?us-ascii?Q?3Vzhqzeu58CZscw4ZIQT6KJ3USf7XDp1qx4Kl/bkJSG9d7W5S+n3bNCKOd9w?= =?us-ascii?Q?L2RxNADkI5Ex4q0RfI72H5MN9HmMKv3RZE/A6lXTKAwXz7Ok3UYT6561l31u?= =?us-ascii?Q?uxsQeViFMnTydIyIQx8Ca5tM0wrmPw+i41zbM81wMAUejSGEr9imsOvZBS20?= =?us-ascii?Q?PY9YXAamiT3EtIA6G05hXFfT1vZYEmbPPquSZf2Fg//pV9CIAKVO6TZv4kib?= =?us-ascii?Q?Dkh9nX9447TNB9PyQzOlBTYvD6K9mtlpezk5u8GeqegwQ7VWH46kG/HkghdW?= =?us-ascii?Q?PS3ELVb1c5eYttH3dclJLFgyPNGq5XLqNbTyhRn8hL3v4TxysflmJRivGLV5?= =?us-ascii?Q?ydlD2y6fpOURsSm0hrmwSn/vuzbCkOC2AyoiVb9u1oRgj7c3ZO4GpylCnFiV?= =?us-ascii?Q?yOT9RGdAHy5/6QWzLKoT1ndKfN0wGJKwF+YwkPqUqsKGneRYU+AwNR+GMrJp?= =?us-ascii?Q?af8agZIB4Scq/+GnIA6PPXvtO8KpMQ/R4sPR8BEeKUk=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR1801MB2058.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 615beffe-29e7-423d-f50f-08d8a7251b34 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Dec 2020 09:28:28.3699 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: MqCxB4GcRISbLnKvjs6oUB+Yiuncv7KJYnzT7iAKhaj1uuB8VsyRJXBo7mw02En1VtPx62GcxnfesEOYzCL1wg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR18MB2889 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.343, 18.0.737 definitions=2020-12-23_04:2020-12-21, 2020-12-23 signatures=0 Subject: Re: [dpdk-dev] [PATCH v1 37/38] net/mvpp2: update qos defaults parameter name X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Reviewed-by: Michael Shamis -----Original Message----- From: dev On Behalf Of lironh@marvell.com Sent: Wednesday, December 2, 2020 12:12 PM To: Jerin Jacob Kollanukkaran Cc: dev@dpdk.org; Dana Vardi ; Liron Himi Subject: [dpdk-dev] [PATCH v1 37/38] net/mvpp2: update qos defaults paramet= er name From: Dana Vardi 'global_default' is only being used for 'qos' so adding 'qos' into its name Signed-off-by: Dana Vardi Reviewed-by: Liron Himi --- drivers/net/mvpp2/mrvl_ethdev.c | 2 +- drivers/net/mvpp2/mrvl_qos.c | 12 ++++++------ drivers/net/mvpp2/mrvl_qos.h | 2 +- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/drivers/net/mvpp2/mrvl_ethdev.c b/drivers/net/mvpp2/mrvl_ethde= v.c index 4b5c4f075..ca94805fb 100644 --- a/drivers/net/mvpp2/mrvl_ethdev.c +++ b/drivers/net/mvpp2/mrvl_ethdev.c @@ -902,7 +902,7 @@ mrvl_dev_start(struct rte_eth_dev *dev) =20 /* For default QoS config, don't start classifier. */ if (mrvl_cfg && - mrvl_cfg->port[dev->data->port_id].use_global_defaults =3D=3D 0) { + mrvl_cfg->port[dev->data->port_id].use_qos_global_defaults =3D=3D 0) = { ret =3D mrvl_start_qos_mapping(priv); if (ret) { MRVL_LOG(ERR, "Failed to setup QoS mapping"); diff --git a/drivers/net/= mvpp2/mrvl_qos.c b/drivers/net/mvpp2/mrvl_qos.c index f3936aec4..d9af07c3d = 100644 --- a/drivers/net/mvpp2/mrvl_qos.c +++ b/drivers/net/mvpp2/mrvl_qos.c @@ -321,7 +321,7 @@ parse_tc_cfg(struct rte_cfgfile *file, int port, int tc= , if (rte_cfgfile_num_sections(file, sec_name, strlen(sec_name)) <=3D 0) return 0; =20 - cfg->port[port].use_global_defaults =3D 0; + cfg->port[port].use_qos_global_defaults =3D 0; entry =3D rte_cfgfile_get_entry(file, sec_name, MRVL_TOK_RXQ); if (entry) { n =3D get_entry_values(entry, @@ -718,7 +718,7 @@ mrvl_get_cfg(const char *key __rte_unused, const char *= path, void *extra_args) MRVL_TOK_PORT, n, MRVL_TOK_DEFAULT); =20 /* Use global defaults, unless an override occurs */ - (*cfg)->port[n].use_global_defaults =3D 1; + (*cfg)->port[n].use_qos_global_defaults =3D 1; =20 /* Skip ports non-existing in configuration. */ if (rte_cfgfile_num_sections(file, sec_name, @@ -796,7 +796,7 @@ mrvl_ge= t_cfg(const char *key __rte_unused, const char *path, void *extra_args) entry =3D rte_cfgfile_get_entry(file, sec_name, MRVL_TOK_MAPPING_PRIORITY); if (entry) { - (*cfg)->port[n].use_global_defaults =3D 0; + (*cfg)->port[n].use_qos_global_defaults =3D 0; if (!strncmp(entry, MRVL_TOK_VLAN_IP, sizeof(MRVL_TOK_VLAN_IP))) (*cfg)->port[n].mapping_priority =3D @@ -828,7 +828,7 @@ mrvl_get_cfg(const char *key __rte_unused, const char *= path, void *extra_args) entry =3D rte_cfgfile_get_entry(file, sec_name, MRVL_TOK_PLCR_DEFAULT); if (entry) { - (*cfg)->port[n].use_global_defaults =3D 0; + (*cfg)->port[n].use_qos_global_defaults =3D 0; if (get_val_securely(entry, &val) < 0) return -1; =20 @@ -867,7 +867,7 @@ mrvl_get_cfg(const char *key __rte_unused, const char *= path, void *extra_args) return -1; (*cfg)->port[n].default_tc =3D (uint8_t)val; } else { - if ((*cfg)->port[n].use_global_defaults =3D=3D 0) { + if ((*cfg)->port[n].use_qos_global_defaults =3D=3D 0) { MRVL_LOG(ERR, "Default Traffic Class required in " "custom configuration!"); @@ -984,7 +984,7 @@ mrvl_configure_rxqs(struct mrvl_priv *priv, uint16_t po= rtid, size_t i, tc; =20 if (mrvl_cfg =3D=3D NULL || - mrvl_cfg->port[portid].use_global_defaults) { + mrvl_cfg->port[portid].use_qos_global_defaults) { /* * No port configuration, use default: 1 TC, no QoS, * TC color set to green. diff --git a/drivers/net/mvpp2/mrvl_qos.h b/drivers/net/mvpp2/mrvl_qos.h in= dex f2e341c37..763130bf1 100644 --- a/drivers/net/mvpp2/mrvl_qos.h +++ b/drivers/net/mvpp2/mrvl_qos.h @@ -45,7 +45,7 @@ struct mrvl_cfg { uint16_t inqs; uint16_t outqs; uint8_t default_tc; - uint8_t use_global_defaults; + uint8_t use_qos_global_defaults; struct pp2_cls_plcr_params policer_params; uint8_t setup_policer; uint8_t forward_bad_frames; -- 2.28.0