From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7043CA052A; Wed, 23 Dec 2020 10:29:30 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A0946CA6E; Wed, 23 Dec 2020 10:28:59 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 334E2CA4D for ; Wed, 23 Dec 2020 10:28:58 +0100 (CET) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 0BN9AVIT019772 for ; Wed, 23 Dec 2020 01:28:56 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0220; bh=BSPa3P/t7L4BGrd4HMhXWp9SgzknK1Yvj6i/t27GN9E=; b=CkDYYfC/ReMbW6jfYVj81uoEC2AG5M8jErHuRJSB0KixKY2/x4V0bJpbKTPdkN4OjYnv Fre5CSWAMS8Bi8/8UN4jRQbtya2UNLS/HswMaiyZeJh+j8olP6yfIQOrRkBcdALqo7XM kly3aKj0tKUQ6GDZukA593P7RH0NYJ9oL5/Q4jNaVcylC2wLC0aW0IbGlGM5o7AN5RNt XvkXWGh4WcgDM4NgH1ZZE3RHWOxUpMGQygMp3yGLkR7P/+Gtz7j8EQfjGQByw1fH+v4S F4F2AuPTIJU0jWh+frJjy46pITd8UwRDpAqaUOl1TaQRKDQGa7YVMZnX8erTzVKJKwI7 vw== Received: from sc-exch01.marvell.com ([199.233.58.181]) by mx0a-0016f401.pphosted.com with ESMTP id 35k0ebdrb6-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT) for ; Wed, 23 Dec 2020 01:28:56 -0800 Received: from SC-EXCH01.marvell.com (10.93.176.81) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 23 Dec 2020 01:28:55 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.173) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Wed, 23 Dec 2020 01:28:55 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=DD5pXZgvaV73rZiG5PtO6eZgtCAc0HLsjWMv9o5QzZkiHk5Fwkxyh1HtYLS+QEK1KdAC402o8cakQjh/KC6XCVM2/SeF+SR4s5dUoXBgKxCP2TFfCCCVUTEXM7xmSe/lzDxl+G7+kRm8s9s2AL+lSUI68oB/fX0iNlJ5wgV21hRNGgR31M/W/Tq6qbLvji1FxAfTwuLUeRldUx3bCBmLYhLsOnLHydv51MaUarhSnkQR4qj0g49QISRRcOm3w30M+0FySfn7DAFbF9+tuIfcPjQ35+2WjjNOkpQdYtuMHYDYkgEVkvGmeAWq7xJyUuJsj8g6peFh+zxPW1PuxoxOnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BSPa3P/t7L4BGrd4HMhXWp9SgzknK1Yvj6i/t27GN9E=; b=hYt8y35osUgR+s3ycQ1uOAKNrZP/ul64YA4t62ZcaAG1g1inGlDwbli2bDEgB6Y93kW9k8DmXteuKdD+h9AcifkyzprSdHXdwCn7GrmYfBLtQs08iEu8bBJagRmUw1vE3osNtSAQGDWqsZWK+/LCGA1L6+FZKrEmBK6GJ8wUP2EA5QS0AbHbLkgocO2DknB6jqJdFQ6CNtZILM3cBS5eZ6xv5m/6M2ZyrdPfCeBoj16d0bHGIOPd45TvWDQw+FqbQWrBDv/N5FRwTqcTBA37dGCHMkurnzPZAFQwqlHRBB5wvbxjjnKTEQKMCDMWmPbfjGia687NujSQmE6Nxs+cAg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BSPa3P/t7L4BGrd4HMhXWp9SgzknK1Yvj6i/t27GN9E=; b=LZA1/pj7JfxIBm3WtgyblkiXDQwr0yv4gNsLrdncUvm7kYwb+OrnoKoFn5HFittlLneemoGyDaJfVTex+nHqJNuuV+lmrj8ZeiluZceYPQUmhMqImWzfD30n7iCG4bBBI4nabSW88sjvnKRoJiHo8bfdcS6HXyKLUN1Y7XpH9S0= Received: from DM5PR1801MB2058.namprd18.prod.outlook.com (2603:10b6:4:67::31) by DM6PR18MB2795.namprd18.prod.outlook.com (2603:10b6:5:172::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3700.27; Wed, 23 Dec 2020 09:28:54 +0000 Received: from DM5PR1801MB2058.namprd18.prod.outlook.com ([fe80::303b:5c79:93c7:b432]) by DM5PR1801MB2058.namprd18.prod.outlook.com ([fe80::303b:5c79:93c7:b432%7]) with mapi id 15.20.3676.033; Wed, 23 Dec 2020 09:28:54 +0000 From: Michael Shamis To: Liron Himi , Jerin Jacob Kollanukkaran CC: "dev@dpdk.org" , Dana Vardi , Liron Himi Thread-Topic: [dpdk-dev] [PATCH v1 36/38] net/mvpp2: forward bad packets support Thread-Index: AQHWyJVXpiUJr26rNUKhteqUYyO0QaoEisqQ Date: Wed, 23 Dec 2020 09:28:54 +0000 Message-ID: References: <20201202101212.4717-1-lironh@marvell.com> <20201202101212.4717-37-lironh@marvell.com> In-Reply-To: <20201202101212.4717-37-lironh@marvell.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [83.130.154.133] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: fd9a66d6-394f-49af-68ce-08d8a7252a8a x-ms-traffictypediagnostic: DM6PR18MB2795: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:538; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: AGUUWIbxJ1JhsuCgLyhGCy9AZX6Z/tlN/loWypogn9hvxdRgvJyEXEkxHZm9ZF114SyyrsChIdAutyXthXGZMRbHBhcOUJfGg3FgyndUYgN9M3XiHLGBpYNqQGlUkEmKMAmHpSheZlHoDgvOsuszbLszYmdS4YAE/kY2n4R6ov7kWPfiH/dTnZYhn8J4Q3WZtZBmrXTv0wRn9Ov/OshXYtwCPM/mIVAak+wwe4c4IuOzSMtdrVbrWW7E5p6gmRx57ES9biGaVp0ZX/GkwfW1lykxHFai/KHhgPSQvF1H8x9XH2uQR0ieJhH+vf4dXskwugsN0adEfZnMoB2fBPY1RebJ5nXVqr/2+QwwxVIUgrXtgIRzYixPmgjCZUfA6CIvTUW9XtNVDwBuTBV9blGVWg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM5PR1801MB2058.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(376002)(136003)(346002)(39860400002)(396003)(6636002)(66476007)(86362001)(64756008)(66556008)(53546011)(52536014)(6506007)(83380400001)(4326008)(107886003)(8936002)(66946007)(71200400001)(110136005)(316002)(66446008)(33656002)(76116006)(2906002)(478600001)(8676002)(7696005)(54906003)(26005)(5660300002)(55016002)(186003)(9686003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?5Gh+qPaII8qbsqA+ar2JzhgnfMYHL+p7w1eoWkwtG5K8da7VdSXBAI9vifOZ?= =?us-ascii?Q?Z/Vw/9Gqjr/Wl3iWmg8Gns17DPDPSk765A42XMJhPiHENI/LmH8J+xLBc7L8?= =?us-ascii?Q?7BYR+zu1T/rBe2GfNYiCTS0yxzwIpYxid+URRb20QmXiZ5OyR/chJptzEnhG?= =?us-ascii?Q?MEQcvoYiPd9DCsjLf8R9SrvYHa3Tk4nOOHel1Vwkpm3y6zELW8ijEcnzP7ia?= =?us-ascii?Q?ilARADaoXgW9VtpO/MPNvtcqTwqql6uGj/cI3mTWd8fdOjAX3UN3a1LMFWtw?= =?us-ascii?Q?6+vCCtwGIbY9rBi3RmBWqF5rD8VAdBP6SFdPw1vGeUz1UMfUynMCVLaoi/Px?= =?us-ascii?Q?G8jVgFF2FHRG7q34o+p4aDzroDzp1oWyMdi52RUGyjS+q1xdr7acMu135zlv?= =?us-ascii?Q?Jn9lTpUML1rfpPj/hu9dWURU74orgcwk5xJZf0WtLBWM6lQnvWlEXzseBlcV?= =?us-ascii?Q?q7rvdoPuSE0jjHj3ShioNDGQ84ZQfq57gnsX8wfoAbvCWJjAUWIwaCcEyYoU?= =?us-ascii?Q?1PjrbI9s7CHOBJrb7HvH3JnVqyTEU0NCbSIzryuGbzCD10VeOmcF1KuRJdmA?= =?us-ascii?Q?mXaCgL76xDj3HYoBA8q0QiEAdJe9paefGOxSFIWn1oPzUkyvYmAOykhGNlyN?= =?us-ascii?Q?hN8Xoj6vTfniOne8BgRNBVzl1XxH7kX3iEwfoCEKCtFGyKc+p4FIDDf4ymCX?= =?us-ascii?Q?W9gpK1NpgiG6ufuW1D+N3C9JPlHrMix3lMmNLdWyA331CSjM2gODpIagMpen?= =?us-ascii?Q?hfc8tUWuuLaRogYpwJzvLuhc6S5gRKb1uX4ZYe1rY5Qs0+MRb41b2oRtJuHW?= =?us-ascii?Q?TIwk7mRhYINzrLlj3eoWCjMrkh97/chKqSQnZoIl6MMjpb81Suy/8giG+ILa?= =?us-ascii?Q?C5vnogvU0gqASFQK2MQdZrIpl5ukvMhOAtMF2+m/mzbYi10mAm1LyXsAl6WL?= =?us-ascii?Q?1zqW/h4x2FsSQIg98lKvtmESDeiJ+37K0sYrW38BrPM=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR1801MB2058.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fd9a66d6-394f-49af-68ce-08d8a7252a8a X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Dec 2020 09:28:54.0418 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Da9jjFF7Skt6sQhs7BnCXmhDEjOOCSzCS35B8yuPkVuHAko0rh+d9Fca+U7vlMAiBILbd8N6uaw2zCTmqpvrdg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR18MB2795 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.343, 18.0.737 definitions=2020-12-23_04:2020-12-21, 2020-12-23 signatures=0 Subject: Re: [dpdk-dev] [PATCH v1 36/38] net/mvpp2: forward bad packets support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Reviewed-by: Michael Shamis -----Original Message----- From: dev On Behalf Of lironh@marvell.com Sent: Wednesday, December 2, 2020 12:12 PM To: Jerin Jacob Kollanukkaran Cc: dev@dpdk.org; Dana Vardi ; Liron Himi Subject: [dpdk-dev] [PATCH v1 36/38] net/mvpp2: forward bad packets support From: Dana Vardi extend the config file with option to forward packets that were marked as "= l2 bad pkts". by default the driver drop those packets Signed-off-by: Dana Vardi Reviewed-by: Liron Himi --- drivers/net/mvpp2/mrvl_ethdev.c | 10 ++++++++-- drivers/net/mvpp2/mrvl_et= hdev.h | 2 ++ drivers/net/mvpp2/mrvl_qos.c | 17 +++++++++++++++++ drivers/net/mvpp2/mrvl_qos.h | 1 + 4 files changed, 28 insertions(+), 2 deletions(-) diff --git a/drivers/net/mvpp2/mrvl_ethdev.c b/drivers/net/mvpp2/mrvl_ethde= v.c index cb792300b..4b5c4f075 100644 --- a/drivers/net/mvpp2/mrvl_ethdev.c +++ b/drivers/net/mvpp2/mrvl_ethdev.c @@ -798,9 +798,14 @@ mrvl_dev_start(struct rte_eth_dev *dev) priv->pp_id, priv->ppio_id); priv->ppio_params.match =3D match; priv->ppio_params.eth_start_hdr =3D PP2_PPIO_HDR_ETH; - if (mrvl_cfg) + priv->forward_bad_frames =3D 0; + + if (mrvl_cfg) { priv->ppio_params.eth_start_hdr =3D mrvl_cfg->port[dev->data->port_id].eth_start_hdr; + priv->forward_bad_frames =3D + mrvl_cfg->port[dev->data->port_id].forward_bad_frames; + } =20 /* * Calculate the minimum bpool size for refill feature as follows: @@ -2709,7 +2714,8 @@ mrvl_rx_pkt_burst(void *rxq, struct rte_mbuf **rx_pkt= s, uint16_t nb_pkts) =20 /* drop packet in case of mac, overrun or resource error */ status =3D pp2_ppio_inq_desc_get_l2_pkt_error(&descs[i]); - if (unlikely(status !=3D PP2_DESC_ERR_OK)) { + if ((unlikely(status !=3D PP2_DESC_ERR_OK)) && + !(q->priv->forward_bad_frames)) { struct pp2_buff_inf binf =3D { .addr =3D rte_mbuf_data_iova_default(mbuf), .cookie =3D (uint64_t)mbuf, diff --git a/drivers/net/mvpp2/mrvl_ethdev.h b/drivers/net/mvpp2/mrvl_ethde= v.h index 148f2acba..2c1c159b9 100644 --- a/drivers/net/mvpp2/mrvl_ethdev.h +++ b/drivers/net/mvpp2/mrvl_ethdev.h @@ -182,6 +182,8 @@ struct mrvl_priv { LIST_HEAD(shaper_profiles, mrvl_tm_shaper_profile) shaper_profiles; LIST_HEAD(nodes, mrvl_tm_node) nodes; uint64_t rate_max; + + uint8_t forward_bad_frames; }; =20 /** Flow operations forward declaration. */ diff --git a/drivers/net/mvpp2= /mrvl_qos.c b/drivers/net/mvpp2/mrvl_qos.c index 10e8636b4..f3936aec4 10064= 4 --- a/drivers/net/mvpp2/mrvl_qos.c +++ b/drivers/net/mvpp2/mrvl_qos.c @@ -76,6 +76,8 @@ #define MRVL_TOK_PARSER_UDF_PROTO_UDP "udp" #define MRVL_TOK_PARSER_UDF_FIELD_UDP_DPORT "dport" =20 +/* paser forward bad frames tokens */ +#define MRVL_TOK_FWD_BAD_FRAMES "forward_bad_frames" =20 /** Number of tokens in range a-b =3D 2. */ #define MAX_RNG_TOKENS 2 @@ -= 872,6 +874,21 @@ mrvl_get_cfg(const char *key __rte_unused, const char *pat= h, void *extra_args) return -1; } } + + /* Parse forward bad frames option */ + entry =3D rte_cfgfile_get_entry(file, sec_name, + MRVL_TOK_FWD_BAD_FRAMES); + if (entry) { + if (get_val_securely(entry, &val) < 0) { + MRVL_LOG(ERR, + "Error in parsing %s value (%s)!\n", + MRVL_TOK_FWD_BAD_FRAMES, entry); + return -1; + } + (*cfg)->port[n].forward_bad_frames =3D (uint8_t)val; + } else { + (*cfg)->port[n].forward_bad_frames =3D 0; + } } =20 return 0; diff --git a/drivers/net/mvpp2/mrvl_qos.h b/drivers/net/mvpp2/mrvl_qos.h in= dex daf4776ec..f2e341c37 100644 --- a/drivers/net/mvpp2/mrvl_qos.h +++ b/drivers/net/mvpp2/mrvl_qos.h @@ -48,6 +48,7 @@ struct mrvl_cfg { uint8_t use_global_defaults; struct pp2_cls_plcr_params policer_params; uint8_t setup_policer; + uint8_t forward_bad_frames; } port[RTE_MAX_ETHPORTS]; }; =20 -- 2.28.0