From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4DAF4A052A; Wed, 23 Dec 2020 10:28:33 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 85412CA86; Wed, 23 Dec 2020 10:28:21 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id BB895CA86 for ; Wed, 23 Dec 2020 10:28:18 +0100 (CET) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 0BN9AWLB019825 for ; Wed, 23 Dec 2020 01:28:16 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0220; bh=VQ13UbgvCC7kZ9qnH7eqG3CZPI5/YbrGhq895NP5miM=; b=kvOfokHBo6Lx//tnEBpOS5JatecUWLnYV7okZtMcml0B8l2N6kN1KVuv+QTEYfOorgxV sjn2Uro0yWuZRI0zDypIctrg+Uhxxs8Yh24rB/mAcQljAzEJXQsfnPmowIloSoRlwE9N NhHyvhhieLfdmHmlCHQjzaKw/t5kgnEmk+0X3HPjVyI76m1ok4jvve1d7yzIiUjWYPVu aQE/L1Sa4irD+GSoblAtaXkBlgNHvpQcwWFEoh9UcmstFC7XSaDDobWivbhmWlfIXGAo Pgcskn9Q+Fxt52SAf6/nfxusDcbsUepbDQYSnjelSWy0dx31KvqlmU6JqouQCbtTAkkO ug== Received: from sc-exch03.marvell.com ([199.233.58.183]) by mx0a-0016f401.pphosted.com with ESMTP id 35k0ebdr7h-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT) for ; Wed, 23 Dec 2020 01:28:16 -0800 Received: from DC5-EXCH02.marvell.com (10.69.176.39) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 23 Dec 2020 01:28:15 -0800 Received: from SC-EXCH02.marvell.com (10.93.176.82) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 23 Dec 2020 01:28:15 -0800 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.174) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Wed, 23 Dec 2020 01:28:14 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VazuQn7ySITesTZHFtIHdx3C9g7CA7boH7PoCbaMs8ncpY9vBiQ72feqPpTMxCYmeRjLD53umnTSZWD4tSLUQiXHwFYirecZkyoye9+kYmZi2buhLwRHckH1hct8XDGatsNQuUxcYwXrrBfQ7JOtrG8pzQ/4q6b+mr99Bn4qPy9KmRPnETB3/yPG8AQjvjq8spOvmMzkb2cOIn0QAAMvB/CbPcX5avelUKJ+BTaFqdhTm+mNpCRGgfy++tSB548m75Li2l12OgDISBtMe5AA72vzsbxuoBIFgYvPalNzTEzHoMXCMrq71M0sRiInv8yabNC3uLobqPmJUxXdyoN1Cg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VQ13UbgvCC7kZ9qnH7eqG3CZPI5/YbrGhq895NP5miM=; b=ncDK2/FAPpIRQtmn8rgr7zEIcAvNOGsOT9kPpaYt53TgOqaUqUITFhNs9FEm6taYyBRTljIH3NUmquDpAErefxZqEmIH/lkXTmBJEwPSxfuvUOkOVkSpE0Xuo7bo2/OHfgGnGVYQ6IZqPKUvoj8qNtCiaIJ5+eOU6PsGkMKHECNQuzcg/eDXv8tdeEqN8Nhi8g3gqdsqv3LqC6+bqmCkL82JvphEk0LhVlhp5bVjrAcErI7mjoVNO+cHcPY8cU88ezciW5bwNEwIF5tUQnku+xf+2iYXDk3A8VdV/VRJrTe0oSxStVqpD6HfhYbUqbr3Voo0B2qYp3MU9YIN/O9qPg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VQ13UbgvCC7kZ9qnH7eqG3CZPI5/YbrGhq895NP5miM=; b=b8LGf6rNAHJAospxLK3TYdDr0XDgiO/nG4k09fgUG9+wu2aPgHO7no6tdyTsQ7iVOkD7eqQn6Ms2w12aV2mC1u9qrTUqFyTBU5nmoXigA0rUKulBo6nk2Ftk5sL0YTdhR9v0ryFJhy9y9xSwUL+u95IxwL6b8NKe9MEk0Algc+M= Received: from DM5PR1801MB2058.namprd18.prod.outlook.com (2603:10b6:4:67::31) by DM6PR18MB2889.namprd18.prod.outlook.com (2603:10b6:5:163::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3676.33; Wed, 23 Dec 2020 09:28:13 +0000 Received: from DM5PR1801MB2058.namprd18.prod.outlook.com ([fe80::303b:5c79:93c7:b432]) by DM5PR1801MB2058.namprd18.prod.outlook.com ([fe80::303b:5c79:93c7:b432%7]) with mapi id 15.20.3676.033; Wed, 23 Dec 2020 09:28:13 +0000 From: Michael Shamis To: Liron Himi , Jerin Jacob Kollanukkaran CC: "dev@dpdk.org" , Dana Vardi , Liron Himi Thread-Topic: [dpdk-dev] [PATCH v1 38/38] net/mvpp2: add fill_bpool_buffs to cfg file Thread-Index: AQHWyJVpR4G1C4L84Ee1UPA5uPRm/6oEiqvQ Date: Wed, 23 Dec 2020 09:28:13 +0000 Message-ID: References: <20201202101212.4717-1-lironh@marvell.com> <20201202101212.4717-39-lironh@marvell.com> In-Reply-To: <20201202101212.4717-39-lironh@marvell.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [83.130.154.133] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 7d77217c-01e6-438d-95e8-08d8a725124b x-ms-traffictypediagnostic: DM6PR18MB2889: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:655; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 0UsBAI1S8ooobc2OkfWmnVqNaVD/LIcuWqghTozr2ODXWgQCYPvEW3mmfnpwENEsNyu6D2d11szm8qLXfCQt/qp6gCRuz/NYfW3oGTKAfUTpN3pk/OEhgy+JS3OD7u9XDIH0L5rTvg/Vu2h7LqgT2ejmf6drTj/EyJ+/UZAd3/1BAZFsbOPyreR6vURYp7ZVRtHOkCr6SY9ASFy7lbDV8mgyMfnxT2/gPwiSDWED6MNA6iCyZDZWRSjgzCq6/WqOR00PJqhK6ymFq1ZhFUkXXMov6HHD7iedIvIb9G+BWLikOqDMn312A14E9InPe0AJ2Z0Na/vHdi3VI0sU2070nCbW+GMrqNPmv+W68V2NTSy8W/Ot0Wnkq7X3AWI2zoqTt/07iicZyVOo941Yr8sqNw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM5PR1801MB2058.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(396003)(376002)(346002)(136003)(366004)(26005)(6636002)(54906003)(5660300002)(33656002)(478600001)(107886003)(52536014)(186003)(71200400001)(8936002)(66556008)(6506007)(66476007)(66446008)(83380400001)(7696005)(53546011)(76116006)(2906002)(66946007)(9686003)(64756008)(55016002)(316002)(86362001)(110136005)(4326008); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?grQ7BoVAD4ztu18VRqVlkASI5y8iKTW0LwX9HbI6er+dozQR97b0vvulZ6to?= =?us-ascii?Q?0/CRBvoFYaOj7lPCwBvIE4kPHzplqtq291MzjTG/e4E+J7tyZ3C2PEgz7KKU?= =?us-ascii?Q?yp+ADTsxtUcMPSDKUF7MvZTB3IpLodzjca+3JTZvUyhIKXM+ISWVvntHWU62?= =?us-ascii?Q?rOkNG/3gs2oV/tOr2pMewbYCftINsF64tjjHSrAXxrvBgRj5XcP+kBxHE63U?= =?us-ascii?Q?rkR9zMEqs1GeKsvFLgG1MS0lxhQTVwGYwrNr5HlaWEjojmbNl/Jhpty2F/zw?= =?us-ascii?Q?b1KIWJlna/yrIb+ZneBUTBTHnMoYOHBy4GXI49vvhYJqiRLLEYLZx6QK89nG?= =?us-ascii?Q?3eA9sjYML8YoOf+uM8p1dHsNr5/JUSvBbAUBGhebCPQG+5bcBX2MekRZu17x?= =?us-ascii?Q?XZ50IqwlYF+mZefuWsDHz86PzqaonXjmz7gVd2gOwdWfqlE6S2iqKQZLdpXe?= =?us-ascii?Q?RnoVD3EkaIY+19XISrLk//HBnBZJcix4AcDaIGxOOpETaP94aIdhsYdS7sFw?= =?us-ascii?Q?utkdWVvvtfxJaBbmyCUF4vdKvHFdgauN8d5PxYOBtjOjMqf0B3DN9KiSYHy2?= =?us-ascii?Q?9uVpCUNPMbkG//28/Nx26mvDiObvBRO3Ds+L9Yumhy2jibIgHgjAdY8KURm1?= =?us-ascii?Q?y3cPmc7+KEfTi4PRHM+2GNZbSiKgpmkEZYUlu4vLrwdWIpD708Q0mGck4ynl?= =?us-ascii?Q?aBwj/c1qiIv1HY/Ifb4yIgrLc547c4F+J2xBaEcROchOUsZBv7Tp8G6B6GC+?= =?us-ascii?Q?K4n/IMosTo46L5UjVIYE66VImujkhh3pFSe2V4MVxf3u7UkpNjZgkiK+8NQ1?= =?us-ascii?Q?nnEMJzluTrAcPQdabzvIZLIjUHfyR7+IswNrjJgDbICLwE6qpgqX2CsE1KXC?= =?us-ascii?Q?zpRDk6HHSvWkbtujI8VRciU/S34ItHK8wqhCd2+NbtqEYbNdsKmtHEKJP1cz?= =?us-ascii?Q?/TQVSdLGdzhTo3bdoLZeYjOiO7cd4jYy5QnLMO2sWtE=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR1801MB2058.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7d77217c-01e6-438d-95e8-08d8a725124b X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Dec 2020 09:28:13.3718 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: GoP8VhUe4Le/+r7V3/6EYSlkqHtmDO63NK35+ZTCzPFkLV27EiS7UJDRshwZkaNSX2jjj2OiBhk2zeektkOOWw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR18MB2889 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.343, 18.0.737 definitions=2020-12-23_04:2020-12-21, 2020-12-23 signatures=0 Subject: Re: [dpdk-dev] [PATCH v1 38/38] net/mvpp2: add fill_bpool_buffs to cfg file X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Reviewed-by: Michael Shamis -----Original Message----- From: dev On Behalf Of lironh@marvell.com Sent: Wednesday, December 2, 2020 12:12 PM To: Jerin Jacob Kollanukkaran Cc: dev@dpdk.org; Dana Vardi ; Liron Himi Subject: [dpdk-dev] [PATCH v1 38/38] net/mvpp2: add fill_bpool_buffs to cfg= file From: Dana Vardi extend config file with 'fill_bpool_buffs' which control the amount of refill buffers Signed-off-by: Dana Vardi Reviewed-by: Liron Himi --- drivers/net/mvpp2/mrvl_ethdev.c | 7 ++++--- drivers/net/mvpp2/mrvl_ethde= v.h | 3 +++ drivers/net/mvpp2/mrvl_qos.c | 21 +++++++++++++++++++++ drivers/net/mvpp2/mrvl_qos.h | 1 + 4 files changed, 29 insertions(+), 3 deletions(-) diff --git a/drivers/net/mvpp2/mrvl_ethdev.c b/drivers/net/mvpp2/mrvl_ethde= v.c index ca94805fb..725ecced4 100644 --- a/drivers/net/mvpp2/mrvl_ethdev.c +++ b/drivers/net/mvpp2/mrvl_ethdev.c @@ -52,8 +52,6 @@ #define MRVL_IFACE_NAME_ARG "iface" #define MRVL_CFG_ARG "cfg" =20 -#define MRVL_BURST_SIZE 64 - #define MRVL_ARP_LENGTH 28 =20 #define MRVL_COOKIE_ADDR_INVALID ~0ULL @@ -799,12 +797,15 @@ mrvl_dev_start(struct rte_eth_dev *dev) priv->ppio_params.match =3D match; priv->ppio_params.eth_start_hdr =3D PP2_PPIO_HDR_ETH; priv->forward_bad_frames =3D 0; + priv->fill_bpool_buffs =3D MRVL_BURST_SIZE; =20 if (mrvl_cfg) { priv->ppio_params.eth_start_hdr =3D mrvl_cfg->port[dev->data->port_id].eth_start_hdr; priv->forward_bad_frames =3D mrvl_cfg->port[dev->data->port_id].forward_bad_frames; + priv->fill_bpool_buffs =3D + mrvl_cfg->port[dev->data->port_id].fill_bpool_buffs; } =20 /* @@ -2754,7 +2755,7 @@ mrvl_rx_pkt_burst(void *rxq, struct rte_mbuf **rx_pkt= s, uint16_t nb_pkts) =20 if (unlikely(num <=3D q->priv->bpool_min_size || (!rx_done && num < q->priv->bpool_init_size))) { - ret =3D mrvl_fill_bpool(q, MRVL_BURST_SIZE); + ret =3D mrvl_fill_bpool(q, q->priv->fill_bpool_buffs); if (ret) MRVL_LOG(DEBUG, "Failed to fill bpool"); } else if (unlikely(num > q->priv->bpool_max_size)) { diff --git a/drive= rs/net/mvpp2/mrvl_ethdev.h b/drivers/net/mvpp2/mrvl_ethdev.h index 2c1c159b= 9..fc4f3b799 100644 --- a/drivers/net/mvpp2/mrvl_ethdev.h +++ b/drivers/net/mvpp2/mrvl_ethdev.h @@ -82,6 +82,8 @@ /** Maximum length of a match string */ #define MRVL_MATCH_LEN 16 =20 +#define MRVL_BURST_SIZE 64 + /** PMD-specific definition of a flow rule handle. */ struct mrvl_mtr; s= truct rte_flow { @@ -184,6 +186,7 @@ struct mrvl_priv { uint64_t rate_max; =20 uint8_t forward_bad_frames; + uint32_t fill_bpool_buffs; }; =20 /** Flow operations forward declaration. */ diff --git a/drivers/net/mvpp2= /mrvl_qos.c b/drivers/net/mvpp2/mrvl_qos.c index d9af07c3d..8a6ad5d3b 10064= 4 --- a/drivers/net/mvpp2/mrvl_qos.c +++ b/drivers/net/mvpp2/mrvl_qos.c @@ -79,6 +79,9 @@ /* paser forward bad frames tokens */ #define MRVL_TOK_FWD_BAD_FRAMES "forward_bad_frames" =20 +/* parse fill bpool buffers tokens */ +#define MRVL_TOK_FILL_BPOOL_BUFFS "fill_bpool_buffs" + /** Number of tokens in range a-b =3D 2. */ #define MAX_RNG_TOKENS 2 =20 @@ -720,6 +723,11 @@ mrvl_get_cfg(const char *key __rte_unused, const char = *path, void *extra_args) /* Use global defaults, unless an override occurs */ (*cfg)->port[n].use_qos_global_defaults =3D 1; =20 + /* Set non-zero defaults before the decision to continue to next + * port or to parse the port section in config file + */ + (*cfg)->port[n].fill_bpool_buffs =3D MRVL_BURST_SIZE; + /* Skip ports non-existing in configuration. */ if (rte_cfgfile_num_sections(file, sec_name, strlen(sec_name)) <=3D 0) { @@ -889,6 +897,19 @@ mrvl_get_cfg(const char *key __rte_unused, const char = *path, void *extra_args) } else { (*cfg)->port[n].forward_bad_frames =3D 0; } + + /* Parse fill bpool buffs option */ + entry =3D rte_cfgfile_get_entry(file, sec_name, + MRVL_TOK_FILL_BPOOL_BUFFS); + if (entry) { + if (get_val_securely(entry, &val) < 0) { + MRVL_LOG(ERR, + "Error in parsing %s value (%s)!\n", + MRVL_TOK_FILL_BPOOL_BUFFS, entry); + return -1; + } + (*cfg)->port[n].fill_bpool_buffs =3D val; + } } =20 return 0; diff --git a/drivers/net/mvpp2/mrvl_qos.h b/drivers/net/mvpp2/mrvl_qos.h in= dex 763130bf1..38ea309ca 100644 --- a/drivers/net/mvpp2/mrvl_qos.h +++ b/drivers/net/mvpp2/mrvl_qos.h @@ -49,6 +49,7 @@ struct mrvl_cfg { struct pp2_cls_plcr_params policer_params; uint8_t setup_policer; uint8_t forward_bad_frames; + uint32_t fill_bpool_buffs; } port[RTE_MAX_ETHPORTS]; }; =20 -- 2.28.0