From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 13C50A052A; Wed, 23 Dec 2020 10:45:46 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 3F014CD27; Wed, 23 Dec 2020 10:43:04 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id D4769CCC7; Wed, 23 Dec 2020 10:43:01 +0100 (CET) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 0BN9V44K002511; Wed, 23 Dec 2020 01:43:01 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0220; bh=ne69fp9G6/ibShOEUz2cfo1eOS+EdItk4S4dnFV7evE=; b=MO/QYFKocZMjyiYJOFZ+gUO300xJmMFlhphyW8yCAC+l2RQj/4YwvJSaf7KTdKZ79d6z 7NqViSleLNWlnVE4UCsu5VHZ79tGQSneySETrmFI4B/odsEhlZgCGbqDDSSNN5/7J1xa 6VJ85gr4YeR9o90YzbwyNf4FZp1WvHgyYaskGbNT6wMF/pk3CmeTQzEZdF9XxqIW9CEh VNrj2i7/0yoenyAKoGcdGXCEWHvpw0g/VZBZpjtDq/m2VAEhHVxgOeizz1fVRUxaoTh+ wdIRuY4xfmwxYnrFamT/CcdepSE46O5HbHvF3kZx7mSoNJFqh3mXTZM/Jauh6+bwLiYM gA== Received: from sc-exch03.marvell.com ([199.233.58.183]) by mx0b-0016f401.pphosted.com with ESMTP id 35k0hx5nav-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Wed, 23 Dec 2020 01:43:01 -0800 Received: from DC5-EXCH02.marvell.com (10.69.176.39) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 23 Dec 2020 01:42:59 -0800 Received: from SC-EXCH02.marvell.com (10.93.176.82) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 23 Dec 2020 01:42:58 -0800 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.173) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Wed, 23 Dec 2020 01:42:58 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jazpnDerg/GJboLUUxmvgZW8MjZWEZcN4gHI0AidvFrIPiFN1ymn/rw8a47Gth1IivPDgjh/LfuqY1T3OuoWITZmADFB5KzOWeX7kS2gOT8MEDtcIF0MJgBVYetwkUbuXUX2RePr7ytDH4av72UGcVK/7QC7woNzgrPt47rDjnU72rkFxGrBu1mT1ND+9WhRX7rinrx9wOpWtgymToseqYPEwZq87LOxDWOVyMZLvOLZ2ysArq3EYTMKjE/Bq/SgSfA6LYJkKzvt5x32Ln+skNQ78VjLP4JP+WsRlJUy+u8qVHFoforRQgMl+V4wjaOHRhdlylHjipSNB9LuATAIGg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ne69fp9G6/ibShOEUz2cfo1eOS+EdItk4S4dnFV7evE=; b=LFhwcGyTnkGx8d+7Z7rtNbs5lr7pO5FHIFyqQmCpS1JQ6arkrMYBWSR/rgBZoxuWyK6+tneBp6OCPgmw3I+FBjTnX2H3rVSSBqfVAIeJbT/7LNvIRN3fhFWQ+RZOO+37xVmkvwu1tHTkhYzwF8EOgr4ShQ/zBgtAuLRyFu0MNIaLeqC90OXypJxMjMcGS5GJYLYcH4CXhvT7A7iYNjUdTP3hhE0XFVgbgRlQrSLWoa4d/XNXR7qmX6yytO+81iwl/MSG+3XqzRsETNGimcTbtFub1R6gjCnfaJmB7eTpKbuXiGWfbylVQSJtW3sfJQldK9+8n19v/GuI0TDf4WTKlA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ne69fp9G6/ibShOEUz2cfo1eOS+EdItk4S4dnFV7evE=; b=VvMrcrsMe0qpsC0G2yw58U4tRBN0lkwzGP1w1xxcGgXuCQOzcxSKxbp/vH0cHpr12iDq5fd2Pl0Hv65UGGvetLSD1FtSKiYsPIs+17Uonyim9zoKIcdc5T/R238paAGvCIwbk52HdMrX2vh8PJGj2bdx66HpXvMRpKK7F1s0A3Q= Received: from DM5PR1801MB2058.namprd18.prod.outlook.com (2603:10b6:4:67::31) by DM6PR18MB3603.namprd18.prod.outlook.com (2603:10b6:5:2a5::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3700.27; Wed, 23 Dec 2020 09:42:57 +0000 Received: from DM5PR1801MB2058.namprd18.prod.outlook.com ([fe80::303b:5c79:93c7:b432]) by DM5PR1801MB2058.namprd18.prod.outlook.com ([fe80::303b:5c79:93c7:b432%7]) with mapi id 15.20.3676.033; Wed, 23 Dec 2020 09:42:57 +0000 From: Michael Shamis To: Liron Himi , Jerin Jacob Kollanukkaran CC: "dev@dpdk.org" , Liron Himi , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v1 04/38] net/mvpp2: skip vlan flush Thread-Index: AQHWyJPxdNiaRiGitUeKad4CCb04y6oEjs0g Date: Wed, 23 Dec 2020 09:42:57 +0000 Message-ID: References: <20201202101212.4717-1-lironh@marvell.com> <20201202101212.4717-5-lironh@marvell.com> In-Reply-To: <20201202101212.4717-5-lironh@marvell.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [83.130.154.133] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b6f21cad-eca7-4ccd-c1d8-08d8a727214e x-ms-traffictypediagnostic: DM6PR18MB3603: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4303; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: fvlZiPqxf5ltKxdlVEdNU0uvkxvtsc9vo1AXZnab8Uss/CSBy1/LzswAZAoeHX+6+3FFm4HmzGPTgGwTw8IuU+s7hzbQibNs53pKtOySHHhLrY8FR5bvgeb/4Nb1bbqEkKwrcvfKUnFNnJricUYrA3CXd8AAFZB41hmnfNzhyWRQ3SZM0xxv9BsBBgeLMH0VUls0XhrqSh4ObLdJ6x0MWrguTvp9xpDnn5esOmShHOjKyrbwJY1Fz3w6hD13+N4ZbL1DuL/uRvsOYk4Zs4v5Dlf0pwgZjRlhK3xL7fhPrPnyn5Ue4AZmT8scKJxlXG66TRboyu1N5oz+ebINDOxON1XMMo6uySdOvw03M79CZGxjI338a90isjLQwQQQi7+QWUcoYgG6C19GiLAN+isLfA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM5PR1801MB2058.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(39860400002)(346002)(366004)(376002)(396003)(66446008)(53546011)(54906003)(450100002)(66556008)(52536014)(66476007)(66946007)(4326008)(5660300002)(64756008)(33656002)(8676002)(9686003)(6506007)(76116006)(55016002)(6636002)(86362001)(71200400001)(478600001)(7696005)(186003)(2906002)(110136005)(316002)(83380400001)(26005)(8936002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?TzZPGF6DoVx6S5+I3h2fCz9PSrdvv8UXvQabjvjiNepn7gumIqttbyVcOCCk?= =?us-ascii?Q?2L+WJxomXzOhYGIfOykVPtv/uWZydq8trsWqrSchZK61xiphNmjIAs1EurWy?= =?us-ascii?Q?MIIAFrHoKNhDnPkU6WVpHTyRrkNAsZIrcmNUTr5GndMg73oGF1/fhbavpVBD?= =?us-ascii?Q?n9S5cnjXIxWAcDkXBVvAHFLsrgI+o6/5lHGkPjzl8drxzWSaKgHXkV5hXc0o?= =?us-ascii?Q?qpMBXNciki7PA5EVMsN+IQysnomca/H1st15iYFMDGGmYQmHgnDLLOnh1WLa?= =?us-ascii?Q?9iPjG3c+5YvsQms7wdXQv32TupszL9gmLxkJEd1cBQki7+k9+JicAwCNa4ir?= =?us-ascii?Q?b3fEflr1EoJLe6/HpN8lhxJKvaxHBcupt6c/llVlR52vVLRvrNlReEIItAQs?= =?us-ascii?Q?zZsqgFWqwuRf97Aj5sNgVNES6cpm8T/v3Ic0QIKojNMbgSOoSqhrH9PvSgHf?= =?us-ascii?Q?ozkmabK8NP1AFs3SbXaCdZLdcdvshivsWsaNxjY2iGoGIcbgSCk48VL3ljAc?= =?us-ascii?Q?J+hLeQ55goazWEIS9JOrh2zKSoN+xmm08JVw4p5BSpz90MghZjrzQTM0qvaw?= =?us-ascii?Q?rBYVucN/4d1DcFnoFG+z9w2uYkJhJL051GdXTMjMTd2HCjUhHHFgzsW0LIdf?= =?us-ascii?Q?guwMvO2p9VxeqOgILqHqnaknZQ7coKha3o5oCvPjVlrEdTgH3LkaYX9l7PXx?= =?us-ascii?Q?PYca66aTEvawRpolN5DZSV9sHNyETsCnjnzTGSFh5fheMtgJTjv/yUDGfx9G?= =?us-ascii?Q?oSXicHGOgkGWW7781H+jCY/bOfnv0CI6TS6MPDzVNKtrcxro6Ff8LBVqZW1X?= =?us-ascii?Q?dUM05mx9TiSZKiuPN57g/19bDW+3gMUG3VHy1AM3GtTU93+mcTYJ7dbxp4RY?= =?us-ascii?Q?GTTvjsKBRVbs5K1sEBHTv1sNeQGWpqIplJhYy+pZ3PABCIaAHCZyi7Ynrhor?= =?us-ascii?Q?1KocTZ8ZWkP4/xsIfhuggzPRjQuP5+76gLcoU292Gdw=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR1801MB2058.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b6f21cad-eca7-4ccd-c1d8-08d8a727214e X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Dec 2020 09:42:57.1431 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: H1mEoKL/cPe1DhjmHF4s5RCAgaWIV/Hnedvcf1vaJD6fLEF99+aFeIsmGb1pGN6hZLDArh2aViDlRyMcwQbxSw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR18MB3603 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.343, 18.0.737 definitions=2020-12-23_04:2020-12-21, 2020-12-23 signatures=0 Subject: Re: [dpdk-dev] [PATCH v1 04/38] net/mvpp2: skip vlan flush X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Reviewed-by: Michael Shamis -----Original Message----- From: dev On Behalf Of lironh@marvell.com Sent: Wednesday, December 2, 2020 12:12 PM To: Jerin Jacob Kollanukkaran Cc: dev@dpdk.org; Liron Himi ; stable@dpdk.org Subject: [dpdk-dev] [PATCH v1 04/38] net/mvpp2: skip vlan flush From: Liron Himi vlan-flush in MUSDK is not supported yet. until it does, the code should be skipped as currently an redundant error = message is displayed. Fixes: a8f3d6783 ("net/mrvl: support VLAN filtering") Cc: stable@dpdk.org Signed-off-by: Liron Himi Reviewed-by: Liron Himi --- drivers/net/mvpp2/mrvl_ethdev.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/net/mvpp2/mrvl_ethdev.c b/drivers/net/mvpp2/mrvl_ethde= v.c index ebd2bb1c8..0985ccebe 100644 --- a/drivers/net/mvpp2/mrvl_ethdev.c +++ b/drivers/net/mvpp2/mrvl_ethdev.c @@ -672,15 +672,15 @@ mrvl_dev_start(struct rte_eth_dev *dev) } =20 if (!priv->vlan_flushed) { - ret =3D pp2_ppio_flush_vlan(priv->ppio); - if (ret) { - MRVL_LOG(ERR, "Failed to flush vlan list"); - /* - * TODO - * once pp2_ppio_flush_vlan() is supported jump to out - * goto out; - */ - } + /* + * TODO + * once pp2_ppio_flush_vlan() is supported call it + * ret =3D pp2_ppio_flush_vlan(priv->ppio); + * if (ret) { + * MRVL_LOG(ERR, "Failed to flush vlan list"); + * goto out; + * } + */ priv->vlan_flushed =3D 1; } ret =3D mrvl_mtu_set(dev, dev->data->mtu); -- 2.28.0