From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1B0A8A052A; Wed, 23 Dec 2020 10:34:03 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id EA238CA74; Wed, 23 Dec 2020 10:34:01 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 6E456CA74 for ; Wed, 23 Dec 2020 10:34:00 +0100 (CET) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 0BN9UXDj023492 for ; Wed, 23 Dec 2020 01:33:58 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0220; bh=GLG9BJcoUlUyVDouo+lXO0xJ1QlJ7IKdD1NMALZIrLs=; b=Nvfc0ZV5/RnarYNxQydASAdkcF4UiTYtV6XVgEi3Q2DuVz6dfpi5AP6z0mt7X2E+qAqR tGWRawDWP4RxNFigVdZrLD0AD0v9YOIqM49iLnOUxr8lFXngZXYZZMLShoohhpEa9AfX IV9iZrh+BwH1lAZecJnuDl4PA1QEDskf38SVEC+J1EeE3WZzlsvk8zNbag6LUHX1zmEp q9L/hRxYDai4tveFUFslbZmcAY7lgbZKLVlIVFQLENja6c5BY1yJTjAjwpuAPmHapHTA sn6SO/ZtPxatJ1NZsLAE5Yqvji6uSLMMvx4okeKkoxyRjXeEF5p+o8ioCu46TKRdsewn VA== Received: from sc-exch02.marvell.com ([199.233.58.182]) by mx0a-0016f401.pphosted.com with ESMTP id 35k0ebdrpf-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT) for ; Wed, 23 Dec 2020 01:33:58 -0800 Received: from DC5-EXCH01.marvell.com (10.69.176.38) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 23 Dec 2020 01:33:57 -0800 Received: from SC-EXCH02.marvell.com (10.93.176.82) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 23 Dec 2020 01:33:56 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.176) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Wed, 23 Dec 2020 01:33:56 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=CAIMZolNhtfb+Ocl0Z9VOb1EV/wgG7bZsiOTs1JQXzhp103mZPPve6fOvp3AXaYWcFkCvLf4PvG7Ko3RBbNjKaemt36xbJEVrVm/rWxdOOAy631FvaPshTSb82IE5hXHNn+6fbgAyK+dOGK3nsjwlanGcC6MZqcJE0VzXsMC5azi5fRvNPi47SwoZ09gG/NjQemMpdxUObTh0pT0lvKHdIlLIRrTsf2a9r9OfD2jyg1rY+dbxV5MndLr17Twp3LcB9H6aydmXJ9Zx2LAlj1rp4mZFNC035lmQyFSbk/ZLib1GMiHgqXH6cyCg/uvPOsyH7DzmqBPAWPCD03hncTRRg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GLG9BJcoUlUyVDouo+lXO0xJ1QlJ7IKdD1NMALZIrLs=; b=gME+0vc1sa+QUnXC7dzA9qvX6O64JoiWk5CfUDvsA+tXY0y2QpQASZ8HOKk0k4pmYpBFh5XNtlyQAn/YW2dT1vEp4qx8p6qbdyw98RrGgFDYiNGMX4+9wY8WLCq7maHxjIzFbxIl5DKokVDlpnZGK7A167wuxYn/JbVjBYpUk0zqRaxCcej9mvV+o6d7ThxPdRXL1y5zzBzDTdVTAiml7FTluKlVgJ9aQm0bh0okP+4VLl+O00FQ9E5LoMd2B4wHEXU+1Vu6AmH8vCqH8V7gL4QrpHN2dB9D+fYI2BcD4ySQlocTOCoQSx8Gzjlkl0UsGf05OxK7oKKjZJM/PP8Srg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GLG9BJcoUlUyVDouo+lXO0xJ1QlJ7IKdD1NMALZIrLs=; b=jrnTyitcIlyngs61D5AS2tCRTFtJZeL9NH4kAeRqMABFRz5ZFtneoRcHi94SKqqZY5/cyYY7giT+pPj10r5a414vKkFiSyoXu7pnXRbj6TWDea/AIvkoi1I42oBA/eIxrvmXMmschceENerkWMPT1FVPKv5xdRUE8OgzKhFwavw= Received: from DM5PR1801MB2058.namprd18.prod.outlook.com (2603:10b6:4:67::31) by DM6PR18MB2795.namprd18.prod.outlook.com (2603:10b6:5:172::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3700.27; Wed, 23 Dec 2020 09:33:55 +0000 Received: from DM5PR1801MB2058.namprd18.prod.outlook.com ([fe80::303b:5c79:93c7:b432]) by DM5PR1801MB2058.namprd18.prod.outlook.com ([fe80::303b:5c79:93c7:b432%7]) with mapi id 15.20.3676.033; Wed, 23 Dec 2020 09:33:55 +0000 From: Michael Shamis To: Liron Himi , Jerin Jacob Kollanukkaran CC: "dev@dpdk.org" , Liron Himi Thread-Topic: [dpdk-dev] [PATCH v1 26/38] net/mvpp2: rearrange functions order Thread-Index: AQHWyJTpg0PnL0PSkUidUDBvDFbRS6oEjBmw Date: Wed, 23 Dec 2020 09:33:55 +0000 Message-ID: References: <20201202101212.4717-1-lironh@marvell.com> <20201202101212.4717-27-lironh@marvell.com> In-Reply-To: <20201202101212.4717-27-lironh@marvell.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [83.130.154.133] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f0d14e7c-9b71-480d-7811-08d8a725de16 x-ms-traffictypediagnostic: DM6PR18MB2795: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:3276; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: vUSYB5hJ0RHn06OuGDm0UUYIgPLc6BSTv8xvK9olhNnj5dtsqo2uR8b6QQ2wPvzKXyIafEEOp58cFytFpT4NZMSdQrA6Wu2BaC16hhU3CrL5gEagPa0qO6FmGDxWXJQJ/mHEOcEbzdsOaVmupfJtqMJ6P6+yiRFt4KogmVbZQ2kn0GwTZ4yMXQSyCt6Nj2Xu4cMnBSHZ0jmIwDueR8UYD2r6QavC3/1hY/toGiev7oViJZ1siHzjYb1AiewTrGjhVPT9Znd26ih/qdU7Dnex1lwKJNcDiX21tGim5tBOTGvWZTNTfGf3dA2c2/yddgS0ape3QENz/qpxN0d5E54c0ee0+9SZ9dGt27ML7H2/yuCyNZavCLIV4K7yq3BPCT8NOrZ1CEbNJp+QmDNuTr2pHA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM5PR1801MB2058.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(396003)(39860400002)(346002)(376002)(366004)(7696005)(26005)(54906003)(2906002)(8676002)(478600001)(186003)(9686003)(5660300002)(55016002)(83380400001)(4326008)(107886003)(8936002)(66946007)(86362001)(64756008)(66556008)(53546011)(66476007)(6636002)(6506007)(52536014)(33656002)(76116006)(110136005)(71200400001)(66446008)(316002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?mBGyOwzMOpXKLRHG08MXHLJS4NvVyi9DPvlzZ4qahXZ4RqPz1f46GdfCxNnl?= =?us-ascii?Q?UrEucLtqYV/xCn6NpkBORtuIF/ZBDd5bO3kVu5rY+yLqDPlVyIIqe5zanFRf?= =?us-ascii?Q?iRquP1g18dVLsGU9gEJRkUVQER/hc0rqFSR4x+pZ8CTrbeM6lRd+b606mdSK?= =?us-ascii?Q?SDUZ6NInKQ4qSE0DzEKMAQ4bULzCN6GzoZiv2iTH6IXLGvHZtWiVfePXmiHp?= =?us-ascii?Q?Hjfqf9XaKwyoPJMxbuu2qti0L2SUo6YuZQ1DCISv1tylgmNU21YBz0X3mbye?= =?us-ascii?Q?vv7k3T4LjwR2To+VuQDiqI5NWV+dw0c7ZP3+EGx8qAZB4KSjPqz4vhDW0/JE?= =?us-ascii?Q?q/NCcMl5G4ternMkstU+71q1s42Lyz2P+w4/Vs3DdED3NhFMh8sac1QWsOEZ?= =?us-ascii?Q?cIzPknQ3smWVd3KMKrP4iKKPQlg2q4feL3qnk7SFw1c9wR09i0heAsc9+oNF?= =?us-ascii?Q?ov5MlkrJ2ftQNPoJR9Fc4rAwQsfTCvw4TPIrN8lxpwsB6kKW+PxyuLKwUvnB?= =?us-ascii?Q?U7O45jPvKhuYRMBzmwwKLHr9jsqlmrRH2+tomKgVwmBdSHjRxXik4BSatXeD?= =?us-ascii?Q?QpX2eC5EZrd4WouOVNrrPeq0ybVsri5Z1Mo7ZnakXl31cNrYxF5e3opGB+Mx?= =?us-ascii?Q?uK5C0dZdGK4qVPdoq2cuEh4Ex8zh6GN56vnNQKyBmNqjUFbUlXD21mzjoKpa?= =?us-ascii?Q?Gw/amf72cGY0cOw4DTuK3UFgwO/rf4xDMP0vEmL8cILzKbNaJp8jlCJnauqL?= =?us-ascii?Q?gh9U8cVmPN4goYYMCqpHkzNYMyVj1o/BYRINuLBujreakWNbarOeyPWOBEou?= =?us-ascii?Q?psfEQ34VSpOmRo7lIaGLhB/Rv60PFH4oVFLD4jYDJsfb2fn8xsH2XjOyjJlK?= =?us-ascii?Q?8juuGLWnOZrKBAqXM5+TnSpcJiK1Sj099xlgEne70IAdJk8g6gAc1UIJuQD1?= =?us-ascii?Q?QZr6pkcO+KfYIWY8VUFPdFqPw8KItEl29edwJ2P2paI=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR1801MB2058.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f0d14e7c-9b71-480d-7811-08d8a725de16 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Dec 2020 09:33:55.3598 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 7a//w3KnAMeNMyMET1UwsyQUHBWKCUI5+XJOSHsPPkXS+C7pbnw6W3ySEqE+gBQWJ3Zu7UPudWF0M9PQWSqKSA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR18MB2795 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.343, 18.0.737 definitions=2020-12-23_04:2020-12-21, 2020-12-23 signatures=0 Subject: Re: [dpdk-dev] [PATCH v1 26/38] net/mvpp2: rearrange functions order X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Reviewed-by: Michael Shamis -----Original Message----- From: dev On Behalf Of lironh@marvell.com Sent: Wednesday, December 2, 2020 12:12 PM To: Jerin Jacob Kollanukkaran Cc: dev@dpdk.org; Liron Himi Subject: [dpdk-dev] [PATCH v1 26/38] net/mvpp2: rearrange functions order From: Liron Himi rearrange functions order Signed-off-by: Liron Himi Reviewed-by: Liron Himi --- drivers/net/mvpp2/mrvl_ethdev.c | 98 ++++++++++++++++----------------- 1 file changed, 49 insertions(+), 49 deletions(-) diff --git a/drivers/net/mvpp2/mrvl_ethdev.c b/drivers/net/mvpp2/mrvl_ethde= v.c index 5ff11e2c9..127861a82 100644 --- a/drivers/net/mvpp2/mrvl_ethdev.c +++ b/drivers/net/mvpp2/mrvl_ethdev.c @@ -189,6 +189,39 @@ static struct { MRVL_XSTATS_TBL_ENTRY(tx_errors) }; =20 +/** + * Initialize packet processor. + * + * @return + * 0 on success, negative error value otherwise. + */ +static int +mrvl_init_pp2(void) +{ + struct pp2_init_params init_params; + + memset(&init_params, 0, sizeof(init_params)); + init_params.hif_reserved_map =3D MRVL_MUSDK_HIFS_RESERVED; + init_params.bm_pool_reserved_map =3D MRVL_MUSDK_BPOOLS_RESERVED; + init_params.rss_tbl_reserved_map =3D MRVL_MUSDK_RSS_RESERVED; + if (mrvl_cfg && mrvl_cfg->pp2_cfg.prs_udfs.num_udfs) + memcpy(&init_params.prs_udfs, &mrvl_cfg->pp2_cfg.prs_udfs, + sizeof(struct pp2_parse_udfs)); + return pp2_init(&init_params); +} + +/** + * Deinitialize packet processor. + * + * @return + * 0 on success, negative error value otherwise. + */ +static void +mrvl_deinit_pp2(void) +{ + pp2_deinit(); +} + static inline void mrvl_fill_shadowq(struct mrvl_shadow_txq *sq, struct rte_mbuf *buf) { @@ = -292,6 +325,22 @@ mrvl_get_hif(struct mrvl_priv *priv, int core_id) return hifs[core_id]; } =20 +/** + * Deinitialize per-lcore MUSDK hardware interfaces (hifs). + */ +static void +mrvl_deinit_hifs(void) +{ + int i; + + for (i =3D mrvl_lcore_first; i <=3D mrvl_lcore_last; i++) { + if (hifs[i]) + pp2_hif_deinit(hifs[i]); + } + used_hifs =3D MRVL_MUSDK_HIFS_RESERVED; + memset(hifs, 0, sizeof(hifs)); +} + /** * Set tx burst function according to offload flag * @@ -3012,39 +3061,6 @@ mrvl_tx_sg_pkt_burst(void *txq, struct rte_mbuf **tx= _pkts, return nb_pkts; } =20 -/** - * Initialize packet processor. - * - * @return - * 0 on success, negative error value otherwise. - */ -static int -mrvl_init_pp2(void) -{ - struct pp2_init_params init_params; - - memset(&init_params, 0, sizeof(init_params)); - init_params.hif_reserved_map =3D MRVL_MUSDK_HIFS_RESERVED; - init_params.bm_pool_reserved_map =3D MRVL_MUSDK_BPOOLS_RESERVED; - init_params.rss_tbl_reserved_map =3D MRVL_MUSDK_RSS_RESERVED; - if (mrvl_cfg && mrvl_cfg->pp2_cfg.prs_udfs.num_udfs) - memcpy(&init_params.prs_udfs, &mrvl_cfg->pp2_cfg.prs_udfs, - sizeof(struct pp2_parse_udfs)); - return pp2_init(&init_params); -} - -/** - * Deinitialize packet processor. - * - * @return - * 0 on success, negative error value otherwise. - */ -static void -mrvl_deinit_pp2(void) -{ - pp2_deinit(); -} - /** * Create private device structure. * @@ -3184,22 +3200,6 @@ mrvl_get_ifnames(const char *key __rte_unused, const= char *value, return 0; } =20 -/** - * Deinitialize per-lcore MUSDK hardware interfaces (hifs). - */ -static void -mrvl_deinit_hifs(void) -{ - int i; - - for (i =3D mrvl_lcore_first; i <=3D mrvl_lcore_last; i++) { - if (hifs[i]) - pp2_hif_deinit(hifs[i]); - } - used_hifs =3D MRVL_MUSDK_HIFS_RESERVED; - memset(hifs, 0, sizeof(hifs)); -} - /** * DPDK callback to register the virtual device. * -- 2.28.0