From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3CBD3A052A; Wed, 23 Dec 2020 10:31:23 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 23503CB03; Wed, 23 Dec 2020 10:31:22 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id EBB1DCAC4 for ; Wed, 23 Dec 2020 10:31:19 +0100 (CET) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 0BN9UXNi023613 for ; Wed, 23 Dec 2020 01:31:19 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0220; bh=iP+HD0rhpR4d59tF+G6Bzg+lorXhfzyXOY+VeN1xPMc=; b=TnHCWQ8eKy6/WH2uqDKw5YD7G1E6nLBzxm8j8xmZX87n3XRG2LT8toTTOHu/y+l7xx/C /AMDRnBByeKC4yAPUk07FkK+fyTZIt/27fmIwj4jMVFV/Gn0rpuCP5ShXXBg0v8+I0Ag oOeRGchb8MEsSrF/vQppq8WVg/QMtkAfehNLiKn0+hDVfstuVBTIUTCDP7o4rD81XbP8 FY/CkCyql1WBjSUUCe3J9fA8rbdzH8DMJ6jjZxUJL7n9j+ag0O91sYM+no9I63XYL6hN XU00wctcnBhWXnJPGKNuGdeUHPoID0m5fneyPCLUjWocYFK9k3wg9ZIm6Wff3fwz6aka Gw== Received: from sc-exch03.marvell.com ([199.233.58.183]) by mx0a-0016f401.pphosted.com with ESMTP id 35k0ebdrgu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT) for ; Wed, 23 Dec 2020 01:31:19 -0800 Received: from SC-EXCH03.marvell.com (10.93.176.83) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 23 Dec 2020 01:31:18 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.171) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Wed, 23 Dec 2020 01:31:18 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=YUUE9adWOh/leE+mtnMeUfywVEW5/7jfpD/28LCVG5QAQYwh+eEg8Vxm942ueB59qFrudsWsp4X5oNuswC15ATCoM7yNGnLFSQYhoNu2RZ0ruwvxZpgqzg0D7mnD+S12ukUlPwPp817yUW3oo77QQhGvnu+CkknJVdeTUZ3mi7NtFK3/K1mSXGKQM/Z5v7nb8y9QTI9t2X9eUZo/BdfAzIx7Sekt0cYS8acT9HyeCYItUbRZkpUuSIwt8A+L7bXrpesq3h/UabRZAuTgXAexZ3yR9KbRNpO82pN4Pmcfg5WmLathTpYL4x0pudVvaTVVxium16EW1WltAaw5MVyplw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iP+HD0rhpR4d59tF+G6Bzg+lorXhfzyXOY+VeN1xPMc=; b=cHET6ibrMI0XuzegfNGc8J40naHbOfry2dw8Chbj0z9Op7OaF7aUuo+8TBrv/KehJpOqIr4FOa83wAG6Q8jBuSbNEdRTTe35Q/Bc5fRBQmJY8At/uqSARln5Cdj9y+Ul7/1YsjT16Y6aSJTgE04f/zLzxDgSJnGmi4h+xcPma8S8VA3F74byFupQfb/d3jn79d9G46+u/FwDv0gnzbXbkuSIizX6JviG9RN9LnI2WM7txnZizqfahoJMbNGW+O5YI8/9Cicn/OdIwzdG70xQu3qZQWAWT1MFKNAbBFq7g0l6nRL3DtOc+uujy8b3QLmP54mbGrNC8QbjhfBHjac4iQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=iP+HD0rhpR4d59tF+G6Bzg+lorXhfzyXOY+VeN1xPMc=; b=Crvdkz67fj3Try5n7jQaCg7wWOqw8Ag2BkxvIDaZdVa8CyHRsuwjOA9OLv3lziD98v19Y6XefZ6g6NM83wzw/O/hESkPphs4fZfVBTFC9bo4w5RuDLneUkSX8wuIu43byZtYoHs1+PPOw3GSJswcvqt4eVPhQdbE0o1+edmSatg= Received: from DM5PR1801MB2058.namprd18.prod.outlook.com (2603:10b6:4:67::31) by DM6PR18MB2795.namprd18.prod.outlook.com (2603:10b6:5:172::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3700.27; Wed, 23 Dec 2020 09:31:17 +0000 Received: from DM5PR1801MB2058.namprd18.prod.outlook.com ([fe80::303b:5c79:93c7:b432]) by DM5PR1801MB2058.namprd18.prod.outlook.com ([fe80::303b:5c79:93c7:b432%7]) with mapi id 15.20.3676.033; Wed, 23 Dec 2020 09:31:16 +0000 From: Michael Shamis To: Liron Himi , Jerin Jacob Kollanukkaran CC: "dev@dpdk.org" , Liron Himi , "Yuri Chipchev" Thread-Topic: [dpdk-dev] [PATCH v1 30/38] net/mvpp2: expose max mtu size Thread-Index: AQHWyJUr8BRzaHNOBkmfdp0GNHWh66oEi2/w Date: Wed, 23 Dec 2020 09:31:16 +0000 Message-ID: References: <20201202101212.4717-1-lironh@marvell.com> <20201202101212.4717-31-lironh@marvell.com> In-Reply-To: <20201202101212.4717-31-lironh@marvell.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [83.130.154.133] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 4de1ba2f-05fb-4ee9-dfa2-08d8a7257fa1 x-ms-traffictypediagnostic: DM6PR18MB2795: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:820; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: j1kfW4JhkBR0b88HB97qdZREXX90qVQdS9/+ax5yopefWNjbnOKwq/kgTd8IOswWeSybr1ln3kUewcVVp3VWLY357FYEYHjInw0D8uzmJH3fCmNjaBq1UuskqbjfwEjmCUgLi6/BvskL76qqDCRQfrvEVZTR92U8+chnkH8gNhIgzK2GCid01UhRTrqhZgx5U0YKFxoxnx9QuLd1/sMI/XsYiZmYBTDa8N0+jo2bY9hb4Yjag5xSz0uYvFPSCE4YkO70ytPl6f18z+4AdyhKtf8TkMQ/l4XmX7Fl5kvMb9Q1K5XgIIe3N9QOLRGHj//6svrNPABWzE6xiYtMEM1BHFQ+Hmnqqqv6HzNLInNXMENi/TDKtfSSKBtJG2WFIXFEM0VCJIo1OOYY1c+Boctwpg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM5PR1801MB2058.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(396003)(39860400002)(346002)(376002)(366004)(7696005)(26005)(54906003)(2906002)(8676002)(478600001)(186003)(9686003)(5660300002)(55016002)(83380400001)(4326008)(107886003)(8936002)(66946007)(86362001)(64756008)(66556008)(53546011)(66476007)(6636002)(6506007)(52536014)(33656002)(76116006)(110136005)(71200400001)(66446008)(316002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?hCKCKrllSIBHHr0SBOedx0ou9qCI4GPkJkXsaixgS6qSwvrRgF0m+J9/f6qN?= =?us-ascii?Q?DGDYvWINQHASe4Y/9ZCHc2V+LO3jSCsaVYeKQ4sThpX1PSxawaHET5KiaSqj?= =?us-ascii?Q?3lrlsUW9JN+SwbBtsPotRt6kOVUwBu9pFNnvFaHqB9hOtbc12GQt7qexFfmS?= =?us-ascii?Q?XmXrjXHlB31bDvsU4Reneoinr6JVibYXexY321Gb5gJ/1kg8ECOqXQqg2JZ0?= =?us-ascii?Q?Bo+I0NI0ZArQZkCWixQQ1g7Kv46eB05EcTw38BQl/O7MimsCr7GeTcO144Qr?= =?us-ascii?Q?dKEtBovp0Vyhg5yP4kknYJQt6tBmujMuxgInpTs3s2yV+BoKE+sKdc8R7uz9?= =?us-ascii?Q?Tnvbwt9XR7NWTtPW1w1UVImLbzrAZm2UVltXG9xbWWfguaI+oBC4+vgTnkOX?= =?us-ascii?Q?vXygvXc+qnaXd1ImfmWoymE/NaHga31B52qe9+xW2cd9pj/1HUWsucrB6gr1?= =?us-ascii?Q?vOjuI1Aqqtzougd3IEXVHhAjYLHVaovSqSkpIA8oeRxd5da2tm8c3Gl3Vuj+?= =?us-ascii?Q?rrD8/xNwOZxaWCz4BizZneuleNOMbrgNFHvOAWZ0ACjgQKJzrtkftYGqQQqT?= =?us-ascii?Q?q2RIUEgO0Cj3U3WxHJZKVHLjdDs5E9GZMIFnE7LKiThJXMEHU5A+7AeM3AWw?= =?us-ascii?Q?tp7E3Mmr2a+2BXrZvgFhfHOFeyHv71zetdtZY/H9RfweWpQNLhY1hAPtf9a7?= =?us-ascii?Q?kDynBHQjIIjudu3ix0Pj194vlU8FYm8xDjvqGwxKbrrDpD3ihaHIX6D4NUmY?= =?us-ascii?Q?eAJBCrGVaMckbfIv8GyrRnrFct79gCIa8aZBel6AwHzW0SmpnoDnW1Nr7AJW?= =?us-ascii?Q?DmnrF4tHYFAIyOVI8I/ICi9jnvQx6owW/aOdPjQ4uBOnaVmkkoZ1GYI224Bn?= =?us-ascii?Q?wDd3zca06Azl6lxlrrs2BlOjp3EHR7Xby0taF48xDmoj0xy0M+1WVCMs19fp?= =?us-ascii?Q?x8oadivgNcjFjqKzxZmpv1r3aA0A/TR57R0sTc+41a4=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR1801MB2058.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4de1ba2f-05fb-4ee9-dfa2-08d8a7257fa1 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Dec 2020 09:31:16.8519 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 5rzESL/72gMKh4ce/+36p0EL9ns3gbrtXQdImkvSzoBbuw3sDR2DuexeV+6/xoB4LAThiQy/yFqXrFdzbdyqoQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR18MB2795 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.343, 18.0.737 definitions=2020-12-23_04:2020-12-21, 2020-12-23 signatures=0 Subject: Re: [dpdk-dev] [PATCH v1 30/38] net/mvpp2: expose max mtu size X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Reviewed-by: Michael Shamis -----Original Message----- From: dev On Behalf Of lironh@marvell.com Sent: Wednesday, December 2, 2020 12:12 PM To: Jerin Jacob Kollanukkaran Cc: dev@dpdk.org; Liron Himi ; Yuri Chipchev Subject: [dpdk-dev] [PATCH v1 30/38] net/mvpp2: expose max mtu size From: Liron Himi expose max-mtu based on the max frame size that l4 checksum generation can be done by HW. Signed-off-by: Liron Himi Reviewed-by: Yuri Chipchev --- drivers/net/mvpp2/mrvl_ethdev.c | 24 ++++++++++++++++++++++-- drivers/net= /mvpp2/mrvl_ethdev.h | 1 + 2 files changed, 23 insertions(+), 2 deletions(-) diff --git a/drivers/net/mvpp2/mrvl_ethdev.c b/drivers/net/mvpp2/mrvl_ethde= v.c index 535d7cc60..9fd9269eb 100644 --- a/drivers/net/mvpp2/mrvl_ethdev.c +++ b/drivers/net/mvpp2/mrvl_ethdev.c @@ -477,9 +477,17 @@ mrvl_dev_configure(struct rte_eth_dev *dev) return -EINVAL; } =20 - if (dev->data->dev_conf.rxmode.offloads & DEV_RX_OFFLOAD_JUMBO_FRAME) + if (dev->data->dev_conf.rxmode.offloads & DEV_RX_OFFLOAD_JUMBO_FRAME)=20 +{ dev->data->mtu =3D dev->data->dev_conf.rxmode.max_rx_pkt_len - MRVL_PP2_ETH_HDRS_LEN; + if (dev->data->mtu > priv->max_mtu) { + MRVL_LOG(ERR, "inherit MTU %u from max_rx_pkt_len %u is larger than max= _mtu %u\n", + dev->data->mtu, + dev->data->dev_conf.rxmode.max_rx_pkt_len, + priv->max_mtu); + return -EINVAL; + } + } =20 if (dev->data->dev_conf.txmode.offloads & DEV_TX_OFFLOAD_MULTI_SEGS) priv->multiseg =3D 1; @@ -1676,9 +1684,11 @@ mrvl_xstats_get_names(struct rte_eth_dev *dev __rte_= unused, * Info structure output buffer. */ static int -mrvl_dev_infos_get(struct rte_eth_dev *dev __rte_unused, +mrvl_dev_infos_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *info) { + struct mrvl_priv *priv =3D dev->data->dev_private; + info->speed_capa =3D ETH_LINK_SPEED_10M | ETH_LINK_SPEED_100M | ETH_LINK_SPEED_1G | @@ -1710,6 +1720,7 @@ mrvl_dev_infos_get(struct rte_eth_dev *dev __rte_unus= ed, info->default_rxconf.rx_drop_en =3D 1; =20 info->max_rx_pktlen =3D MRVL_PKT_SIZE_MAX; + info->max_mtu =3D priv->max_mtu; =20 return 0; } @@ -3125,6 +3136,7 @@ mrvl_priv_create(const char *dev_name) struct pp2_bpool_params bpool_params; char match[MRVL_MATCH_LEN]; struct mrvl_priv *priv; + uint16_t max_frame_size; int ret, bpool_bit; =20 priv =3D rte_zmalloc_socket(dev_name, sizeof(*priv), 0, rte_socket_id());= @@ -3136,6 +3148,14 @@ mrvl_priv_create(const char *dev_name) if (ret) goto out_free_priv; =20 + ret =3D pp2_ppio_get_l4_cksum_max_frame_size(priv->pp_id, priv->ppio_id, + &max_frame_size); + if (ret) + goto out_free_priv; + + priv->max_mtu =3D max_frame_size + RTE_ETHER_CRC_LEN - + MRVL_PP2_ETH_HDRS_LEN; + bpool_bit =3D mrvl_reserve_bit(&used_bpools[priv->pp_id], PP2_BPOOL_NUM_POOLS); if (bpool_bit < 0) diff --git a/drivers/net/mvpp2/mrvl_ethdev.h b/drivers/net/mvpp2/mrvl_ethde= v.h index 24dbe20d7..ada2c51b2 100644 --- a/drivers/net/mvpp2/mrvl_ethdev.h +++ b/drivers/net/mvpp2/mrvl_ethdev.h @@ -160,6 +160,7 @@ struct mrvl_priv { uint8_t vlan_flushed; uint8_t isolated; uint8_t multiseg; + uint16_t max_mtu; =20 struct pp2_ppio_params ppio_params; struct pp2_cls_qos_tbl_params qos_tbl_params; -- 2.28.0