From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A963AA052A; Wed, 23 Dec 2020 10:32:02 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8F276CA95; Wed, 23 Dec 2020 10:32:01 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id A795BCA87 for ; Wed, 23 Dec 2020 10:32:00 +0100 (CET) Received: from pps.filterd (m0045851.ppops.net [127.0.0.1]) by mx0b-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 0BN9Uijt002395 for ; Wed, 23 Dec 2020 01:31:59 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0220; bh=GB+NnxHCWrYVJ9Z5csh4Z+5kzMl2G5qrzbBW2er1Ow8=; b=NOjFXamgXEa9TKJQhG09K31W1kW/dfuW1cwKkxoJ4u4bO75GMzjq6nRSzxSyneiTux2w CW17f1dLGRUoqdnFj+iUE1TKlhEBL4xorlSpH9aorSrATEVveVHbxRgrZe8bDQFLTmAz xw3MqEoZbaeTGekgrg990+cWilZMJW92qcQgtQlAYLVBzRC89BwIjDzC0DuGMPe8EAlQ lhd8wguwm/clC4jR8gWrBBYV7jUcDw/G8oL9/GMNX2T56nMfl2FLpK9pDbFqi4gxLDRu eLxX7ZzFBvu05LQPtao0hmbtzLUCqyVB/q6fvRQZBBOBV1l8K8iNe5W+YygucZdZk3jw Ag== Received: from sc-exch02.marvell.com ([199.233.58.182]) by mx0b-0016f401.pphosted.com with ESMTP id 35k0hx5mhq-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT) for ; Wed, 23 Dec 2020 01:31:58 -0800 Received: from DC5-EXCH02.marvell.com (10.69.176.39) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 23 Dec 2020 01:31:57 -0800 Received: from SC-EXCH02.marvell.com (10.93.176.82) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 23 Dec 2020 01:31:56 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.169) by SC-EXCH02.marvell.com (10.93.176.82) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Wed, 23 Dec 2020 01:31:56 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Q/pbQOin/E3QezRy4g6oa6GJuNosYuW2fd43alv/F+3wq4Du6VRXtVnFqLynmK7csUsgZuVXQNPNXiPqYAQM5wRHDMy2ylWYghpmvDLlYKL5VuJ53fL/5tW47LniDYzUZugtzcgLWhBTRJEpM+JElwhxfhebPVkWKL52MMNhsnMjCXvlXqr9npaIRbqBgotpvpwiEfYcI3E0gQ/rVYmPNq1nP2qVEGitzL6RqWJ7wuZN6fhGnVs89cb7BOFX+B4hDfEEMYmQ18n7X0u8LJJQLvs3ubl829vlJ03p2F4X7/98VVmSZf5u0P6CcGENPdNloNauEov/dYa45oQgP9JAsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GB+NnxHCWrYVJ9Z5csh4Z+5kzMl2G5qrzbBW2er1Ow8=; b=VaslCdfX67GT9kPg9YZ/2n3pMJrdNGAwpUwYP4TNno9d5FhZ9qKzIDMx1/vQJ4ALBbP9dlfZIZrzuHR1D/p8Td6SswWQx3S8X9f1u+T04B2UyqNkThSTwxPmD8lc3C+DK9Qgaq02PKyuDXcY7SUSWHG6wELCCQ/nZpT7f8nwyFRhM06HsjjLcaO91Gf15WXzc1l6fxnb4MJ0xuTTRBuSaLUo811qLpXrhkLdaCHiOJP40DYYWbHKzFnpxVTl6CCtKa2NYIAXBgvm24sdqBPiZtnFjGmaPlpVeyMTWZ+pSie9ztxOltw1TkGhSsaIVIXwUFqyG04j9FDFSWdYIkxUtQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GB+NnxHCWrYVJ9Z5csh4Z+5kzMl2G5qrzbBW2er1Ow8=; b=FQA7+mwRshfxTEXigsO8V+aHXBcDM6Djnozg2Htd5TsjHWFhoSKOpUsoGrgOAMg4ZBxPaBCbQmU/L//LLLBNtFafgZ+v9uuU2Rys4lsfpCHMExb62pSr3jJmDh2s41Nj5uTPkIXhBMcgzB8IrKsiS95VF33XKvnwUJISyqVCVcw= Received: from DM5PR1801MB2058.namprd18.prod.outlook.com (2603:10b6:4:67::31) by DM6PR18MB2795.namprd18.prod.outlook.com (2603:10b6:5:172::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3700.27; Wed, 23 Dec 2020 09:31:55 +0000 Received: from DM5PR1801MB2058.namprd18.prod.outlook.com ([fe80::303b:5c79:93c7:b432]) by DM5PR1801MB2058.namprd18.prod.outlook.com ([fe80::303b:5c79:93c7:b432%7]) with mapi id 15.20.3676.033; Wed, 23 Dec 2020 09:31:55 +0000 From: Michael Shamis To: Liron Himi , Jerin Jacob Kollanukkaran CC: "dev@dpdk.org" , Yuri Chipchev , "Liron Himi" Thread-Topic: [dpdk-dev] [PATCH v1 29/38] net/mvpp2: autoneg disable handling Thread-Index: AQHWyJUb4/832M5cSUSC89kF6cuuo6oEi6Yg Date: Wed, 23 Dec 2020 09:31:55 +0000 Message-ID: References: <20201202101212.4717-1-lironh@marvell.com> <20201202101212.4717-30-lironh@marvell.com> In-Reply-To: <20201202101212.4717-30-lironh@marvell.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [83.130.154.133] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 1e99b594-7901-43ed-fa62-08d8a7259675 x-ms-traffictypediagnostic: DM6PR18MB2795: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:873; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: FRYAO37KKLdloZgiu4L8Vqd1cTM85u26Vh2X4082MfYJVwJSEunrYNa3tcieCaKAI3D+9sT/0MJbImFheZN/BXfs8gVzAxcVbN0HLXfljG4bWasnDQNJaXBAZ3U+5WtWmg04SJgfq7oOPHVqe61UtfdUhu3s4NZ46Nxld4LUKcHmi7Y7ig0jC9h/NgOSBHLk2aSP/QWi1k8+UmOB1BXnV1JYXiFQXthRrJhSeq5IxOmIiY6VJaRX2nMBB7gZ/R4dCv563syLl/b7GB6sZNR5OVMuW4V3DITCt8cRs8spugapxewVzKzIYD/sh0NElDMp8b1XaGy4bwC4uy00WRwkKl0eqRZ5F0VUMRDkSfmZltZQgeoZQ1Pv/+KXgZJYa61Mf3bs7fQKLVSGZNBDub/bWA== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM5PR1801MB2058.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(396003)(39860400002)(346002)(376002)(366004)(7696005)(26005)(54906003)(2906002)(8676002)(478600001)(186003)(9686003)(5660300002)(55016002)(83380400001)(4326008)(107886003)(8936002)(66946007)(86362001)(64756008)(66556008)(53546011)(66476007)(6636002)(6506007)(52536014)(33656002)(76116006)(110136005)(71200400001)(66446008)(316002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?cDQp9xtdz/Ki7r+pQNoZ2cnhXnmUCv72zBk3qVR1wfG5lmLrsUwPhLSS2YgU?= =?us-ascii?Q?uTKjR6koZ2cB/qKP/ZGT7TQT9gEua5ULufLFxYIWvh+ViGFWWdIFRzzUD3Sz?= =?us-ascii?Q?xaEPXQQ626GwbH8lx0aEOb3d+2PBgZD4umHTBw1crisU8z+LkkJRYXC/LqM4?= =?us-ascii?Q?wJMx47EJNA2yJwSh5nEcZvFgH8iGTDF12MyAwVfhKd1XG/MtX5Gd+uk9oop5?= =?us-ascii?Q?WcuCfkk0/rC/HixSRMTMgmq2M04qbPvCNd2u2FYe2PBv8uy7mvBYvC6RaJ3T?= =?us-ascii?Q?5iZkV0KLNVPm+8jRsLE5IWiIcpUvGPNzc+J0J5mQcPxBX6BcRhURwOvdWMoN?= =?us-ascii?Q?dfMP5ebX2cKkSP/sn6cqKjTZCb8tcHnEtIbhj/VQKQEOeo3+Bzsk0h0vi3lQ?= =?us-ascii?Q?nKWTgKbEsQTj4XXkC+UZsL1pXMoMaRNYMgxZSu4kWh8knDfqFth295PNBRpG?= =?us-ascii?Q?7uxQ4zjF+bDd5GCT5hljQbG3rs225T476VBR4uy+MMbwHl5KphwRfMSrKWdI?= =?us-ascii?Q?UY+QlTo7qWwKE5zmStc/DMDwvtfOEr/eApIwsyi9zr18I6IjICXfv5R1ksQl?= =?us-ascii?Q?iDpDhzVnAMLCUOIjyRkiCqvY4pX4fLk3RMAfWec6mYy3q8HxnxUVyoSX/BNP?= =?us-ascii?Q?CrCgWCPBIaFpi2GaAEioIr0vkP/pGa4QIYIiQiAip+xBvMYtDO+44TzmLXuf?= =?us-ascii?Q?g9+JQeOvltutdR97T99W63cBoqC9c2cDdxlDvon8b13izv/Pk/10lUBntRIY?= =?us-ascii?Q?RE+brV6oakrvdD296g1VWlhgViDiVcOQ+N3a5ffoSYKodFqJk1+5t2wqeday?= =?us-ascii?Q?YOty+/5VR8EwsrQSLbN/AgbfwyBguScM9gS3mPG9GNPPxur74gC1su1wS3KS?= =?us-ascii?Q?tUAEM+CHlkL8vHvR5pJecRBeXNboXNZODVCOtsD9izZu4oYrhSsSHWuE8kmC?= =?us-ascii?Q?dLqnnt7EdjDx8YTEKt9yOlOoi8O0SP5gOxVM4UVPHfI=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR1801MB2058.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1e99b594-7901-43ed-fa62-08d8a7259675 X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Dec 2020 09:31:55.1418 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: pI22r345CNA7/oCRTLJ0EYUHZkt5FUjED5w+0DBfCyfm+ldDuar8SsBVkCWLetkz+ANMExDjE/eAJcSHXUSCnQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR18MB2795 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.343, 18.0.737 definitions=2020-12-23_04:2020-12-21, 2020-12-23 signatures=0 Subject: Re: [dpdk-dev] [PATCH v1 29/38] net/mvpp2: autoneg disable handling X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Reviewed-by: Michael Shamis -----Original Message----- From: dev On Behalf Of lironh@marvell.com Sent: Wednesday, December 2, 2020 12:12 PM To: Jerin Jacob Kollanukkaran Cc: dev@dpdk.org; Yuri Chipchev ; Liron Himi Subject: [dpdk-dev] [PATCH v1 29/38] net/mvpp2: autoneg disable handling From: Yuri Chipchev flow control autoneg disable is not supported Signed-off-by: Yuri Chipchev Reviewed-by: Liron Himi --- drivers/net/mvpp2/mrvl_ethdev.c | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/net/mvpp2/mrvl_ethdev.c b/drivers/net/mvpp2/mrvl_ethde= v.c index 66c3c8e57..535d7cc60 100644 --- a/drivers/net/mvpp2/mrvl_ethdev.c +++ b/drivers/net/mvpp2/mrvl_ethdev.c @@ -2135,6 +2135,7 @@ mrvl_flow_ctrl_get(struct rte_eth_dev *dev, struct rt= e_eth_fc_conf *fc_conf) if (!priv) return -EPERM; =20 + fc_conf->autoneg =3D 1; ret =3D pp2_ppio_get_rx_pause(priv->ppio, &en); if (ret) { MRVL_LOG(ERR, "Failed to read rx pause state"); @@ -2184,13 +2185,17 @@ = mrvl_flow_ctrl_set(struct rte_eth_dev *dev, struct rte_eth_fc_conf *fc_conf= ) if (fc_conf->high_water || fc_conf->low_water || fc_conf->pause_time || - fc_conf->mac_ctrl_frame_fwd || - fc_conf->autoneg) { + fc_conf->mac_ctrl_frame_fwd) { MRVL_LOG(ERR, "Flowctrl parameter is not supported"); =20 return -EINVAL; } =20 + if (fc_conf->autoneg =3D=3D 0) { + MRVL_LOG(ERR, "Flowctrl Autoneg disable is not supported"); + return -EINVAL; + } + switch (fc_conf->mode) { case RTE_FC_FULL: rx_en =3D 1; -- 2.28.0