From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id EAFB3A052A;
	Wed, 23 Dec 2020 10:46:03 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 11BD6CD05;
	Wed, 23 Dec 2020 10:43:15 +0100 (CET)
Received: from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com
 [67.231.156.173]) by dpdk.org (Postfix) with ESMTP id 6987DCACE;
 Wed, 23 Dec 2020 10:43:13 +0100 (CET)
Received: from pps.filterd (m0045851.ppops.net [127.0.0.1])
 by mx0b-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id
 0BN9Uikt002395; Wed, 23 Dec 2020 01:43:11 -0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;
 h=from : to : cc :
 subject : date : message-id : references : in-reply-to : content-type :
 content-transfer-encoding : mime-version; s=pfpt0220;
 bh=emBuZVpy86wyWv8DEpZkhEUEHwxK8UY5cLvVOCbfTxg=;
 b=XVvFjOV3E1gCeoa5OfyKWS+yYR5JcWeBE1SNLq+HIsXCtId/v0GY7ohRrwItnRyMoeES
 a1OCCok1lIxgcj21F0ggb2meL5AxTcVLurUp+orpWAKmlr1W04x/JswrLVqQvqNeInKi
 EeLHIbvP/EnEpDpVgJNfjjDrE/hQHIOvhPRecs1pbw5So5Hl4gZVF9aTqRsqR2WZ0ia+
 kFoPRgXehEXkXh7eHvqBRS3iEko/imGQmaGfrpWhnmf7zyWHGN0SgPYHnToZkNq9AYLc
 VUrqIhfekhnwvewjMjvFG6Kmv1S28iW0shgB3gFnNyLQBSb4VTyCuK7DVkfQ5tfY1uEN lg== 
Received: from sc-exch01.marvell.com ([199.233.58.181])
 by mx0b-0016f401.pphosted.com with ESMTP id 35k0hx5nb8-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);
 Wed, 23 Dec 2020 01:43:11 -0800
Received: from SC-EXCH01.marvell.com (10.93.176.81) by SC-EXCH01.marvell.com
 (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 23 Dec
 2020 01:43:10 -0800
Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.174)
 by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id
 15.0.1497.2 via Frontend Transport; Wed, 23 Dec 2020 01:43:10 -0800
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=N0BNQRxduRp2vxJda0mecoFsMw1YyxTwfn/Sb8VWGnlMNKq5HqpcZ0RfPdCWnqgAo/NJUzZ0akV04vULnOnCRltFm3/vOHAHdeE0QkXXZPiWTmzmGapFzy9WZNUZ4/MJN61IiK0WGQ/Ts8KqeDHMOGqGrjbaVGzoo3SQhhGxm/3MTzxBowCgXzrgDM612dRAaeotGy9D5Z05PaCSD6+03omcTif3GN+ryElfV/AK0bTUd30V4wLix18RATxxWWVGVxjShfrcH+/y4FBRfKPsThkSjDZeNG/vZh5Ww0/RJylrL3NLZrYeACiIBcu/V0iZAQDtWtt8kzuawuTCOo9nvQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; 
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=emBuZVpy86wyWv8DEpZkhEUEHwxK8UY5cLvVOCbfTxg=;
 b=ES6R1eSp+UZuKvu03ORwaRPdjTdbTq94h7rqqQVVTdsOND1jAWTbAqbSw2cLZO0xG2QEOOAdqG1TqPMggCO7TCYu5U57XkUr4UxvnYI5xFxlWLkHr1WCF0zryQE6M0Mr2j9KkEhd0vJn6Dj32YANX8C0CZqsgf3VMfZPP1/tivZGudvfazKULmHhPLIYW2Qx8TGGm4Z3rhpFzF6vii5XZIhuQKMcGqXMZ1bTiWOAPRknxXkXIFKBPuM+mMgl7a+T5RnI6Al+kjfcVkBdeCPCKd/8BrosCV5LiOG0+YAdy306woyVpQ0I41Q/jpU+2U1QMH0haOfcXV29KHzWXpcTVA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com;
 dkim=pass header.d=marvell.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=emBuZVpy86wyWv8DEpZkhEUEHwxK8UY5cLvVOCbfTxg=;
 b=hrYZKU35E5e2nVo3IP9FacAhrmPdTzTW0C61Ak7wALdQfNKgha1dwinRbBln4dPXF52t8mABfzPkjelbdwAMAT0Kj2Ob5y6lhXkE56MCJm8GDafnhxk7E1SSbR/rkjvFGANC11YafI1AM3E+K0YVv9A4O9rhR7ZZh5JI4QxAmKQ=
Received: from DM5PR1801MB2058.namprd18.prod.outlook.com (2603:10b6:4:67::31)
 by DM6PR18MB3603.namprd18.prod.outlook.com (2603:10b6:5:2a5::21) with
 Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3700.27; Wed, 23 Dec
 2020 09:43:09 +0000
Received: from DM5PR1801MB2058.namprd18.prod.outlook.com
 ([fe80::303b:5c79:93c7:b432]) by DM5PR1801MB2058.namprd18.prod.outlook.com
 ([fe80::303b:5c79:93c7:b432%7]) with mapi id 15.20.3676.033; Wed, 23 Dec 2020
 09:43:09 +0000
From: Michael Shamis <michaelsh@marvell.com>
To: Liron Himi <lironh@marvell.com>, Jerin Jacob Kollanukkaran
 <jerinj@marvell.com>
CC: "dev@dpdk.org" <dev@dpdk.org>, Yuri Chipchev <yuric@marvell.com>,
 "stable@dpdk.org" <stable@dpdk.org>, Liron Himi <lironh@marvell.com>
Thread-Topic: [dpdk-dev] [PATCH v1 03/38] net/mvpp2: fix rx/tx bytes statistics
Thread-Index: AQHWyJPtTojo1GqpzEC0bqxYAAkT+6oEjtjw
Date: Wed, 23 Dec 2020 09:43:09 +0000
Message-ID: <DM5PR1801MB2058D4F3528BFE0818BAE4C8A4DE0@DM5PR1801MB2058.namprd18.prod.outlook.com>
References: <20201202101212.4717-1-lironh@marvell.com>
 <20201202101212.4717-4-lironh@marvell.com>
In-Reply-To: <20201202101212.4717-4-lironh@marvell.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [83.130.154.133]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 2d2ae6a0-a657-447e-44bd-08d8a7272852
x-ms-traffictypediagnostic: DM6PR18MB3603:
x-ms-exchange-transport-forked: True
x-microsoft-antispam-prvs: <DM6PR18MB3603083F1D4A88361F9B2BF3A4DE1@DM6PR18MB3603.namprd18.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:3383;
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: n1DRZJsa+PkOkrmY1vgcGRb0Q0mTW4j/YA6bbgkcibJZ7lBwPza5jvRNOSwlKpOPmNrpOXtpesrm9i1QZ8HFdtUmgvbxxTrAlauRPLuGw22jFJsiWigYIatlv/dWgS3zNb4yvXIb9yKDNLi2gKTgdhK39+mvJZzudCDJtl0LoB42pSlUI7l9raYLDR+p/nBMVsuZks2q3k8k6UfSCegx2Sz5MVi4Dp7AxTD5O22mHUHsI5OB5h0DkoJ9ucGWsTPZZ4J/dLmYBVOqFD45T9G7gfkN3rYugGHItfqRZlWh6ydhq6q8n13p42WtTEGGWuumn4NUw+qP37948l8ObLUTCyu48ExlU0qauD9s6vMUuVZ8b/wuYAYDCSdxqkIdpeWbyx/y9tGMHIqX+TEIhh1HuA==
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
 IPV:NLI; SFV:NSPM; H:DM5PR1801MB2058.namprd18.prod.outlook.com; PTR:; CAT:NONE;
 SFS:(4636009)(136003)(39860400002)(346002)(366004)(376002)(396003)(66446008)(53546011)(54906003)(450100002)(66556008)(52536014)(66476007)(66946007)(4326008)(5660300002)(64756008)(107886003)(33656002)(8676002)(9686003)(6506007)(76116006)(55016002)(6636002)(86362001)(71200400001)(478600001)(7696005)(186003)(2906002)(110136005)(316002)(83380400001)(26005)(8936002);
 DIR:OUT; SFP:1101; 
x-ms-exchange-antispam-messagedata: =?us-ascii?Q?q0abXpEJHOiEoH4xYncxxfPvwwZUS5T+3/o85uen+9Oc+XOA9XusGTDV4ETA?=
 =?us-ascii?Q?vm9H+5lSh5FO1KRqQNwHxu4YQrtv/tR61uS/omT5/jlNqyScim86+iNgxLTf?=
 =?us-ascii?Q?ZJy9zpnol0N8cpEl42IM84KHMIKzSYq8/ISpT0/hnqpzKlMaI/WQ9lL8MlAj?=
 =?us-ascii?Q?nI4YaRubC+cLOIp0Mj3DEX9YrnmCZ4ie3JR/+A3p8R0pQxILPOw4xb2Q1q4r?=
 =?us-ascii?Q?Lspvy9sPuK8gBJyzyb7V710v1ALZuVoG89Sv3exfk7ZTlfFFMyc0gLUUe5UA?=
 =?us-ascii?Q?P5KVKTp4mGxV8WRnPeDQY701HxM7jQNsPBoNMqiEqCT7mCTCU6B2ytdTtXR2?=
 =?us-ascii?Q?QREr+ZyFrbfWMJjFL45gkeiuHeD6Kx1IUzB/PgByOYYbcKAgjOrsnoRh4uQV?=
 =?us-ascii?Q?1UZ2GwHoRoxaXwUZlCQh0R6mBY8BjhDewMr89zYzmFt3WmHhXkj4iFx6DGzj?=
 =?us-ascii?Q?O2Hw3L312Y1scJDcFT0Ynq7CKYxKqRCRuOHHHs7UoGRD/4vMhXEtQfNBQxmm?=
 =?us-ascii?Q?mOc3knTArQ2ANSglintetI11bXa5A0lCzMaHl2EW3m1OvUzfxLYciny2SPuk?=
 =?us-ascii?Q?1l1pnMoXzh7q6gM2CdpuA0zex16NhV26IS3ak0mqjkKBf8KOoJmRAcHK+FwQ?=
 =?us-ascii?Q?qaoERt7OW2eIThql9Z/oqLMzEl2ES6F4I0ky2qXoxIx6ZKUxwfoSdjARy+e4?=
 =?us-ascii?Q?UG6+AR0KZSsKLqVV9HhJ7yNmHLNS6mb5PbsFfmaYU7NttOH+DplL2f610jEJ?=
 =?us-ascii?Q?nHLPZhUyLzDxQWpJoLADCPMoLstRzO7U6x8qleHriPyQMvJV3FG/x/893i1I?=
 =?us-ascii?Q?1jtIFe40jXruN4FDEdDB/SDDA1jMeHTJXuNM3HQnJv4c66hkmnJ1wRjD7ihh?=
 =?us-ascii?Q?F8RWWGzKOwu12ani7mG31YDbAjriKlJjQP+54pbEIeYwHR8wI+xAT7GUMlhD?=
 =?us-ascii?Q?ZzDmYI5rvoTYyc9H5gAdsK91+VqXkLJtDIZAjWqEoT0=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM5PR1801MB2058.namprd18.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2d2ae6a0-a657-447e-44bd-08d8a7272852
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Dec 2020 09:43:09.3249 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: WK2Kdny143qA6gcua/bWiuJ+SPD5G4N2WzOaWxBr9Q8wj7aziSEnhGL9VKgOi0jn4Dkr6DO0V2E+kvvdLbLQ/w==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR18MB3603
X-OriginatorOrg: marvell.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.343, 18.0.737
 definitions=2020-12-23_04:2020-12-21,
 2020-12-23 signatures=0
Subject: Re: [dpdk-dev] [PATCH v1 03/38] net/mvpp2: fix rx/tx bytes
	statistics
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Reviewed-by: Michael Shamis <michaelsh@marvell.com>

-----Original Message-----
From: dev <dev-bounces@dpdk.org> On Behalf Of lironh@marvell.com
Sent: Wednesday, December 2, 2020 12:12 PM
To: Jerin Jacob Kollanukkaran <jerinj@marvell.com>
Cc: dev@dpdk.org; Yuri Chipchev <yuric@marvell.com>; stable@dpdk.org; Liron=
 Himi <lironh@marvell.com>
Subject: [dpdk-dev] [PATCH v1 03/38] net/mvpp2: fix rx/tx bytes statistics

From: Yuri Chipchev <yuric@marvell.com>

4B of CRC was not included in the bytes statistics

Fixes: bdffe0c70 ("net/mrvl: support basic stats")
Cc: stable@dpdk.org

Signed-off-by: Yuri Chipchev <yuric@marvell.com>
Reviewed-by: Liron Himi <lironh@marvell.com>
---
 drivers/net/mvpp2/mrvl_ethdev.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/mvpp2/mrvl_ethdev.c b/drivers/net/mvpp2/mrvl_ethde=
v.c index 8c3278ec4..ebd2bb1c8 100644
--- a/drivers/net/mvpp2/mrvl_ethdev.c
+++ b/drivers/net/mvpp2/mrvl_ethdev.c
@@ -1278,7 +1278,6 @@ mrvl_stats_get(struct rte_eth_dev *dev, struct rte_et=
h_stats *stats)
 				       rx_stats.drop_fullq +
 				       rx_stats.drop_bm +
 				       rxq->drop_mac;
-		stats->ibytes +=3D rxq->bytes_recv;
 		drop_mac +=3D rxq->drop_mac;
 	}
=20
@@ -1306,7 +1305,6 @@ mrvl_stats_get(struct rte_eth_dev *dev, struct rte_et=
h_stats *stats)
=20
 		stats->q_opackets[idx] =3D tx_stats.deq_desc;
 		stats->q_obytes[idx] =3D txq->bytes_sent;
-		stats->obytes +=3D txq->bytes_sent;
 	}
=20
 	ret =3D pp2_ppio_get_statistics(priv->ppio, &ppio_stats, 0); @@ -1315,6 +=
1313,8 @@ mrvl_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *sta=
ts)
 		return ret;
 	}
=20
+	stats->ibytes +=3D ppio_stats.rx_bytes;
+	stats->obytes +=3D ppio_stats.tx_bytes;
 	stats->ipackets +=3D ppio_stats.rx_packets - drop_mac;
 	stats->opackets +=3D ppio_stats.tx_packets;
 	stats->imissed +=3D ppio_stats.rx_fullq_dropped +
--
2.28.0