From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7FE84A052A; Wed, 23 Dec 2020 10:46:41 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9E532CA4D; Wed, 23 Dec 2020 10:44:10 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id 453A2C9AE; Wed, 23 Dec 2020 10:44:08 +0100 (CET) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 0BN9UXJm023546; Wed, 23 Dec 2020 01:44:07 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0220; bh=5YsHdJzY8hoJVbHqNvts7LYu3BpDeHuQm08ArfIuDIU=; b=V+i10blbaClZltGMI9XV3+1U3RkAOdr18zsgi1NV5Lo49ZxnSb9n6o4VAdR3d6trCmQT zlqeyBKFpQyfYdRCv8LaYB01xFcTSfOHtIlmrCgqgYT0dG0iCRj6jUCFIKgRsGb2xqSs 7lV33askujbgdmM7+gyFH/5Kc7dnJa55I4mNO0wpeBGBgNRs7htIROFH/1Ccivcqco9E fH8cGiav0cyJfOwVneplQY5HKQj76kBPJh5usZjgAbTusjKcwch7tqiDBdPPUicJi7B9 QgSbJV71aPi4wyiK1ghCNwG8dVtIRmMaD2q2ymsWv8WTdEgYXEi2vyGyjI3sKQM3cKol TQ== Received: from sc-exch01.marvell.com ([199.233.58.181]) by mx0a-0016f401.pphosted.com with ESMTP id 35k0ebdsmn-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Wed, 23 Dec 2020 01:44:07 -0800 Received: from SC-EXCH03.marvell.com (10.93.176.83) by SC-EXCH01.marvell.com (10.93.176.81) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 23 Dec 2020 01:44:06 -0800 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.172) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Wed, 23 Dec 2020 01:44:06 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EqcmcCI4G6/NDMH0hbsCqUvTGbmlf2mC/+94WJ0cjsPC6j5x16t/a9uU9LisDtJ1mXK+Q7SmBtS6XWxsuSFmchVK3NFUWwtnpIEG7ZSgX6YhSZUUN1ViLpOsKMNgyFdNmCZixsLImBlOqLonc07goUyjkIg2Or4YnBOoCfcmQzy60BI7rF6YlfzzXX2qrxWA8dtBYzZwaq/4zbCkqGTbUhpSPpZmjBHreY93K5xz7S7ZJ5bu0JcIP6YGk4p/8lRz1SQu74MUvxWVQOjHKSLbDBbwOUaFekaV8HdUhq5rqBKPVRRHWOZQXcPeRaEjW43zCivY/S7xte26/SCLbUY0pg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5YsHdJzY8hoJVbHqNvts7LYu3BpDeHuQm08ArfIuDIU=; b=OgghP8SfJxgcx6E/mHUgvrj7QDMHCYTsmp9QlVyAQUsKftAPu24Nk8+7pEabW17gQIH/VpK3HVPcF2MAwByJwjbppzNoMYre7Xl+NVEcVFcyEV4rqR0eT8t/sAbEZQocAGwjtVwH2Oh97ish2kb8fNL8TaOhAuz+yINkiYLZ4d84X/LcgPZO9v30NO6l2dxyrCyX3akksFKyLCJujxdezdl0c+I2g0ZEG+TTeyQZjWomRUVjNFfYtnasjokR98fMJRf3hi/9Cg6Ioksi6vIhB1HCBiEHMuoSmo54ztZo/6pcCEFpPNjBw0dL6D7CKmoGeADLFUY0qLNuUh9ozMcq/w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5YsHdJzY8hoJVbHqNvts7LYu3BpDeHuQm08ArfIuDIU=; b=eVKm5XShfWer3XLLSCabbyL4M1ythxNDvPR1/Tdh3St8deM3RqubZ7HL1Aujr+ERsOSW6ltqx7eGzHHsU5XmcWuec6IBOIgzDe2gcUn8JgKU/DKsd7/A0W2lBC8Ttz8V1lRZRBW7808VL2ver0Rlr+DFrlnh6VcZzj2bIzccwyw= Received: from DM5PR1801MB2058.namprd18.prod.outlook.com (2603:10b6:4:67::31) by DM6PR18MB3603.namprd18.prod.outlook.com (2603:10b6:5:2a5::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3700.27; Wed, 23 Dec 2020 09:44:05 +0000 Received: from DM5PR1801MB2058.namprd18.prod.outlook.com ([fe80::303b:5c79:93c7:b432]) by DM5PR1801MB2058.namprd18.prod.outlook.com ([fe80::303b:5c79:93c7:b432%7]) with mapi id 15.20.3676.033; Wed, 23 Dec 2020 09:44:05 +0000 From: Michael Shamis To: Liron Himi , Jerin Jacob Kollanukkaran CC: "dev@dpdk.org" , Liron Himi , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v1 02/38] net/mvpp2: remove debug log on fast-path Thread-Index: AQHWyJO5iFnv6M38C0ysRtn32tKj3aoEjxNg Date: Wed, 23 Dec 2020 09:44:05 +0000 Message-ID: References: <20201202101212.4717-1-lironh@marvell.com> <20201202101212.4717-3-lironh@marvell.com> In-Reply-To: <20201202101212.4717-3-lironh@marvell.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [83.130.154.133] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 74637b20-a21d-4139-db3e-08d8a727499b x-ms-traffictypediagnostic: DM6PR18MB3603: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6108; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: MS4aNCvnU7kdSNYleDvpogiuRcCvbKcbjeTaJrIPjUMavaGPMi4Ufr1GkIxjis0Yisp5d8pi2M7F1nR5ZrViw3nc6V8MdWKK32z0ZcVbGTCp81JdgaEk9yhG25vl2tDMoUA+yYB23zPn4yVET1CepeixjEJoimkGW+gNt/pskW2hbVBDSQR1DhrXCc+6OOvVvuZxCQUIWYBa1VpmDSjIOUVjMn7NunNIHv4c5wkYFpUUg2aqmqmpT7JqFAZrltc1h8+umXFq3EqFnMQ7p2HgU1trY1TvSkQkfkkBdt4ODJ/eQw7pbCkMzyMThZ2PcZnOrKbLWX6CvFf4cTSCttUtPSRS6LyY+mlpyQfflYHyZKWNGDfkKr2RyFQJZ8y07sQnuk/t9yEpvAquy5hrW9U33w== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM5PR1801MB2058.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(39860400002)(346002)(366004)(376002)(396003)(66446008)(53546011)(54906003)(450100002)(66556008)(52536014)(66476007)(66946007)(4326008)(5660300002)(64756008)(33656002)(8676002)(9686003)(6506007)(76116006)(55016002)(6636002)(86362001)(71200400001)(478600001)(7696005)(186003)(2906002)(110136005)(316002)(83380400001)(26005)(8936002); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?7KjS30ct4CT3nFoFm+83XKs6BnPqSdgIp66oKflL/YmwEtfR85ExLjbl3ZBJ?= =?us-ascii?Q?QdFiOpgqigo+VXtwYJogtUeOreCqAKJcklJxHmp6OVh4B4mXiaYaypyAkcAL?= =?us-ascii?Q?2y3SPcc60OIeUWQUWfoahYuZEA9ZRwgd+j6GdVPBxVtumMbaddzTuHESUCfn?= =?us-ascii?Q?uY/VVkHEZRrbMbwrTzraAt0KKmchUdk4KhrXMJt2TX+CfTvIs2ttQQD6M2XB?= =?us-ascii?Q?SN5zTMeWQhII9cJow8L0OHKHPJPGgrIchFduXuIzHQDlm0ZvyUMbdow7/iN/?= =?us-ascii?Q?djX94IMZfdPRiC4Wo9at0WPWOfbnCoQ+/CltvtZhS8VxcYCBpG7eeBpJ5hYW?= =?us-ascii?Q?C3tha6PeYUZC0QL8NV7CjWMTNK+JxDjpx2sYG83lUImVc3zh2rekENZiKgru?= =?us-ascii?Q?nhyq0nfl6aFIWlhAFzQ5nI27BdzpaBTR5KiARhOM48015W/xz3EBeE6ydqMl?= =?us-ascii?Q?KgBgl67kbOQqAd2b//X6+wfeoYLdZnmEkdzfBBJbKnf6aPVTNMxYlSVN0Jwd?= =?us-ascii?Q?hvuAX43o2B8UKSGfmJcc02utGzYH1L7/jNkivTIp/jkKZy5vQokSnKIt6dnv?= =?us-ascii?Q?6z6W0AxN8rlEjnWWGdleKpGVJASdzBvesE1zmoyhhwRjuxl8bMnPqjwnsZVR?= =?us-ascii?Q?roYwkUVJt1Zm4Bb7GbOZ995rBkTMlXMlDNj5/5DAUUv0hYDHo16w9pDyK7hG?= =?us-ascii?Q?aTUeCzHcs806LKfeQnwPtsa2H1zQQzvU2qwXQt7LoSmqJeelNI+MjuGYnM8x?= =?us-ascii?Q?MluhjbHW7wIVVbFRDQiloEN9auRmNrDSV2VATIJmsejpzdy/YkCGiXGU8jqi?= =?us-ascii?Q?oXYFBeaUgi7clUz7juRYfJOspm7zlFwK8Nm44mVjuxKuBj6suZiUTxl1XEue?= =?us-ascii?Q?wCf7X+IonfeyOTUsaRmmVHnZY0UzgUpljCvohXDejQoRWFm/TZ4CATpgdf+2?= =?us-ascii?Q?Wxnd/Fl8XhuDmgt7BUc1DP8Q7QfAFJYExx1uCeL0fJw=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR1801MB2058.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 74637b20-a21d-4139-db3e-08d8a727499b X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Dec 2020 09:44:05.2180 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: PmNt2QPJv2/t989ufTwcD5kCKO/kYCwjm3VOXOQ0VTEbXyRzOiGT1WDuNo4NU98DMwg4aobx4NVizwp//CrSWA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR18MB3603 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.343, 18.0.737 definitions=2020-12-23_04:2020-12-21, 2020-12-23 signatures=0 Subject: Re: [dpdk-dev] [PATCH v1 02/38] net/mvpp2: remove debug log on fast-path X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Reviewed-by: Michael Shamis -----Original Message----- From: dev On Behalf Of lironh@marvell.com Sent: Wednesday, December 2, 2020 12:12 PM To: Jerin Jacob Kollanukkaran Cc: dev@dpdk.org; Liron Himi ; stable@dpdk.org Subject: [dpdk-dev] [PATCH v1 02/38] net/mvpp2: remove debug log on fast-pa= th From: Liron Himi in case of non-ip frame the current code reached the 'default' case which result with function call to log a msg. those kind of calls should not be performed on fast-path. The performance for this kind of frames increased by 50% Fixes: acab7d58c ("net/mvpp2: convert to dynamic logging") Cc: stable@dpdk.org Signed-off-by: Liron Himi Reviewed-by: Liron Himi --- drivers/net/mvpp2/mrvl_ethdev.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/mvpp2/mrvl_ethdev.c b/drivers/net/mvpp2/mrvl_ethde= v.c index 93fb30cdb..8c3278ec4 100644 --- a/drivers/net/mvpp2/mrvl_ethdev.c +++ b/drivers/net/mvpp2/mrvl_ethdev.c @@ -2171,7 +2171,6 @@ mrvl_desc_to_packet_type_and_offset(struct pp2_ppio_d= esc *desc, *l4_offset =3D *l3_offset + MRVL_ARP_LENGTH; break; default: - MRVL_LOG(DEBUG, "Failed to recognise l3 packet type"); break; } =20 @@ -2183,7 +2182,6 @@ mrvl_desc_to_packet_type_and_offset(struct pp2_ppio_d= esc *desc, packet_type |=3D RTE_PTYPE_L4_UDP; break; default: - MRVL_LOG(DEBUG, "Failed to recognise l4 packet type"); break; } =20 -- 2.28.0