DPDK patches and discussions
 help / color / mirror / Atom feed
From: Liron Himi <lironh@marvell.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: "ferruh.yigit@intel.com" <ferruh.yigit@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>,
	Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
	Liron Himi <lironh@marvell.com>
Subject: Re: [dpdk-dev] [EXT] Re: [PATCH v3] meson: update meson build for armada drivers
Date: Mon, 11 Jan 2021 16:08:56 +0000
Message-ID: <DM5PR18MB2214279E76FF9C0BC553C29AC6AB9@DM5PR18MB2214.namprd18.prod.outlook.com> (raw)
In-Reply-To: <1776515.fif75YaaBN@thomas>


-----Original Message-----
From: Thomas Monjalon <thomas@monjalon.net> 
Sent: Monday, 11 January 2021 18:05
To: Liron Himi <lironh@marvell.com>
Cc: ferruh.yigit@intel.com; dev@dpdk.org; Jerin Jacob Kollanukkaran <jerinj@marvell.com>; Liron Himi <lironh@marvell.com>
Subject: Re: [EXT] Re: [dpdk-dev] [PATCH v3] meson: update meson build for armada drivers

11/01/2021 16:29, Liron Himi:
> Hi Thomas,
> 
> When did you take this MUSDK version?
> Is this your head "pkg-config: expose dma-add-size"?

I'm using musdk-SDK-10.3.5.0-PR2 as recommended in the doc.

> If not, this explain the mvneta issue.
> I already noticed that and pushed a fixed to the github.

I see. So it may need a doc update.
[L.H.] why need to update the doc? It is still the same release branch, I just added a fix patch to it.

> As for the prefix issue,
> The prefix is being set in the 'configure' phase by using the '--prefix' variable. Have you tried that?

No I didn't try that, and I'm using DESTDIR variable when installing.
Whould it be possible to update the prefix with DESTDIR when installing?
[L.H.] need to explore this option. But for now use 'prefix', as this is what supported by MUSDK



> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Monday, 11 January 2021 13:28
> To: Liron Himi <lironh@marvell.com>
> Cc: ferruh.yigit@intel.com; dev@dpdk.org; Jerin Jacob Kollanukkaran 
> <jerinj@marvell.com>
> Subject: [EXT] Re: [dpdk-dev] [PATCH v3] meson: update meson build for 
> armada drivers
> 
> External Email
> 
> ----------------------------------------------------------------------
> 16/12/2020 22:36, lironh@marvell.com:
> > From: Liron Himi <lironh@marvell.com>
> > 
> > With pkg-config support available within musdk library (from
> > musdk-release-SDK-10.3.5.0-PR2 version), meson option 'lib_musdk_dir' 
> > can be removed.
> > PKG_CONFIG_PATH environment variable should be set appropriately to 
> > use the musdk library.
> 
> Sorry, it does not work.
> 
> First, when installing MUSDK, the .pc file is not updated with the correct prefix path:
> 	make install DESTDIR=$(readlink -f install) In install/mv/lib/pkgconfig/libmusdk.pc:
> 	prefix=/mv
> instead of:
> 	prefix=/musdk_path/install/mv
> 
> Second, after manually fixing the prefix path and compiling DPDK:
> 
> In file included from musdk/install/mv/include/mv_std.h:101,
>                  from musdk/install/mv/include/drivers/mv_neta.h:100,
>                  from dpdk/drivers/net/mvneta/mvneta_ethdev.h:24,
>                  from dpdk/drivers/net/mvneta/mvneta_rxtx.h:10,
>                  from dpdk/drivers/net/mvneta/mvneta_rxtx.c:7:
> musdk/install/mv/include/env/mv_autogen_build_assert.h:43:5: error:
> "MVCONF_DMA_PHYS_ADDR_T_SIZE" is not defined, evaluates to 0 
> [-Werror=undef]
> musdk/install/mv/include/env/mv_autogen_build_assert.h:44:2: error:
> #error "MVCONF_DMA_PHYS_ADDR_T_SIZE must match size used during musdk_lib compilation."
> 
> The CFLAGS may be incomplete:
> 	Cflags: -I${includedir} -DMVCONF_TYPES_PUBLIC -DMVCONF_DMA_PHYS_ADDR_T_PUBLIC I fixed it by adding:
> 	-DMVCONF_DMA_PHYS_ADDR_T_SIZE=64
> 
> Please could you fix MUSDK quickly?
> 
> I think I will pull next-net as is, but I consider it is broken.
> 
> 
> 






  reply	other threads:[~2021-01-11 16:09 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-02 13:05 [dpdk-dev] [PATCH v1 0/2] armada: introduce musdk pkg-config lironh
2020-12-02 13:05 ` [dpdk-dev] [PATCH v1 1/2] meson: update meson build for armada drivers lironh
2020-12-09 10:49   ` Ferruh Yigit
2020-12-13 20:06     ` [dpdk-dev] [EXT] " Liron Himi
2020-12-14  9:57       ` Ferruh Yigit
2020-12-15 10:04         ` Liron Himi
2020-12-15 10:29           ` Ferruh Yigit
2020-12-15 22:19   ` [dpdk-dev] [PATCH v2] " lironh
2020-12-15 22:23   ` lironh
2020-12-16 13:37     ` Ferruh Yigit
2020-12-16 13:41       ` [dpdk-dev] [EXT] " Liron Himi
2020-12-16 13:48         ` Ferruh Yigit
2020-12-16 21:15           ` Liron Himi
2020-12-16 13:52         ` Ferruh Yigit
2020-12-17 10:06           ` Luca Boccassi
2020-12-17 10:16             ` Ferruh Yigit
2020-12-16 21:36     ` [dpdk-dev] [PATCH v3] " lironh
2020-12-17 12:15       ` Ferruh Yigit
2021-01-11 11:28       ` Thomas Monjalon
2021-01-11 15:29         ` [dpdk-dev] [EXT] " Liron Himi
2021-01-11 16:05           ` Thomas Monjalon
2021-01-11 16:08             ` Liron Himi [this message]
2021-01-11 16:17               ` Thomas Monjalon
2021-01-11 17:07                 ` Bruce Richardson
2021-01-11 17:30                   ` Thomas Monjalon
2021-01-11 18:01                   ` Luca Boccassi
2021-01-11 17:04             ` Bruce Richardson
2021-01-11 17:06               ` Thomas Monjalon
2020-12-02 13:05 ` [dpdk-dev] [PATCH v1 2/2] doc: update armada docs lironh
2020-12-09 10:45   ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM5PR18MB2214279E76FF9C0BC553C29AC6AB9@DM5PR18MB2214.namprd18.prod.outlook.com \
    --to=lironh@marvell.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=jerinj@marvell.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror https://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ https://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git