From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 343DDA0524; Mon, 7 Dec 2020 13:38:06 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5FFC4F72; Mon, 7 Dec 2020 13:38:04 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by dpdk.org (Postfix) with ESMTP id C0BCBF12; Mon, 7 Dec 2020 13:38:01 +0100 (CET) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 0B7CQFVT022234; Mon, 7 Dec 2020 04:37:59 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h=from : to : cc : subject : date : message-id : references : in-reply-to : content-type : content-transfer-encoding : mime-version; s=pfpt0220; bh=qcQ/DDS64gKiUsxF/fvPJiABgUm2FG593LO6coVcC9g=; b=UucXRK1pZKzHTsSoAu2T1+SSCrpExubqhWSHIqyeTl39fmUgiqTtxBwdJ+5/OPlJbPnP Xghmd1BuYj4jmxEUX8lAfiu57dWtfGwc6sxGtHAHSFVbz1KY8I9drFcGrvFKPYqYQIMW nBKSQTruf2jKpMf28zDk3XUTiI3dfAyQDJsdW7wSOsNYJ6uHskYTjlAi9sRL64RPT+3y 9INcvzPPS04UwaPNhrIWHY7hgNZ8mARvyrADWx6Cl9Z7cHQyhFxXTL4YfLlL8ZvBzIjP r/dApR7Ni/0HMoAobBgTVsN1nTF7WAvM2Y/Sc8FHDF4B6DiMeqh12K91xG6ir9aFmpPC hw== Received: from sc-exch03.marvell.com ([199.233.58.183]) by mx0a-0016f401.pphosted.com with ESMTP id 3588et466m-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT); Mon, 07 Dec 2020 04:37:59 -0800 Received: from SC-EXCH04.marvell.com (10.93.176.84) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 7 Dec 2020 04:37:58 -0800 Received: from SC-EXCH03.marvell.com (10.93.176.83) by SC-EXCH04.marvell.com (10.93.176.84) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 7 Dec 2020 04:37:58 -0800 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.109) by SC-EXCH03.marvell.com (10.93.176.83) with Microsoft SMTP Server (TLS) id 15.0.1497.2 via Frontend Transport; Mon, 7 Dec 2020 04:37:58 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=E1RWaVZ6idF7emmPGXt8G84GBXCuyGVEKvwIFyNJthIVVHemD22c+IYGjlUFXBH75DNbIp5X6y4hnXwoF4CXVBCL39GzO6/6XxI3pwif9Ixk7dntU048YYy1Ew4+RE1L8QrVQYs3JRIYsBljOy/1R9J5KrMPu9NlBjmRWdXeCLzp1xSghD/YTaPb1lQQbwdDJwQqb4IsOVhNJlAN07UAEpPM5n5UrrsaMVBLybStM1VM3ZlkAo1NnHcHjhbQTVg8rnOSVytuw3eIJHjVNTAl9Y/RH9gzjZ9f+hD6dmsssXQoLhe77S+jQeZMKXyE2opgbSozTYJBTw3KGv3Y+z3CwQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qcQ/DDS64gKiUsxF/fvPJiABgUm2FG593LO6coVcC9g=; b=XzzXlaGOfbyM+cu41XijKW4YYsLJWddUHVbv2gX6M9IvvP9RlWce0GkxVI+DvP9oqi/6Qh49PwlvsOmf8rriyC+L119kzs44nMUrEbuUSUbSywImq9Q8/Glgw60S8v4f4AtYtDhZ3MKn/L1aaAP0DUJLmVXEYbtGH0bIKStQob9+cmynp1Aob5/mbbAUOnGbY8kI8ZTsjzhV9m93ZEvtPkVLOSU4dGarEo84GdneKMVpBxON4v68NVkCNLzhQ9W7CY5p4fkfdQNA9a5K2yoJ1wqyY0DOgEA6kd1p/4eiIpP1hoCsUuVXTWl64jKdsGm0yoWOLcYaEmiJ8rUg9LGDYw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=marvell.com; dmarc=pass action=none header.from=marvell.com; dkim=pass header.d=marvell.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.onmicrosoft.com; s=selector1-marvell-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qcQ/DDS64gKiUsxF/fvPJiABgUm2FG593LO6coVcC9g=; b=YonGzP6eV6H2eUbD3QSZj3Jmma1S9cOBfvC0Voa9TcgOeFTDSrsSqFRQz7ZZralF2hxhNnRX8GXrxulQahKxKZePBcWEYLVnxG11E57t9QgE2vf999YqXH0J305txiCnvUs2JRgIDEKVsJsX+Hy7AhgNEc12FKZdHBmYbxHJgfI= Received: from DM5PR18MB2214.namprd18.prod.outlook.com (2603:10b6:4:b9::21) by DM5PR18MB2279.namprd18.prod.outlook.com (2603:10b6:4:b7::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3632.22; Mon, 7 Dec 2020 12:37:57 +0000 Received: from DM5PR18MB2214.namprd18.prod.outlook.com ([fe80::5d76:dae3:afeb:1da8]) by DM5PR18MB2214.namprd18.prod.outlook.com ([fe80::5d76:dae3:afeb:1da8%4]) with mapi id 15.20.3632.023; Mon, 7 Dec 2020 12:37:56 +0000 From: Liron Himi To: wangyunjian , "dev@dpdk.org" CC: "zr@semihalf.com" , "jerry.lilijun@huawei.com" , "xudingke@huawei.com" , "stable@dpdk.org" , Liron Himi Thread-Topic: [EXT] [dpdk-dev] [PATCH] net/mvneta: check allocation in rx queue flush Thread-Index: AQHWzI1bLlnpUuP9zE2NdUUNXPnamqnrkYyQ Date: Mon, 7 Dec 2020 12:37:56 +0000 Message-ID: References: <1607341035-9372-1-git-send-email-wangyunjian@huawei.com> In-Reply-To: <1607341035-9372-1-git-send-email-wangyunjian@huawei.com> Accept-Language: he-IL, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: huawei.com; dkim=none (message not signed) header.d=none;huawei.com; dmarc=none action=none header.from=marvell.com; x-originating-ip: [89.139.15.162] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: cc1bd447-1960-4bd9-da1d-08d89aacecb9 x-ms-traffictypediagnostic: DM5PR18MB2279: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:6430; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: +W0yGHwXNaZ5u7lsw9DAquy87SDt04BU9+tePIhBPRRNjt9PGcW13UdTYVmmjTTHGpxM91ETbQvgBYQS9uhn33egDgwqxcFG8Nd1PYfp1nL67aDfS6Na/JrTDT0x6D5K6zUG2iYmSBp1zVopjVhyBCl0SKbu3ynjwR0G/JYfkXpm1J57UogAdxBWCQOgHOv+JH0fxfBYMavLBX3NE933sSauJqR7MBmz923mbGV9QT1sQkZSKIGJ/Ih6aMBaUQPZ+/zCQGXGF9M/UV8F7k5JdfzCZmtvehbt6erdXf4gCUramg9aJAHKA6/ekMppJAJo/qUAedXH9aAZyLhFFMp8JQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM5PR18MB2214.namprd18.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(366004)(136003)(376002)(39850400004)(396003)(346002)(66946007)(478600001)(66476007)(316002)(64756008)(86362001)(83380400001)(33656002)(2906002)(8936002)(55016002)(5660300002)(9686003)(76116006)(107886003)(110136005)(4326008)(7696005)(66446008)(71200400001)(52536014)(6506007)(53546011)(54906003)(66556008)(26005)(8676002)(186003); DIR:OUT; SFP:1101; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?CoN1H017gabglfkOB37LSqX8SdLN3PZLivPCTFDGhFav+beVl8qRIqqeBHbo?= =?us-ascii?Q?63uSeZlGf661VMxYApbCNqMKjWqUSAhbTqSXequum5KIUIg0FDQ2rlXoPYZ3?= =?us-ascii?Q?qG2lqAyAKQcXb2VcrmacwXbILJOKnRgAfo+rEyA8BDXS3Hbob3F0dmmvuYlX?= =?us-ascii?Q?gP0710o4m97Eo8oLvGaa9nC5syZ5HmOMkY1oRUHn554StEJF4RcsaWjxs2yt?= =?us-ascii?Q?55Yp6tUUdqdTKtxpFnOwjtB9re492WNKm7CcuhLLgRPFLOjzBj9eHUQv1pV9?= =?us-ascii?Q?NxRRtmnxtxl6rSATU6zNlccS48c3D0I/fZzE3owrQKK1Syx/3BfBVH0V+/He?= =?us-ascii?Q?+zT8tYpFJPNQUEtUlzbsXmt06uqedeYD5lNLp3cxcOE1yhoDTv8Qwyz4dWda?= =?us-ascii?Q?yAdVgveoq8YS3OrwG5vlfY68vbHjSaOY6OdShATWN3RT9R3yqQmRieMBprIQ?= =?us-ascii?Q?Mhf2JeoeOoIjfLwaWcnxmyDn853XVvNIS3zANWe2onSJ+VjbXSg0B2J+Nio9?= =?us-ascii?Q?qGXj+94N5sRgfSQ3Pp5L+5pidVbwoPHvSHO2ba5fAZ7D5Vb9ovyu1+3r/oC2?= =?us-ascii?Q?NP/lsIaHzSwfxyMeaEATSAcXdGtZD7Nec8CjRQpIgmQUxXXdAWRUBbrhsoCB?= =?us-ascii?Q?0XSuESMYCS728A/2LHkD7EpD7Ljm/rH5dGHhWMN4JxdyM61sx+V1mVB/Kqyk?= =?us-ascii?Q?/1fW+uBym3DfM1ax0ph7jP/RSf+I7ISdjz21JleY1qnATkVEKLTjkPwAQFDM?= =?us-ascii?Q?rYh/873JpyBXUUSyiGKrrlbk+vyHmZWq7Ad2SCOZrCSj/J7FFMiSKOXaz4Xe?= =?us-ascii?Q?v70xLfpc3O4LLis/MAFWKgOPV8+EBRG2DX1MnheS0ZK1CK4ebI1etlqxj4lY?= =?us-ascii?Q?PwsZRWYgeD075hqg1btb0hQWT0QND4AoYjWf2kAvie11+JdEjYHg4e5ddPnH?= =?us-ascii?Q?YUWE4naqOVnVUBV6BHTbkWeem+Ww+Q6WQqUJ09pbjpw=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM5PR18MB2214.namprd18.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: cc1bd447-1960-4bd9-da1d-08d89aacecb9 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Dec 2020 12:37:56.8021 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: w+ZX5nkYQg9bUDPA0LUk9taEAqYxa06PxQTSnzy3bLm75EPWUm81iu9BkolVOx1HBIUr2nmBnJNo0tr1uJJwUg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR18MB2279 X-OriginatorOrg: marvell.com X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.343, 18.0.737 definitions=2020-12-07_11:2020-12-04, 2020-12-07 signatures=0 Subject: Re: [dpdk-dev] [EXT] [PATCH] net/mvneta: check allocation in rx queue flush X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, How about use 2 local arrays for descs & bufs instead of the malloc/free?=20 Liron -----Original Message----- From: wangyunjian =20 Sent: Monday, 7 December 2020 13:37 To: dev@dpdk.org Cc: Liron Himi ; zr@semihalf.com; jerry.lilijun@huawei.= com; xudingke@huawei.com; Yunjian Wang ; stable@dpd= k.org Subject: [EXT] [dpdk-dev] [PATCH] net/mvneta: check allocation in rx queue = flush External Email ---------------------------------------------------------------------- From: Yunjian Wang The function rte_malloc() could return NULL, the return value need to be ch= ecked. Fixes: ce7ea764597e ("net/mvneta: support Rx/Tx") Cc: stable@dpdk.org Signed-off-by: Yunjian Wang --- drivers/net/mvneta/mvneta_rxtx.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/drivers/net/mvneta/mvneta_rxtx.c b/drivers/net/mvneta/mvneta_r= xtx.c index 10b6f57584..dfa7ecc090 100644 --- a/drivers/net/mvneta/mvneta_rxtx.c +++ b/drivers/net/mvneta/mvneta_rxtx.c @@ -872,7 +872,17 @@ mvneta_rx_queue_flush(struct mvneta_rxq *rxq) int ret, i; =20 descs =3D rte_malloc("rxdesc", MRVL_NETA_RXD_MAX * sizeof(*descs), 0); + if (descs =3D=3D NULL) { + MVNETA_LOG(ERR, "Failed to allocate descs."); + return; + } + bufs =3D rte_malloc("buffs", MRVL_NETA_RXD_MAX * sizeof(*bufs), 0); + if (bufs =3D=3D NULL) { + MVNETA_LOG(ERR, "Failed to allocate bufs."); + rte_free(descs); + return; + } =20 do { num =3D MRVL_NETA_RXD_MAX; -- 2.23.0