From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id CA84DA09FF;
	Wed, 30 Dec 2020 12:23:34 +0100 (CET)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 09930C9C2;
	Wed, 30 Dec 2020 12:23:33 +0100 (CET)
Received: from NAM11-BN8-obe.outbound.protection.outlook.com
 (mail-bn8nam11on2131.outbound.protection.outlook.com [40.107.236.131])
 by dpdk.org (Postfix) with ESMTP id A46C4C9C8
 for <dev@dpdk.org>; Wed, 23 Dec 2020 19:16:20 +0100 (CET)
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=gJL0MzzY1NAyHQu6PWnBXB3lILIbneS5oaaHRo0ptNJBIJcWlgtoH6Wj190ofxYzHPslkjC/pLAyyW5Gshu98gTHBgNEc51kyVgcLq8F1xJym6Vjdv84BnARiijH/85BsJolhAuASndaN2V9xKHXApm4W1sMsE8sPg3fYT/mDkk47NVriNnXp9SFDwxgDF/13wZqKKdcS/T02eWc+bxVSEPUU6lpk6j+PCkjNYGyxCkdUGiYK7iGEeNFBkTrn2QJwDsmQaVIDQc6+aRJv5kAC+gA1sj+MiS5OrVcZKlyDkYKYJuBo/nPnxaJRfwcwze+5GLx1l8s7+F20gZoecu/Dg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; 
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=TzHo1cBjk9XIsXy5uXYc9ZhW6cbGGt93f1rzC/pAA2w=;
 b=oYhthmsoKiZB3lzJGNuLcHUnyrsu0+CV48lV+BtapSiYMV+/IG/hysfjqWgtyOPItzo8T/hczTrNjOTxeoepS6/0Zb6+w+5o/5zQZeIrBLPr/y+JtB2CpWaqS8O+6lqCXirsYl/r6Y4eAEss7hr3Z8fxT2PVUqCawAMaeJ9k7B4vyrXUDF4GE2N+YJgYce7ZopaX+4wCtU5sFOE1kOQhD4ilK81jdmV0z0LeVoBhNu0LbSbGoIL5JRZSAxng02FKa/wL4OeABEija+Jv2pqELG6HSq0dr2h5gzb/c6qgd1BMxGCWjjCqNJst8JhVKzAzx06QJV43XcTyeuK9RpN4aA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=microsoft.com; dmarc=pass action=none
 header.from=microsoft.com; dkim=pass header.d=microsoft.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
 s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=TzHo1cBjk9XIsXy5uXYc9ZhW6cbGGt93f1rzC/pAA2w=;
 b=d+XIiwHUTmdK0/6t9Q55EzgzJyT0skjjM42ctpkTb3oXLuj6oZUJpB74fJ+OUhO2Dgyh1QpU5YrQ/mVWtGGAAn6KIkmYSoSEJdSMxAjCzF14qbvj7lto7UjxLma3JNm1STDX2teHVWcK1XJ4t/ZmpKtnRi6I9QKDit9qDknv/CM=
Received: from (2603:10b6:4:a4::30) by DM5PR21MB0140.namprd21.prod.outlook.com
 (2603:10b6:3:a5::15) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3721.6; Wed, 23 Dec
 2020 18:16:17 +0000
Received: from DM5PR21MB1816.namprd21.prod.outlook.com
 ([fe80::42f:a3e7:5bb5:681f]) by DM5PR21MB1816.namprd21.prod.outlook.com
 ([fe80::42f:a3e7:5bb5:681f%8]) with mapi id 15.20.3721.013; Wed, 23 Dec 2020
 18:16:17 +0000
From: "Dmitry Malloy (MESHCHANINOV)" <dmitrym@microsoft.com>
To: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>, Tal Shnaiderman
 <talshn@nvidia.com>
CC: "dev@dpdk.org" <dev@dpdk.org>, thomas <thomas@monjalon.net>, "Kadam,
 Pallavi" <pallavi.kadam@intel.com>, "navasile@linux.microsoft.com"
 <navasile@linux.microsoft.com>, "david.marchand@redhat.com"
 <david.marchand@redhat.com>
Thread-Topic: [EXTERNAL] Re: [PATCH v4] eal: add generic thread-local-storage
 functions
Thread-Index: AQHW2SEE5K+kxYGnqEGJNGaSHNSQlaoEk60AgABpM1A=
Date: Wed, 23 Dec 2020 18:16:17 +0000
Message-ID: <DM5PR21MB18163B9987787F6C6F838495B3DE9@DM5PR21MB1816.namprd21.prod.outlook.com>
References: <20201217174913.14280-1-talshn@nvidia.com>
 <20201222073044.9084-1-talshn@nvidia.com>	<20201223041801.5ea13a37@sovereign>
 <DM6PR12MB3945ECF08431F60301FE36C6A4DE0@DM6PR12MB3945.namprd12.prod.outlook.com>
 <20201223145846.433883d8@sovereign>
In-Reply-To: <20201223145846.433883d8@sovereign>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
msip_labels: MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Enabled=true;
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SetDate=2020-12-23T18:16:15Z; 
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Method=Standard;
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_Name=Internal;
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_SiteId=72f988bf-86f1-41af-91ab-2d7cd011db47;
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ActionId=7c08d99b-0459-400f-a2fa-3ee272aa8814;
 MSIP_Label_f42aa342-8706-4288-bd11-ebb85995028c_ContentBits=0
authentication-results: gmail.com; dkim=none (message not signed)
 header.d=none;gmail.com; dmarc=none action=none header.from=microsoft.com;
x-originating-ip: [2001:4898:80e8:a:1545:ed84:ca5f:2854]
x-ms-publictraffictype: Email
x-ms-office365-filtering-ht: Tenant
x-ms-office365-filtering-correlation-id: 90f736f4-7b0d-4f94-303b-08d8a76ed760
x-ms-traffictypediagnostic: DM5PR21MB0140:
x-ms-exchange-transport-forked: True
x-ld-processed: 72f988bf-86f1-41af-91ab-2d7cd011db47,ExtAddr
x-microsoft-antispam-prvs: <DM5PR21MB0140B009DB66D19177980565B3DE9@DM5PR21MB0140.namprd21.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:7219;
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: pG9XGxapbSOiaOLsuIH0YNEs3VfwWt2jAo+ph2NKLXxUp8IGpA3s/jr3vCaDqGNfNCOfvtI38KlkLhocLn3J8UNBZNjXIsq3X+jWw0xMnWXd5bgbkwyxKetnxYxXSb4GOzCwRVq5/fu9n0qzfIPK9cMEv7MA4htrEsB3PDVCLlAkTFcp9FxvAfkS9beebTGFsPPQ01N4+fUcdsJ8BfTSlWKPEdU+qaxlDKuX7TrRNv0AA/BWMQ6Yyityrv/qg99PiSu8VRVU7MMsiQ6vvdbeQj3oaGEqOzToE9JgjWKJR+HLbdR+9i/8mItsVlgLeSNnDqOqiHXvUcFbOma6tZFCOvyifsoQTVH5JvAQ2imenKYDHXqTdPGD4sLerjuwsE0XSTpD+SH9CK87gNq9mDe+dORwf9fx+EVfGA6H+cu1uxqZRFvqgXV7CrJKR2xZ2Ps7
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
 IPV:NLI; SFV:NSPM; H:DM5PR21MB1816.namprd21.prod.outlook.com; PTR:; CAT:NONE;
 SFS:(4636009)(346002)(39860400002)(396003)(376002)(136003)(366004)(110136005)(54906003)(4326008)(7696005)(55016002)(71200400001)(8990500004)(8936002)(83380400001)(5660300002)(82960400001)(9686003)(6506007)(82950400001)(52536014)(76116006)(33656002)(66946007)(66476007)(66556008)(64756008)(2906002)(66446008)(53546011)(8676002)(316002)(86362001)(478600001)(186003)(10290500003)(41533002);
 DIR:OUT; SFP:1102; 
x-ms-exchange-antispam-messagedata: =?us-ascii?Q?Vx5FOwZYynuuxzOQsVqoTMg0/DRuNked6ZUiMxXmlamIESwWLQNPV9jOSCnJ?=
 =?us-ascii?Q?HgQgQWSBqCLnTg4vZoFCJYxvonuMGm1UVnJghtPIuUcU5Tk6nwEfrsmELjLP?=
 =?us-ascii?Q?Mv9k9GnEPz4x29IsASd0MjELtOAzJksMDkQ7YOFtvgYD9TFLmdt5/E3iXy2J?=
 =?us-ascii?Q?nz567bZgrnce0o+408wc9SdtHMhO5JUw55h6ZsXJUh75kqYxnnoaMXhZWqhD?=
 =?us-ascii?Q?BD629fX6/wHd0QpM04XSTXXktY13awYcgis6EY/qBfHd54FxuboRNI1MCj8e?=
 =?us-ascii?Q?83PUyvHUL/pD7fTkMnqmY+7lePqDqik3A1vFPJR7msCIn2+6qg8O6P74I5+o?=
 =?us-ascii?Q?ohDpf8sGP34WgO94G1sm2llpeEudITbuMJuys4u++zbKf3FWNeuBxcZAl5j/?=
 =?us-ascii?Q?AgylriT6ZuznBeRtVzx3vUDZERdhLOznKDADFqf+RBQ9SiJZ+DboIqbJRZ4A?=
 =?us-ascii?Q?F8L1LGcP71l6hJ5ktvXQA9ff7z20YIQdf5LazRKpOPpJXifBmNg8Z+vSzpPy?=
 =?us-ascii?Q?Fmzxk2/YqIN/s1zLq1i1PxgW6ws+5kjSTXcIAJ/oukPmJNivQpFKZEBqbNUY?=
 =?us-ascii?Q?/Wczvpl8MZE8fTNIeU464J6OwvMDPTVI6Iz9hbVdRrCvK7cC614lNwtG79X1?=
 =?us-ascii?Q?FOiv97TWI6s+LFlkkvi7SbIt9/PlVR1ZYYf0MDEhBVeDYBfEIrPBwdfcv+l+?=
 =?us-ascii?Q?+OCO1bJNmFfbGCC7D0FF7aBQZz6CBGmllfA1byTXVJkK5iq3GzHI2iY5l8Vt?=
 =?us-ascii?Q?obobiirfBvNfxq+z/XPXMXlPImq7oLfFZzc91WseZIYtjI52W8X+sSrBvHle?=
 =?us-ascii?Q?F1JU+NYztSEDNNSn2k9HvuPYmOKyyHB782LvZ0wnxPFgVDVr5KciwvTincGb?=
 =?us-ascii?Q?OkYKaw4YwNuweNpkbkGeSAOEbIJynZz/oJVHweBl3DsAb+DD5QDc3zKZapI9?=
 =?us-ascii?Q?6PQoZ9bbCs9YSLTnmZ14YaaPK8DjXI3r6HpUD86xd9MzPLUkRgzzHkogAcBg?=
 =?us-ascii?Q?BbEQEg+qROmNYnZobLdfQm52SKLI39l5Mpjm7wN23dR+tgI=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: microsoft.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM5PR21MB1816.namprd21.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 90f736f4-7b0d-4f94-303b-08d8a76ed760
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Dec 2020 18:16:17.3132 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 72f988bf-86f1-41af-91ab-2d7cd011db47
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: gR/LzsNV1Yqs2/Gzz1xD9iQwsFBekSxLyIJN7UFrsLsmDq2MhjvRvROIbeo0s9hOWyFcZJMsLBVheKra01fytBGNMTtNbwsrUdRw34AF3fQ=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR21MB0140
X-Mailman-Approved-At: Wed, 30 Dec 2020 12:23:31 +0100
Subject: Re: [dpdk-dev] [EXTERNAL] Re: [PATCH v4] eal: add generic
 thread-local-storage functions
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

I wonder if this should be consistent with Nick's meson (to use external pt=
hread library) change?

-----Original Message-----
From: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>=20
Sent: Wednesday, December 23, 2020 3:59 AM
To: Tal Shnaiderman <talshn@nvidia.com>
Cc: dev@dpdk.org; thomas <thomas@monjalon.net>; Kadam, Pallavi <pallavi.kad=
am@intel.com>; navasile@linux.microsoft.com; Dmitry Malloy (MESHCHANINOV) <=
dmitrym@microsoft.com>; david.marchand@redhat.com
Subject: [EXTERNAL] Re: [PATCH v4] eal: add generic thread-local-storage fu=
nctions

On Wed, 23 Dec 2020 11:44:31 +0000, Tal Shnaiderman wrote:
> > > diff --git a/lib/librte_eal/windows/meson.build
> > > b/lib/librte_eal/windows/meson.build
> > > index 3b2faf29eb..1f1398dfe9 100644
> > > --- a/lib/librte_eal/windows/meson.build
> > > +++ b/lib/librte_eal/windows/meson.build
> > > @@ -21,4 +21,10 @@ sources +=3D files(
> > >       'getopt.c',
> > >  )
> > >
> > > +if (dpdk_conf.has('use_external_pthread')) =20
> >=20
> > Please describe the new option in meson_options.txt.
> > Maybe drop "external" from the name, what do you think? =20
>=20
> How about use_windows_pthread to be clear that it's unrelated to UNIX pth=
reads?

Sounds good.