From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id CB34DA0573; Wed, 4 Mar 2020 19:16:55 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B81692BB8; Wed, 4 Mar 2020 19:16:54 +0100 (CET) Received: from us-smtp-delivery-181.mimecast.com (us-smtp-delivery-181.mimecast.com [216.205.24.181]) by dpdk.org (Postfix) with ESMTP id AC8E92BB8 for ; Wed, 4 Mar 2020 19:16:52 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rbbn.com; s=mimecast20180816; t=1583345811; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type; bh=MDJL4tmgOmPEBYCIk0nDuiWoL3BwioGKMH1RnIs2cJQ=; b=ChmLvDg/qH9ESNGrSDfi4euiXKoEXHWRi9p6VZTsToEvWCM07lqvlKaXYbYu9vqZfwXM0n S1kLVB0Lb3UD2aI6mZISNs7zFjP5hZX5ZZ3fNnsv2YImZWBSY0W23+UaRlMUBCL9OmZ+KR BBzlIL0fBuR/7eOkvbdaZBZDFOdFfns= Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12lp2174.outbound.protection.outlook.com [104.47.59.174]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-393-75gZHLnzPvmZ83U9zBmkdw-1; Wed, 04 Mar 2020 13:16:49 -0500 Received: from DM6PR03MB4777.namprd03.prod.outlook.com (2603:10b6:5:18b::26) by DM6PR03MB3724.namprd03.prod.outlook.com (2603:10b6:5:a9::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2772.14; Wed, 4 Mar 2020 18:16:48 +0000 Received: from DM6PR03MB4777.namprd03.prod.outlook.com ([fe80::8a1:2fec:6da4:5789]) by DM6PR03MB4777.namprd03.prod.outlook.com ([fe80::8a1:2fec:6da4:5789%5]) with mapi id 15.20.2772.019; Wed, 4 Mar 2020 18:16:48 +0000 From: "Dey, Souvik" To: "dev@dpdk.org" CC: "xiaolong.ye@intel.com" , "xiao.zhang@intel.com" , "users@dpdk.org" Date: Wed, 4 Mar 2020 13:16:47 -0500 Thread-Topic: Issue with X550 link status Thread-Index: AdXyT8/bQlsnsGziSD2jyQ8c0Wwhlw== Message-ID: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US x-originating-ip: [208.45.178.4] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 3fcc887d-8219-41f3-6f40-08d7c068342d x-ms-traffictypediagnostic: DM6PR03MB3724: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-forefront-prvs: 0332AACBC3 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(136003)(39860400002)(346002)(396003)(376002)(366004)(189003)(199004)(478600001)(4326008)(81166006)(8676002)(26005)(8936002)(966005)(9326002)(9686003)(81156014)(55016002)(186003)(7696005)(71200400001)(6506007)(86362001)(316002)(66946007)(54906003)(76116006)(66476007)(66446008)(66556008)(33656002)(64756008)(6916009)(2906002)(52536014)(5660300002); DIR:OUT; SFP:1101; SCL:1; SRVR:DM6PR03MB3724; H:DM6PR03MB4777.namprd03.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: QEODSuuu6S8HNCxHgHxh+BhDoOVI10ZP9sY4crNTmVAdpffq0N3RlbhZH7pFENFb9lkFZ/DNt8wCplVjDoqdtz/yAj7vE5WWncvs3BeDaRQmf9w4gyNraVtAgU1RDj/2IYQNB6dyAEuPd17sufPPcoCfKM/JPHa0jhWJ6a4XpZU621HYXmdq6iH8kY2LpHukW7SIiAjLB/KzMmenxn3afHdSMcrON9brgVoGljkBlMbNFzDuWGEkuY+KXZ+0Eiym3U/9349vhLuTkhIsbTSkMa9PO/1CNCE55EBbAynlUxcqPLfRsLbLO+1CvEJGdLr8Uhh+iTO7t+0xmP0dILFs7yYiIIyne4rwKTNIUNquPuNog+/ohLFB7EyaRios7GJWNrNhwV5o6y0CkBhxh7d6iyOAzRUU3bwFRADl0oYHiLxs+ZXT9T6hfXvU41ZeTO56OuXBNXjNuT7pVsgJVxAiTz58yKeWGTlOLuv+XS0y2UNr0wGUzbhw8WAt8wwNG7g1pj1RaOETewAJCjcA2bTB/A== x-ms-exchange-antispam-messagedata: 7Y/iZIEewKSLlUwfjPFjDpeDf0Sb+hB6ulmGw4TqPzPP60r06EqUVG1lR7UTYLOb5UbiRARg7dpSSpaYndUH/wuLsgnmKEc85b1b2bcuZtQHq3g9Bw7U3KJL6cA/tQLdAhgTN5fqsl4V8tGWXbOwyQ== x-ms-exchange-transport-forked: True x-mc-unique: 75gZHLnzPvmZ83U9zBmkdw-1 x-originatororg: rbbn.com x-ms-exchange-crosstenant-network-message-id: 3fcc887d-8219-41f3-6f40-08d7c068342d x-ms-exchange-crosstenant-originalarrivaltime: 04 Mar 2020 18:16:47.9230 (UTC) x-ms-exchange-crosstenant-fromentityheader: Hosted x-ms-exchange-crosstenant-id: 29a671dc-ed7e-4a54-b1e5-8da1eb495dc3 x-ms-exchange-crosstenant-mailboxtype: HOSTED x-ms-exchange-crosstenant-userprincipalname: Q8+KTP5SdNN9mffkZ8z+11AnFgw7ttbTMPOuOuOgTifWuDGcUiOvniLFwdXqsV5U x-ms-exchange-transport-crosstenantheadersstamped: DM6PR03MB3724 MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: rbbn.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: [dpdk-dev] Issue with X550 link status X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi All, After upgrading to DPDK 18.11.6 LTS release from 18.11.2 the = link_update call for link status update is not working for X550 NICs SR-IO= V enabled. On debugging it looks like the change introduced as a part of th= is patch is causing the issue. https://patches.dpdk.org/patch/62140/ @@ -4135,6 +4138,10 @@ ixgbe_dev_link_update_share(struct rte_eth_dev *dev= , return rte_eth_linkstatus_set(dev, &link); } + esdp_reg =3D IXGBE_READ_REG(hw, IXGBE_ESDP); + if ((esdp_reg & IXGBE_ESDP_SDP3)) + link_up =3D 0; + if (link_up =3D=3D 0) { if (ixgbe_get_media_type(hw) =3D=3D ixgbe_media_type_fiber) { intr->flags |=3D IXGBE_FLAG_NEED_LINK_CONFIG; I can see that the esdp_req is coming as 3735928495(0xDEADBEAF) and due to = which the link_up is set to 0 even when ixgbevf_check_link returned link_up= as 1. Along with this patch I also see a path_fullchk patch introduced , d= oes that play any role in this ? Can someone please let me know if the patch has got some issues or it is be= having correctly and the link_status is failing for valid reason. As mentio= ned earlier the same HW with same NIC acting in SR-IOV works fine with 18.1= 1.2 DPDK . I am blocked at a customer bug dew to this and any urgent help w= ill be much appreciated. -- Regards, Souvik ---------------------------------------------------------------------------= -------------------------------------------- Notice: This e-mail together with any attachments may contain information o= f Ribbon Communications Inc. that is confidential and/or proprietary for the sole use of the intended recipie= nt. Any review, disclosure, reliance or distribution by others or forwarding without express permission is strictly= prohibited. If you are not the intended recipient, please notify the sender immediately and then delete all copies,= including any attachments. ---------------------------------------------------------------------------= --------------------------------------------