From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0C02AA0573; Wed, 4 Mar 2020 22:23:10 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A6A021BFB5; Wed, 4 Mar 2020 22:23:05 +0100 (CET) Received: from us-smtp-delivery-181.mimecast.com (us-smtp-delivery-181.mimecast.com [63.128.21.181]) by dpdk.org (Postfix) with ESMTP id AF7E42C4F for ; Wed, 4 Mar 2020 22:23:02 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rbbn.com; s=mimecast20180816; t=1583356982; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=9yLEEUqW4UjDIQ+ct40abdO1TosKjZ2Puy/Z6POkLsg=; b=JPeLCWWDIrQbx7Sh9uEXNP9lXMTzp8gxDgEicPE1sOHLkeS3EjTNTRjkLloC4v3nCnzpzL RcY7M3KUKv3GF/jlQzaf3KTiPy20PUV7q5cRigh1jRcD5imrnwqww4qpvPULwDlRpfIrg7 VRYrlwB4oLzzoFPKniuNlFhCBBWirJ8= Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11lp2169.outbound.protection.outlook.com [104.47.56.169]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-112-J8DQNR8vNg2zRFUFfF1cfQ-1; Wed, 04 Mar 2020 16:22:59 -0500 Received: from DM6PR03MB4777.namprd03.prod.outlook.com (2603:10b6:5:18b::26) by DM6PR03MB5211.namprd03.prod.outlook.com (2603:10b6:5:24a::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2772.15; Wed, 4 Mar 2020 21:22:57 +0000 Received: from DM6PR03MB4777.namprd03.prod.outlook.com ([fe80::8a1:2fec:6da4:5789]) by DM6PR03MB4777.namprd03.prod.outlook.com ([fe80::8a1:2fec:6da4:5789%5]) with mapi id 15.20.2772.019; Wed, 4 Mar 2020 21:22:57 +0000 From: "Dey, Souvik" To: "dev@dpdk.org" CC: "xiaolong.ye@intel.com" , "xiao.zhang@intel.com" , "users@dpdk.org" , Stephen Hemminger , Ferruh Yigit , "stable@dpdk.org" Thread-Topic: Issue with X550 link status Thread-Index: AdXyT8/bQlsnsGziSD2jyQ8c0WwhlwAGOUbwAAB8AuA= Importance: high X-Priority: 1 Date: Wed, 4 Mar 2020 21:22:57 +0000 Message-ID: References: In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [208.45.178.4] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a1979864-7191-4d2c-44c2-08d7c0823592 x-ms-traffictypediagnostic: DM6PR03MB5211: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-forefront-prvs: 0332AACBC3 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(136003)(39860400002)(346002)(396003)(376002)(366004)(189003)(199004)(478600001)(26005)(81166006)(4326008)(966005)(55016002)(8936002)(8676002)(2940100002)(9686003)(53546011)(71200400001)(86362001)(81156014)(7696005)(186003)(6506007)(316002)(66556008)(76116006)(54906003)(66446008)(66476007)(64756008)(33656002)(66946007)(2906002)(6916009)(52536014)(5660300002); DIR:OUT; SFP:1101; SCL:1; SRVR:DM6PR03MB5211; H:DM6PR03MB4777.namprd03.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: aMAiVByklEfG08Irc+WexKt0p4bjBOz9k9xY3idMj5PfWcr/dgjfdB0Y581cdx7ytpCbPJAI+5eZ5bjCxWRb6p0CvT291zqyiiyqtObv4TIFtIfkRtOcuGFsMD/fiXMMBA5x0t3UUUzmzIeiUM0q7/XElCzabzv6PFXwA2c9tCRaJy9AEruOKwGeauGzPP9bCl838rTPJHeOPO6m3s3PjtcUFjHpgK0ff6euqmhL2FIAvqDf6sIlsHsnPGnryw6mlc8TSsDQSMGgfCUGPsIIo9tXSLdmHQpYPbf4ro0aAA9c2R9N1J2XueFydOgQJXs+ocn0U9sEEtf56Ua3xtzhLHRnacE3L7LQchGpfHuFEM7Wsf+b4M9xQ254Z08MduOoA7r6jIY8BOQqUdY72kI5cpgI69KmMRDZ8NneaNfhyp1ik/u7KDfO2XDqgw2lMJkd0CJsR9HAvlEr1AbwaEPFv7fJryGtMQnCoqf3cGLQTNNd7bZ6dZYzs3JVLKm/Bt69DJ489u6/03itwFXT/gX9FQ== x-ms-exchange-antispam-messagedata: OY54/NwpATH6KHH5yFLIUetCIK/ZxaeeAhF6gFaup9HB81fw1VawAMpEHp/JWJiiEpjbpXJJgl/mxk4C3gxz725tZUT8MGxGcwfMp62KjYeyRt8TUxZOTFF814dFUe0jIoPmdqxEcqzzJFpzGvg+0A== x-ms-exchange-transport-forked: True x-mc-unique: J8DQNR8vNg2zRFUFfF1cfQ-1 x-originatororg: rbbn.com x-ms-exchange-crosstenant-network-message-id: a1979864-7191-4d2c-44c2-08d7c0823592 x-ms-exchange-crosstenant-originalarrivaltime: 04 Mar 2020 21:22:57.1285 (UTC) x-ms-exchange-crosstenant-fromentityheader: Hosted x-ms-exchange-crosstenant-id: 29a671dc-ed7e-4a54-b1e5-8da1eb495dc3 x-ms-exchange-crosstenant-mailboxtype: HOSTED x-ms-exchange-crosstenant-userprincipalname: fwM5bzNCA924u9pb1qHQ4M17RQrqPLWtpYFQlgJglicwXG5zjdJ+LtP/+4zf98aS x-ms-exchange-transport-crosstenantheadersstamped: DM6PR03MB5211 MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: rbbn.com Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] Issue with X550 link status X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Little more information. It looks like the below X550 nic is broken as the = change related to http://patches.dpdk.org/patch/63951/ is not been backport= ed. The below patch broken the link status for ixgbevf and the fix was done in = the above patch but we have only backported the below patch to 18.11.6 whic= h breaks the ixgbevf link status. When is plan for 18.11.7 or updated 18.11= .6 as we should not have a broken release. -- Regads, Souvik From: Dey, Souvik Sent: Wednesday, March 4, 2020 4:08 PM To: dev@dpdk.org Cc: xiaolong.ye@intel.com; xiao.zhang@intel.com; users@dpdk.org; Stephen He= mminger ; Ferruh Yigit Subject: RE: Issue with X550 link status The X550 NIC is of the below device id. [root@stdell10 ~]# lspci -nnn | grep -i ether 19:00.0 Ethernet controller [0200]: Intel Corporation Ethernet Controller 1= 0G X550T [8086:1563] (rev 01) 19:00.1 Ethernet controller [0200]: Intel Corporation Ethernet Controller 1= 0G X550T [8086:1563] (rev 01) 19:10.0 Ethernet controller [0200]: Intel Corporation X550 Virtual Function= [8086:1565] 19:10.1 Ethernet controller [0200]: Intel Corporation X550 Virtual Function= [8086:1565] 19:10.2 Ethernet controller [0200]: Intel Corporation X550 Virtual Function= [8086:1565] 19:10.3 Ethernet controller [0200]: Intel Corporation X550 Virtual Function= [8086:1565] So the mac_type is ixgbe_mac_X550_vf in the below case. -- Regards, Souvik From: Dey, Souvik Sent: Wednesday, March 4, 2020 1:17 PM To: dev@dpdk.org Cc: xiaolong.ye@intel.com; xiao.zhang@intel.c= om; users@dpdk.org Subject: Issue with X550 link status Hi All, After upgrading to DPDK 18.11.6 LTS release from 18.11.2 the = link_update call for link status update is not working for X550 NICs SR-IO= V enabled. On debugging it looks like the change introduced as a part of th= is patch is causing the issue. https://patches.dpdk.org/patch/62140/ @@ -4135,6 +4138,10 @@ ixgbe_dev_link_update_share(struct rte_eth_dev *dev= , return rte_eth_linkstatus_set(dev, &link); } + esdp_reg =3D IXGBE_READ_REG(hw, IXGBE_ESDP); + if ((esdp_reg & IXGBE_ESDP_SDP3)) + link_up =3D 0; + if (link_up =3D=3D 0) { if (ixgbe_get_media_type(hw) =3D=3D ixgbe_media_type_fiber) { intr->flags |=3D IXGBE_FLAG_NEED_LINK_CONFIG; I can see that the esdp_req is coming as 3735928495(0xDEADBEAF) and due to = which the link_up is set to 0 even when ixgbevf_check_link returned link_up= as 1. Along with this patch I also see a path_fullchk patch introduced , d= oes that play any role in this ? Can someone please let me know if the patch has got some issues or it is be= having correctly and the link_status is failing for valid reason. As mentio= ned earlier the same HW with same NIC acting in SR-IOV works fine with 18.1= 1.2 DPDK . I am blocked at a customer bug dew to this and any urgent help w= ill be much appreciated. -- Regards, Souvik ---------------------------------------------------------------------------= -------------------------------------------- Notice: This e-mail together with any attachments may contain information o= f Ribbon Communications Inc. that is confidential and/or proprietary for the sole use of the intended recipie= nt. Any review, disclosure, reliance or distribution by others or forwarding without express permission is strictly= prohibited. If you are not the intended recipient, please notify the sender immediately and then delete all copies,= including any attachments. ---------------------------------------------------------------------------= --------------------------------------------