From: "Dey, Souvik" <sodey@rbbn.com>
To: Jerin Jacob <jerinjacobk@gmail.com>
Cc: Rasesh Mody <rmody@marvell.com>,
Shahed Shaikh <shshaikh@marvell.com>,
Jerin Jacob Kollanukkaran <jerinj@marvell.com>,
"ferruh.yigit@intel.com" <ferruh.yigit@intel.com>,
"thomas@monjalon.net" <thomas@monjalon.net>,
"dev@dpdk.org" <dev@dpdk.org>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2] net/bnx2x: handle guest vlan for SR-IOV case
Date: Mon, 6 Apr 2020 12:59:34 -0400 [thread overview]
Message-ID: <DM6PR03MB4777F26F4F668EB4F9D37B14CDC20@DM6PR03MB4777.namprd03.prod.outlook.com> (raw)
In-Reply-To: <CALBAE1OcVrEf-1E1Att2P2y+jF=Nn1MmYAc_fZZvNzw+AytypQ@mail.gmail.com>
Just for reference also attached the changed patch in text format with the changes requested below. Have raised a v3 of the patch too.
Now bit ceckpatches and check-git-logs works fine and also updated vlan to VLAN.
--
Thanks,
Souvik
From: Jerin Jacob <jerinjacobk@gmail.com>
Sent: Sunday, April 5, 2020 9:06 AM
To: Dey, Souvik <sodey@rbbn.com>
Cc: Rasesh Mody <rmody@marvell.com>; Shahed Shaikh <shshaikh@marvell.com>; Jerin Jacob Kollanukkaran <jerinj@marvell.com>; ferruh.yigit@intel.com; thomas@monjalon.net; dev@dpdk.org; stable@dpdk.org
Subject: Re: [dpdk-dev] [PATCH v2] net/bnx2x: handle guest vlan for SR-IOV case
________________________________
NOTICE: This email was received from an EXTERNAL sender
________________________________
On Thu, Mar 5, 2020 at 7:21 PM Dey, Souvik <sodey@rbbn.com<mailto:sodey@rbbn.com>> wrote:
>
> Thanks will do that. And will also try to remove the trailer in the patches. Thanks for pointing it out.
>
> From: dev <dev-bounces@dpdk.org<mailto:dev-bounces@dpdk.org>> On Behalf Of Rasesh Mody
> Sent: Tuesday, March 3, 2020 6:01 PM
> To: Dey, Souvik <sodey@rbbn.com<mailto:sodey@rbbn.com>>; Shahed Shaikh <shshaikh@marvell.com<mailto:shshaikh@marvell.com>>; Jerin Jacob Kollanukkaran <jerinj@marvell.com<mailto:jerinj@marvell.com>>; ferruh.yigit@intel.com<mailto:ferruh.yigit@intel.com>; thomas@monjalon.net<mailto:thomas@monjalon.net>
> Cc: dev@dpdk.org<mailto:dev@dpdk.org>; stable@dpdk.org<mailto:stable@dpdk.org>
> Subject: Re: [dpdk-dev] [PATCH v2] net/bnx2x: handle guest vlan for SR-IOV case
1) Please change vlan to VLAN
2) Fix the following checkpatch issue. Probably move the new code to a
new function
to get enough space.
[master][dpdk-next-net-mrvl] $ ./devtools/checkpatches.sh
### net/bnx2x: handle guest VLAN for SR-IOV case
WARNING:BAD_SIGN_OFF: email address '"Dey Souvik" <sodey@rbbn.com<mailto:sodey@rbbn.com>>'
might be better as 'Dey Souvik <sodey@rbbn.com<mailto:sodey@rbbn.com>>'
#16:
Signed-off-by: "Dey Souvik" <sodey@rbbn.com<mailto:sodey@rbbn.com>>
WARNING:LONG_LINE_COMMENT: line over 80 characters
#27: FILE: drivers/net/bnx2x/bnx2x.c:2219:
+ /* when transmitting in a vf, start bd must
hold the ethertype
WARNING:LONG_LINE: line over 80 characters
#36: FILE: drivers/net/bnx2x/bnx2x.c:2225:
+ if (eh->ether_type ==
rte_cpu_to_be_16(RTE_ETHER_TYPE_VLAN)) {
WARNING:LONG_LINE: line over 80 characters
#41: FILE: drivers/net/bnx2x/bnx2x.c:2230:
+
ETH_TX_BD_FLAGS_VLAN_MODE_SHIFT);
WARNING:LONG_LINE: line over 80 characters
#47: FILE: drivers/net/bnx2x/bnx2x.c:2236:
+
(rte_be_to_cpu_16(eh->ether_type)));
WARNING:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal
patch author 'Dey, Souvik <sodey@rbbn.com<mailto:sodey@rbbn.com>>'
total: 0 errors, 6 warnings, 0 checks, 28 lines checked
0/1 valid patch
----------------------------------------------------------------------------
next prev parent reply other threads:[~2020-04-06 16:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-03 1:29 Dey, Souvik
2020-03-03 23:01 ` Rasesh Mody
2020-03-05 13:51 ` Dey, Souvik
2020-04-05 13:06 ` Jerin Jacob
2020-04-06 16:59 ` Dey, Souvik [this message]
2020-04-06 16:57 ` [dpdk-dev] [PATCH v3] net/bnx2x: handle guest VLAN " Dey, Souvik
-- strict thread matches above, loose matches on Subject: below --
2020-02-26 16:36 [dpdk-dev] [PATCH] bnx2x: handle guest vlan " Dey, Souvik
2020-02-28 18:28 ` [dpdk-dev] [PATCH v2] net/bnx2x: " Dey, Souvik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR03MB4777F26F4F668EB4F9D37B14CDC20@DM6PR03MB4777.namprd03.prod.outlook.com \
--to=sodey@rbbn.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jerinj@marvell.com \
--cc=jerinjacobk@gmail.com \
--cc=rmody@marvell.com \
--cc=shshaikh@marvell.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).