From: "Iremonger, Bernard" <bernard.iremonger@intel.com>
To: Dharmik Thakkar <dharmik.thakkar@arm.com>,
"Lu, Wenzhuo" <wenzhuo.lu@intel.com>,
"Wu, Jingjing" <jingjing.wu@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>, "nd@arm.com" <nd@arm.com>
Subject: Re: [dpdk-dev] [PATCH 1/5] app/testpmd: print clock with CPU cycles per pkt
Date: Thu, 7 May 2020 13:38:28 +0000 [thread overview]
Message-ID: <DM6PR11MB2537453123E67F8D8A1EBB9FEFA50@DM6PR11MB2537.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20200506215847.7628-1-dharmik.thakkar@arm.com>
Hi Dharmik,
> -----Original Message-----
> From: Dharmik Thakkar <dharmik.thakkar@arm.com>
> Sent: Wednesday, May 6, 2020 10:59 PM
> To: Lu, Wenzhuo <wenzhuo.lu@intel.com>; Wu, Jingjing
> <jingjing.wu@intel.com>; Iremonger, Bernard
> <bernard.iremonger@intel.com>
> Cc: dev@dpdk.org; nd@arm.com; Dharmik Thakkar
> <dharmik.thakkar@arm.com>
> Subject: [PATCH 1/5] app/testpmd: print clock with CPU cycles per pkt
>
> On aarch64 platforms, the cycles are counted using either a low-resolution
> generic counter or a high-resolution PMU cycle counter.
> Print the clock frequency along with CPU cycles/packet to identify which
> cycle counter is being used.
>
> Signed-off-by: Dharmik Thakkar <dharmik.thakkar@arm.com>
> Reviewed-by: Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
> Reviewed-by: Phil Yang <phil.yang@arm.com>
> ---
> app/test-pmd/testpmd.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index
> 99bacddbfdca..9a8cbbd6fc7c 100644
> --- a/app/test-pmd/testpmd.c
> +++ b/app/test-pmd/testpmd.c
> @@ -1953,11 +1953,12 @@ fwd_stats_display(void)
> "%s\n",
> acc_stats_border, acc_stats_border); #ifdef
> RTE_TEST_PMD_RECORD_CORE_CYCLES
> +#define CYC_PER_MHZ 1E6
> if (total_recv > 0)
> printf("\n CPU cycles/packet=%u (total cycles="
> - "%"PRIu64" / total RX packets=%"PRIu64")\n",
> + "%"PRIu64" / total RX packets=%"PRIu64") at %lu MHz
> Clock\n",
Better to use =%"PRIu64" instead of %lu in previous line
> (unsigned int)(fwd_cycles / total_recv),
> - fwd_cycles, total_recv);
> + fwd_cycles, total_recv, (uint64_t)(rte_get_tsc_hz() /
> +CYC_PER_MHZ));
> #endif
> }
>
> --
> 2.20.1
Better to fix checkpatch the following checkpatch warning:
WARNING:LONG_LINE: line over 80 characters
#77: FILE: app/test-pmd/testpmd.c:1961:
+ fwd_cycles, total_recv, (uint64_t)(rte_get_tsc_hz() / CYC_PER_MHZ));
Regards,
Bernard.
next prev parent reply other threads:[~2020-05-07 13:38 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200506215939eucas1p1fd98a671dda83adf884c30d7bf9b77c4@eucas1p1.samsung.com>
2020-05-06 21:58 ` Dharmik Thakkar
2020-05-06 21:58 ` [dpdk-dev] [PATCH 2/5] app/testpmd: print fractional part in CPU cycles Dharmik Thakkar
2020-05-07 9:50 ` Ananyev, Konstantin
2020-05-07 22:16 ` Dharmik Thakkar
2020-05-08 17:17 ` Ananyev, Konstantin
2020-05-08 17:36 ` Dharmik Thakkar
2020-05-08 18:08 ` Ananyev, Konstantin
2020-05-06 21:58 ` [dpdk-dev] [PATCH 3/5] doc: add cycles per packet in testpmd user guide Dharmik Thakkar
2020-05-07 5:24 ` Jerin Jacob
2020-05-07 22:27 ` Dharmik Thakkar
2020-05-07 14:30 ` Iremonger, Bernard
2020-05-06 21:58 ` [dpdk-dev] [PATCH 4/5] doc: include config options " Dharmik Thakkar
2020-05-07 14:42 ` Iremonger, Bernard
2020-05-06 21:58 ` [dpdk-dev] [PATCH 5/5] doc: add aarch64 generic counter section Dharmik Thakkar
2020-05-07 5:17 ` Jerin Jacob
2020-05-06 22:48 ` [dpdk-dev] [PATCH 1/5] app/testpmd: print clock with CPU cycles per pkt Lukasz Wojciechowski
2020-05-07 13:38 ` Iremonger, Bernard [this message]
2020-05-08 22:38 ` [dpdk-dev] [PATCH v2 " Dharmik Thakkar
2020-05-08 22:38 ` [dpdk-dev] [PATCH v2 2/5] app/testpmd: print fractional part in CPU cycles Dharmik Thakkar
2020-05-12 10:19 ` Iremonger, Bernard
2020-05-08 22:38 ` [dpdk-dev] [PATCH v2 3/5] doc: add cycles per packet in testpmd user guide Dharmik Thakkar
2020-05-12 10:20 ` Iremonger, Bernard
2020-05-15 12:15 ` Ferruh Yigit
2020-05-15 20:33 ` Dharmik Thakkar
2020-05-18 9:47 ` Ferruh Yigit
2020-05-18 21:49 ` Dharmik Thakkar
2020-05-19 8:27 ` Ferruh Yigit
2020-05-20 3:20 ` [dpdk-dev] [PATCH v3 1/2] " Dharmik Thakkar
2020-05-20 3:20 ` [dpdk-dev] [PATCH v3 2/2] doc: include config options " Dharmik Thakkar
2020-06-17 18:21 ` Ferruh Yigit
2020-06-17 19:48 ` Thomas Monjalon
2020-06-19 15:38 ` Dharmik Thakkar
2020-06-19 15:43 ` Thomas Monjalon
2020-06-19 16:13 ` Dharmik Thakkar
2020-06-22 15:26 ` Thomas Monjalon
2020-06-29 14:25 ` Dharmik Thakkar
2020-07-14 21:51 ` [dpdk-dev] [PATCH 0/6] app/testpmd: add runtime config Dharmik Thakkar
2020-07-14 21:51 ` [dpdk-dev] [PATCH 1/6] app/testpmd: add record-core-cycles " Dharmik Thakkar
2020-07-14 21:51 ` [dpdk-dev] [PATCH 2/6] doc: add record-core-cycles to testpmd funcs doc Dharmik Thakkar
2020-07-14 21:51 ` [dpdk-dev] [PATCH 3/6] app/testpmd: add record-burst-stats runtime config Dharmik Thakkar
2020-07-14 21:51 ` [dpdk-dev] [PATCH 4/6] doc: add record-burst-stats to testpmd funcs doc Dharmik Thakkar
2020-07-14 21:51 ` [dpdk-dev] [PATCH 5/6] app/testpmd: enable burst stats for noisy vnf mode Dharmik Thakkar
2020-07-14 21:51 ` [dpdk-dev] [PATCH 6/6] app/testpmd: enable empty polls in 5tswap Dharmik Thakkar
2020-07-15 4:29 ` Phil Yang
2020-08-26 16:33 ` [dpdk-dev] [PATCH 0/6] app/testpmd: add runtime config Ferruh Yigit
2020-08-26 16:41 ` Bruce Richardson
2020-08-26 17:07 ` Dharmik Thakkar
2020-08-26 22:06 ` Ferruh Yigit
2020-09-10 15:06 ` Ferruh Yigit
2020-08-26 21:24 ` Ferruh Yigit
2020-05-20 14:49 ` [dpdk-dev] [PATCH v3 1/2] doc: add cycles per packet in testpmd user guide Ferruh Yigit
2020-05-21 17:41 ` Ferruh Yigit
2020-05-08 22:38 ` [dpdk-dev] [PATCH v2 4/5] doc: include config options " Dharmik Thakkar
2020-05-12 10:20 ` Iremonger, Bernard
2020-05-19 7:42 ` Thomas Monjalon
2020-05-19 22:58 ` Dharmik Thakkar
2020-05-20 7:53 ` Thomas Monjalon
2020-05-20 22:39 ` Dharmik Thakkar
2020-05-19 7:45 ` Thomas Monjalon
2020-05-08 22:38 ` [dpdk-dev] [PATCH v2 5/5] doc: add aarch64 generic counter section Dharmik Thakkar
2020-05-12 10:18 ` [dpdk-dev] [PATCH v2 1/5] app/testpmd: print clock with CPU cycles per pkt Iremonger, Bernard
2020-05-15 12:23 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR11MB2537453123E67F8D8A1EBB9FEFA50@DM6PR11MB2537.namprd11.prod.outlook.com \
--to=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=dharmik.thakkar@arm.com \
--cc=jingjing.wu@intel.com \
--cc=nd@arm.com \
--cc=wenzhuo.lu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).