From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1A71FA034F; Wed, 13 May 2020 12:11:54 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 878EB1D16F; Wed, 13 May 2020 12:11:53 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id C8D9F1D162; Wed, 13 May 2020 12:11:51 +0200 (CEST) IronPort-SDR: 05GwYEDHnwqEYhkjvJzSv5EcEPMvcEqCxdvOqPE+rhYa2YnzfaBXKAKuSYqjZpnaaotpGRDcOA IDdyGtmxRNxw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 May 2020 03:11:50 -0700 IronPort-SDR: 1SUt2IFui5tKnbOQCgdvRl5H9bt6WzNOJD9U7phMsjt5OoB8GGB6GbhxQuRi5Ic7CfQlwhDfz0 B1fiCZ3+Y17g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,387,1583222400"; d="scan'208";a="253152400" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga008.fm.intel.com with ESMTP; 13 May 2020 03:11:50 -0700 Received: from fmsmsx158.amr.corp.intel.com (10.18.116.75) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 13 May 2020 03:11:50 -0700 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by fmsmsx158.amr.corp.intel.com (10.18.116.75) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 13 May 2020 03:11:50 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.102) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 13 May 2020 03:11:50 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=EebVm2dMIwVSs9AAwPL2EMe/HYxUtnmgL/0IDchj12t5Mh/1xwq3dgb4EL5ciWrQoM7Nrvj5Ji411NG6TzFU+ceoyaUF3NB8RnNc4RBuAX5LBrJ7i2FfCSjhF6+IPfs9sE6dHuBv03PnuQFK+JmEQ0kFYei1MqD/RkfXFHPMT+i/GfExDmgNxurH+tcJXNLdzBPfCZ30sAUH9Rqtgt/IDhgdyOObbgkPTz2EvlDn7/iRYJ9eeizUFj3n+EPyVD46dzmOgAYTh+DvoAfVElvn3DsWOxvwbqT32V4XcMUggbFfGbXLegg6Rp/I3ov8BbLqKiI9ODLXYaUlAl0GqS/mhg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ejt03wJieK/9+v0KVv2PDUiHQZWcp6D76GAer+CvP5Q=; b=aoX7CMmjsHoJZQ7xOIL7TsaAOrdXiWJga6K0iHi3KRuY86l/tr6rTc+vGQEs0ypX3K8ReqRhNsGJ/vfhFIS9GLKUPmWaOsYmuC91Ah5tV5oUCE0ANf3tao/0qChOmd3ZEgv7enBH7kFmjH7o7lxzoN8AmYOoP/RY/Rzu45ojpWx1dpym0aU2TJdt0/nHPPkxhFq5nENTKyKpv7bFYPkeaeEMtjHHx7IUuG6PM4OLBxRMR7zkf4RDQzEwDYGMyE8B3k+Fn+IT/X7+wwmvS3phIjoa7L9kHjj1EEir23j2rYF1lOJ2bEoSMGr04FH8/Smxri+fBvAfM8b+FtWRCxArqw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ejt03wJieK/9+v0KVv2PDUiHQZWcp6D76GAer+CvP5Q=; b=IRziGdEsBnft6PStGlaKt92KKQyU1Rtc4u0TpBURrJ60ewFPrE3k2NhPqI7DBtp36RNgJlX44qsTUT5AnhPU9SGENMc805UrCMc8gLCdT7VxyhEDRKYxBw4yB4iUc1G7IfkYQRsWzsl+jDhHe8SlXvFLBWqQeSlJoOWjdlpCwtM= Received: from DM6PR11MB2537.namprd11.prod.outlook.com (2603:10b6:5:cd::16) by DM6PR11MB2745.namprd11.prod.outlook.com (2603:10b6:5:c7::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2979.30; Wed, 13 May 2020 10:11:48 +0000 Received: from DM6PR11MB2537.namprd11.prod.outlook.com ([fe80::7c08:b4ae:e9c2:a4fa]) by DM6PR11MB2537.namprd11.prod.outlook.com ([fe80::7c08:b4ae:e9c2:a4fa%6]) with mapi id 15.20.2979.033; Wed, 13 May 2020 10:11:48 +0000 From: "Iremonger, Bernard" To: "Wang, ShougangX" , "dev@dpdk.org" CC: "Xing, Beilei" , "Guo, Jia" , "Wang, ShougangX" , "stable@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH v3] net/i40e: fix queue region issue in RSS flow Thread-Index: AQHWKNk6+Gb+/Rh9dUWv76L6OAday6ilyVCw Date: Wed, 13 May 2020 10:11:48 +0000 Message-ID: References: <20200424085225.27655-1-shougangx.wang@intel.com> <20200513033320.15771-1-shougangx.wang@intel.com> In-Reply-To: <20200513033320.15771-1-shougangx.wang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.151.165] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 925f3e65-fff1-4626-bf0f-08d7f7260c44 x-ms-traffictypediagnostic: DM6PR11MB2745: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1388; x-forefront-prvs: 0402872DA1 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: gFYxNHvdA9t9jHQvaDlGb0Qw3fhlJHtIfj/1Qde3ZRUv38eAnamuf0qbx4Y0yin47FTxJfNpSj8cwOyezOwvUsy9/kyMetGOPaBgImY6k5BeX3mh7fYcJ9J8yw2q+KtaEGx6pnm0XjozyM5CDnGg2eGQwmkPQwCaMuadKPeVbfZXtgeefoGg0pWVoxH0A0eazWmHq95hImnjmoMSEbmTpW+rOLXicCa45liZNMWQm+jZ71xcUGhiEaHaR2wNwcpuvdnkbphPVsTn2sp6Ojo00JgkZisvomgrhojIGIa8svwlMLd9SOP7jdvSu4ur+zbytqcUqSDbFFhUscQa8mceV5h03CoMsQAAyXq7lVVu/Ey/pzuOe+gFoZkHgwgTLtPqnwqulsZbslwLDt0y4N7gWmfrYziFj1WrJ0ywiuPQip79UdbkBIp00LZKpczlvjllaNkIqvf5LxrPuog4bvdDmCzFPfoM5LV1SEqpgQl0xinLyCrIhlxcjWaEacDG/P1ZYSyEdnJY8yxJ0eoCH0IPbg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB2537.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(39860400002)(366004)(346002)(396003)(136003)(376002)(33430700001)(6506007)(26005)(66476007)(8936002)(4326008)(71200400001)(64756008)(55016002)(8676002)(478600001)(66946007)(66556008)(66446008)(53546011)(7696005)(33656002)(186003)(9686003)(450100002)(5660300002)(54906003)(316002)(33440700001)(52536014)(110136005)(2906002)(76116006)(86362001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: J9UihNuj86brFgkn+geqfPc7Bevl/EodLNnrj805wnMD8LckeKFyZqRMhn/HmlRbycs5nmV0DviD3JIYrhmHbUU3VLVBqzXmiXN9+FJEOZme1EB3z88R28Qm6pWMVF46wClIGT0qW/rrgVHgpHUpUfLO2GGxJOjc3ft70T6n+Yu6Tc3b5fGDrQ/5MMsIl5G+9RUqLa3dzvyMxZLa+wc4LqdZMzI4Y8LF+AZ2kIq1AhF8rLch+jj+7jqt5KbC7dKMiciyAzs2HsCnpQH1RDftnidQhyv2JH8kSxx0xgpdG6N3Z00V4uozII1qIF2VqQamrkfqPbm8fuESnRefCAyyhq9nGmijPBEZpa4pcIzZy/QZGYc2JJRtJpUVTePj0hzX9QVoWyJ8NP09wJQ4qnEqzzHy2cU0dsuS1IN4JAwptqvTGx4NberAV8cYzJbEFejmdVOheso1CNw0MhxYFa7XkaThsGKFGYfqIJneFl14vvtAmrHrrfQk1yzM/0glbtO0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 925f3e65-fff1-4626-bf0f-08d7f7260c44 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 May 2020 10:11:48.1445 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: tnDZRZA9ytPKL+HBBaixE/7HrUp1ErpfET5CjjxvJAI+Ma/u85A0aeCIlnOq6qLJmwFhDXOE8B49aLErlTs4YYqh/G7Z6j8l16UQ2axP0Ws= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB2745 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v3] net/i40e: fix queue region issue in RSS flow X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Shougang, > -----Original Message----- > From: dev On Behalf Of Shougang Wang > Sent: Wednesday, May 13, 2020 4:33 AM > To: dev@dpdk.org > Cc: Xing, Beilei ; Guo, Jia ; W= ang, > ShougangX ; stable@dpdk.org > Subject: [dpdk-dev] [PATCH v3] net/i40e: fix queue region issue in RSS fl= ow >=20 > This patch fixes the issue that the queue region does not take effect due= to > incorrectly setting the flow type. >=20 > Fixes: ecad87d22383 ("net/i40e: move RSS to flow API") > Cc: stable@dpdk.org >=20 > Signed-off-by: Shougang Wang > Reviewed-by: Jeff Guo > --- > drivers/net/i40e/i40e_flow.c | 35 ++++++++++++++++++++++++++++++++- > -- > 1 file changed, 32 insertions(+), 3 deletions(-) >=20 > diff --git a/drivers/net/i40e/i40e_flow.c b/drivers/net/i40e/i40e_flow.c > index 7e64ae53a..2f937567b 100644 > --- a/drivers/net/i40e/i40e_flow.c > +++ b/drivers/net/i40e/i40e_flow.c > @@ -4625,6 +4625,34 @@ i40e_flow_parse_rss_action(struct rte_eth_dev > *dev, > uint32_t index =3D 0; > uint64_t hf_bit =3D 1; >=20 > + static const struct { > + uint64_t rss_type; > + enum i40e_filter_pctype pctype; > + } pctype_match_table[] =3D { > + {ETH_RSS_FRAG_IPV4, > + I40E_FILTER_PCTYPE_FRAG_IPV4}, > + {ETH_RSS_NONFRAG_IPV4_TCP, > + I40E_FILTER_PCTYPE_NONF_IPV4_TCP}, > + {ETH_RSS_NONFRAG_IPV4_UDP, > + I40E_FILTER_PCTYPE_NONF_IPV4_UDP}, > + {ETH_RSS_NONFRAG_IPV4_SCTP, > + I40E_FILTER_PCTYPE_NONF_IPV4_SCTP}, > + {ETH_RSS_NONFRAG_IPV4_OTHER, > + I40E_FILTER_PCTYPE_NONF_IPV4_OTHER}, > + {ETH_RSS_FRAG_IPV6, > + I40E_FILTER_PCTYPE_FRAG_IPV6}, > + {ETH_RSS_NONFRAG_IPV6_TCP, > + I40E_FILTER_PCTYPE_NONF_IPV6_TCP}, > + {ETH_RSS_NONFRAG_IPV6_UDP, > + I40E_FILTER_PCTYPE_NONF_IPV6_UDP}, > + {ETH_RSS_NONFRAG_IPV6_SCTP, > + I40E_FILTER_PCTYPE_NONF_IPV6_SCTP}, > + {ETH_RSS_NONFRAG_IPV6_OTHER, > + I40E_FILTER_PCTYPE_NONF_IPV6_OTHER}, > + {ETH_RSS_L2_PAYLOAD, > + I40E_FILTER_PCTYPE_L2_PAYLOAD}, > + }; I don't think this is a complete list of RSS offload types. See file librte_ethdev/rte_ethdev,h lines 496 to 523. See also app/test-pmd/config.c lines 77 to 121. > + > NEXT_ITEM_OF_ACTION(act, actions, index); > rss =3D act->conf; >=20 > @@ -4641,9 +4669,10 @@ i40e_flow_parse_rss_action(struct rte_eth_dev > *dev, > } >=20 > if (p_info.action_flag) { > - for (n =3D 0; n < 64; n++) { > - if (rss->types & (hf_bit << n)) { > - conf_info->region[0].hw_flowtype[0] =3D n; > + for (j =3D 0; j < RTE_DIM(pctype_match_table); j++) { > + if (rss->types & pctype_match_table[j].rss_type) { > + conf_info->region[0].hw_flowtype[0] =3D > + > (uint8_t)pctype_match_table[j].pctype; > conf_info->region[0].flowtype_num =3D 1; > conf_info->queue_region_number =3D 1; > break; > -- > 2.17.1 Regards, Bernard.