From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 48454A034F; Thu, 7 May 2020 15:22:02 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 915D41DC37; Thu, 7 May 2020 15:22:01 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 2699E1DBFA for ; Thu, 7 May 2020 15:21:58 +0200 (CEST) IronPort-SDR: gndYHuuDmJJb7Na2zp5YJr8YNcSSaaG78dSq3n7ccneA0xn2uc1m64myp6GTjvAdzINAGMAAHd NEisLhhYuB7w== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 May 2020 06:21:58 -0700 IronPort-SDR: 6QLO43yUd4p6FlztugOqT/5ZHAllKmfd+Y9eagRMWjJw4rgJiDAz6oWYj4m0NVceAoiT8rJMTy c2GHtNbL7yfA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,363,1583222400"; d="scan'208";a="435286277" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by orsmga005.jf.intel.com with ESMTP; 07 May 2020 06:21:57 -0700 Received: from fmsmsx153.amr.corp.intel.com (10.18.125.6) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 7 May 2020 06:21:57 -0700 Received: from FMSEDG002.ED.cps.intel.com (10.1.192.134) by FMSMSX153.amr.corp.intel.com (10.18.125.6) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 7 May 2020 06:21:57 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.170) by edgegateway.intel.com (192.55.55.69) with Microsoft SMTP Server (TLS) id 14.3.439.0; Thu, 7 May 2020 06:21:57 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=OweRw/BbyAxnqfAO11Iaig4RYHsihdcEvi4cv4PeyIDfmy+RtYGeKJMd6o7Z0bUnglby9LgstVSWPCXYCzRPx3s54gYuupbrB2IMgtbEexA5Xidku08S/5IJrKLdwBjukoNviq7q5C6Sr0FrSJtg0oNjo5h1QpQuEMZOwpgxw77R/5+dHIwZBsUPrChDjET/VyBSJzoqaLahxKrg0e8/KqPiOciswkZhYJD8jogPpSGaUU3sH4omoFqb7+fd+1kEUADgJrIa3WZOL+2MbDJXXTFMkIFUOBn2hz8oK9yf/bBMmuUAIIJEHQoMbAX3hhkhh/nOhMSO/7PeABDA8USvuQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9SqAhN7nNyBG0fG+dll/5AM/5S42xigFiW9kPTukosU=; b=QAIYdDVBYTu7/jUfdQQU/fffqfaGIizcVf8YWXSEQSjTUiuwkAyjM/isb0pOudRV0jmSR15xzhR8KFPO7X+9B1Ya1S41EUoUmuy4tkSn+b8901e8U+yYfFDWFUiqhE6aDIbDppkxe8gVgh/8oIQ5bY/zinyKaG7nyFvjg9mm6kndm1Pqz2KaglpQB3ouXPlTxexn1mmHFdNeoc4zWscSpzAgUBXmIp9olXNwnIo58u8tAQGz/V4iB8e4SZ7VrgfxokWDK7H6XKyTScgmO7Vg+tJ92WIQJ6sT4c7j2LpLIQSLKU51yVcpUgojkMey49A96cwb0z3kOnQD4GlBmgmnKA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9SqAhN7nNyBG0fG+dll/5AM/5S42xigFiW9kPTukosU=; b=X5G1plEXPqMUSjkwLzOB/bCf6LAnOMGX0eDk0Pg8JsUd080vmspVjYQBOabAirJlfMF9kLxGMRer3UWqkk8PTYE3m8TA3k2UngoCjI/+Z7lDhlaDZxkROcWgVEzVVLmezU6ZE2w7hV5DBQWub3Sqe+aI7yulvuggeiM9i+5IWWY= Received: from DM6PR11MB2537.namprd11.prod.outlook.com (2603:10b6:5:cd::16) by DM6PR11MB3563.namprd11.prod.outlook.com (2603:10b6:5:13e::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2958.29; Thu, 7 May 2020 13:21:55 +0000 Received: from DM6PR11MB2537.namprd11.prod.outlook.com ([fe80::7c08:b4ae:e9c2:a4fa]) by DM6PR11MB2537.namprd11.prod.outlook.com ([fe80::7c08:b4ae:e9c2:a4fa%6]) with mapi id 15.20.2958.034; Thu, 7 May 2020 13:21:55 +0000 From: "Iremonger, Bernard" To: Kalesh A P , "dev@dpdk.org" CC: "Yigit, Ferruh" , "Xing, Beilei" , "Wu, Jingjing" Thread-Topic: [dpdk-dev] [PATCH v2] app/testpmd: fix null pointer dereferencing issue Thread-Index: AQHWJF1iPjBex7EtEEq8ZQ8WPbnn0qicmwyw Date: Thu, 7 May 2020 13:21:55 +0000 Message-ID: References: <20200507090827.27945-1-kalesh-anakkur.purayil@broadcom.com> <20200507110611.30877-1-kalesh-anakkur.purayil@broadcom.com> In-Reply-To: <20200507110611.30877-1-kalesh-anakkur.purayil@broadcom.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.2.0.6 authentication-results: broadcom.com; dkim=none (message not signed) header.d=none;broadcom.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.151.188] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 856fcff7-064f-43a0-c8e8-08d7f2899cdf x-ms-traffictypediagnostic: DM6PR11MB3563: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:5236; x-forefront-prvs: 03965EFC76 x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: uzB5yHxwXpLnvNKs+5aW8PIgLAq69Je29rW/x9rFz/awuLJDhdX+hyokuRaYuCJN2n2QAZaugnmnc2EyI6K7CJLROaO9meVvwnvJ0gsu5fOWKC8rCeJzal4vR9rOKGgaXMRhv+xgP0XaEjgrJjfR6KwFj02mM49kSyU0F1rASZIc2MoWVZpzPSDCURNK5z5zmTUxw9Ei3nt6PAoVTDmlLx+STfk4iK3f34xN0hLTnoFKEr3A5wGb7UjPoxpBYrqnwmbNyVpGeIWGXK1Se/BCuVOQSd3XoRtlCOnvn7Nkf2BEz0ytGdhbE3f4EbrnL1ypW2Cyv+XSB5qQrO4CnhZXIw4twIrSr6nNpVN4tse51rcPY964vuCJ/33yPTPcH9QMNYVv5IMqDS1ycfhZEk0xeUB0UAINPymNy98fizwAXo2W47PwmB5k3UQrQlr7kmoUn+k8D+11m9fDZ75nfoLQK6Vxh6Fy8gplHKuBvWyYSxTaiqYs61Jhb1H2GQKhRO1dviZZMdEhAOf6gC+J4i6Nhw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB2537.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFTY:; SFS:(396003)(366004)(346002)(136003)(39860400002)(376002)(33430700001)(2906002)(66476007)(86362001)(52536014)(9686003)(83300400001)(55016002)(4326008)(71200400001)(83320400001)(83280400001)(83310400001)(83290400001)(5660300002)(478600001)(53546011)(64756008)(66446008)(33440700001)(76116006)(33656002)(26005)(107886003)(66556008)(110136005)(316002)(8936002)(66946007)(54906003)(186003)(8676002)(7696005)(6506007); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: cO49c5bHiALNJrnjWRbYr9kreZZER19SbdKzpecdrXqx24DFXp3N+8Zr4KcXSjfHFvVdGOOw+pVP7gs5aVVw0Vw3rS1A//h/HNjiCHYTqy38OlvZpKfAF/Jz4OQlHD0CMZxuRxPAiBJoD28Mt5pXtpu/JfgPB8LrPF/p0H17YxS96M+UBR3gHSFW7MEksfateI/JUdknx+x17y/aPU+xc7WcseGr/YaCvzm9wXhBNxkCSNwbOSqki7tyQ+tpx+ZvfFY8U4CUyOeGygn3TjwuyFvaPEbDEMzb1MZL9z9z/0SzmnpMgGD5Lc3DDt7i2hE1TqcuNQSKOD672pX4RBpzAZ/ZlQ3v0Afs6WYmxQUYd1M98djjJzrtJ6P4zxwv7oBRBv5gSVLTQjP+wJ2kPd/jtoBU5zQ/kZdZSOn9tv3RmFVUlrGZKpVXOfjGbkWWdysOgN4m93NDMSjTb4jMa+ClqZZfY+khL/KcyjFzgfpiHqauQa33CQt9cv3XKPElhe4vJMbJdQiXHYqysISTBcqLXzCFOBlJFJv+kGH+Z/iOvFLY4MXiw74tQXpWFiyiAycM0u0yi4MCCR6J/TByrHOgQ4VezENVhbaViFJ7Zu8mJnyOPLa8ZC5IS4eSSMN8jyg6nfqXwxhQldvt/vL6xmAIjRHPY0zBl+Pg5ZDfUsgJbas11xHubh2lxe/qfL05+K959QvWA0NYeT5POhJMyECxqH52lK2O41cdDcaAz2QYn5b/yKw+iVm9XmUm8iW7IoZr4StbgtV7LMsx4mp+xzmZ4iVTnGvgntVOjtIfCoucAq7f6xc7IMHDPd75QwRgH9or Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 856fcff7-064f-43a0-c8e8-08d7f2899cdf X-MS-Exchange-CrossTenant-originalarrivaltime: 07 May 2020 13:21:55.0878 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: ZmK9SNooSlmpOA4A1M3ZK9wwGZMfEXUugZcEFYwfu43TM16nsS6Uhh0kgoL+nPiVK/5PNml67efR5iDcKvzQdd9PR7PDvEWLIMXTFj0Ky9E= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3563 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2] app/testpmd: fix null pointer dereferencing issue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Kalesh, > -----Original Message----- > From: Kalesh A P > Sent: Thursday, May 7, 2020 12:06 PM > To: dev@dpdk.org > Cc: Yigit, Ferruh ; Xing, Beilei > ; Wu, Jingjing ; Iremonger, > Bernard > Subject: [dpdk-dev] [PATCH v2] app/testpmd: fix null pointer dereferencin= g > issue >=20 > From: Kalesh AP >=20 > Note that the issue was observed in an internal Coverity scan. >=20 > Fixes: e088907bb851 ("app/testpmd: add command for getting loaded DDP > profiles") > Cc: stable@dpdk.org >=20 > Signed-off-by: Kalesh AP > --- > v2: fixed headline case >=20 > app/test-pmd/cmdline.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) >=20 > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index > b040630..996a498 100644 > --- a/app/test-pmd/cmdline.c > +++ b/app/test-pmd/cmdline.c > @@ -16891,8 +16891,10 @@ cmd_ddp_get_list_parsed( #ifdef > RTE_LIBRTE_I40E_PMD > size =3D PROFILE_INFO_SIZE * MAX_PROFILE_NUM + 4; > p_list =3D (struct rte_pmd_i40e_profile_list *)malloc(size); > - if (!p_list) > + if (!p_list) { > printf("%s: Failed to malloc buffer\n", __func__); > + return; > + } >=20 > if (ret =3D=3D -ENOTSUP) > ret =3D rte_pmd_i40e_get_ddp_list(res->port_id, > -- > 2.10.1 ./devtools/check-git-log.sh=20 Missing 'Coverity issue:' tag: app/testpmd: fix null pointer dereferencing issue As there is no Coverity issue tag for this bug, then best not to mention Co= verity in the commit message. An explanation of the fix should be added to the commit message. How the bug was found is not relevant to the commit message. Otherwise Acked-by Bernard Iremonger