From: "Power, Ciara" <ciara.power@intel.com>
To: David Marchand <david.marchand@redhat.com>,
Thomas Monjalon <thomas@monjalon.net>
Cc: dev <dev@dpdk.org>,
"Richardson, Bruce" <bruce.richardson@intel.com>,
Matan Azrad <matan@nvidia.com>,
Shahaf Shuler <shahafs@nvidia.com>,
Viacheslav Ovsiienko <viacheslavo@nvidia.com>,
Ruifeng Wang <ruifeng.wang@arm.com>
Subject: Re: [dpdk-dev] [PATCH] doc: fix references to removed guide
Date: Thu, 1 Oct 2020 10:15:37 +0000 [thread overview]
Message-ID: <DM6PR11MB255531BD29E363D44BA8F759E6300@DM6PR11MB2555.namprd11.prod.outlook.com> (raw)
In-Reply-To: <CAJFAV8wUk9s0tWD5Kwctr+=ZU5kza6bkq_QKdpcRxQOL8EXEcw@mail.gmail.com>
>-----Original Message-----
>From: David Marchand <david.marchand@redhat.com>
>Sent: Wednesday 30 September 2020 20:08
>To: Thomas Monjalon <thomas@monjalon.net>
>Cc: dev <dev@dpdk.org>; Richardson, Bruce <bruce.richardson@intel.com>;
>Matan Azrad <matan@nvidia.com>; Shahaf Shuler <shahafs@nvidia.com>;
>Viacheslav Ovsiienko <viacheslavo@nvidia.com>; Power, Ciara
><ciara.power@intel.com>; Ruifeng Wang <ruifeng.wang@arm.com>
>Subject: Re: [PATCH] doc: fix references to removed guide
>
>On Wed, Sep 30, 2020 at 7:27 PM Thomas Monjalon
><thomas@monjalon.net> wrote:
>>
>> The page "Development Kit Build System" was about make, so it has been
>> removed. A better help is in the Linux guide
>> (note: mlx4/mlx5 are supported on Linux only for now).
>>
>> Fixes: 3cc6ecfdfe85 ("build: remove makefiles")
>>
>> Signed-off-by: Thomas Monjalon <thomas@monjalon.net>
>> ---
>> doc/guides/nics/mlx4.rst | 4 ++--
>> doc/guides/nics/mlx5.rst | 4 ++--
>> 2 files changed, 4 insertions(+), 4 deletions(-)
>>
>> diff --git a/doc/guides/nics/mlx4.rst b/doc/guides/nics/mlx4.rst index
>> 1f1e2f6c77..6818b6af51 100644
>> --- a/doc/guides/nics/mlx4.rst
>> +++ b/doc/guides/nics/mlx4.rst
>> @@ -335,8 +335,8 @@ Quick Start Guide
>>
>> service openibd restart
>>
>> -4. Compile DPDK and you are ready to go. See instructions on
>> - :ref:`Development Kit Build System <Development_Kit_Build_System>`
>> +4. Install DPDK and you are ready to go.
>> + See :doc:`compilation instructions <../linux_gsg/build_dpdk>`.
>>
>> Performance tuning
>> ------------------
>> diff --git a/doc/guides/nics/mlx5.rst b/doc/guides/nics/mlx5.rst index
>> 211c0c5a6c..b0614ae335 100644
>> --- a/doc/guides/nics/mlx5.rst
>> +++ b/doc/guides/nics/mlx5.rst
>> @@ -1247,8 +1247,8 @@ Quick Start Guide on OFED/EN
>>
>> echo [num_vfs] >
>> /sys/class/infiniband/mlx5_0/device/sriov_numvfs
>>
>> -6. Compile DPDK and you are ready to go. See instructions on
>> - :ref:`Development Kit Build System <Development_Kit_Build_System>`
>> +6. Install DPDK and you are ready to go.
>> + See :doc:`compilation instructions <../linux_gsg/build_dpdk>`.
>>
>> Enable switchdev mode
>> ---------------------
>> --
>> 2.28.0
>>
>
>Acked-by: David Marchand <david.marchand@redhat.com>
>
>
>--
>David Marchand
Acked-by: Ciara Power <ciara.power@intel.com>
Missed this in my doc changes for make removal, thanks.
Ciara
next prev parent reply other threads:[~2020-10-01 10:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-30 17:27 Thomas Monjalon
2020-09-30 19:07 ` David Marchand
2020-10-01 10:15 ` Power, Ciara [this message]
2020-10-01 14:41 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR11MB255531BD29E363D44BA8F759E6300@DM6PR11MB2555.namprd11.prod.outlook.com \
--to=ciara.power@intel.com \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=matan@nvidia.com \
--cc=ruifeng.wang@arm.com \
--cc=shahafs@nvidia.com \
--cc=thomas@monjalon.net \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).