Re: [dpdk-dev] [PATCH v5 17/20] doc: remove reference to make from tools guides

["Power, Ciara" <ciara.power@intel.com>]

>-----Original Message-----
>From: Power, Ciara <ciara.power@intel.com>
>Sent: Monday 21 September 2020 14:59
>To: dev@dpdk.org
>Cc: Power, Ciara <ciara.power@intel.com>; Mcnamara, John
><john.mcnamara@intel.com>; Kovacevic, Marko
><marko.kovacevic@intel.com>; Doherty, Declan <declan.doherty@intel.com>;
>Pattan, Reshma <reshma.pattan@intel.com>; Tahhan, Maryam
><maryam.tahhan@intel.com>; Chautru, Nicolas <nicolas.chautru@intel.com>;
>Jerin Jacob <jerinj@marvell.com>
>Subject: [PATCH v5 17/20] doc: remove reference to make from tools guides
>
>Make is no longer supported for compiling DPDK, references are now
>removed in the documentation.
>
>Signed-off-by: Ciara Power <ciara.power@intel.com>
>Reviewed-by: Kevin Laatz <kevin.laatz@intel.com>
>Acked-by: Nicolas Chautru <nicolas.chautru@intel.com>
>

<snip>

>diff --git a/doc/guides/tools/testbbdev.rst b/doc/guides/tools/testbbdev.rst
>index 393c3e9d0d..0f2b1cdde7 100644
>--- a/doc/guides/tools/testbbdev.rst
>+++ b/doc/guides/tools/testbbdev.rst
>@@ -13,25 +13,10 @@ parameters passed to a python running script.
> Compiling the Application
> -------------------------
>
>-**Step 1: PMD setting**
>+**Build the application**
>
>-The ``dpdk-test-bbdev`` tool depends on crypto device drivers PMD which -
>are disabled by default in the build configuration file ``common_base``.
>-The bbdevice drivers PMD which should be tested can be enabled by setting
>+See :doc:`../linux_gsg/build_dpdk` for compilation steps.
>
>-   ``CONFIG_RTE_LIBRTE_PMD_<name>=y``
>-
>-Setting example for (*baseband_turbo_sw*) PMD
>-
>-   ``CONFIG_RTE_LIBRTE_PMD_BBDEV_TURBO_SW=y``
>-
>-**Step 2: Build the application**
>-
>-Execute the ``dpdk-setup.sh`` script to build the DPDK library together with
>the -``dpdk-test-bbdev`` application.
>-
>-Initially, the user must select a DPDK target to choose the correct target type
>-and compiler options to use when building the libraries.
> The user must have all libraries, modules, updates and compilers installed  in
>the system prior to this, as described in the earlier chapters in this  Getting
>Started Guide.
>@@ -60,7 +45,7 @@ The following are the command-line options:
>
> ``-p TESTAPP_PATH, --testapp_path TESTAPP_PATH``
>  Indicates the path to the bbdev test app. If not specified path is set based
>- on *$RTE_SDK* environment variable concatenated with
>"*/build/app/testbbdev*".
>+ on "../.." concatenated with "*/build/app/dpdk-test-bbdev*".
>
> ``-e EAL_PARAMS, --eal_params EAL_PARAMS``
>  Specifies EAL arguments which are passed to the test app. For more details,
>@@ -82,9 +67,8 @@ The following are the command-line options:
>
> ``-v TEST_VECTOR [TEST_VECTOR ...], --test_vector TEST_VECTOR
>[TEST_VECTOR ...]``
>  Specifies paths to the test vector files. If not specified path is set based
>- on *$RTE_SDK* environment variable concatenated with
>- "*/app/test-bbdev/test_vectors/bbdev_null.data*" and indicates default
>- data file.
>+ on "../.." concatenated with "*/app/test-
>bbdev/test_vectors/bbdev_null.data*"
>+and indicates default data file.

I missed an indent here, there should be a space before "and" at the start of the line I think.

- Ciara

>
>  **Example usage:**
>
>@@ -259,8 +243,8 @@ They are chosen to have a good coverage across sizes
>and processing  parameters while still keeping their number limited as part
>of sanity  regression.

<snip>