From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2E498A04CC; Mon, 21 Sep 2020 12:16:59 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C923D1D716; Mon, 21 Sep 2020 12:16:57 +0200 (CEST) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 4ECB41D711 for ; Mon, 21 Sep 2020 12:16:55 +0200 (CEST) IronPort-SDR: +d2UqJttK7elKtqaO2zSFnN/B2yZ/UrDRKSg/h/i7Qwnl98vN9glNlkkMSF+vCZKyvlTLQXZ5I /cjxOwuGvDMQ== X-IronPort-AV: E=McAfee;i="6000,8403,9750"; a="224487314" X-IronPort-AV: E=Sophos;i="5.77,286,1596524400"; d="scan'208";a="224487314" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Sep 2020 03:16:53 -0700 IronPort-SDR: itQLvRCD+5cD3CzUJEukjXQVuDe+0AbqVJ3i9OVNDfJtkVM5r7dI5T3iRGx9QzmBsPn9X20461 kbNMG9v2g8yQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,286,1596524400"; d="scan'208";a="341493045" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga002.fm.intel.com with ESMTP; 21 Sep 2020 03:16:53 -0700 Received: from orsmsx601.amr.corp.intel.com (10.22.229.14) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 21 Sep 2020 03:16:53 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Mon, 21 Sep 2020 03:16:53 -0700 Received: from NAM11-BN8-obe.outbound.protection.outlook.com (104.47.58.175) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Mon, 21 Sep 2020 03:16:51 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=HhVfvKpRcLlk5Qqqmx/E4mlDQqdBWX+sSA90kE6TWs77gWrauszNzUcQBM5Q6KXNjjQUWdk3DjYli0SQJZHustnpSaBXu8t6SnzzXkaJ/z/93zN0hytoYVk6P0iQmT5ac020Yd5g6XclnlPsiNKgN8tifpIbOcMf2cCjxWew5jLwW3QTlNAa+vSSJPsQIV0O/a+wFSHY2r7QVUACMDWp0RTSkH7K9NcGdc6V5YTjLTiVDAMq+hs2DNxZDFvgI7n5+8NtDFEMG2Jm3YIelJawDqkpIASIJQvOEV1hTK3w1Ba4XlLpyKylIj3g8pNBwkYfLny0Zj3V/60XQlZPIU9z+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4EmfzZhurTfpwoqDKQ9+Gj+F/esA/NX6TjmvrNYNBg0=; b=VRHVs/+m5TY/345CZKaGsIjb/b+++rj/tYOvXUgfZj599ild2vVr6Lb+k+olcYDkuBf2Y0R4QqX+9Rx9Mj7fYSItr/vYui0mZamBmtUB/hx+Nw8b12OMWZlfrmjXpFlT55eAf/coxwbrWVE9guvYV/lDBDoBjrFyQ0i6KFk2b/7X/MZ4vmE3O2O0bKZz7voM4JaKjixURZ93ELZwxkby5wxvoIWNKpLUWFzKQjbsEVXR9cVQbZicKnJi2rmAUL9y6LD5XZlh5aDCzg2+JcYy68ZrKn8hkRRJLweoDeZqPzlsNrCNBwnv3NpQYEda0zQ8BO55GsTTpAOnImvtBNEqgA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4EmfzZhurTfpwoqDKQ9+Gj+F/esA/NX6TjmvrNYNBg0=; b=n6BEriStbIdGKFTeyWLBzxBl3SK8jxuTS6Cj8XoZSBz2oNPpnhgYRjy6/xvZayxNhxF/waG/I4Eef7Vl85Ii2M9PaTDsIjdwK+n70YO+ACo1ApfFU0TvrxX4uewyHDCempUN0DLyIVLF73VR8QHyr5ps3c+kEij3hReyo/3oSn4= Received: from DM6PR11MB2555.namprd11.prod.outlook.com (2603:10b6:5:c5::33) by DM6PR11MB4395.namprd11.prod.outlook.com (2603:10b6:5:1de::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.19; Mon, 21 Sep 2020 10:16:49 +0000 Received: from DM6PR11MB2555.namprd11.prod.outlook.com ([fe80::59db:260c:93d9:2439]) by DM6PR11MB2555.namprd11.prod.outlook.com ([fe80::59db:260c:93d9:2439%5]) with mapi id 15.20.3391.019; Mon, 21 Sep 2020 10:16:49 +0000 From: "Power, Ciara" To: "Chen, Mike Ximing" , Jerin Jacob CC: "dev@dpdk.org" , "Eads, Gage" , "Vedantham, Sundar" , "Richardson, Bruce" Thread-Topic: [PATCH v3] eventdev: support telemetry with xstats info Thread-Index: AQHWjeKqnuodEXrlxE2npiIr3IM8PKly5AQQ Date: Mon, 21 Sep 2020 10:16:49 +0000 Message-ID: References: <20200909205447.29398-1-mike.ximing.chen@intel.com> <20200918173922.25495-1-mike.ximing.chen@intel.com> In-Reply-To: <20200918173922.25495-1-mike.ximing.chen@intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [37.228.239.233] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 0b84da78-de89-44b1-b6e3-08d85e1773bf x-ms-traffictypediagnostic: DM6PR11MB4395: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1303; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: UhwKFDZ6dWShSISPwDG8eFQnFitQEnxZtbso/vipia9IDPEHLV1vXFFiY2n6K+G+hd6QX62ZChzQ+4Xex6gd83YVaYa6wf/t5aFCOg7gOK/vYiqogP+8l1g108Ra3OcbJrvQhIU4VDLRYKRbDad+J3EoQf4W95aM1zDa8t/KsYgytNiccKbnt0lX4bN3oqFoTWcZXsxeoT7W+wLQxqOuy0TGysHj/8VrPg6I4ztpJH2J/Mr5kDo+pu4yW9oR5qGguXWAF3rmPz4utr9gOJfrR5iEvO+pjqFNYo3KcCV/+6d34TySKl7EEJ7Jd0h+vPtWMxz7DZl9o1Jk/U4/f7qFVg== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB2555.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(39860400002)(346002)(366004)(396003)(376002)(52536014)(66556008)(66476007)(107886003)(64756008)(33656002)(4326008)(66446008)(71200400001)(86362001)(5660300002)(66946007)(2906002)(76116006)(9686003)(186003)(8676002)(7696005)(110136005)(55016002)(478600001)(54906003)(6506007)(26005)(83380400001)(8936002)(316002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: QMYzbjAB1B/lhV2AdzFBvuXkGRXUbQQNbNWALGfSBIkQlcdQTj/2Gn2lF74BSbVMNaGV2U3j03QVTZWgTr6inoNef3xafkr0ioaRgv6qgJ6BEKw5xFTh1WfnPY+8SQmTzNPUYsME5ukdpP90WJdwcl+PYhO6v/x4stt4o+dUpPb1OjOBBcZMMCqbqZLiqfXhXbgjlxfD6nORar5s0CeKzBR0/OR1VfltSPMryeqUyJ6ECzf+8LvL00ziAk8JZNPPw3nGZM2fGH3TvZmCcoWIh3GSNr0PnCefw6yQfIW3V9PxL149xH8bqUx6qqMm1qyj3D9Ou6kB9gLkd/eHlhkcJCon5iU8QRlLGaV/nlXvFbr/fqt82OBVaeFGECKouCPjLQibO3mhkJKEFyS2TuBqdNf3dWqTk0BhvO2X2+pPn6cdPMVqaCEDHbAUOF1QMl+gplF4M6ccmFrKDIylLZeAGRn07eSxmBTWhjmGZqAsjhZ5WCZU66QEDkVek7xt52PCYdO3vQGJx32Ju4gtvHP9jpKKBgq+ataQWfjpGGTDS0L9J2Qvj0rKQqy0vaC9Xx7buNcH9ihIoNTgfmDUwT4gAowqHuRherT7XlKf7Sv//fuA/gtLmjPmGJE4W/8Kf1LbE5RKPBRTpE6ByN6+l69lWQ== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB2555.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 0b84da78-de89-44b1-b6e3-08d85e1773bf X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Sep 2020 10:16:49.1128 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: gPP97WF9ilPitbcVGwZqo2q2UR3eL975yqtm5HSkaWJ+xvzjyIo1DDeWNvLIpMJqTC83QC1lw6cOwVtSx/OgfA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4395 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v3] eventdev: support telemetry with xstats info X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" >-----Original Message----- >From: Chen, Mike Ximing >Sent: Friday 18 September 2020 18:39 >To: Jerin Jacob >Cc: dev@dpdk.org; Eads, Gage ; Vedantham, Sundar >; Power, Ciara ; >Richardson, Bruce >Subject: [PATCH v3] eventdev: support telemetry with xstats info > >The telemetry library is connected with eventdev xstats and port link info= . The >following new telemetry commands are added: > >/eventdev/dev_list >/eventdev/port_list,DevID >/eventdev/queue_list,DevID >/eventdev/dev_xstats,DevID >/eventdev/port_xstats,DevID,PortID >/eventdev/queue_xstats,DevID,PortID >/eventdev/queue_links,DevID,PortID > >queue_links command displays a list of queues linked with a specified >eventdev port and a service priority associated with each link. > >Signed-off-by: Mike Ximing Chen >--- >Depends-on: patch-76075 ("lib/telemetry: fix passing full params string to >command") >--- >v2: >* Fixed an issue with p_param in handles. > >v3: >* No code change. >* Add --in-reply-to v1 patch. >--- > lib/librte_eventdev/meson.build | 1 + > lib/librte_eventdev/rte_eventdev.c | 304 +++++++++++++++++++++++++++++ > 2 files changed, 305 insertions(+) > >+static int >+handle_queue_links(const char *cmd __rte_unused, >+ const char *params, >+ struct rte_tel_data *d) >+{ >+ int i, ret, port_id =3D 0; >+ char *end_param; >+ uint8_t dev_id; >+ uint8_t queues[RTE_EVENT_MAX_QUEUES_PER_DEV]; >+ uint8_t priorities[RTE_EVENT_MAX_QUEUES_PER_DEV]; >+ const char *p_param; >+ >+ if (params =3D=3D NULL || strlen(params) =3D=3D 0 || !isdigit(*params)) >+ return -1; >+ >+ /* Get dev ID from parameter string */ >+ dev_id =3D strtoul(params, &end_param, 10); >+ RTE_EVENTDEV_VALID_DEVID_OR_ERR_RET(dev_id, -EINVAL); >+ >+ p_param =3D strtok(end_param, ","); >+ if (p_param =3D=3D NULL || strlen(p_param) =3D=3D 0 || !isdigit(*p_param= )) >+ return -1; >+ >+ port_id =3D strtoul(p_param, &end_param, 10); >+ p_param =3D strtok(NULL, "\0"); >+ if (p_param !=3D NULL) >+ RTE_EDEV_LOG_DEBUG( >+ "Extra parameters passed to eventdev telemetry >command, ignoring"); >+ This fix avoids the seg fault I previously mentioned, looks fine to me. Reviewed-by: Ciara Power