From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (xvm-189-124.dc0.ghst.net [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6611FA0A01; Mon, 4 Jan 2021 11:04:29 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E69D41606DB; Mon, 4 Jan 2021 11:04:28 +0100 (CET) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id 59E731606D8 for ; Mon, 4 Jan 2021 11:04:25 +0100 (CET) IronPort-SDR: keSkEcmBS995+gSn0GqHStNrU8a9cBqD9gJrcAvSfACN12wEUnujd5BRnkLnlkOfmbYUFKNkEC H+bSmMprxI9A== X-IronPort-AV: E=McAfee;i="6000,8403,9853"; a="174357065" X-IronPort-AV: E=Sophos;i="5.78,473,1599548400"; d="scan'208";a="174357065" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 04 Jan 2021 02:04:24 -0800 IronPort-SDR: 87sETQwlf7G/O7anlbe5FigVDC8pPgoxGs49tiWIXMQfev3TW1jBIZaOtefzAhIpPqG6Q143BD ZeolrQlvqSfA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.78,473,1599548400"; d="scan'208";a="378359301" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by orsmga008.jf.intel.com with ESMTP; 04 Jan 2021 02:04:24 -0800 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 4 Jan 2021 02:04:24 -0800 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Mon, 4 Jan 2021 02:04:23 -0800 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Mon, 4 Jan 2021 02:04:23 -0800 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.102) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Mon, 4 Jan 2021 02:04:21 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=k9kTtgtRsflTFYacAyNDKnrSVGZRmDXLj5HYDdnbzEayJVEQcZ9JYv+KOl6B2RKMyFEqZfuFXON0a58BYDr+1BAFSF7TjqNRf3S6PYogOK+ReAzP0na5l9TrI6YuKjxZPSPIQVGWwgkSNSzhgaI3VgeBBj8RO4mpNQe1HXJiJtU+su1oVX5wy6cfh2lAcLTaKeIMVtz8/k9AvNahg9rxbr/4tsQ5NUjiXD66vqE4olWsSThzwg7vf8tOhsfEye1tD+oL0jpEghJZloH+LZxt1G8rdRJ18fSfPI1JGrY0ggLKR380zRAtKyDpaBxKwHfC1+mXBuZa54M0RKacON13NA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=S4xtD+AUfSJfzioY0AuQhjEEgDIhd02FXmTp5d/ZU1A=; b=mbmJwYeMoO8xVT5GAq23fyQXa7y8vEBDfiGU+Awi2eXnlRnq2f7XdWIfsAwGxdbcJa1rybU+NGlPDp+JEYarHMfbeeIzZz/58vnrNYvJ400zJYTO4bDYVRq/dNqOWrY+5XOCOVEx/OjzPacsnTJtsNDAJfooTuQLghNpz6vgaFPd/X0lpc2fzQZCtLWN3FCE6GIY/accCdUfJlx/QOTO5ApZBMeV9tZ6naLTi0dmWv89Er8ekH2Z/iRELPkZ+EJvPVBu8pynyD4R2aNuLnawKt+PkIbHcMcsD0J6cvux63aUbKxzq9bd4GDwkwVKogA/3pRZdbXP+FImYixoMBRzxQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=S4xtD+AUfSJfzioY0AuQhjEEgDIhd02FXmTp5d/ZU1A=; b=ZZ17EZEFmWTwMnC4aYvSFyB43xkZZaG9ECQqLR8R/I4JnPexsEaLoIInrIbzmTv7xr9ImnvTDMd3NOQPHMgX25NOaoG681WIu95FC2RIZncCzr9nce9zxdhQYiaE6zp+dPR+0q6xzIsHfF2kMgkWr7TClSC5FfP0YtyT1dLQx+M= Received: from DM6PR11MB2555.namprd11.prod.outlook.com (2603:10b6:5:c5::33) by DM5PR1101MB2297.namprd11.prod.outlook.com (2603:10b6:4:54::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3721.19; Mon, 4 Jan 2021 10:04:16 +0000 Received: from DM6PR11MB2555.namprd11.prod.outlook.com ([fe80::10e1:1783:a953:6c2f]) by DM6PR11MB2555.namprd11.prod.outlook.com ([fe80::10e1:1783:a953:6c2f%7]) with mapi id 15.20.3721.024; Mon, 4 Jan 2021 10:04:16 +0000 From: "Amber, Kumar" To: "Zhang, Qi Z" , "dev@dpdk.org" CC: "Zhao1, Wei" Thread-Topic: [dpdk-dev] [PATCH v4] net/i40e: fix argument in RSS action Thread-Index: AQHWuOFqoXRfVqQZlkWLQxea1nxFv6oFroKAgBHhBqA= Date: Mon, 4 Jan 2021 10:04:16 +0000 Message-ID: References: <20201111101031.52758-1-kumar.amber@intel.com> <20201112104245.91324-1-kumar.amber@intel.com> <14f80db083464cb7adcbd2d8bcfccede@intel.com> In-Reply-To: <14f80db083464cb7adcbd2d8bcfccede@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [157.42.25.37] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: dca50a56-4c26-45b5-90d0-08d8b09818ae x-ms-traffictypediagnostic: DM5PR1101MB2297: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2733; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: M4tuTOOgct4N8ZPiq/AUt3yO78KETAfS8//fSQfRuI4nDBo4/B5Wmf+P5xD33FGcOamBP7ombkzNd1ly990gFcXFxrCZwjvUMVUd6yy5SkoEaQKHTueG0JP/XBw7NblrzzDJdvkkwVgw7Upjn6A8Q+dwmg9vMtk0vx2RW3EI47Z7FNmtYh8qB5ccdfDDbAKcpYdCx9+vLUCIPlfg1xf2D20mFopkxQehfQnER58mr4ZTg1jpp2G1GceD9ZudMR3Qe4PbWwSJei2DbmS3ipmHoTzqcZIKW73N5BqsLKoe86rHORp8ztnEpVfCRToPH9sB9fWjMZKSl1dQifOjq9ao8jkUOQKYHewE4frpiDEnBjJy27H3qAFXIlWTlybf7bZR1Z8dazheEWD4YnAg1XyG6A== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB2555.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(396003)(376002)(346002)(39860400002)(366004)(55016002)(8936002)(26005)(4326008)(9686003)(186003)(478600001)(53546011)(33656002)(6506007)(7696005)(110136005)(316002)(83380400001)(86362001)(71200400001)(8676002)(107886003)(52536014)(76116006)(2906002)(66946007)(66476007)(66556008)(5660300002)(64756008)(66446008); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?m7lMTmW+wOI4JuvjJxO30SWA3d7U5LzKhVMFXaXJxNEu+kTeU8fEJaXAjcdJ?= =?us-ascii?Q?JLWNJVVmpTDWLphlNS/ZL7nvz886gFu5dZGIrYbi3YP8jCGgcTvQfXL1k5NG?= =?us-ascii?Q?nBW8XJehW8BtotJX8auobn6Ze8+xgwasFBs9EcL0v+y9TMLwh4QlIClWfnTs?= =?us-ascii?Q?3aSWjG7YXCVeaPNk4xZpZ8EEbWyhIbwOF6g9/uqJsA6h5vIIud1kJKXySCx9?= =?us-ascii?Q?xTdxAtrAicBJvEoSLwv6pM7AiVGso699ofOxBq+R2/CmE8+nDYpaK2wbjo16?= =?us-ascii?Q?RNUlRc/a0J2mAjLSgRlSZgXwmyc5IM7UrdKJpyf83Hp/IhsTss+AHOm7dRlL?= =?us-ascii?Q?bXs3Z2X6VzNFu5vL3/maV6/EbjHiFSGp1QDQvDpgj39w3MpHNavjOV365CzE?= =?us-ascii?Q?J/V0NDg3QY33ijrfImt0dmnonFPtUY57kM5Vif0xwGHeGJQiQy/GSa8vq4QN?= =?us-ascii?Q?hVNBbW6RCWlgrlkzYQ2xNfqJnYbwZiN3yMcQZWQDULBwgXqR9zEIjhNhYPeP?= =?us-ascii?Q?uqzTGU05CTi62casnlfVObGIChm82NSzV4FGPkuOG/gHae+OA2igy0OwPHpl?= =?us-ascii?Q?YpT5NlCvBplVETwmbdnAeSOL9N8uaQmZBvHPCcLo1TNeVU0X3SNJ6sxYhLD4?= =?us-ascii?Q?g23HyoZULWaCLQt0Mkk6Pd+kr+oE4HE33fq9rJY1QLxy99caWbGW+nMIKeLb?= =?us-ascii?Q?97pVfdeQ0kqeOTaAXThL3hb62NKwbeqR8gm1hAJKFerdts88nu8Rd80/eQo+?= =?us-ascii?Q?VIK/epKz3+mGxJiE7B8P87/NIMtPzLYESxEZHwycj++kme6E3B7/PztT95OV?= =?us-ascii?Q?2JIIRGt2QLBs0CqD+jbPLpKbcHWCseTTZeEG0fpHZqJ4fWUWtz9KXWJKJnK0?= =?us-ascii?Q?62aKx5liAnnRcp5khliSRU7zuMQsmccTuOyPwSCkzxMFfCOU1oqfG7JQv19M?= =?us-ascii?Q?IXDihLIDdzrVl+IAkWP5md2kQszOdbltrDk3IAM0Onw=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB2555.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: dca50a56-4c26-45b5-90d0-08d8b09818ae X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Jan 2021 10:04:16.7976 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: HEJnX2X3c7ToxUUlVAvNYt7yTk/RNpvXXXLvCuLoNoCn1gYIsl+s8c1yoDpyehJhAyMXsB61SRmXoDzGZ511lQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR1101MB2297 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v4] net/i40e: fix argument in RSS action X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Zhang , With the current understanding we agree we don't actually need to fix . Will abandon the patch and close the issue . Regards Amber=20 -----Original Message----- From: Zhang, Qi Z =20 Sent: Thursday, December 24, 2020 6:30 AM To: Amber, Kumar ; dev@dpdk.org Cc: Zhao1, Wei Subject: RE: [dpdk-dev] [PATCH v4] net/i40e: fix argument in RSS action > -----Original Message----- > From: dev On Behalf Of Kumar Amber > Sent: Thursday, November 12, 2020 6:43 PM > To: dev@dpdk.org > Cc: Zhao1, Wei > Subject: [dpdk-dev] [PATCH v4] net/i40e: fix argument in RSS action >=20 > The driver must check for the queue number in the RSS action list and=20 > if not should return with a proper error message to user. >=20 > Bugzilla ID: 573 > Fixes: 9486d60b94b5 ("net/i40e: fix flow RSS queue index check") > Cc: wei.zhao1@intel.com >=20 > Signed-off-by: Kumar Amber > --- > drivers/net/i40e/i40e_flow.c | 12 ++++++++++++ > 1 file changed, 12 insertions(+) >=20 > diff --git a/drivers/net/i40e/i40e_flow.c=20 > b/drivers/net/i40e/i40e_flow.c index > 5bec0c7a84..397ed0ae77 100644 > --- a/drivers/net/i40e/i40e_flow.c > +++ b/drivers/net/i40e/i40e_flow.c > @@ -4917,6 +4917,18 @@ i40e_flow_parse_rss_action(struct rte_eth_dev=20 > *dev, NEXT_ITEM_OF_ACTION(act, actions, index); rss =3D act->conf; >=20 > +/** > + * Check if Queue number is specified > + * in argument else throw an error. > + */ > +if (!rss->queue || !rss->queue_num) { rte_flow_error_set(error,=20 > +EINVAL, RTE_FLOW_ERROR_TYPE_ACTION, act, > + "no valid queues"); > +return -rte_errno; > +} I'm not sure if this is the right solution, the case we may have is: apply = a RSS for a specific pattern for all enabled queues, so an empty queue conf= igure that implicit for all enabled queues could still be acceptable. Can y= ou share what kind of expected failure you are looking for? > + > /** > * RSS only supports forwarding, > * check if the first not void action is RSS. > -- > 2.17.1