DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Power, Ciara" <ciara.power@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: "Laatz, Kevin" <kevin.laatz@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>,
	"Richardson, Bruce" <bruce.richardson@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2] doc: add more detail to telemetry guides
Date: Fri, 24 Jul 2020 11:32:59 +0000	[thread overview]
Message-ID: <DM6PR11MB2555B031153A99FCE1C08BDBE6770@DM6PR11MB2555.namprd11.prod.outlook.com> (raw)
In-Reply-To: <1763279.BZtJzAqO4x@thomas>

Hi Thomas,

Thanks for the review.
I have addressed your comments in the v3 patch, with one exception mentioned below.


<snip>

>[...]
>> +   * List all commands.
>> +
>> +      .. code-block:: console
>
>I think you can achieve the same result as code-block with adding double
>colons (::) at the end of the previous line:
>	* List all commands::
>

I have added this in the v3 for all console code-blocks.
I left the C code-blocks as they were to ensure C syntax highlighting is maintained.

<snip>


Thanks,
Ciara

  reply	other threads:[~2020-07-24 11:33 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-21 16:09 Ciara Power
2020-07-21 17:38 ` Bruce Richardson
2020-07-22 17:27 ` Thomas Monjalon
2020-07-24 11:32   ` Power, Ciara [this message]
2020-07-24 11:20 ` [dpdk-dev] [PATCH v3] " Ciara Power
2020-07-24 11:45   ` Power, Ciara
2020-07-30 18:28   ` Thomas Monjalon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM6PR11MB2555B031153A99FCE1C08BDBE6770@DM6PR11MB2555.namprd11.prod.outlook.com \
    --to=ciara.power@intel.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=kevin.laatz@intel.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).