From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C1CA7A04E1; Tue, 22 Sep 2020 12:28:25 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A86AD1DB4C; Tue, 22 Sep 2020 12:28:25 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 7042A1DB48; Tue, 22 Sep 2020 12:28:24 +0200 (CEST) IronPort-SDR: rBvfigBb/9Ce400/BiIGZ2I7eO22sFrodLx+6u88Zg8Hang8lQvliHb6pJXmbB+djcnhvlja8G T4oU/rK696AQ== X-IronPort-AV: E=McAfee;i="6000,8403,9751"; a="148237799" X-IronPort-AV: E=Sophos;i="5.77,290,1596524400"; d="scan'208";a="148237799" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Sep 2020 03:28:23 -0700 IronPort-SDR: RePS+INFzz9JnrtWDSigjhzHFW2IGQc13i2scSg1FslE/g6aK1FxrdHHR1PZhxOGmwy3WTkN31 Hg+BZbDTaztw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,290,1596524400"; d="scan'208";a="412616295" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by fmsmga001.fm.intel.com with ESMTP; 22 Sep 2020 03:28:23 -0700 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 22 Sep 2020 03:28:22 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 22 Sep 2020 03:28:22 -0700 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (104.47.36.55) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Tue, 22 Sep 2020 03:28:21 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=bNsPxEvxvME0yKx3ns4H7FbY0CYfzQGXsNSUQ5SZ9cyDMj9KAw282njuqWbaPdnF4nSeDMKa7BVB15enHIXJatOn09TOXIj6UxQJr1LLH6USla8hgRh4jxqmsp0UL5qNGZ9wn0XaGQVZZ5T/F6eeTj1aW9FbwHwV5gFjQeSpBN+BOwR3cbDtR5jUpLRS9RY384qAX18ya5r+UVvlKlLG8aNZ7AMZlHIc9x7TDd2WLmj33DkMtw+zzgpjWp7b12prqro3IL55pS2nbdJHj0Aa6D5BFVIMWvCNuDeNkKJJq/xKZcWpkgGPBHyZgd5ayuDixSrrRF87tnqDG5KUeSHoQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bReqIzrPXi4oa5RDlN+dSZiDSzN37Cy2KTa0dT2JDCE=; b=Vsr4KsqCP5NdtXERlqGkJqwG0GT+kUG+u7m1hSYhitGovZXqDxDuM4hqFsulUInFIu4tBrSuFBFwJxyWyAQUCRfokHdbo4884bFv2BbVZtqAPGV25xsDLzd0ww29xK4mmhZNoeYaA3VmRTtHgcAOe6qO1DNax8Tq+lj5ujYi5HuhOO0Y3G07QRW4DVmlnxNkj/hn8TOQvy9wrHXEGIn3Sky10LoRzQS9cdWITFb7prKPGpScNpG+Xy+6e8Hpu2a+iAdyPYXGPX5OOvI74rLyirg8z0kkqj6xX21QPFlWyp2Jh0FW2vVKQTE3CudR+up+v0KwVC2fBHI9ssvuV+b8Lg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=bReqIzrPXi4oa5RDlN+dSZiDSzN37Cy2KTa0dT2JDCE=; b=ZTQvpfGhNqC3cW2C+UEmNirQ9o+dvcts/ErjJ5vbDgC9GagjFZrEPKKdV0PAKx9MzoTcXjtmxJfgPlp6oUa6K57nFhiqRdWjOX2d+P55imDigZG555fky7LW/kL5KuTEgKxSF1flzEjZpQz3srkTimb1fFr9MyGMo2qmUcCAWW0= Received: from DM6PR11MB2555.namprd11.prod.outlook.com (2603:10b6:5:c5::33) by DM6PR11MB3099.namprd11.prod.outlook.com (2603:10b6:5:6c::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3391.11; Tue, 22 Sep 2020 10:28:19 +0000 Received: from DM6PR11MB2555.namprd11.prod.outlook.com ([fe80::59db:260c:93d9:2439]) by DM6PR11MB2555.namprd11.prod.outlook.com ([fe80::59db:260c:93d9:2439%5]) with mapi id 15.20.3391.026; Tue, 22 Sep 2020 10:28:19 +0000 From: "Power, Ciara" To: Honnappa Nagarahalli , "Mcnamara, John" , "dev@dpdk.org" CC: "stable@dpdk.org" , "Wiles, Keith" , nd , nd Thread-Topic: [dpdk-dev] [dpdk-stable] [PATCH] metrics: fix resource leak on memory allocation fail Thread-Index: AQHWkHEOqDccnqoa/kqEIgCQFy3MXql0dOsA Date: Tue, 22 Sep 2020 10:28:19 +0000 Message-ID: References: <20200917150341.66298-1-ciara.power@intel.com> In-Reply-To: Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: arm.com; dkim=none (message not signed) header.d=none;arm.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [37.228.239.233] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b9b8dd1f-698a-423c-2f29-08d85ee2397e x-ms-traffictypediagnostic: DM6PR11MB3099: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: efNQtXysa9exnvNJ8KA+JH9jZ2T78K8/jO8NX3J/lPj4NQf6O2z+ajQvAiFnxyR+fqbhS7UAu6CbzYGPQO7Rhsm/no03MKxJhBixEJCqWUEv08uMIdBfJOyol+mHw76S0J/4esWQa/9trke8eKX36uEN7wJLhYT8l7j2nVaoqhcJZoRDslSS11vvTWLaTHcpe/Wcc64L34Arfn1YpFxJ+UeAbCLdaG4yF8+FC8vpAsO9QyOLXXUYu/dZS0EaawLqywIHa+v1tBnEd1JVhtQVvZuhyss2pAkNWxZyhQaEM0Zqy2F7MU6wIHjRWqCfVGS/WHflpPsiPEzAl/1CWz87/pIxoi6LUXnfGJfitxb+a7kUoZt4LWdQ/5thYvjeozqfClIm26imUahRyMuBVva8Xw== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB2555.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(376002)(346002)(366004)(136003)(39860400002)(478600001)(86362001)(6506007)(316002)(83380400001)(4326008)(52536014)(55016002)(2906002)(33656002)(76116006)(5660300002)(8936002)(110136005)(66476007)(66946007)(9686003)(66446008)(64756008)(66556008)(7696005)(26005)(54906003)(186003)(966005)(71200400001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: nFw8r9fhojWaDpQRZpPVwSt2An/ud3w5dpruJzlXf7GavXiPWmwU5KWKqh0+2SE8UG/rw+OTxriBbPa2Ep7CducSPZYTxo3Pgt8TfR4m6pyG5+i96ezhN7zkENCg2vY4z19I3T2zEArnML2bNsd29ckWJkGMhfFiqsSpJbz1sOMMDj0MA0c4K2Yrsdu/wjh9dFHdVkvGPYIS/Z0Udqu0+yMgD0zuNhc6gqVLsMmKk68rFvz7IikBLFFRdmi1xe89UVO+xmuGL3vCwKmMpcDYg3Qvs1i+N2W1SAcdtCRMcq1CgsqXS/S+gP7JcFuE3/umoScu0ikOBl7H6Vg/0xUaCwcTkcVwiwwTtB7peWa2kpkPc5mfkukXQzFizfGYN38k6CLUTYlpMJ3YmYEQEnzfrv4evCktGuruBDhwKGWfDJtYZeepu+Ru38CoNtVfps5OpsRDLstv0h2tY8aRIANVkECZoQ3TVfA91IR8RosVCo9XhbouapJAziFgeDP+utj/JFazTHBr3YeOgKCZad+3/Kd4NhWM7o6pfGeDmMXWwlERrZxguRJXyUTUUBKy1oKUZ8G0cyb+phw4HSJt4M8lZ1vBo8DFmWRUTRahrfNpBKv0oFtnPepJBWoFkCG3Ssd4S+Se836h8GzBQxlCHvWiMg== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB2555.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b9b8dd1f-698a-423c-2f29-08d85ee2397e X-MS-Exchange-CrossTenant-originalarrivaltime: 22 Sep 2020 10:28:19.1306 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: EC7s6cRmkLL9HAoiji5yHeBeYkujfYCl5bHXb3pAdOuJZvzAA6BCE7jHVaDNOMG33/TYAEtiiOziRbgsEEMuqQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3099 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] metrics: fix resource leak on memory allocation fail X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Honnappa, >-----Original Message----- >From: Honnappa Nagarahalli >Sent: Tuesday 22 September 2020 00:43 >To: Mcnamara, John ; Power, Ciara >; dev@dpdk.org >Cc: Power, Ciara ; stable@dpdk.org; Wiles, Keith >; nd ; Honnappa Nagarahalli >; nd >Subject: RE: [dpdk-dev] [dpdk-stable] [PATCH] metrics: fix resource leak o= n >memory allocation fail > > > >> >> > If an error occurred when allocating memory for metrics or names, >> > the function returned without freeing allocated memory. This is now >> > fixed to avoid the resource leak in the case that either metrics or >> > names had been successfully allocated memory. >> > >> > Coverity issue: 362053 >> > Fixes: c5b7197f662e ("telemetry: move some functions to metrics >> > library") >> > Cc: stable@dpdk.org >> >> Acked-by: John McNamara >> >This is fixed in https://patches.dpdk.org/patch/75323/. Can you please che= ck >if that suffices? I left some comments on that patch, but seeing as it is fixing the same iss= ue, I will remove this patch. Thanks, Ciara