From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6152DA04BA; Wed, 7 Oct 2020 13:10:52 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 427D81B3F3; Wed, 7 Oct 2020 13:10:51 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 8496C1B3D9 for ; Wed, 7 Oct 2020 13:10:48 +0200 (CEST) IronPort-SDR: wfgrCrYuXc4+pNXxQMZljBPmYyxkFjfYyEPXpIa2MQr3o2KEmx/XzJ2ZgQOnQyxBPIJgQ9oT4F bKZaXwbLC2Zg== X-IronPort-AV: E=McAfee;i="6000,8403,9766"; a="151832294" X-IronPort-AV: E=Sophos;i="5.77,346,1596524400"; d="scan'208";a="151832294" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Oct 2020 04:10:39 -0700 IronPort-SDR: UQb/+Oc90bZdc7cjtCWf+T+MLVb7vbCQIOI4nF5LoHIEFdZUWTR3pYG7b1CF06x6mfdTFo21Cl JyhT3AtjndXw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,346,1596524400"; d="scan'208";a="517763436" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga006.fm.intel.com with ESMTP; 07 Oct 2020 04:10:38 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 7 Oct 2020 04:10:38 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Wed, 7 Oct 2020 04:10:37 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.101) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Wed, 7 Oct 2020 04:10:37 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=W8Zt87CXjeVn6kNPk+XTo+4oiT8zTsRQWP2qcHDA6plgTKBX5z5oe780embueSvr/AsFf3NXVgdOD9UzcyQbtoJjQnCs3HNELIqCpPemQY3dF4HB7ZfqOv2MGXdVNxiKIjqUdVnm8abP7tOraEetD7xW4TOfTkWGmliGPx1hAGKzDyE7tKhnCOfAfB9UJ/L5v3CATHDvvnXTdRPNT0/C0rv/anm555+gIR0i9YIyRN7J4x8j1BJoL8RfCa15K87u7EwrHrQu2SADFUFoI2ln3EKfxRkZDeuAe95fV+tX6mV10RlRM4Tm1VIOKCbRkGFu/J3qlbHtVp9jSgMjusKhJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=P8kVpf+93cIuuOJlmPKP3LUSBeqEHpM0Dnauqq67Luk=; b=EDwWtmJ9Tutiu6TmxOMZQQznnT30jVuVlegULxaYKGPve02ClAKKQTlViSGJ36j4EJ5cCTEu9Rt1p5QVPn+PcNf17ek/NwKmsOT+XRqQbjZ26KCYS9eJKRnf6UMSbrt9ZvlJQhZzHPROcKew25kXQ0say+W38Nvq5NCVdlechdxsAa/qDc7pxseCqiPMpTDDYQC7j9DhpHBlw58jx391ywMKkriE7XGu62VT5HB8GUAzpRtBS9xU6GkX3rnMVmMK5R2cj367eARsB0zaqYC6+YYYq2Exmrk+z5Q+5LOcq0gMi5A8wglbMEPTwbtJxXQmvhTrOBvBiD6zyWfu5q44og== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=P8kVpf+93cIuuOJlmPKP3LUSBeqEHpM0Dnauqq67Luk=; b=JzuNQZGjoO5h11F6CcnayYMnsLpn/fH/e402ebnprDeUJ3VDY35w4vsVGWTxzQimCoHhr9biWOBUaQ7/aJiIuCGbMJ7qSl6GQ+AWkq21lNCD1uRcnt+Gb1qg7ANyZUEGA1M8A5t2xHK/ppD3rlOT/Z9a4uFvO7hBJNPWBGjdMLk= Received: from DM6PR11MB2555.namprd11.prod.outlook.com (2603:10b6:5:c5::33) by DM6PR11MB3786.namprd11.prod.outlook.com (2603:10b6:5:142::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3433.41; Wed, 7 Oct 2020 11:10:33 +0000 Received: from DM6PR11MB2555.namprd11.prod.outlook.com ([fe80::78d4:d670:95af:773d]) by DM6PR11MB2555.namprd11.prod.outlook.com ([fe80::78d4:d670:95af:773d%5]) with mapi id 15.20.3433.043; Wed, 7 Oct 2020 11:10:33 +0000 From: "Power, Ciara" To: "Richardson, Bruce" CC: Olivier Matz , "dev@dpdk.org" , "Ray Kinsella" , Neil Horman Thread-Topic: [dpdk-dev] [PATCH v3 01/18] eal: add max SIMD bitwidth Thread-Index: AQHWlyrBAbDihkshFEi9z+NzKaB/wamKWNOAgAGiw0CAAAXmAIAABO9A Date: Wed, 7 Oct 2020 11:10:33 +0000 Message-ID: References: <20200807155859.63888-1-ciara.power@intel.com> <20200930130415.11211-1-ciara.power@intel.com> <20200930130415.11211-2-ciara.power@intel.com> <20201006093217.GG21395@platinum> <20201007105212.GE680@bricha3-MOBL.ger.corp.intel.com> In-Reply-To: <20201007105212.GE680@bricha3-MOBL.ger.corp.intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [78.18.45.234] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: f66cbbe4-4b4f-434c-bc47-08d86ab19c67 x-ms-traffictypediagnostic: DM6PR11MB3786: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: E6dZoCYTLx+Mmru3fshIm0RNQ4jLfl3rygDI7Z5LYmr9gfEjOqQYa3NxJqiNAxhSIzTJEFn316X0CzKS+Zn+HX1C/pelJCvYl6WJUZ6QxXFXVLW750Kwd3TUtlIKBWZABFgEZwPRVEYrqW3GxFLoOBlDVxi9lOK20AhpllPtKmVgmmG/Jhk33AfeZmYARO23yBF/7atdW30XRF5AyCDZcK5RXuJWbkzW+nguTMHX/K/yN6kN8vigrP2+wcGrXq4s5WxtjiapefB25nDgDSGXabarBM7tJ3KjoSBK2Sh5bdwDNUqvO7hP5/DshUzpLm8aJLtodxA6HYp8ufvRBTU57Q== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB2555.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(39860400002)(376002)(396003)(346002)(366004)(2906002)(316002)(8676002)(66946007)(52536014)(8936002)(54906003)(5660300002)(33656002)(66446008)(64756008)(66476007)(76116006)(66556008)(6636002)(55016002)(26005)(7696005)(186003)(83380400001)(71200400001)(478600001)(86362001)(4326008)(9686003)(6862004)(6506007); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: PJb2fvbNSlmlERsmtXRephXdl917P1Il7AsEO9NNcUke/aeauSN4a8RzshhbbKZD3/gj6uAnWY5BP3ytAPv/+IvJs/dXKWXMajM7iRu5G5gd22aDCYxJP+l2GtURjHYBWZJ3rq2i/lIzjUXAeow+WDMosoCY8WOLeTL7r7UmG4KNC5TWgkjr5w2IkmK+iez6WelA8v/6kDgBU6WFYJQsr9heVFdN4IqClBYmd8N+QXzjv+HZB4sRsgnuGRDR8iOktoWOONy4cRqGPiCofMNJbd+ki6AnuGF3mNYBLCW9R334drhagIibrupwNG7QnzRoCmms8Vd2Vmq1crq09zydan8Cu9dg0C2oJoKS7n0LSdXhFiGGDUqeHnBQn8l5MRwXzRfdaCuJmu7jntu3l/jvTWN7EXATEHgukJ//71/NDtHbfIpYT8U+96TzBY7dEJLl/diccvbKG4kJsmmMVbX8oi2BoDOJMNg1/cGrnm9BAW9+louewsaXgurIvVivLwi5qbKH7Zpz9n6WsxVg/APvyGRiahamcZFP+k+p6cWm3JnHNRhuK3p+FBdZ0QODFLAbJSSb9hxMCy7zVo/4Li/SoAmAQDHDBcsekNSNvd3gFglDXYvkFrIsrGJs/eTpImBxWkxxXLxJoJeZNEVVz/ad4Q== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB2555.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: f66cbbe4-4b4f-434c-bc47-08d86ab19c67 X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Oct 2020 11:10:33.7775 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 0EwIN/5wJQb5IoUVQzxy5uo9fllmyLslYmLsyz4QZ++ymbRhZsXqg0TXaw9bzRHwGlmO/lpc9RQA9GLAeWZ5nQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3786 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v3 01/18] eal: add max SIMD bitwidth X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Bruce, >-----Original Message----- >From: Bruce Richardson >Sent: Wednesday 7 October 2020 11:52 >To: Power, Ciara >Cc: Olivier Matz ; dev@dpdk.org; Ray Kinsella >; Neil Horman >Subject: Re: [dpdk-dev] [PATCH v3 01/18] eal: add max SIMD bitwidth > >On Wed, Oct 07, 2020 at 11:47:34AM +0100, Power, Ciara wrote: >> Hi Olivier, >> >> Thanks for reviewing, some comments below. >> >> >> >-----Original Message----- >> >From: Olivier Matz >> >Sent: Tuesday 6 October 2020 10:32 >> >To: Power, Ciara >> >Cc: dev@dpdk.org; Ray Kinsella ; Neil Horman >> > >> >Subject: Re: [dpdk-dev] [PATCH v3 01/18] eal: add max SIMD bitwidth >> > >> >Hi Ciara, >> > >> >Please find some comments below. >> > >> >On Wed, Sep 30, 2020 at 02:03:57PM +0100, Ciara Power wrote: >> >> This patch adds a max SIMD bitwidth EAL configuration. The API >> >> allows for an app to set this value. It can also be set using EAL >> >> argument --force-max-simd-bitwidth, which will lock the value and >> >> override any modifications made by the app. >> >> >> >> Signed-off-by: Ciara Power >> >> >> >> --- >> >> v3: >> >> - Added enum value to essentially disable using max SIMD to choose >> >> paths, intended for use by ARM SVE. >> >> - Fixed parsing bitwidth argument to return an error for values >> >> greater than uint16_t. >> >> v2: Added to Doxygen comment for API. >> >> --- >> >> >> >> >> >> >> +uint16_t >> >> +rte_get_max_simd_bitwidth(void) >> >> +{ >> >> +const struct internal_config *internal_conf =3D >> >> +eal_get_internal_configuration(); >> >> +return internal_conf->max_simd_bitwidth.bitwidth; >> >> +} >> > >> >Should the return value be enum rte_max_simd_t? >> >If not, do we really need the enum definition? >> > >> >> I kept the return value and param value below as uint16_t to allow for >> arbitrary values, and will allow it be more flexible for future addition= s as >new enums won't need to be added. >> For the set function below, this is used when a user passes the EAL >> command line flag, which passes an integer value rather than an enum one= . >> The enums are useful when checking the max_simd_bitwidth in >> drivers/libs, for example using "RTE_MAX_256_SIMD" instead of "256" in >the condition checks. >> >So basically these enum values are #defines for readability, just in enum >form, right? Yes, that's exactly right. Thanks, Ciara