From: "Power, Ciara" <ciara.power@intel.com>
To: David Marchand <david.marchand@redhat.com>,
Jerin Kollanukkaran <jerinj@marvell.com>,
"Richardson, Bruce" <bruce.richardson@intel.com>
Cc: "Wiles, Keith" <keith.wiles@intel.com>,
Thomas Monjalon <thomas@monjalon.net>, dpdk-dev <dev@dpdk.org>
Subject: Re: [dpdk-dev] No telemetry legacy support print
Date: Fri, 22 May 2020 09:55:26 +0000 [thread overview]
Message-ID: <DM6PR11MB2555F1C46963E6A6EBC8EB0FE6B40@DM6PR11MB2555.namprd11.prod.outlook.com> (raw)
In-Reply-To: <CAJFAV8x8yV1UGCeBiXQZYQZN22KXf2fHkUUcRBtf9+xx=d59Mw@mail.gmail.com>
>-----Original Message-----
>From: David Marchand <david.marchand@redhat.com>
>Sent: Friday 22 May 2020 08:47
>To: Jerin Kollanukkaran <jerinj@marvell.com>; Richardson, Bruce
><bruce.richardson@intel.com>; Power, Ciara <ciara.power@intel.com>
>Cc: Wiles, Keith <keith.wiles@intel.com>; Thomas Monjalon
><thomas@monjalon.net>; dpdk-dev <dev@dpdk.org>
>Subject: Re: No telemetry legacy support print
>
>On Fri, May 22, 2020 at 9:15 AM Jerin Kollanukkaran <jerinj@marvell.com>
>wrote:
>>
>> "No telemetry legacy support " prints pops up on all the default dpdk
>applications now.
>> Is it worth to print? Since it using direct 'printf', we cannot even disable
>through dynamic logging.
>> Is possible to remove that print at least, if non legacy telemetry init is
>successful.
>> Thoughts?
>
>This init function is odd as it calls printf in error and warning cases and sets an
>error string when it succeeds.
>Let's remove the two printf in this init function.
>
>If we really care about the warning message, we have to initialise *err_str to
>NULL (+ this must be described in the function prototype).
>In EAL init, we can then add a rte_eal_init_alert with the error string when
>telemetry init fails and maybe a warning message if err_str != NULL.
>
>
>--
>David Marchand
I agree with this solution, I can work on getting a patch done to fix this.
Thanks!
- Ciara
prev parent reply other threads:[~2020-05-22 9:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-22 7:14 Jerin Kollanukkaran
2020-05-22 7:47 ` David Marchand
2020-05-22 8:14 ` Thomas Monjalon
2020-05-22 9:55 ` Power, Ciara [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR11MB2555F1C46963E6A6EBC8EB0FE6B40@DM6PR11MB2555.namprd11.prod.outlook.com \
--to=ciara.power@intel.com \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=keith.wiles@intel.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).