From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id B77A6A04BC; Fri, 9 Oct 2020 16:03:02 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6872C1D6B1; Fri, 9 Oct 2020 16:03:01 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id A9A7C1D6B0 for ; Fri, 9 Oct 2020 16:02:59 +0200 (CEST) IronPort-SDR: +xJ+EGhleuuLdOC1wadSpASGKlWdrEY0W9DfHE7GuS29BDp+XOqwC3nl0r4oFxR9WY2lBuIbM+ k1QKCgaGB/qA== X-IronPort-AV: E=McAfee;i="6000,8403,9768"; a="145351614" X-IronPort-AV: E=Sophos;i="5.77,355,1596524400"; d="scan'208";a="145351614" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 09 Oct 2020 07:02:57 -0700 IronPort-SDR: +wjHmFBvfM9Dy6mu4DYMrkLEgNPb2HikUc08exNzGKpMeKuh7S9KfmMaf85IzxS9nVtZlgdb/W XActotO7ehpg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,355,1596524400"; d="scan'208";a="389149243" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by orsmga001.jf.intel.com with ESMTP; 09 Oct 2020 07:02:57 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Fri, 9 Oct 2020 07:02:57 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Fri, 9 Oct 2020 07:02:57 -0700 Received: from NAM12-BN8-obe.outbound.protection.outlook.com (104.47.55.172) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Fri, 9 Oct 2020 07:02:56 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MTSsZmavcOmEDsIEVOtDepDEXW39vudsOqn13ETM9o8nJdjarpCIp1NrHAgMba3dmLuBvSOH4RcAxyGPerrZeOwHv+/ZdcIa20CTMYZCsr++pl5FsEcHAWG2cMDs/BMRdy/LjdyUlySpPoxcUIj+JlBrFHD7su/cDioLfy5+RFLCWL0By2aT4/mFTq/J9uAK3fzYYsfvYBkjJiwSnDbPNm/rTGEPZiNhrCd0WEUB9z1U3UQUnNN7Os6u84sSpTpiWpnxQQiEKk1Eisf3Mk2iQwnrgwdlhTOnOw+G8YQZilL3PjjiR6/LR2bI3fORuzQpcHLzvZoWf71wU6f5cRIovg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Xr+tBv74dYxP981JTzj+0MySThZpMS90IhcOt5MVfyc=; b=dh9sbpYXTAlkxuDLgMUKY4hbezOk16sMp3FiZZ0B+OiRVFHHiCRKjQvEnaEm04hab7FPCMFCNDMEHVqPZn7MATlYCRzAk8IZZxCmJeiHsUIYckeMg3qH4LK0WmR2VInfqhbOcKd6z/W7Uw74jwss6dJOvmm1AJvJ0uBCKIbjghaWqYQvWEP3DR2gbDZCMXnH0a7YVnl7sGHmsNcZiOXRnlyCMYJT5u/wrzxSJnBWYn6p5v2ShCjdTnYVW9gTtaZjvLDuzeoeYuN4xHadeajiFWyHU/Yf7+Ic5T6DXoHXPd+WOq7yHguyD2UZiBp1RJWZP2Ed9olT9G+izYCYUiRCFw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Xr+tBv74dYxP981JTzj+0MySThZpMS90IhcOt5MVfyc=; b=NVjjN8U6omngzbKQqV4HEMjFyJyh8MsC5C5G/w+ks2tRHWvMEmdhwzs/VSGjJUFDCHCaS8wx51BxXA4dk7OKQEWUx47OK4/DHpcUxOYSm+KPFxyWISWMNbMTVMzRCLfsirgMk0JKPyK9RjRKLur+H9uowyS89z16PjGK9tIFC58= Received: from DM6PR11MB2555.namprd11.prod.outlook.com (2603:10b6:5:c5::33) by DM5PR11MB1564.namprd11.prod.outlook.com (2603:10b6:4:d::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3455.27; Fri, 9 Oct 2020 14:02:45 +0000 Received: from DM6PR11MB2555.namprd11.prod.outlook.com ([fe80::78d4:d670:95af:773d]) by DM6PR11MB2555.namprd11.prod.outlook.com ([fe80::78d4:d670:95af:773d%5]) with mapi id 15.20.3433.043; Fri, 9 Oct 2020 14:02:45 +0000 From: "Power, Ciara" To: "Guo, Jia" , "dev@dpdk.org" CC: "Xing, Beilei" Thread-Topic: [PATCH v3 04/18] net/i40e: add checks for max SIMD bitwidth Thread-Index: AQHWlyrFuIKGRKldn0Cob9nP/xRIzKmOowiAgAC2/lA= Date: Fri, 9 Oct 2020 14:02:44 +0000 Message-ID: References: <20200807155859.63888-1-ciara.power@intel.com> <20200930130415.11211-1-ciara.power@intel.com> <20200930130415.11211-5-ciara.power@intel.com> In-Reply-To: Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [78.18.45.234] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 2e29a391-fcac-4083-6ede-08d86c5bff7b x-ms-traffictypediagnostic: DM5PR11MB1564: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: McITLh3fAo6swY/LS2Raff9IJywuqwfDGXxpENH1FQoigtgeVa38gu3D7Lc6dnN+2pzDCA0wv+nmnL4BZpUNzOspLQddyTAIv8NMY2MFGaW00VD1Pt+hvkommSQF8jsIMFarOrU30p+ZC60mEIHOraXg5w4TCPR3kX+DYOmuAkZHASeHHjkmUap2qRD6zJqYAfkNNM/IfcV0Zw84ad7+RbBtcIYZDp7rvuXf09XOLpxgRMJH1jnfWX0wWIaWH168/DmIZ+lBzCzBzWUo/oEYRpZ2Q+L4kIqy2M1M/lFAOWQnEthQoUyyx4LAF+saLMcDcvv7xA9WS5g787tFJiIrjQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB2555.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(39860400002)(376002)(396003)(346002)(366004)(83380400001)(86362001)(52536014)(66946007)(5660300002)(71200400001)(107886003)(76116006)(66556008)(66476007)(66446008)(64756008)(4326008)(33656002)(9686003)(8676002)(7696005)(2906002)(26005)(186003)(8936002)(6506007)(53546011)(316002)(55016002)(478600001)(110136005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: ISw9C9wvNJ55Q2mfoduCVA+PikaGfFx5NtFPZHaXblyiNcLxZWG23LJzbb5HvmtZgBOjWijlrwUAM4mCtGTkM9WTUIOc3wUfnqZ45RefKwWB86/WBlkcOZnGyUzmuwfE0vj92+NiyKW0hAdT+PZuHSGnVWnJNOf67UFwx1XctVf4bYOdfvud//txoU67baEMu7XX4++PtBunthAF/oNfYHjeGJTauyfzKGTfWfCg0qeD+MVkjgd971S2prSyR4qKysf8HohZdv5NtDMEfuxmQxczsJdHx5cAO/lqElP4+Vd/k19e3mUPPBMTpVEyIoUxYmNBe5YgtKGYrqjodINLxWLpa/bCl14fT9eX2wKGOLdUBN778av4ApmhagCrd6JARihCmwGmSeoRsMdxU/N6KVgKEUaE1/0n4MQ9sr9b2JhGRm/Ify0y8D0bFlZsCRvfPwTsoKP9rH69dcOMePh1Ws5kV5G9g9cjVCz0C2qaCo4f2JriX4wpwvtmoU2jEQux5MmXPxUJL+7iCIfdSMfTCiYLXZRNVaa9AIvd9P1Tft0NT0BZsPwiPLJSD3V+I2WMOpzDlagljCRESrTPC22MejY+1rO5g5e6O7256AjaDMo+b6zLiixBtcN6L7v1M2nLYQwCGFwT2m/TJ0nCTcGI7Q== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB2555.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 2e29a391-fcac-4083-6ede-08d86c5bff7b X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Oct 2020 14:02:45.4499 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: xdxfm/Txf+RMBljbT4XsgqVAQ5xg34TwswhROhVEHdrdPN3iQ/4wHHO92AW7ngMw03WjKU+F9Q4d2kV+mPMMdQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR11MB1564 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v3 04/18] net/i40e: add checks for max SIMD bitwidth X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Archived-At: List-Archive: Hi Jeff, >-----Original Message----- >From: Guo, Jia >Sent: Friday 9 October 2020 04:03 >To: Power, Ciara ; dev@dpdk.org >Cc: Xing, Beilei >Subject: RE: [PATCH v3 04/18] net/i40e: add checks for max SIMD bitwidth > >Hi, power > >> -----Original Message----- >> From: Power, Ciara >> Sent: Wednesday, September 30, 2020 9:04 PM >> To: dev@dpdk.org >> Cc: Power, Ciara ; Xing, Beilei >> ; Guo, Jia >> Subject: [PATCH v3 04/18] net/i40e: add checks for max SIMD bitwidth >> >> When choosing a vector path to take, an extra condition must be >> satisfied to ensure the max SIMD bitwidth allows for the CPU enabled pat= h. >> >> Cc: Beilei Xing >> Cc: Jeff Guo >> >> Signed-off-by: Ciara Power >> --- >> drivers/net/i40e/i40e_rxtx.c | 19 +++++++++++++------ >> 1 file changed, 13 insertions(+), 6 deletions(-) >> >> diff --git a/drivers/net/i40e/i40e_rxtx.c >> b/drivers/net/i40e/i40e_rxtx.c index 60b33d20a1..9b535b52fa 100644 >> --- a/drivers/net/i40e/i40e_rxtx.c >> +++ b/drivers/net/i40e/i40e_rxtx.c >> @@ -3098,7 +3098,8 @@ static eth_rx_burst_t >> i40e_get_latest_rx_vec(bool >> scatter) { #if defined(RTE_ARCH_X86) && defined(CC_AVX2_SUPPORT) -if >> (rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX2)) >> +if (rte_cpu_get_flag_enabled(RTE_CPUFLAG_AVX2) && >> +rte_get_max_simd_bitwidth() >=3D > >Nitpick: I think if consistent to keep alignment for open parenthesis in t= his >patch set would be better. Do you think so? > This file doesn't seem to have any if statements indented as you suggest,=20 Some do have a double indent for the continued line as I have done here tho= ugh. Thanks, Ciara