DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Amber, Kumar" <kumar.amber@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: "Wang, Yipeng1" <yipeng1.wang@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>,
	"Richardson, Bruce" <bruce.richardson@intel.com>,
	"Gobriel, Sameh" <sameh.gobriel@intel.com>
Subject: Re: [dpdk-dev] [PATCH v1] lib/hash: support non sse42 cpu architecture
Date: Fri, 9 Apr 2021 03:17:16 +0000	[thread overview]
Message-ID: <DM6PR11MB2555FBB366B9CDD25A4DA0A5F8739@DM6PR11MB2555.namprd11.prod.outlook.com> (raw)
In-Reply-To: <23449419.HG3X9kRrra@thomas>

Hi Thomas ,

Pls reject it 

-----Original Message-----
From: Thomas Monjalon <thomas@monjalon.net> 
Sent: Friday, April 9, 2021 4:12 AM
To: Amber, Kumar <kumar.amber@intel.com>
Cc: Wang, Yipeng1 <yipeng1.wang@intel.com>; dev@dpdk.org; Richardson, Bruce <bruce.richardson@intel.com>; Gobriel, Sameh <sameh.gobriel@intel.com>
Subject: Re: [dpdk-dev] [PATCH v1] lib/hash: support non sse42 cpu architecture

25/03/2021 09:06, Thomas Monjalon:
> 24/03/2021 23:59, Wang, Yipeng1:
> > From: kumar amber
> > > 
> > > add _SSE42_ flag to enable compilation of
> > > sse42 specific instructions only on supported architecture
> > > 
> > > Signed-off-by: kumar amber <kumar.amber@intel.com>
[...]
> > [Wang, Yipeng] 
> > Hi, Kumar, thanks for the patch.
> > I think the minimum required machine for x86 is sse4.2 compatible already. So I wonder if we really need this.
> 
> Yes, that's why I don't understand this patch.

Any comment? Should we reject the patch?




      parent reply	other threads:[~2021-04-09  3:17 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-12  7:24 kumar amber
2021-03-24 21:20 ` Thomas Monjalon
2021-03-24 22:59 ` Wang, Yipeng1
2021-03-25  8:06   ` Thomas Monjalon
2021-04-08 22:41     ` Thomas Monjalon
2021-04-08 23:01       ` Stephen Hemminger
2021-04-09  3:17       ` Amber, Kumar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DM6PR11MB2555FBB366B9CDD25A4DA0A5F8739@DM6PR11MB2555.namprd11.prod.outlook.com \
    --to=kumar.amber@intel.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=sameh.gobriel@intel.com \
    --cc=thomas@monjalon.net \
    --cc=yipeng1.wang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).