From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DD9B5A04BB; Tue, 6 Oct 2020 23:33:38 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B7EF01023; Tue, 6 Oct 2020 23:33:37 +0200 (CEST) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 5BDBB160 for ; Tue, 6 Oct 2020 23:33:34 +0200 (CEST) IronPort-SDR: bLiR3lZpBpdvRlxmD/p7bHvYLKGouAg/G2tPtljI5fXI7italUIIRj8+VIUGlyox2aAzzOuCZf hEQQ6I7Mp6+Q== X-IronPort-AV: E=McAfee;i="6000,8403,9766"; a="164771843" X-IronPort-AV: E=Sophos;i="5.77,343,1596524400"; d="scan'208";a="164771843" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Oct 2020 14:33:32 -0700 IronPort-SDR: I0UeX0RUgbgYjsReqHWY3gF5Fr7SLE0fXgkBtH9Xmo1/Jys1Q8di7hIaSW4oNhL3ww/lIsD08I +WxuAeU3EI2g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,343,1596524400"; d="scan'208";a="517459133" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by fmsmga006.fm.intel.com with ESMTP; 06 Oct 2020 14:33:32 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Tue, 6 Oct 2020 14:33:31 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Tue, 6 Oct 2020 14:33:31 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.168) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Tue, 6 Oct 2020 14:33:30 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lWpcIP3Bc51Kzmp8+EiMGjngvr5EbQhYeoBW8pRm1NqmYcgiudkGjT8wxh8p65Rlp6FWxpuwVJyQzpaM2F+6UMBg6QhRKGNNWkpFhk7VsLCiDTqDJ0Fj8GOC9dj8f3R2DAt1653ZE2CfOMeT21Swp5nmHllSmVEGRI/GZgqeM4E5CGZ9USLcGyWkg6KIZ+QZuFxmMt5POovI0KapMeO2xpn/LQCvNe22PkJ+wqfLOHdcSB7/ZeUG5oweH6/vGJr709Kzj3LK+cKcCvEDbreDI0Wi3Ovsb6SQpdOUHb7+8q9GutXdatlpNasYykCaapw5LyuO18L+b3mnC66qV9QYRA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=txWpFrYyOfYyKvTQn0vFO8lZZzwMGJi5c9wqRX6NPWY=; b=fDFU7FzTH/QhmNxp97CAV4YHNdOjJpaUM53ZyNCIQl/j7WQz07vLsQfxIlC+bmMIBX8kz3wpZFKML8wjSieOcnkUZ1f63XE2XGpvr1m2h9ldtW3QmsoODQxaJ5yOtYgKZaTY//4VJwrmJgsDVTKjIS7HAab9rb0a8dKvpTHOzEBDEY6qerqXhnq44U4mNHiqtEIg2TC4tQrOZTqMAkDfmmR7CbtOBDcDBIea5YOUA1Mp2h8e6eC9RuDxzQVzcnhG3Ca/N/LosWmBJeGrQ1BpdKHlmRTatoKEkviUT1VtAslvIF6QTANBSaYlMI/u12wkvvUAqghWkhuGmDtAS9p8Ig== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=txWpFrYyOfYyKvTQn0vFO8lZZzwMGJi5c9wqRX6NPWY=; b=yEtr3wWQ6NbSA/o9rWSfGzGbRxtggQ0eYXFUbIcBK4Tk45NL2cTfH/Gp7GuIQL1Lom2VAJF7mRkXjNlDmSvOj6FettMV7gDy2dY1dNhxtzLEg84nD+2eYRd80wd9/gKD8wTG+JAUkFx9QAoV4qOO+TC6fxu0mXID7Ag+FWcTlZw= Received: from DM6PR11MB2572.namprd11.prod.outlook.com (2603:10b6:5:c8::31) by DM5PR1101MB2076.namprd11.prod.outlook.com (2603:10b6:4:54::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3433.32; Tue, 6 Oct 2020 21:33:28 +0000 Received: from DM6PR11MB2572.namprd11.prod.outlook.com ([fe80::f9f3:3166:9bba:50d8]) by DM6PR11MB2572.namprd11.prod.outlook.com ([fe80::f9f3:3166:9bba:50d8%6]) with mapi id 15.20.3433.045; Tue, 6 Oct 2020 21:33:28 +0000 From: "Eads, Gage" To: "McDaniel, Timothy" CC: "dev@dpdk.org" , "Carrillo, Erik G" , "Van Haaren, Harry" , "jerinj@marvell.com" Thread-Topic: [PATCH 05/22] event/dlb2: add inline functions Thread-Index: AQHWiHpVVvQbgodgeECPDQ+B/KKKC6mLHIOw Date: Tue, 6 Oct 2020 21:33:28 +0000 Message-ID: References: <1599855987-25976-1-git-send-email-timothy.mcdaniel@intel.com> <1599855987-25976-6-git-send-email-timothy.mcdaniel@intel.com> In-Reply-To: <1599855987-25976-6-git-send-email-timothy.mcdaniel@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-product: dlpe-windows dlp-reaction: no-action authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [68.203.30.51] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: bb9718ed-5109-4a4e-bd3c-08d86a3f772e x-ms-traffictypediagnostic: DM5PR1101MB2076: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:8882; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: cOMfGW8z0kl5VewnjFIryFyeT4agNzMema2IAAgUDeKKZ8QkfDqMlvuEYEuoEAbstfavv/nybesH1Rymz1TYtgtMVOI5GYfhgHxEAj15ATotuzfeCrjeMIf/wDMI76G0T2BMVa0cA9KazzoFs5a9PkbXlF0ZUlgiojEvSPAqp4Tb6P0zw30qtfE8k83IlaiP4Zm4znMTK0CFOnn74pCpyjKaK52ujEBCkTiSvdiRK0tZwEzEP///t59RxpOpl4TOXwpKJVXsszoq17Fv0y1KQPV9kkWwytg4NOn8uhJz1egVbIbHxAtIibGTPYo9yQ7OUokUGqXJKdBYCbms5iYY+Q== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB2572.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(396003)(346002)(366004)(136003)(39860400002)(6506007)(71200400001)(52536014)(5660300002)(33656002)(7696005)(4326008)(2906002)(26005)(9686003)(186003)(76116006)(66556008)(66446008)(55016002)(66476007)(64756008)(66946007)(86362001)(6636002)(8936002)(54906003)(316002)(8676002)(83380400001)(6862004)(478600001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: dHkb4JxcUPUEQ0H6p0ovcUrR/WlzNx7zB/v6q6VkCNVFiMYWf2jIKjyiqkO4xi4X4OAbl/F1JE9vLYVTAF+uj7iD6A/7FOTLs831z29H0Y40VhCMprPzNLVDiEPrtF2IAOq+PcpIkuViosrkk29HZwheB/BbeZuupVT4KZIfIbkSqJ1gK4SnNsoFOQGHcSnL8/IxKlMgndS+iszcCcwpD/zds4KuXGUHAHZFXnpvSgDmNsBnRmHP+yBT4aSuwEuaJZ49jWFUP6xKt7ApRmBilkCzSmDB5IF/cSX1C5ONqV1sFy0j9S4uqCM9ZKOMPgbknIw0AgFZOjJZ03MWXKUNstD84TJIkCzftnfI0WIR30FFGh15iOyCHhyKxEeYKT2O+Ho3fF6UKtNyrl7PAjPGfutShWACeE74kuEgo9jQZFJuZdS4KCXu1ux1aGE8XJycBvu2RirbY/5NEYmoyfXy337gqq0mIUMINQx+U+epr2MJgcVCt6g8LcZi43EAhvZnVDv+bVemA3RZK4s4p263SniIwhopu/s+5J9xwYbRHldQ/1/5kbsgeH8FMqJrXItkEvcF8mp+KXbkY0FaUVKqRI/IWqTqe91vu0Bth/HdhUABGZn94gLoOUWCvcjEe8CTBcYvS7RuSPqAggBQcAPKqg== Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB2572.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: bb9718ed-5109-4a4e-bd3c-08d86a3f772e X-MS-Exchange-CrossTenant-originalarrivaltime: 06 Oct 2020 21:33:28.6941 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: vYTnD/KEzSxJeI9NwKL5OAHVBZIZp3iw7wBTiPXERWKsO01Pd4mUXQE/Rj1g19pQSeflRMGHWC2KhHLmwh3ngw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR1101MB2076 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH 05/22] event/dlb2: add inline functions X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: McDaniel, Timothy > Sent: Friday, September 11, 2020 3:26 PM > Cc: dev@dpdk.org; Carrillo, Erik G ; Eads, Gag= e > ; Van Haaren, Harry ; > jerinj@marvell.com > Subject: [PATCH 05/22] event/dlb2: add inline functions >=20 > Add miscellaneous inline functions that may be called > from multiple files. These functions include inline > assembly of new x86 instructions, such as movdir64b, > since they are not available as builtin functions in > the minimum supported GCC version. >=20 > Signed-off-by: Timothy McDaniel > --- > drivers/event/dlb2/dlb2_inline_fns.h | 85 > ++++++++++++++++++++++++++++++++++++ > 1 file changed, 85 insertions(+) > create mode 100644 drivers/event/dlb2/dlb2_inline_fns.h >=20 > diff --git a/drivers/event/dlb2/dlb2_inline_fns.h > b/drivers/event/dlb2/dlb2_inline_fns.h > new file mode 100644 > index 0000000..f2f0935 > --- /dev/null > +++ b/drivers/event/dlb2/dlb2_inline_fns.h > @@ -0,0 +1,85 @@ > +/* SPDX-License-Identifier: BSD-3-Clause > + * Copyright(c) 2016-2020 Intel Corporation > + */ > + > +#ifndef _DLB2_INLINE_FNS_H_ > +#define _DLB2_INLINE_FNS_H_ > + > +/* Inline functions required in more than one source file. > + */ Nit: this comment can be a one-liner. > + > +static inline struct dlb2_eventdev * > +dlb2_pmd_priv(const struct rte_eventdev *eventdev) > +{ > + return eventdev->data->dev_private; > +} > + > +static inline void > +dlb2_umonitor(volatile void *addr) > +{ > + /* TODO: Change to proper assembly when compiler support available */ I would drop/reword the 'TODO', here and elsewhere in the file, so it doesn= 't give the wrong impression that this code is incomplete. > + asm volatile(".byte 0xf3, 0x0f, 0xae, 0xf7\t\n" > + : > + : "D" (addr)); > +} Thanks, Gage