From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 75EC0A3160 for ; Fri, 11 Oct 2019 11:01:39 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id CC0B11C205; Fri, 11 Oct 2019 11:01:38 +0200 (CEST) Received: from rcdn-iport-1.cisco.com (rcdn-iport-1.cisco.com [173.37.86.72]) by dpdk.org (Postfix) with ESMTP id 395DC1C1E4 for ; Fri, 11 Oct 2019 11:01:35 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=cisco.com; i=@cisco.com; l=1932; q=dns/txt; s=iport; t=1570784496; x=1571994096; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=LomHp1wGdg3BfKbQ+NqNuS0z1aNQpTqa7qEHH1VdgDk=; b=G102jRZDT4FdbZPdH1WMOVgkVI/XZ5Knu6OWq939VS8c+ExXoNVSk+BB EZF9juWbvisvj8sXYJk9jYcZOU43emStnF7Q+r60ee4JvNqo7RrDwAM57 SnPtq6Ep3eqS4Ozu4crj8raAaElvCStOl0zqToFm5lKiFf+ysMJ8t0i2O Y=; IronPort-PHdr: =?us-ascii?q?9a23=3ABUep5hG3eP8TkZN1ZRAmnJ1GYnJ96bzpIg4Y7I?= =?us-ascii?q?YmgLtSc6Oluo7vJ1Hb+e4z1A3SRYuO7fVChqKWqK3mVWEaqbe5+HEZON0pNV?= =?us-ascii?q?cejNkO2QkpAcqLE0r+ef77aCo5HcFqX15+9Hb9Ok9QS47z?= X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: =?us-ascii?q?A0BwAAA3RKBd/4cNJK1lGwEBAQEBAQE?= =?us-ascii?q?FAQEBEQEBAwMBAQGBagMBAQELAYFKUAWBQiAECyqHagOKR4Jcl3yCUgNUCQE?= =?us-ascii?q?BAQwBAS0CAQGEQAKCXCM3Bg4CAwkBAQQBAQECAQUEbYUtDIVLAQEBAQMSFRM?= =?us-ascii?q?GAQE3AQsEAgEIEQQBAR8QMh0IAgQBDQUIGoVHAy4BAqZQAoE4iGGBdDOCfQE?= =?us-ascii?q?BBYEHAQGEARiCFwmBNAGMDRiBQD+BEEeCTD6ERiSDGoIsnlSOcwqCIpU0mUA?= =?us-ascii?q?tjgCZNgIEAgQFAg4BAQWBaCOBWHAVgydQEBSBT4NzihwBNnSBKY9NAQE?= X-IronPort-AV: E=Sophos;i="5.67,283,1566864000"; d="scan'208";a="642233476" Received: from alln-core-2.cisco.com ([173.36.13.135]) by rcdn-iport-1.cisco.com with ESMTP/TLS/DHE-RSA-SEED-SHA; 11 Oct 2019 09:00:59 +0000 Received: from XCH-RCD-009.cisco.com (xch-rcd-009.cisco.com [173.37.102.19]) by alln-core-2.cisco.com (8.15.2/8.15.2) with ESMTPS id x9B90xR6029402 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=FAIL); Fri, 11 Oct 2019 09:00:59 GMT Received: from xhs-rtp-001.cisco.com (64.101.210.228) by XCH-RCD-009.cisco.com (173.37.102.19) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Fri, 11 Oct 2019 04:00:58 -0500 Received: from xhs-aln-001.cisco.com (173.37.135.118) by xhs-rtp-001.cisco.com (64.101.210.228) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Fri, 11 Oct 2019 05:00:57 -0400 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (173.37.151.57) by xhs-aln-001.cisco.com (173.37.135.118) with Microsoft SMTP Server (TLS) id 15.0.1473.3 via Frontend Transport; Fri, 11 Oct 2019 04:00:57 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Fcfc18x87SRKEpcwFW+lZQOaetTCofqRwsp5f8zvXX4ip8Xjko3O7y4bZqxX/zlDS43LiNBQtNKMyQElksN0ukHV2HPEs2BKYWk1KOL0JLiFpXlYVYzvv7YRYe9bBNJVEvEADmQVonSlxhdqGbiysM7C5DJNuAkmZQRT3RuhH1ou9tEejdKunCOCz1Yt9h1s9uyTwamVP0461tJVbxQpB2dmcLW+3pzR5qd9faWTz++7jEs4jaTjjnA5XLVH0sLOWGk23r6RSzuZysxGDORfQ3RypVn/MahZIzfzb6QI40gqGK+iNwpp9l0SsHl86axkhuCWtNu/ADxZ+7hFQU5UOQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=X/6xbAD0HJjQ7eLd1f9EGrg/SHdAkqnaFBnPmE1IlrQ=; b=Z7Q1+iBB7Hh00iIwoWJjCzHc6QLiXJdZHzjSfR8AjwB6McFoiGfJESkLMivLsdHOuB8wDrcjPyQQS9BxMiPU9aqUHGBTo1DrT77XcVfSzFFOIUwEVE8QfPgWIecJlru38ImnCWaR5LMk7NbAmlz2eEyWF2V1DrejwhPPA6lGEyJxhi20IIzANGaXb18wIC7upkLQjK8meGp4BkqKt+YrAWTH4+cXIKCGeWX10O+LvlCcbv5rP5nlqdFpweTyTIxtlT3Tj5bnYlwF100O/atvXw/KldbIQWU+vv5BgC3d9iTuIa+Pi8RI3cdDuw1rYGkPz1NxtedJz/RWHFqv14iDdA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=cisco.com; dmarc=pass action=none header.from=cisco.com; dkim=pass header.d=cisco.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cisco.onmicrosoft.com; s=selector2-cisco-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=X/6xbAD0HJjQ7eLd1f9EGrg/SHdAkqnaFBnPmE1IlrQ=; b=IsyAE2hVzewUlTtRWOH0r03riPbsiu/TqxYOERKP3+goj8mZCiAGH8G7PqzNsWs7iWt9GEyt+nFPMH+ROffyNsOZbEuLt9AbSMynxT2yktIRueCfQ2kttmuhPJWNBkXaJTQyZx2dH/6O4sif3z6BOrcYva1zEU/Y4kUT+KViEyk= Received: from DM6PR11MB2745.namprd11.prod.outlook.com (20.176.99.159) by DM6PR11MB3131.namprd11.prod.outlook.com (20.177.219.96) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2347.17; Fri, 11 Oct 2019 09:00:56 +0000 Received: from DM6PR11MB2745.namprd11.prod.outlook.com ([fe80::81c8:fcc:428a:1fa4]) by DM6PR11MB2745.namprd11.prod.outlook.com ([fe80::81c8:fcc:428a:1fa4%6]) with mapi id 15.20.2347.016; Fri, 11 Oct 2019 09:00:56 +0000 From: "Hyong Youb Kim (hyonkim)" To: "pbhagavatula@marvell.com" , Hemant Agrawal , Sachin Saxena , Akhil Goyal , Igor Russkikh , "Pavel Belous" , Ravi Kumar , Rasesh Mody , Shahed Shaikh , Rahul Lakkireddy , Marcin Wojtas , Michal Krawczyk , Guy Tzalik , Evgeny Schemeilin , Igor Chauskin , "John Daley (johndale)" , "Wei Hu (Xavier)" , "Min Hu (Connor)" , Yisen Zhuang , Beilei Xing , Qi Zhang , Jingjing Wu , Wenzhuo Lu , Qiming Yang , Alejandro Lucero , Andrew Rybchenko , Jerin Jacob , Maciej Czekaj , Rosen Xu , Tianfei zhang CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH 2/3] drivers: use RTE_DIM instead of ARRAY_SIZE Thread-Index: AQHVf+mGKEgJ+U0DgUy7l23QQLLn+adVIgZA Date: Fri, 11 Oct 2019 09:00:56 +0000 Message-ID: References: <20191011040709.8344-1-pbhagavatula@marvell.com> <20191011040709.8344-2-pbhagavatula@marvell.com> In-Reply-To: <20191011040709.8344-2-pbhagavatula@marvell.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=hyonkim@cisco.com; x-originating-ip: [2001:420:c0c8:1006::20e] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 70ebb8a6-9ebf-4034-a4c8-08d74e298762 x-ms-traffictypediagnostic: DM6PR11MB3131: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:483; x-forefront-prvs: 0187F3EA14 x-forefront-antispam-report: SFV:NSPM; SFS:(10009020)(4636009)(136003)(366004)(396003)(346002)(376002)(39860400002)(189003)(199004)(13464003)(55016002)(8676002)(9686003)(86362001)(110136005)(99286004)(7696005)(81156014)(6436002)(11346002)(76176011)(6246003)(81166006)(6116002)(229853002)(2906002)(4326008)(8936002)(52536014)(5660300002)(486006)(2501003)(7416002)(7406005)(478600001)(305945005)(316002)(14454004)(74316002)(7736002)(66476007)(33656002)(66556008)(64756008)(256004)(66446008)(25786009)(186003)(66946007)(476003)(446003)(71200400001)(102836004)(71190400001)(6506007)(46003)(76116006)(53546011)(921003)(1121003); DIR:OUT; SFP:1101; SCL:1; SRVR:DM6PR11MB3131; H:DM6PR11MB2745.namprd11.prod.outlook.com; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; MX:1; A:1; received-spf: None (protection.outlook.com: cisco.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: j3vz422ibdW78r01EwlcbNlaziCdY90APLdVG8XC/VhNcHpYTyM2twzgaUt4OBg5iOgz2f8zmtv2IINDPi1zyOSBzy+pXwAUAGwlVpP6g2n60/6VRiYV6tC9EwGxwtHlFeUIXZDP9XNUC9EQbu2BNza10dDq00u+lRxEgd4tDyE8M/At9OOLUhw/KIafzpd+IVSxlUcgUaHWFotma+o+L9cg4Ggza+Kz6uLdp8m0AgWOp5rNrMacA3+pFPhMwjKx2lVDKKQ3jPRUl5JHL32eGa4CKPOvKNX7t4xTXt0RxSKT7CniXp+Nb/3qKp8uOel2/vh4p1ckhkgOFFbqJIstPszY0XuhY4hmlGCU7vnQYUDDuj+eQIqs/gQRlCLZHsrqqtz2/n4iKDyQBroH+2vUG+BtNAuOYTPQtTAsU2R9PbI= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 70ebb8a6-9ebf-4034-a4c8-08d74e298762 X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Oct 2019 09:00:56.5380 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 5ae1af62-9505-4097-a69a-c1553ef7840e X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: mle8KlQA8/1VxlHLlzTmK1UQPE+yUv8RUvMH7uS3zJ0JbLt7FKTnOBPbbPd4WUQHNe2cEk+lNGOMOpL2+5sYsA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3131 X-OriginatorOrg: cisco.com X-Outbound-SMTP-Client: 173.37.102.19, xch-rcd-009.cisco.com X-Outbound-Node: alln-core-2.cisco.com Subject: Re: [dpdk-dev] [PATCH 2/3] drivers: use RTE_DIM instead of ARRAY_SIZE X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: pbhagavatula@marvell.com > Sent: Friday, October 11, 2019 1:07 PM [...] > Subject: [dpdk-dev] [PATCH 2/3] drivers: use RTE_DIM instead of > ARRAY_SIZE >=20 > From: Pavan Nikhilesh >=20 > Use RTE_DIM instead of re-defining ARRAY_SIZE. >=20 > Signed-off-by: Pavan Nikhilesh > --- [...] > drivers/net/enic/base/vnic_dev.c | 4 +-- > drivers/net/enic/base/vnic_devcmd.h | 2 -- [...] > diff --git a/drivers/net/enic/base/vnic_dev.c > b/drivers/net/enic/base/vnic_dev.c > index 8e190687d..3b9a336ff 100644 > --- a/drivers/net/enic/base/vnic_dev.c > +++ b/drivers/net/enic/base/vnic_dev.c > @@ -417,11 +417,11 @@ int vnic_dev_cmd(struct vnic_dev *vdev, enum > vnic_devcmd_cmd cmd, > switch (vdev->proxy) { > case PROXY_BY_INDEX: > err =3D vnic_dev_cmd_proxy(vdev, CMD_PROXY_BY_INDEX, > cmd, > - args, ARRAY_SIZE(args), wait); > + args, RTE_DIM(args), wait); > break; > case PROXY_BY_BDF: > err =3D vnic_dev_cmd_proxy(vdev, CMD_PROXY_BY_BDF, > cmd, > - args, ARRAY_SIZE(args), wait); > + args, RTE_DIM(args), wait); > break; > case PROXY_NONE: > default: > diff --git a/drivers/net/enic/base/vnic_devcmd.h > b/drivers/net/enic/base/vnic_devcmd.h > index fffe307e0..5a4f48106 100644 > --- a/drivers/net/enic/base/vnic_devcmd.h > +++ b/drivers/net/enic/base/vnic_devcmd.h > @@ -63,8 +63,6 @@ > #define _CMD_VTYPE(cmd) (((cmd) >> _CMD_VTYPESHIFT) & > _CMD_VTYPEMASK) > #define _CMD_N(cmd) (((cmd) >> _CMD_NSHIFT) & _CMD_NMASK) >=20 > -#define ARRAY_SIZE(x) (sizeof(x) / sizeof((x)[0])) > - > enum vnic_devcmd_cmd { > CMD_NONE =3D _CMDC(_CMD_DIR_NONE, > _CMD_VTYPE_NONE, 0), >=20 [...] For enic. Acked-by: Hyong Youb Kim Thanks. -Hyong