From: "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>
To: Li Zhang <lizh@nvidia.com>,
"dekelp@nvidia.com" <dekelp@nvidia.com>,
"orika@nvidia.com" <orika@nvidia.com>,
"viacheslavo@nvidia.com" <viacheslavo@nvidia.com>,
"matan@nvidia.com" <matan@nvidia.com>,
"shahafs@nvidia.com" <shahafs@nvidia.com>,
"lironh@marvell.com" <lironh@marvell.com>,
"Singh, Jasvinder" <jasvinder.singh@intel.com>,
"Thomas Monjalon" <thomas@monjalon.net>,
"Yigit, Ferruh" <ferruh.yigit@intel.com>,
Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>,
Jerin Jacob <jerinjacobk@gmail.com>,
Hemant Agrawal <hemant.agrawal@nxp.com>,
"Ajit Khaparde" <ajit.khaparde@broadcom.com>,
"Richardson, Bruce" <bruce.richardson@intel.com>,
"Doherty, Declan" <declan.doherty@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"rasland@nvidia.com" <rasland@nvidia.com>,
"roniba@nvidia.com" <roniba@nvidia.com>
Subject: Re: [dpdk-dev] [PATCH 2/2] [RFC]: ethdev: manage meter API object handles by the drivers
Date: Tue, 23 Mar 2021 21:33:20 +0000 [thread overview]
Message-ID: <DM6PR11MB279621F143546E694B27B957EB649@DM6PR11MB2796.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20210318085815.804896-2-lizh@nvidia.com>
Hi Li and Matan,
> -----Original Message-----
> From: Li Zhang <lizh@nvidia.com>
> Sent: Thursday, March 18, 2021 8:58 AM
> To: dekelp@nvidia.com; orika@nvidia.com; viacheslavo@nvidia.com;
> matan@nvidia.com; shahafs@nvidia.com; lironh@marvell.com; Singh,
> Jasvinder <jasvinder.singh@intel.com>; Thomas Monjalon
> <thomas@monjalon.net>; Yigit, Ferruh <ferruh.yigit@intel.com>; Andrew
> Rybchenko <andrew.rybchenko@oktetlabs.ru>; Dumitrescu, Cristian
> <cristian.dumitrescu@intel.com>
> Cc: dev@dpdk.org; rasland@nvidia.com; roniba@nvidia.com
> Subject: [PATCH 2/2] [RFC]: ethdev: manage meter API object handles by the
> drivers
>
> Currently, all the meter objects are managed by the user IDs:
> meter, profile and policy.
> Hence, each PMD should manage data-structure in order to
> map each API ID to the private PMD management structure.
>
> From the application side, it has all the picture how meter
> is going to be assigned to flows and can easily use direct
> mapping even when the meter handler is provided by the PMDs.
>
> Also, this is the approach of the rte_flow API handles:
> the flow handle and the shared action handle
> is provided by the PMDs.
>
> Use drivers handlers in order to manage all the meter API objects.
>
This seems to be take 2 of the discussion that we already had in this thread: https://mails.dpdk.org/archives/dev/2021-March/200710.html, so apologies for mostly summarizing my previous feedback here.
I am against this proposal because:
1. We already discussed this topic of user-provided handles vs. driver-provided handles at length on this exact email list back in 2017, when we first introduced this API, and I don't see any real reason to revisit the decision we took then.
2. For me, it is more natural and it also helps the application to simplify its data structures if the user provides its own IDs rather than the user having to deal with the IDs provided by the driver.
3. It is much easier and portable to pass numeric and string-based IDs around (e.g. between processes) as opposed to pointer-based IDs, as pointers are only valid in one address space and not in others. There are several DPDK APIs that moved away from pointer handles to string IDs.
4. The mapping of user IDs to internal pointers within the driver is IMO not a big issue in terms of memory footprint or API call rate. Matan also confirmed this in the above thread when saying tis is not about either driver memory footprint or API call speed, as this mapping is easy to optimize.
And last but not least, this change obviously propagates in every API function, so it would result in big churn in API, all drivers and all apps (including testpmd, etc) implementing it (for IMO no real benefit). Yes, this API is experimental and therefore we can operate changes in it, but I'd rather see incremental and converging improvements rather than this.
If you guys insist with this proposal, I would like to get more opinions from other vendors and contributors from within our DPDK community.
> The following API will be changed:
> - rte_mtr_meter_profile_add
> - rte_mtr_meter_profile_delete
> - rte_mtr_meter_policy_validate
> - rte_mtr_meter_policy_add
> - rte_mtr_meter_policy_delete
> - rte_mtr_create
> - rte_mtr_destroy
> - rte_mtr_meter_disable
> - rte_mtr_meter_enable
> - rte_mtr_meter_profile_update
> - rte_mtr_meter_policy_update
> - rte_mtr_meter_dscp_table_update
> - rte_mtr_stats_update
> - rte_mtr_stats_read
> The next struct will be changed:
> - rte_flow_action_meter
> - rte_mtr_params
>
> Signed-off-by: Li Zhang <lizh@nvidia.com>
> ---
> lib/librte_ethdev/rte_flow.h | 9 ++-
> lib/librte_ethdev/rte_mtr.c | 77 ++++++++++++----------
> lib/librte_ethdev/rte_mtr.h | 102 +++++++++++++++--------------
> lib/librte_ethdev/rte_mtr_driver.h | 36 +++++-----
> 4 files changed, 122 insertions(+), 102 deletions(-)
>
> diff --git a/lib/librte_ethdev/rte_flow.h b/lib/librte_ethdev/rte_flow.h
> index 5f38aa7fa4..6d2b86592d 100644
> --- a/lib/librte_ethdev/rte_flow.h
> +++ b/lib/librte_ethdev/rte_flow.h
> @@ -2480,6 +2480,13 @@ struct rte_flow_action_port_id {
> uint32_t id; /**< DPDK port ID. */
> };
>
> +/**
> + * Opaque type returned after successfully creating a meter.
> + *
> + * This handle can be used to manage the related meter (e.g. to destroy it).
> + */
> +struct rte_mtr;
> +
> /**
> * RTE_FLOW_ACTION_TYPE_METER
> *
> @@ -2489,7 +2496,7 @@ struct rte_flow_action_port_id {
> * next item with their color set by the MTR object.
> */
> struct rte_flow_action_meter {
> - uint32_t mtr_id; /**< MTR object ID created with rte_mtr_create().
> */
> + struct rte_mtr *mtr; /**< MTR object created with rte_mtr_create().
> */
> };
>
> /**
> diff --git a/lib/librte_ethdev/rte_mtr.c b/lib/librte_ethdev/rte_mtr.c
> index fccec3760b..e407c6f956 100644
> --- a/lib/librte_ethdev/rte_mtr.c
> +++ b/lib/librte_ethdev/rte_mtr.c
> @@ -57,6 +57,19 @@ rte_mtr_ops_get(uint16_t port_id, struct
> rte_mtr_error *error)
> ops->func; \
> })
>
> +#define RTE_MTR_FUNC_PTR(port_id, func) \
> +({ \
> + const struct rte_mtr_ops *ops = \
> + rte_mtr_ops_get(port_id, error); \
> + if (ops == NULL) \
> + return NULL; \
> + \
> + if (ops->func == NULL) \
> + return NULL; \
> + \
> + ops->func; \
> +})
> +
> /* MTR capabilities get */
> int
> rte_mtr_capabilities_get(uint16_t port_id,
> @@ -69,26 +82,25 @@ rte_mtr_capabilities_get(uint16_t port_id,
> }
>
> /* MTR meter profile add */
> -int
> +struct rte_mtr_profile *
> rte_mtr_meter_profile_add(uint16_t port_id,
> - uint32_t meter_profile_id,
> struct rte_mtr_meter_profile *profile,
> struct rte_mtr_error *error)
> {
> struct rte_eth_dev *dev = &rte_eth_devices[port_id];
> - return RTE_MTR_FUNC(port_id, meter_profile_add)(dev,
> - meter_profile_id, profile, error);
> + return RTE_MTR_FUNC_PTR(port_id, meter_profile_add)(dev,
> + profile, error);
> }
>
> /** MTR meter profile delete */
> int
> rte_mtr_meter_profile_delete(uint16_t port_id,
> - uint32_t meter_profile_id,
> + struct rte_mtr_profile *profile,
> struct rte_mtr_error *error)
> {
> struct rte_eth_dev *dev = &rte_eth_devices[port_id];
> return RTE_MTR_FUNC(port_id, meter_profile_delete)(dev,
> - meter_profile_id, error);
> + profile, error);
> }
>
> /* MTR meter policy validate */
> @@ -103,126 +115,123 @@ rte_mtr_meter_policy_validate(uint16_t port_id,
> }
>
> /* MTR meter policy add */
> -int
> +struct rte_mtr_policy *
> rte_mtr_meter_policy_add(uint16_t port_id,
> - uint32_t policy_id,
> const struct rte_flow_action *actions[RTE_COLORS],
> struct rte_mtr_error *error)
> {
> struct rte_eth_dev *dev = &rte_eth_devices[port_id];
> - return RTE_MTR_FUNC(port_id, meter_policy_add)(dev,
> - policy_id, actions, error);
> + return RTE_MTR_FUNC_PTR(port_id, meter_policy_add)(dev,
> + actions, error);
> }
>
> /** MTR meter policy delete */
> int
> rte_mtr_meter_policy_delete(uint16_t port_id,
> - uint32_t policy_id,
> + struct rte_mtr_policy *policy,
> struct rte_mtr_error *error)
> {
> struct rte_eth_dev *dev = &rte_eth_devices[port_id];
> return RTE_MTR_FUNC(port_id, meter_policy_delete)(dev,
> - policy_id, error);
> + policy, error);
> }
>
> /** MTR object create */
> -int
> +struct rte_mtr *
> rte_mtr_create(uint16_t port_id,
> - uint32_t mtr_id,
> struct rte_mtr_params *params,
> int shared,
> struct rte_mtr_error *error)
> {
> struct rte_eth_dev *dev = &rte_eth_devices[port_id];
> - return RTE_MTR_FUNC(port_id, create)(dev,
> - mtr_id, params, shared, error);
> + return RTE_MTR_FUNC_PTR(port_id, create)(dev, params, shared,
> error);
> }
>
> /** MTR object destroy */
> int
> rte_mtr_destroy(uint16_t port_id,
> - uint32_t mtr_id,
> + struct rte_mtr *mtr,
> struct rte_mtr_error *error)
> {
> struct rte_eth_dev *dev = &rte_eth_devices[port_id];
> return RTE_MTR_FUNC(port_id, destroy)(dev,
> - mtr_id, error);
> + mtr, error);
> }
>
> /** MTR object meter enable */
> int
> rte_mtr_meter_enable(uint16_t port_id,
> - uint32_t mtr_id,
> + struct rte_mtr *mtr,
> struct rte_mtr_error *error)
> {
> struct rte_eth_dev *dev = &rte_eth_devices[port_id];
> return RTE_MTR_FUNC(port_id, meter_enable)(dev,
> - mtr_id, error);
> + mtr, error);
> }
>
> /** MTR object meter disable */
> int
> rte_mtr_meter_disable(uint16_t port_id,
> - uint32_t mtr_id,
> + struct rte_mtr *mtr,
> struct rte_mtr_error *error)
> {
> struct rte_eth_dev *dev = &rte_eth_devices[port_id];
> return RTE_MTR_FUNC(port_id, meter_disable)(dev,
> - mtr_id, error);
> + mtr, error);
> }
>
> /** MTR object meter profile update */
> int
> rte_mtr_meter_profile_update(uint16_t port_id,
> - uint32_t mtr_id,
> - uint32_t meter_profile_id,
> + struct rte_mtr *mtr,
> + struct rte_mtr_profile *profile,
> struct rte_mtr_error *error)
> {
> struct rte_eth_dev *dev = &rte_eth_devices[port_id];
> return RTE_MTR_FUNC(port_id, meter_profile_update)(dev,
> - mtr_id, meter_profile_id, error);
> + mtr, profile, error);
> }
>
> /** MTR object meter policy update */
> int
> rte_mtr_meter_policy_update(uint16_t port_id,
> - uint32_t mtr_id,
> - uint32_t meter_policy_id,
> + struct rte_mtr *mtr,
> + struct rte_mtr_policy *policy,
> struct rte_mtr_error *error)
> {
> struct rte_eth_dev *dev = &rte_eth_devices[port_id];
> return RTE_MTR_FUNC(port_id, meter_policy_update)(dev,
> - mtr_id, meter_policy_id, error);
> + mtr, policy, error);
> }
>
> /** MTR object meter DSCP table update */
> int
> rte_mtr_meter_dscp_table_update(uint16_t port_id,
> - uint32_t mtr_id,
> + struct rte_mtr *mtr,
> enum rte_color *dscp_table,
> struct rte_mtr_error *error)
> {
> struct rte_eth_dev *dev = &rte_eth_devices[port_id];
> return RTE_MTR_FUNC(port_id, meter_dscp_table_update)(dev,
> - mtr_id, dscp_table, error);
> + mtr, dscp_table, error);
> }
>
> /** MTR object enabled stats update */
> int
> rte_mtr_stats_update(uint16_t port_id,
> - uint32_t mtr_id,
> + struct rte_mtr *mtr,
> uint64_t stats_mask,
> struct rte_mtr_error *error)
> {
> struct rte_eth_dev *dev = &rte_eth_devices[port_id];
> return RTE_MTR_FUNC(port_id, stats_update)(dev,
> - mtr_id, stats_mask, error);
> + mtr, stats_mask, error);
> }
>
> /** MTR object stats read */
> int
> rte_mtr_stats_read(uint16_t port_id,
> - uint32_t mtr_id,
> + struct rte_mtr *mtr,
> struct rte_mtr_stats *stats,
> uint64_t *stats_mask,
> int clear,
> @@ -230,5 +239,5 @@ rte_mtr_stats_read(uint16_t port_id,
> {
> struct rte_eth_dev *dev = &rte_eth_devices[port_id];
> return RTE_MTR_FUNC(port_id, stats_read)(dev,
> - mtr_id, stats, stats_mask, clear, error);
> + mtr, stats, stats_mask, clear, error);
> }
> diff --git a/lib/librte_ethdev/rte_mtr.h b/lib/librte_ethdev/rte_mtr.h
> index 07961f2777..2b20e55079 100644
> --- a/lib/librte_ethdev/rte_mtr.h
> +++ b/lib/librte_ethdev/rte_mtr.h
> @@ -181,8 +181,8 @@ struct rte_mtr_meter_profile {
> * @see enum rte_mtr_stats_type
> */
> struct rte_mtr_params {
> - /** Meter profile ID. */
> - uint32_t meter_profile_id;
> + /** Meter profile. */
> + struct rte_mtr_profile *profile;
>
> /** Meter input color in case of MTR object chaining. When non-
> zero: if
> * a previous MTR object is enabled in the same flow, then the color
> @@ -221,8 +221,8 @@ struct rte_mtr_params {
> */
> uint64_t stats_mask;
>
> - /** Meter policy ID. */
> - uint32_t meter_policy_id;
> + /** Meter policy. */
> + struct rte_mtr_policy *policy;
> };
>
> /**
> @@ -395,28 +395,32 @@ rte_mtr_capabilities_get(uint16_t port_id,
> struct rte_mtr_capabilities *cap,
> struct rte_mtr_error *error);
>
> +/**
> + * Opaque type returned after successfully creating a profile.
> + *
> + * This handle can be used to manage the related profile (e.g. to destroy it).
> + */
> +struct rte_mtr_profile;
> +
> /**
> * Meter profile add
> *
> - * Create a new meter profile with ID set to *meter_profile_id*. The new
> profile
> + * Create a new meter profile. The new profile
> * is used to create one or several MTR objects.
> *
> * @param[in] port_id
> * The port identifier of the Ethernet device.
> - * @param[in] meter_profile_id
> - * ID for the new meter profile. Needs to be unused by any of the existing
> - * meter profiles added for the current port.
> * @param[in] profile
> * Meter profile parameters. Needs to be pre-allocated and valid.
> * @param[out] error
> * Error details. Filled in only on error, when not NULL.
> * @return
> - * 0 on success, non-zero error code otherwise.
> + * A valid handle in case of success, NULL otherwise and rte_errno is set
> + * to the positive version of one of the error codes.
> */
> __rte_experimental
> -int
> +struct rte_mtr_profile *
> rte_mtr_meter_profile_add(uint16_t port_id,
> - uint32_t meter_profile_id,
> struct rte_mtr_meter_profile *profile,
> struct rte_mtr_error *error);
>
> @@ -428,8 +432,8 @@ rte_mtr_meter_profile_add(uint16_t port_id,
> *
> * @param[in] port_id
> * The port identifier of the Ethernet device.
> - * @param[in] meter_profile_id
> - * Meter profile ID. Needs to be the valid.
> + * @param[in] profile
> + * Meter profile pointer. Needs to be the valid.
> * @param[out] error
> * Error details. Filled in only on error, when not NULL.
> * @return
> @@ -438,16 +442,15 @@ rte_mtr_meter_profile_add(uint16_t port_id,
> __rte_experimental
> int
> rte_mtr_meter_profile_delete(uint16_t port_id,
> - uint32_t meter_profile_id,
> + struct rte_mtr_profile *profile,
> struct rte_mtr_error *error);
>
> /**
> - * Policy id 0 is default policy.
> - * Action per color as below:
> - * green - no action, yellow - no action, red - drop
> - * It can be used without creating it by the rte_mtr_meter_policy_add
> function.
> + * Opaque type returned after successfully creating a policy.
> + *
> + * This handle can be used to manage the related policy (e.g. to destroy it).
> */
> -#define RTE_MTR_DEFAULT_POLICY_ID 0
> +struct rte_mtr_policy;
>
> /**
> * Check whether a meter policy can be created on a given port.
> @@ -478,7 +481,6 @@ rte_mtr_meter_profile_delete(uint16_t port_id,
> __rte_experimental
> int
> rte_mtr_meter_policy_validate(uint16_t port_id,
> - uint32_t policy_id,
> const struct rte_flow_action *actions[RTE_COLORS],
> struct rte_mtr_error *error);
>
> @@ -490,8 +492,6 @@ rte_mtr_meter_policy_validate(uint16_t port_id,
> *
> * @param[in] port_id
> * The port identifier of the Ethernet device.
> - * @param[in] policy_id
> - * Policy identifier for the new meter policy.
> * @param[in] actions
> * Associated actions per color.
> * list NULL is legal and means no special action.
> @@ -499,12 +499,12 @@ rte_mtr_meter_policy_validate(uint16_t port_id,
> * @param[out] error
> * Error details. Filled in only on error, when not NULL.
> * @return
> - * 0 on success, non-zero error code otherwise.
> + * A valid handle in case of success, NULL otherwise and rte_errno is set
> + * to the positive version of one of the error codes.
> */
> __rte_experimental
> -int
> +struct rte_mtr_policy *
> rte_mtr_meter_policy_add(uint16_t port_id,
> - uint32_t policy_id,
> const struct rte_flow_action *actions[RTE_COLORS],
> struct rte_mtr_error *error);
>
> @@ -516,8 +516,8 @@ rte_mtr_meter_policy_add(uint16_t port_id,
> *
> * @param[in] port_id
> * The port identifier of the Ethernet device.
> - * @param[in] policy_id
> - * Policy identifier.
> + * @param[in] policy
> + * Policy pointer. Needs to be valid.
> * @param[out] error
> * Error details. Filled in only on error, when not NULL.
> * @return
> @@ -526,20 +526,28 @@ rte_mtr_meter_policy_add(uint16_t port_id,
> __rte_experimental
> int
> rte_mtr_meter_policy_delete(uint16_t port_id,
> - uint32_t policy_id,
> + struct rte_mtr_policy *policy,
> struct rte_mtr_error *error);
>
> +/**
> + * Opaque type returned after successfully creating a meter.
> + *
> + * This handle can be used to manage the related meter (e.g. to destroy it).
> + */
> +struct rte_mtr;
> +
> /**
> * MTR object create
> *
> * Create a new MTR object for the current port. This object is run as part of
> * associated flow action for traffic metering and policing.
> + * Policy pointer NULL is default policy.
> + * Action per color as below:
> + * green - no action, yellow - no action, red - drop
> + * It can be used without creating it by the rte_mtr_meter_policy_add
> function.
> *
> * @param[in] port_id
> * The port identifier of the Ethernet device.
> - * @param[in] mtr_id
> - * MTR object ID. Needs to be unused by any of the existing MTR objects.
> - * created for the current port.
> * @param[in] params
> * MTR object params. Needs to be pre-allocated and valid.
> * @param[in] shared
> @@ -548,14 +556,14 @@ rte_mtr_meter_policy_delete(uint16_t port_id,
> * @param[out] error
> * Error details. Filled in only on error, when not NULL.
> * @return
> - * 0 on success, non-zero error code otherwise.
> + * A valid handle in case of success, NULL otherwise and rte_errno is set
> + * to the positive version of one of the error codes.
> *
> * @see enum rte_flow_action_type::RTE_FLOW_ACTION_TYPE_METER
> */
> __rte_experimental
> -int
> +struct rte_mtr *
> rte_mtr_create(uint16_t port_id,
> - uint32_t mtr_id,
> struct rte_mtr_params *params,
> int shared,
> struct rte_mtr_error *error);
> @@ -568,8 +576,8 @@ rte_mtr_create(uint16_t port_id,
> *
> * @param[in] port_id
> * The port identifier of the Ethernet device.
> - * @param[in] mtr_id
> - * MTR object ID. Needs to be valid.
> + * @param[in] mtr
> + * MTR pointer. Needs to be valid.
> * created for the current port.
> * @param[out] error
> * Error details. Filled in only on error, when not NULL.
> @@ -579,7 +587,7 @@ rte_mtr_create(uint16_t port_id,
> __rte_experimental
> int
> rte_mtr_destroy(uint16_t port_id,
> - uint32_t mtr_id,
> + struct rte_mtr *mtr,
> struct rte_mtr_error *error);
>
> /**
> @@ -607,7 +615,7 @@ rte_mtr_destroy(uint16_t port_id,
> __rte_experimental
> int
> rte_mtr_meter_disable(uint16_t port_id,
> - uint32_t mtr_id,
> + struct rte_mtr *mtr,
> struct rte_mtr_error *error);
>
> /**
> @@ -629,7 +637,7 @@ rte_mtr_meter_disable(uint16_t port_id,
> __rte_experimental
> int
> rte_mtr_meter_enable(uint16_t port_id,
> - uint32_t mtr_id,
> + struct rte_mtr *mtr,
> struct rte_mtr_error *error);
>
> /**
> @@ -649,8 +657,8 @@ rte_mtr_meter_enable(uint16_t port_id,
> __rte_experimental
> int
> rte_mtr_meter_profile_update(uint16_t port_id,
> - uint32_t mtr_id,
> - uint32_t meter_profile_id,
> + struct rte_mtr *mtr,
> + struct rte_mtr_profile *profile,
> struct rte_mtr_error *error);
>
> /**
> @@ -660,8 +668,6 @@ rte_mtr_meter_profile_update(uint16_t port_id,
> * The port identifier of the Ethernet device.
> * @param[in] mtr_id
> * MTR object ID. Needs to be valid.
> - * @param[in] meter_policy_id
> - * Meter policy ID for the current MTR object. Needs to be valid.
> * @param[out] error
> * Error details. Filled in only on error, when not NULL.
> * @return
> @@ -670,8 +676,8 @@ rte_mtr_meter_profile_update(uint16_t port_id,
> __rte_experimental
> int
> rte_mtr_meter_policy_update(uint16_t port_id,
> - uint32_t mtr_id,
> - uint32_t meter_policy_id,
> + struct rte_mtr *mtr,
> + struct rte_mtr_policy *policy,
> struct rte_mtr_error *error);
>
> /**
> @@ -695,7 +701,7 @@ rte_mtr_meter_policy_update(uint16_t port_id,
> __rte_experimental
> int
> rte_mtr_meter_dscp_table_update(uint16_t port_id,
> - uint32_t mtr_id,
> + struct rte_mtr *mtr,
> enum rte_color *dscp_table,
> struct rte_mtr_error *error);
>
> @@ -720,7 +726,7 @@ rte_mtr_meter_dscp_table_update(uint16_t port_id,
> __rte_experimental
> int
> rte_mtr_stats_update(uint16_t port_id,
> - uint32_t mtr_id,
> + struct rte_mtr *mtr,
> uint64_t stats_mask,
> struct rte_mtr_error *error);
>
> @@ -752,7 +758,7 @@ rte_mtr_stats_update(uint16_t port_id,
> __rte_experimental
> int
> rte_mtr_stats_read(uint16_t port_id,
> - uint32_t mtr_id,
> + struct rte_mtr *mtr,
> struct rte_mtr_stats *stats,
> uint64_t *stats_mask,
> int clear,
> diff --git a/lib/librte_ethdev/rte_mtr_driver.h
> b/lib/librte_ethdev/rte_mtr_driver.h
> index 1ad8fb4c40..d7a8853b51 100644
> --- a/lib/librte_ethdev/rte_mtr_driver.h
> +++ b/lib/librte_ethdev/rte_mtr_driver.h
> @@ -30,82 +30,80 @@ typedef int (*rte_mtr_capabilities_get_t)(struct
> rte_eth_dev *dev,
> struct rte_mtr_error *error);
> /**< @internal MTR capabilities get */
>
> -typedef int (*rte_mtr_meter_profile_add_t)(struct rte_eth_dev *dev,
> - uint32_t meter_profile_id,
> +typedef struct rte_mtr_profile *(*rte_mtr_meter_profile_add_t)
> + (struct rte_eth_dev *dev,
> struct rte_mtr_meter_profile *profile,
> struct rte_mtr_error *error);
> /**< @internal MTR meter profile add */
>
> typedef int (*rte_mtr_meter_profile_delete_t)(struct rte_eth_dev *dev,
> - uint32_t meter_profile_id,
> + struct rte_mtr_profile *profile,
> struct rte_mtr_error *error);
> /**< @internal MTR meter profile delete */
>
> typedef int (*rte_mtr_meter_policy_validate_t)(struct rte_eth_dev *dev,
> - uint32_t policy_id,
> const struct rte_flow_action *actions[RTE_COLORS],
> struct rte_mtr_error *error);
> /**< @internal MTR meter policy validate */
>
> -typedef int (*rte_mtr_meter_policy_add_t)(struct rte_eth_dev *dev,
> - uint32_t policy_id,
> +typedef struct rte_mtr_policy *(*rte_mtr_meter_policy_add_t)
> + (struct rte_eth_dev *dev,
> const struct rte_flow_action *actions[RTE_COLORS],
> struct rte_mtr_error *error);
> /**< @internal MTR meter policy add */
>
> typedef int (*rte_mtr_meter_policy_delete_t)(struct rte_eth_dev *dev,
> - uint32_t policy_id,
> + struct rte_mtr_policy *policy,
> struct rte_mtr_error *error);
> /**< @internal MTR meter policy delete */
>
> -typedef int (*rte_mtr_create_t)(struct rte_eth_dev *dev,
> - uint32_t mtr_id,
> +typedef struct rte_mtr *(*rte_mtr_create_t)(struct rte_eth_dev *dev,
> struct rte_mtr_params *params,
> int shared,
> struct rte_mtr_error *error);
> /**< @internal MTR object create */
>
> typedef int (*rte_mtr_destroy_t)(struct rte_eth_dev *dev,
> - uint32_t mtr_id,
> + struct rte_mtr *mtr,
> struct rte_mtr_error *error);
> /**< @internal MTR object destroy */
>
> typedef int (*rte_mtr_meter_enable_t)(struct rte_eth_dev *dev,
> - uint32_t mtr_id,
> + struct rte_mtr *mtr,
> struct rte_mtr_error *error);
> /**< @internal MTR object meter enable */
>
> typedef int (*rte_mtr_meter_disable_t)(struct rte_eth_dev *dev,
> - uint32_t mtr_id,
> + struct rte_mtr *mtr,
> struct rte_mtr_error *error);
> /**< @internal MTR object meter disable */
>
> typedef int (*rte_mtr_meter_profile_update_t)(struct rte_eth_dev *dev,
> - uint32_t mtr_id,
> - uint32_t meter_profile_id,
> + struct rte_mtr *mtr,
> + struct rte_mtr_profile *profile,
> struct rte_mtr_error *error);
> /**< @internal MTR object meter profile update */
>
> typedef int (*rte_mtr_meter_policy_update_t)(struct rte_eth_dev *dev,
> - uint32_t mtr_id,
> - uint32_t meter_policy_id,
> + struct rte_mtr *mtr,
> + struct rte_mtr_policy *policy,
> struct rte_mtr_error *error);
> /**< @internal MTR object meter policy update */
>
> typedef int (*rte_mtr_meter_dscp_table_update_t)(struct rte_eth_dev
> *dev,
> - uint32_t mtr_id,
> + struct rte_mtr *mtr,
> enum rte_color *dscp_table,
> struct rte_mtr_error *error);
> /**< @internal MTR object meter DSCP table update */
>
> typedef int (*rte_mtr_stats_update_t)(struct rte_eth_dev *dev,
> - uint32_t mtr_id,
> + struct rte_mtr *mtr,
> uint64_t stats_mask,
> struct rte_mtr_error *error);
> /**< @internal MTR object enabled stats update */
>
> typedef int (*rte_mtr_stats_read_t)(struct rte_eth_dev *dev,
> - uint32_t mtr_id,
> + struct rte_mtr *mtr,
> struct rte_mtr_stats *stats,
> uint64_t *stats_mask,
> int clear,
> --
> 2.21.0
Regards,
Cristian
next prev parent reply other threads:[~2021-03-23 21:33 UTC|newest]
Thread overview: 78+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-18 8:58 [dpdk-dev] [PATCH 1/2] [RFC]: ethdev: add pre-defined meter policy API Li Zhang
2021-03-18 8:58 ` [dpdk-dev] [PATCH 2/2] [RFC]: ethdev: manage meter API object handles by the drivers Li Zhang
2021-03-23 21:33 ` Dumitrescu, Cristian [this message]
2021-03-25 8:21 ` Matan Azrad
2021-03-25 23:16 ` Ajit Khaparde
2021-03-29 19:56 ` Matan Azrad
2021-03-27 13:15 ` Jerin Jacob
2021-03-29 20:10 ` Matan Azrad
2021-03-31 10:22 ` Jerin Jacob
2021-03-23 21:02 ` [dpdk-dev] [PATCH 1/2] [RFC]: ethdev: add pre-defined meter policy API Dumitrescu, Cristian
2021-03-25 6:56 ` Matan Azrad
2021-03-29 9:23 ` Ori Kam
2021-03-29 16:24 ` Dumitrescu, Cristian
2021-04-01 13:13 ` Ori Kam
2021-04-01 13:35 ` Dumitrescu, Cristian
2021-04-01 14:22 ` Ori Kam
2021-03-29 16:08 ` Dumitrescu, Cristian
2021-03-29 20:43 ` Matan Azrad
2021-03-31 15:46 ` Dumitrescu, Cristian
2021-04-04 13:48 ` Matan Azrad
2021-03-29 10:38 ` Jerin Jacob
2021-03-29 20:31 ` Matan Azrad
2021-03-31 10:50 ` Jerin Jacob
2021-04-13 0:14 ` [dpdk-dev] [PATCH v3 0/2] Support " Li Zhang
2021-04-13 0:14 ` [dpdk-dev] [PATCH v3 1/2] ethdev: add pre-defined " Li Zhang
2021-04-13 14:19 ` Dumitrescu, Cristian
2021-04-14 3:23 ` Li Zhang
2021-04-13 14:59 ` Dumitrescu, Cristian
2021-04-14 4:55 ` Li Zhang
2021-04-14 8:02 ` Thomas Monjalon
2021-04-14 8:31 ` Matan Azrad
2021-04-14 8:47 ` Asaf Penso
2021-04-14 8:59 ` Li Zhang
2021-04-14 9:04 ` Thomas Monjalon
2021-04-14 14:00 ` Dumitrescu, Cristian
2021-04-14 16:21 ` Li Zhang
2021-04-13 16:25 ` Kinsella, Ray
2021-04-13 0:14 ` [dpdk-dev] [PATCH v3 2/2] app/testpmd: support policy actions per color Li Zhang
2021-04-14 3:12 ` [dpdk-dev] [PATCH v4 0/2] Support meter policy API Li Zhang
2021-04-14 3:12 ` [dpdk-dev] [PATCH v4 1/2] ethdev: add pre-defined " Li Zhang
2021-04-14 3:12 ` [dpdk-dev] [PATCH v4 2/2] app/testpmd: support policy actions per color Li Zhang
2021-04-14 6:32 ` [dpdk-dev] [PATCH v5 0/2] Support meter policy API Li Zhang
2021-04-14 6:32 ` [dpdk-dev] [PATCH v5 1/2] ethdev: add pre-defined " Li Zhang
2021-04-14 6:32 ` [dpdk-dev] [PATCH v5 2/2] app/testpmd: support policy actions per color Li Zhang
2021-04-14 8:57 ` [dpdk-dev] [PATCH v6 0/2] Support meter policy API Li Zhang
2021-04-14 8:57 ` [dpdk-dev] [PATCH v6 1/2] ethdev: add pre-defined " Li Zhang
2021-04-14 16:16 ` Dumitrescu, Cristian
2021-04-15 1:59 ` Li Zhang
2021-04-14 22:21 ` Singh, Jasvinder
2021-04-15 2:00 ` Li Zhang
2021-04-14 8:58 ` [dpdk-dev] [PATCH v6 2/2] app/testpmd: support policy actions per color Li Zhang
2021-04-15 4:54 ` [dpdk-dev] [PATCH v7 0/2] Support meter policy API Li Zhang
2021-04-15 4:54 ` [dpdk-dev] [PATCH v7 1/2] ethdev: add pre-defined " Li Zhang
2021-04-15 4:54 ` [dpdk-dev] [PATCH v7 2/2] app/testpmd: support policy actions per color Li Zhang
2021-04-15 9:20 ` [dpdk-dev] [PATCH v8 0/2] Support meter policy API Li Zhang
2021-04-15 9:20 ` [dpdk-dev] [PATCH v8 1/2] ethdev: add pre-defined " Li Zhang
2021-04-15 15:13 ` Ori Kam
2021-04-19 12:34 ` Singh, Jasvinder
2021-04-19 16:13 ` Jiawei(Jonny) Wang
2021-04-15 9:20 ` [dpdk-dev] [PATCH v8 2/2] app/testpmd: support policy actions per color Li Zhang
2021-04-19 16:08 ` [dpdk-dev] [PATCH v9 0/2] Support meter policy API Jiawei Wang
2021-04-19 16:08 ` [dpdk-dev] [PATCH v9 1/2] ethdev: add pre-defined " Jiawei Wang
2021-04-20 11:18 ` Dumitrescu, Cristian
2021-04-20 12:55 ` Asaf Penso
2021-04-20 21:01 ` Dumitrescu, Cristian
2021-04-19 16:08 ` [dpdk-dev] [PATCH v9 2/2] app/testpmd: support policy actions per color Jiawei Wang
2021-04-20 11:36 ` [dpdk-dev] [PATCH v9 0/2] Support meter policy API Ferruh Yigit
2021-04-20 14:08 ` Jiawei(Jonny) Wang
2021-04-20 14:04 ` [dpdk-dev] [PATCH v10 " Jiawei Wang
2021-04-20 14:04 ` [dpdk-dev] [PATCH v10 1/2] ethdev: add pre-defined " Jiawei Wang
2021-04-20 17:12 ` Ajit Khaparde
2021-04-21 19:43 ` Thomas Monjalon
2021-04-22 1:29 ` Li Zhang
2021-04-20 14:04 ` [dpdk-dev] [PATCH v10 2/2] app/testpmd: support policy actions per color Jiawei Wang
2021-04-20 17:14 ` Ajit Khaparde
2021-04-21 10:23 ` [dpdk-dev] [PATCH v10 0/2] Support meter policy API Ferruh Yigit
2021-04-20 17:56 ` [dpdk-dev] [PATCH 1/2] [RFC]: ethdev: add pre-defined " Stephen Hemminger
2021-04-21 2:49 ` Li Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR11MB279621F143546E694B27B957EB649@DM6PR11MB2796.namprd11.prod.outlook.com \
--to=cristian.dumitrescu@intel.com \
--cc=ajit.khaparde@broadcom.com \
--cc=andrew.rybchenko@oktetlabs.ru \
--cc=bruce.richardson@intel.com \
--cc=declan.doherty@intel.com \
--cc=dekelp@nvidia.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=hemant.agrawal@nxp.com \
--cc=jasvinder.singh@intel.com \
--cc=jerinjacobk@gmail.com \
--cc=lironh@marvell.com \
--cc=lizh@nvidia.com \
--cc=matan@nvidia.com \
--cc=orika@nvidia.com \
--cc=rasland@nvidia.com \
--cc=roniba@nvidia.com \
--cc=shahafs@nvidia.com \
--cc=thomas@monjalon.net \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).