From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 3BEB4A0A0A;
	Tue, 23 Mar 2021 19:56:42 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id C68194014F;
	Tue, 23 Mar 2021 19:56:41 +0100 (CET)
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by mails.dpdk.org (Postfix) with ESMTP id 07ED64014D
 for <dev@dpdk.org>; Tue, 23 Mar 2021 19:56:39 +0100 (CET)
IronPort-SDR: 9eUkuhxO8wi0L+4qkNyHH1YKA5ZTJvt/xYEglKAyRwmLZ1rJcmtJoUPS/Kjw7mdDp1bUVI0bP1
 sJp9ROuGflpQ==
X-IronPort-AV: E=McAfee;i="6000,8403,9932"; a="210633436"
X-IronPort-AV: E=Sophos;i="5.81,272,1610438400"; d="scan'208";a="210633436"
Received: from orsmga003.jf.intel.com ([10.7.209.27])
 by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 23 Mar 2021 11:56:38 -0700
IronPort-SDR: HPUk1J7O6p4g5l95R0tymu9HOXHL2kVJ9Uu7OGNv9oM//8gcMrSp0eVvB1lCXP8268O6PyIqoG
 e9LVm96ggiIg==
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.81,272,1610438400"; d="scan'208";a="374349931"
Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16])
 by orsmga003.jf.intel.com with ESMTP; 23 Mar 2021 11:56:37 -0700
Received: from orsmsx608.amr.corp.intel.com (10.22.229.21) by
 ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2106.2; Tue, 23 Mar 2021 11:56:37 -0700
Received: from orsmsx605.amr.corp.intel.com (10.22.229.18) by
 ORSMSX608.amr.corp.intel.com (10.22.229.21) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2106.2; Tue, 23 Mar 2021 11:56:36 -0700
Received: from orsedg603.ED.cps.intel.com (10.7.248.4) by
 orsmsx605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2
 via Frontend Transport; Tue, 23 Mar 2021 11:56:36 -0700
Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.105)
 by edgegateway.intel.com (134.134.137.100) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.1.2106.2; Tue, 23 Mar 2021 11:56:36 -0700
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=cls4zUZ1MCBKW6VDo4VChbDtLgWOudPYWt7Ej8IgpErKjPLgYlc1z0hxqokDAxdLslPMyQver8uL2cifyr2FN4oVWItawlULvcKjWwePEKMLMgE1Jiw6VQnEvN/FKZk9NHq05xesSoHeJdItIW6GpWTNQz0DITgSJlNFRgko+uFhNs2q2B6dIEqSTWN9q2JiQCVR4UERROJgGSQBkkHKXa2qUiu2JH+FE/eCXgzq3qgh+zZxRg1ORr7drmmQyWWQweNx04x6XUxlRD7pf77RhjPz/WWr73/Pc1ZfqBZ986lCX4+Qm1+qIxpfCO4fXmJ9e1OJOZE2/AkVxb30DCgLRA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; 
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=xNKbTyw7yJP4HxYGIMbX4ME4ABqhb3RUyQS/lQbu8aQ=;
 b=ZiygzZ6F0qiczmZfFcVkpSiMuxJW3TQJSF4ZVl8h5q6UssZ0b6rpJviA+zGsrOkZD9CWgH/aG29faXZqmiuFaGssdru2rtKIUp6XBLyhUt3eYk2fd9EgBo9B2Z2NuI4IdkgDuVZES3LvndeAkhNgydPwjwXSbdkqgop6cOIvhM/67r3G0av61e7e1c9gWcet/ar+EuENHnPu764TWAbH1DVjrO7Yi+SIjCuiCaKPfeeXwk6l5Y6JE6SlR6nawsld4Atvxw+YTK/r2sjrzhdR4hwnDNzuCy5u3MxmxxekuBIK51/cbwoV2bpgbFEW1IeUhw0RKpPdV0WDDYrmD3BxKw==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;
 dkim=pass header.d=intel.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; 
 s=selector2-intel-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=xNKbTyw7yJP4HxYGIMbX4ME4ABqhb3RUyQS/lQbu8aQ=;
 b=KFPlHSR7YIxbMAcYBjEecofM2xdwrFssxsQRkQx3f8s2BRF23Loz5bqwmnBpCDAJ/DbxMoXfydkAIK8UK2kcjQtyDJpA0BpFyH7MUXYuWIMo8BdNZrP+WWqVhX/CJdmWRao9NvkEYYEGPqv7B78QI8vliw1+mAB7up1N+mrFJYU=
Received: from DM6PR11MB2796.namprd11.prod.outlook.com (2603:10b6:5:c8::23) by
 DM4PR11MB5248.namprd11.prod.outlook.com (2603:10b6:5:38b::7) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.3955.18; Tue, 23 Mar 2021 18:56:35 +0000
Received: from DM6PR11MB2796.namprd11.prod.outlook.com
 ([fe80::b5d2:6f20:3c0:3627]) by DM6PR11MB2796.namprd11.prod.outlook.com
 ([fe80::b5d2:6f20:3c0:3627%7]) with mapi id 15.20.3955.027; Tue, 23 Mar 2021
 18:56:35 +0000
From: "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>, "P, Venkata Suresh Kumar"
 <venkata.suresh.kumar.p@intel.com>
CC: "dev@dpdk.org" <dev@dpdk.org>, "Khangar, Churchill"
 <churchill.khangar@intel.com>, "Jangra, Yogesh" <yogesh.jangra@intel.com>
Thread-Topic: [dpdk-dev] [PATCH] port: add file descriptor SWX port
Thread-Index: AQHXHLdHCjSRFf2gLEy6r5vkzL6GqqqRx+mAgAAdhoCAAAiqAIAAA7ag
Date: Tue, 23 Mar 2021 18:56:35 +0000
Message-ID: <DM6PR11MB2796B50854BB5737AD041F34EB649@DM6PR11MB2796.namprd11.prod.outlook.com>
References: <1616155326-2639-1-git-send-email-venkata.suresh.kumar.p@intel.com>
 <6532294.cV1ATAUDhe@thomas>
 <BYAPR11MB30774B50A6AA5E1CB0F3298799649@BYAPR11MB3077.namprd11.prod.outlook.com>
 <7787288.vlQI503CXK@thomas>
In-Reply-To: <7787288.vlQI503CXK@thomas>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
dlp-version: 11.5.1.3
dlp-reaction: no-action
dlp-product: dlpe-windows
authentication-results: monjalon.net; dkim=none (message not signed)
 header.d=none;monjalon.net; dmarc=none action=none header.from=intel.com;
x-originating-ip: [51.37.64.137]
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: b13b23f3-a1fc-4178-ebdc-08d8ee2d61c9
x-ms-traffictypediagnostic: DM4PR11MB5248:
x-ms-exchange-transport-forked: True
x-microsoft-antispam-prvs: <DM4PR11MB5248007F46A4E2F84916E559EB649@DM4PR11MB5248.namprd11.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:9508;
x-ms-exchange-senderadcheck: 1
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: gKrl1kn5YKkwhf6GRSKe0M2vc7r/bZ5SDwNzKq1oYOsjsaeoGMU8GmUvYv53vDK+LTILU8aMMLteLjSEyVIIdkkMAU0xDvgr/N/La0ttu8wQSJdcnGzXmHsLM4VIhAMhU5Sq0NJB5iogMX2gIKZdlMSM9MMoHRvT3hl1N6uFjBoJ/ERM077aD2pNH692uU7CmpVvlrJoeJ5tqdcqk38DsBjWazs63b0K0oGyHbqpeD2HOV6az3j0G5JQV4xS+qfrm2ocWuqATF0eQiybB1Dx523HZ8nRSXa1F99uCaIz3+dE4YLm23BwbC/V0jt/jef9E78JnYErDIS6MqpMrvrB3bRoQldgRuSfslFGqq7/Sxn8LAY1ySwFq6KxyI4PUNntGeFOQMOXlIlko3FCzea26XGkL0UA12ZnWIIW6kCa3GTps3mHU3DXfZ/MvF84wdRi+zG82+7NUT5OkGpyQgT4h6GSCD0eZrATIyY2cqE1aiUWs3GXfPmV2Zr/O3ZG1WYdZaTdT/lsNXEym70Qrl3BC1ddla216bxGcqk/In+9G+kieOw7fQTm3EITkdcUZxCIVwio5NAbBZ/usuwk8g7RCQr+BDkoB/yPrK4Mf46S8Lp7cIqp6aN2Sz9Qt+08aJdisql4Dry3PfHNGn6OYEmzEP6bHPjpt8t0qaQFPCz8FVE=
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
 IPV:NLI; SFV:NSPM; H:DM6PR11MB2796.namprd11.prod.outlook.com; PTR:; CAT:NONE;
 SFS:(376002)(346002)(396003)(136003)(366004)(39860400002)(76116006)(66476007)(66446008)(54906003)(71200400001)(107886003)(52536014)(8676002)(66556008)(6506007)(64756008)(66946007)(186003)(86362001)(33656002)(110136005)(53546011)(26005)(2906002)(316002)(8936002)(38100700001)(7696005)(6636002)(5660300002)(83380400001)(55016002)(478600001)(4326008)(9686003);
 DIR:OUT; SFP:1102; 
x-ms-exchange-antispam-messagedata: =?us-ascii?Q?5rqj53HqxPe4BXzaIS+F2hVBfCuypVW/+xrOmtOwQdhZDVMS7WkqZz1yiD59?=
 =?us-ascii?Q?vBle1ZdCkVPe9G7n5bfSTIcV+H4kKTLVB3rbTEUa0InCh9R/X25eybp4cuZk?=
 =?us-ascii?Q?soA+de/J8QrA+KxOZVnl3KLWovtGmf1MLDimANzVmeH7iKAPL5DHjdVp7/5d?=
 =?us-ascii?Q?CWQwkrVDiJOn4m7apikgXnylDr0sSg3gJxFol9XURquWjtC8eFBQiGeCdI5G?=
 =?us-ascii?Q?GwhlrlHDu5HmAUfSWx+i3wsTxdvT3NuqvkCd4oredozOGpTFltROFkb36quG?=
 =?us-ascii?Q?xCM9oEaEPqhns8NIteg6aDadhZ2iEqi1QsyOPPI4wpGh73QLKvFUL/kaJ7i+?=
 =?us-ascii?Q?cyDWY++MLDKZA8alYY4GhIR5WO5Z3kV7M9AZX2pFYeWvm3Er5Mw9WBnO20Zq?=
 =?us-ascii?Q?owLgFHQBaM8aMZFYT5uIZAk4MQ/qhR0DfCXI+nRqDZ4PkP5bbt9y4JP2tEVi?=
 =?us-ascii?Q?+88NGdlyQr25QJFUteBF0jW93qwyBBxzB4sViJHK58TO5/hBWdo8f97WGemd?=
 =?us-ascii?Q?n/+H/LBE3FKQLynYLCZi6KF7aDKrSBce6hu5rIDG+htboKv8dqb983EUgysb?=
 =?us-ascii?Q?IKW6CXsnZCT/L1MAX68WZPgtO1rM76E3PrakmnARkyWueyf8CSOj7gXnivK9?=
 =?us-ascii?Q?rVCDvC7sX8o90FkRCImOE/BCDiax1iwu4CRn9KZP3IOVEZYqwT3frpPQH05A?=
 =?us-ascii?Q?CZa3FU6k/tZbYnBBRXwJ3muL+/7pkEhK6ZRuKz/RxxA3b7jF4wrsIv4mCTIh?=
 =?us-ascii?Q?T6AOa7mPYb4mM6t5jBDSaz1mm5xyTAIHOqTyYFuZIlmsqX6Eoe2g/h7j1kC9?=
 =?us-ascii?Q?6Q6j7RQHlvJuQ8fTZfvjMcwZVoXGfM5gch00uCAGdHOOfuPH2lbDHicpUsOG?=
 =?us-ascii?Q?M87tpfiTPKVF7qb96Pf/NkTIG4Bbx1meDq4rlsn5duxl5UjI4N72QCIFhru2?=
 =?us-ascii?Q?f0ZhdADB0fIigK3HlP2IuWqoY3L0x7yGPJT7AMauSceVYo3j3l8BQ7pqvHad?=
 =?us-ascii?Q?2xtVIKP5dlYoXlvS8Icn2FwL+p1okQbglkyqmEZPdo7bBynMYhLnqaMoBrFV?=
 =?us-ascii?Q?6YStREv+selP3VupS5rbpGU5f2doFXurrYGMRYFpnq22JlBUxN1wCWvsQY7q?=
 =?us-ascii?Q?gnHU3qFv1JzzMIVJuOwmhsnPE3hEQ76HU3vlhohjOIFpN+LgpZzjYqPAjtf6?=
 =?us-ascii?Q?zsyK/HO4cMJ8xEw7nzrlMSjGCgPtdOoL5hicIlLJYku15TiYx97GfVTnxRnq?=
 =?us-ascii?Q?JTBARa0Swdl8VQWrElnfAzJPVlyosu96S+sCWzKIAasYIDRbYMvh9UTGeNgt?=
 =?us-ascii?Q?c8U=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB2796.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b13b23f3-a1fc-4178-ebdc-08d8ee2d61c9
X-MS-Exchange-CrossTenant-originalarrivaltime: 23 Mar 2021 18:56:35.3557 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Mqo4W+8AZ5Tu5tNWqA0ROOBnirhb3ra+mI4kaor2InJtSv5qTizR5oa429IeJtEpsL25YmdsYS6t3NoVclhsnJw/P3Nz7mUSaRoJnWt9av0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5248
X-OriginatorOrg: intel.com
Subject: Re: [dpdk-dev] [PATCH] port: add file descriptor SWX port
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>



> -----Original Message-----
> From: Thomas Monjalon <thomas@monjalon.net>
> Sent: Tuesday, March 23, 2021 6:39 PM
> To: P, Venkata Suresh Kumar <venkata.suresh.kumar.p@intel.com>;
> Dumitrescu, Cristian <cristian.dumitrescu@intel.com>
> Cc: dev@dpdk.org; Khangar, Churchill <churchill.khangar@intel.com>; Jangr=
a,
> Yogesh <yogesh.jangra@intel.com>
> Subject: Re: [dpdk-dev] [PATCH] port: add file descriptor SWX port
>=20
> 23/03/2021 19:07, P, Venkata Suresh Kumar:
> > Thanks a lot for reviewing the code and providing your comments.
> >
> > I have addressed below comments in V2 patch.
>=20
> OK thanks.
>=20
> What about the question about rte_trace?
> Opinions?
>=20

Hi Thomas,

All rte_swx_port ports are currently following this pattern, so it makes se=
nse to have this one do the same for now.

I am not that familiar with the (relatively new) rte_trace mechanism, so I =
am not sure if it has any run-time performance (I am assuming that it doesn=
't). We will take the AR to take a look at rte_trace and come back with a p=
atch to convert traces for all ports to rte_trace, most likely in the 21.05=
 time frame. Is this OK for you?

Regards,
Cristian

>=20
>=20
> > From: Thomas Monjalon <thomas@monjalon.net>
> > 19/03/2021 13:02, Venkata Suresh Kumar P:
> > > Add the file descriptor input/output port type for the SWX pipeline.
> >
> > I think it deserves a bit more explanation about what is FD I/O port. -=
-
> [Suresh] - Addressed in V2 patch
> >
> > >  /*
> > > + * tap
> > > + */
> > > +#define TAP_DEV                                            "/dev/net=
/tun"
> >
> > Spaces are free :) -- [Suresh] - Addressed in V2 patch
> >
> >
> > > +#ifndef TRACE_LEVEL
> > > +#define TRACE_LEVEL 0
> > > +#endif
> > > +
> > > +#if TRACE_LEVEL
> > > +#define TRACE(...) printf(__VA_ARGS__) #else #define TRACE(...)
> > > +#endif
> >
> > Would you consider rte_trace?
> >
> > > --- /dev/null
> > > +++ b/lib/librte_port/rte_swx_port_fd.h
> > > @@ -0,0 +1,57 @@
> > > +/* SPDX-License-Identifier: BSD-3-Clause
> > > + * Copyright(c) 2016 Intel Corporation
> >
> > I guess you did not create it in 2016. -- [Suresh] - Addressed in V2 pa=
tch
> >
> > > + */
> > > +
> > > +#ifndef __INCLUDE_RTE_SWX_PORT_FD_H__ #define
> > > +__INCLUDE_RTE_SWX_PORT_FD_H__
> > > +
> > > +#ifdef __cplusplus
> > > +extern "C" {
> > > +#endif
> > > +
> > > +/**
> > > + * @file
> > > + * RTE SWX FD Input and Output Ports
> > > + *
> > > + ***/
> >
> > Useless blank line. -- [Suresh] - Addressed in V2 patch
> >
> > [...]
> > > +
> > > +#ifdef __cplusplus
> > > +}
> > > +#endif
> > > +
> > > +#endif
> >
> > A comment after such a far #endif is better: -- [Suresh] - Addressed in=
 V2
> patch
> > 	/* __INCLUDE_RTE_SWX_PORT_FD_H__ */
> >
> > > --- a/lib/librte_port/version.map
> > > +++ b/lib/librte_port/version.map
> > > @@ -48,4 +48,6 @@ EXPERIMENTAL {
> > >         #added in 21.02
> >
> > In 21.05
> >
> > >         rte_swx_port_ring_reader_ops;
> > >         rte_swx_port_ring_writer_ops;
> > > +       rte_swx_port_fd_reader_ops;
> > > +       rte_swx_port_fd_writer_ops;
> >
> > Please sort in alphabetical order. -- [Suresh] - Addressed in V2 patch
>=20
>=20
>=20