From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 97DDFA0A0F; Wed, 7 Apr 2021 22:13:25 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 12C73140F2E; Wed, 7 Apr 2021 22:13:25 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id D618E140F29 for ; Wed, 7 Apr 2021 22:13:23 +0200 (CEST) IronPort-SDR: 3C6YV27iTV7+nupfkOZjwmmWHD4idsktUuJg98824Wai0xMXsf2wJKbvvcPmpncpKEFAfosltq fNIKKDeHnPSg== X-IronPort-AV: E=McAfee;i="6000,8403,9947"; a="278654333" X-IronPort-AV: E=Sophos;i="5.82,203,1613462400"; d="scan'208";a="278654333" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 07 Apr 2021 13:13:22 -0700 IronPort-SDR: aqS2dwxQ6eTzB5O3yahFtdJYwEjlem/ZZvVcFGE0EjyiTx/Wu2S1u3ucJiz8ggqF1AFmeqzq9H VNcwEQiM1ITg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,203,1613462400"; d="scan'208";a="519565108" Received: from fmsmsx603.amr.corp.intel.com ([10.18.126.83]) by fmsmga001.fm.intel.com with ESMTP; 07 Apr 2021 13:13:22 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Wed, 7 Apr 2021 13:13:22 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Wed, 7 Apr 2021 13:13:21 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Wed, 7 Apr 2021 13:13:21 -0700 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.176) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Wed, 7 Apr 2021 13:13:21 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Y4reWx5TuCgJk+JGfEa6Ynlx+0PC79zfOduRiEmPm2bNZq+BSPHikSF90eHaQmcH6xovd5jgnucDltAghNsiLWhlldni4z4vNBXjlQ0B9pDdYbQqQqIWjFZMW48Rl3DqxwkTx/g3og3ctNn0z4x5HEGoxcNX076Q1qxwAKj+Xd/B7MQqlfyIwYw3zR2f7D9NivKTc0+wx87PRlJZdUeuolzr6R/FjwovvpgEC7twvVXKjVDO4vO3ytZqWFt3WGQYGYFMuhgQqeX90Bnn05P0dfHI7KwENxRm6Izry+7+Kz5eRQ9T4aVn6V06rZuvIJP7u1msCmju3vxVEC0Jn/i1Jg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dYTIIe9sRCvfWXHtZBHeYq7vtPYJRNAUWLqPPN4ANug=; b=iHZNqIFYkGTNdgvSwoiQsI/4oXeS8Pra7ZKU9QcppivRG26BDGrbBrmQxg0NEVNvqddklCXtQILM4TvM7pZrmoWw9d3FJXYTBPo+sP5apaSTDlanUWxg5i6IooyZDLWJ+ggbGr86UZOyAVre12V7TRvqNWvIGIuHm9Kua9zMFJf6MMZhHwP+vWR6qThgL6/XxxxoP1r5g52vXwI4AJqZQnOIIaDC+VNiJM3w0Rgya6EfxLkg/aX1v0pc+jQYu/7sQdCz9n1ZfqxCbLUVdc6xHUQtU1AkgpR0PaLrQB6Vqgyq4QzKk29avVELC/Aik95n7cWZn9EsU+i1rmNtiUfhEQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dYTIIe9sRCvfWXHtZBHeYq7vtPYJRNAUWLqPPN4ANug=; b=aHHKtxTeo+AFQaZO4e6QEoCV7zqdQ2ReEx5fS+qGJz8yofQGXlKPS6J2VdN1MDpbi4t41CBBktuFNfJta0vnOe4SXms6X36JcUuy1M84SPBdvjOojYBohDs1wHbEGWEt5MQCCNTc3ICuXbjInfct9fnehFh2xb6pTG4MLK2Gqao= Received: from DM6PR11MB2796.namprd11.prod.outlook.com (2603:10b6:5:c8::23) by DM5PR11MB1740.namprd11.prod.outlook.com (2603:10b6:3:112::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3999.28; Wed, 7 Apr 2021 20:13:20 +0000 Received: from DM6PR11MB2796.namprd11.prod.outlook.com ([fe80::b5d2:6f20:3c0:3627]) by DM6PR11MB2796.namprd11.prod.outlook.com ([fe80::b5d2:6f20:3c0:3627%7]) with mapi id 15.20.3999.032; Wed, 7 Apr 2021 20:13:20 +0000 From: "Dumitrescu, Cristian" To: Li Zhang , "dekelp@nvidia.com" , "orika@nvidia.com" , "viacheslavo@nvidia.com" , "matan@nvidia.com" , "shahafs@nvidia.com" , "lironh@marvell.com" , "Singh, Jasvinder" CC: "dev@dpdk.org" , "thomas@monjalon.net" , "rasland@nvidia.com" , "roniba@nvidia.com" Thread-Topic: [PATCH 1/2] net/softnic: check meter packet mode Thread-Index: AQHXJr6XDuk08lxvyE67ekOqPdGjSqqphxwg Date: Wed, 7 Apr 2021 20:13:20 +0000 Message-ID: References: <20210401061618.1478961-1-lizh@nvidia.com> <20210401061618.1478961-2-lizh@nvidia.com> In-Reply-To: <20210401061618.1478961-2-lizh@nvidia.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [109.79.23.215] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 9ad67965-5455-47e9-535e-08d8fa0196eb x-ms-traffictypediagnostic: DM5PR11MB1740: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1468; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: PnJXLcMZZnj7qzTjvPX0Sx3wjW0uSaPEVsFo1lwdWWyDE6HCpR3RP758blL0Rx1UxiolthHFIBEGp3jj805LqMhMuypkJPH4rfwvZahOsM6VXf9vjA0P6YLfWWJM+uTKe1nPjrRaAEZVvkW1uQFK6SOMeskAiy/iba7bNYTBUHbeUv5GLqqGdpGP3I2GhF+oHuJ/b42moPHPYIOq08D6EEIF/IUVYi8ubvJ2rbhgfoQ+Ktl6S6rvteX930Bg/DQwrupTCIGGkx5anSm9azzbPDmAY5SqdL/abcTsNC/PLOaQcjr0tj8dCORWdWhWeLWT/13ciqjLceNS1bwid7aWP6pXRAgVd8a1/EfJAnvFbvOVCu0gzeckNwX+nGRMBqseGuo97R8hpUSt4ZHDWkHFn2c+whoI6KhptbwQTNAGuSYVCqqa4Io4QfPMDTWzNIr2yrrcRjSz5uG+1JBrhdYxnMisBGDEsv+ava+0MmiZ6x+9V88aztbvO/3yHn8rmk6zlXUjugvEyxP1SevokT3h3ilCwmqE3yEWjrW3mgkfBKwZi6/HEMOPoA6IHAxPZlANP6H/+3M8l6/OvjIfrQHLlTR0AmMlU/m9R85RKorpJ2xNW3LqnzPeXC7qCRxJe+iRNjsTJHw0yO9obJoU3jpKDi/MQtT8s7397J6x9Jp43HY= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB2796.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(136003)(396003)(346002)(366004)(376002)(39860400002)(9686003)(6636002)(110136005)(71200400001)(54906003)(4326008)(7416002)(26005)(38100700001)(6506007)(66476007)(66556008)(66946007)(316002)(64756008)(8936002)(66446008)(83380400001)(76116006)(2906002)(5660300002)(7696005)(53546011)(186003)(8676002)(52536014)(86362001)(478600001)(33656002)(55016002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?hZy5BFs/Y6eCcDG4fZObpKYErWJX1ujGj1TN+5BDLJEIlTDewNyOksJua7tw?= =?us-ascii?Q?Euc/0N47hQhmDgNSjKRrm1f8y4KgWaTHKYjvXRVodOTVfp5MbxSkqh8QDc1D?= =?us-ascii?Q?Bz+0fRS6Y4rQ0Yagl6MnIzdYuS+RriyADU2CQFoVVUDaboB3o9diqH5bQ2Vt?= =?us-ascii?Q?aGOJY7ywBJreXLMm2EHEEA7zLkDqwdWNmeE07s6d32hGjApUaJB8I6nLcT6x?= =?us-ascii?Q?eG8u5MHmqBQDwwa92RwJZbsuEmvLRZE7/1DrPE9Ss11DxlgzWKENDO0Jaqvh?= =?us-ascii?Q?G/kHMKTkQLeMdGVv/h9U2KVvpUhU+Af2N4NM195Nc3EMw5Ln/5cdPOBOhqgi?= =?us-ascii?Q?LcUDqHWr7i7tltrJbLp4xF3MZGmoMKRvxQ7igI+O1B/SzNMksnZVqP376glg?= =?us-ascii?Q?0gi0itll6aolxi0P2cUalKF6ezvLb0YkU1MtimhUp/q5rUKc8YsGHCq5gJtg?= =?us-ascii?Q?HEaU/P/K9JE+k03/feDtTh8Mn1Y6tfscIg766j1YUmud5uo3Z60aII34i+Ef?= =?us-ascii?Q?63IS20oQ8WNifA7+itp8Xzv0KulpSijziCeBGr1rPPRS7rsfa/BhvtGYXc/L?= =?us-ascii?Q?4qNYZPyaA44Bi+kEv3j+mGajQWqXqeLBzGU0NYvUL7hUgleUzByLsKjwvpB0?= =?us-ascii?Q?ESUfCdFLrGxW7xbkJIaKGtcnX6cUMBBo/ZXVcfE16B7TQ2Jg+qGTuCMX7J+6?= =?us-ascii?Q?xlZHhXcCeN80DoX5veDO8aLMH7a8RLJblDofoXZ/sA8K5r3HsT0+m9U0a7xp?= =?us-ascii?Q?lkHiEjMLgGGHD9iV4amBWyXwlktLOy7UUayrkMIpDuM8BLIq5bbpMIunTFnC?= =?us-ascii?Q?scnCIkTYgBVaF82EDqWQnGSan9LBM1O9nkWrqHDSymVD7BGzpOun7x2bNaWv?= =?us-ascii?Q?h1EmIfSqyPr7ms/rnNxruOn6uroY/vs6UDy5/tVGQnnQmL71LIgr39a7bohj?= =?us-ascii?Q?9sdunFaABF46wpWsFv4HQSzZaHsM5LubNZdZPWEcyxLvsd37O86pS4TlnUCd?= =?us-ascii?Q?BHLe5y9z8xs21oehRHSKAjLROLRpC9PO+YkF0yNh1fo3vVm8ozPXecW+cbri?= =?us-ascii?Q?PvA+fdOrAD90eY5huvdz5a0SLrNC5snGMTLQWwIV3ot93YX/T0LyAtSHmrfn?= =?us-ascii?Q?WwG2wLhXvzqrAHXJKp9Nd4irl+asSYP9G44iHkxOBjDXAjq5Kk5rQInQnfoh?= =?us-ascii?Q?m0dllQc3AApj63L4YQZlTCa5sxsSNwkvnbs5/2WSfnz1UDP7GQmg5l6FLwL2?= =?us-ascii?Q?3sUeJyVMWqNk+OHvNINtVlUBENIzPGY/JsBZb2xi2INCRcp1vhOsxsvTDnfB?= =?us-ascii?Q?p81tnrNM8JHXwz7YDOwqAKeF?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB2796.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9ad67965-5455-47e9-535e-08d8fa0196eb X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Apr 2021 20:13:20.5461 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: f2zkwJX+qf8RFtxUUQyIJmOiUwyR2dmf9gaN4b8t7VLRaoxER8+/pBOXctp+eZa/3/9L/hPg+ubpplXMhbsmweov3s6MlBbga9AP6C0uZnI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR11MB1740 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH 1/2] net/softnic: check meter packet mode X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Li Zhang > Sent: Thursday, April 1, 2021 7:16 AM > To: dekelp@nvidia.com; orika@nvidia.com; viacheslavo@nvidia.com; > matan@nvidia.com; shahafs@nvidia.com; Dumitrescu, Cristian > ; lironh@marvell.com; Singh, Jasvinder > > Cc: dev@dpdk.org; thomas@monjalon.net; rasland@nvidia.com; > roniba@nvidia.com > Subject: [PATCH 1/2] net/softnic: check meter packet mode >=20 > Currently meter algorithms only supports bytes per second(BPS). > Check packet_mode set to TRUE are rejected. >=20 > Signed-off-by: Li Zhang > --- > drivers/net/softnic/rte_eth_softnic_meter.c | 8 ++++++++ > 1 file changed, 8 insertions(+) >=20 > diff --git a/drivers/net/softnic/rte_eth_softnic_meter.c > b/drivers/net/softnic/rte_eth_softnic_meter.c > index 0cbf94e8b0..50db74f52f 100644 > --- a/drivers/net/softnic/rte_eth_softnic_meter.c > +++ b/drivers/net/softnic/rte_eth_softnic_meter.c > @@ -128,6 +128,14 @@ meter_profile_check(struct rte_eth_dev *dev, > NULL, > "Metering alg not supported"); >=20 > + /* Not support packet mode, just support byte mode. */ > + if (profile->packet_mode) > + return -rte_mtr_error_set(error, > + EINVAL, > + RTE_MTR_ERROR_TYPE_METER_PROFILE, Can you please add a new error type for this specific error case, i.e. RTE_= MTR_ERROR_TYPE_METER_PROFILE_PACKET_MODE. > + NULL, > + "Meter packet mode not supported"); > + > return 0; > } >=20 > -- > 2.27.0