From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 105F2A0524; Tue, 20 Apr 2021 12:04:57 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DAD66412B0; Tue, 20 Apr 2021 12:04:56 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id 159F8411A5 for <dev@dpdk.org>; Tue, 20 Apr 2021 12:04:54 +0200 (CEST) IronPort-SDR: ekaq/rscLiJtK4mBuVsga9r0VHAb0v0BM/7sIGHTXu+WS2+542Z3KUS/LN2z1jvgtA+o2AlTQ7 +qJevhLfVoxA== X-IronPort-AV: E=McAfee;i="6200,9189,9959"; a="192292369" X-IronPort-AV: E=Sophos;i="5.82,236,1613462400"; d="scan'208";a="192292369" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Apr 2021 03:04:51 -0700 IronPort-SDR: DTly0B0NOe0rPbG/VuGNWljr3wr6djGDP+3bemnnSAjnXvirONEuLDEkHcs4CoGPRkq7USQo3s yKd5tDwxbfvw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,236,1613462400"; d="scan'208";a="463062713" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by orsmga001.jf.intel.com with ESMTP; 20 Apr 2021 03:04:50 -0700 Received: from fmsmsx606.amr.corp.intel.com (10.18.126.86) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Tue, 20 Apr 2021 03:04:50 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Tue, 20 Apr 2021 03:04:50 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.169) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Tue, 20 Apr 2021 03:04:49 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=AkdrIJMIXI7AQKtJsnX0Dvqgq9Iq5umDvHiLFjJAL4Rwx9p3FDORq8HTfLdYIUkKtfBaSyMgoTIjqZ26oqgIDELmFsgplDZtq39HB/sCVJfVMxSeIY5LEBpjpa40qua8x+H6EJuzihsIi2BQVvoeZZyJMPPQa4Qdyx9s6PH0oAKPg4zaRAU97zDx/fc02+A4rj/PqLqgST6fvSxKLjrpPxP5oata02M7l0sts7isTZMOabpGfJ41cYENMtq8sxA6znGrSLi6JZdHx0XY9kJiw4bfqIV7/rIafQeDBZ6Z3XCYKB20DNQeWc5Pi/cjmiU5BtP96q1cwccQyXJyIi13Ug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wLMs5YijlwFCZXTRX5oFP/vMMAuxwOrPgPgo2zGXmjI=; b=Q1pehpwHZLSEwg7yBHi8xMx/LinjVEnMIu/kUMH6T3OcoyJ8HJ4Keo8+dB818GK0uE7nfvzXCcfU6UPRtvXbtrYhxnC25iOZZcFrwHuYVwXNbUM6iFSjx+ag5Chyl9XJH+64xX87XH3mVURYbQU/xvXIdYpCk+umEo5OuvhdT/0z9M+aWl3qQOk20j8w5QpTNbN0KSBOK6OPj3jwTI4DhRivi0Y6DlcibiFRbj/CQtVOrbtl8wkSHXHYabZBc0Fa/9o82c3eo7ikef5Vqnsd5SJh3Uo/DegzbDitPXbHgpBJJj02YQF2m+QV+lBM6E+QTfi/OrTw2CAFKp8gH8SHxg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=wLMs5YijlwFCZXTRX5oFP/vMMAuxwOrPgPgo2zGXmjI=; b=TsaAQj3YkO9j5bJf+aqDKUxY/u4bSd3MEeWtf4KWzhOWUeNEF1Xe4plT2tRrTBlXlPatHa34L723QaBn8iBtHvmvI9zrl6QBAlDevk/CH0PsH9mjOSl0XnmQI+vidheQn43BAYFWo49xq9piqhmnLjOLip0zqPoTYOOAXvMr27Y= Received: from DM6PR11MB2796.namprd11.prod.outlook.com (2603:10b6:5:c8::23) by DM4PR11MB5504.namprd11.prod.outlook.com (2603:10b6:5:39d::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4042.19; Tue, 20 Apr 2021 10:04:48 +0000 Received: from DM6PR11MB2796.namprd11.prod.outlook.com ([fe80::d099:834d:f5ad:39c9]) by DM6PR11MB2796.namprd11.prod.outlook.com ([fe80::d099:834d:f5ad:39c9%3]) with mapi id 15.20.4042.024; Tue, 20 Apr 2021 10:04:48 +0000 From: "Dumitrescu, Cristian" <cristian.dumitrescu@intel.com> To: Thomas Monjalon <thomas@monjalon.net> CC: "dev@dpdk.org" <dev@dpdk.org> Thread-Topic: [dpdk-dev] [PATCH 2/2] pipeline: autodetect endianness of action args Thread-Index: AQHXLyneEQreL0SXuESXCf4XuBA+W6q8n0sAgACaFYA= Date: Tue, 20 Apr 2021 10:04:48 +0000 Message-ID: <DM6PR11MB2796CCD79ED36B937C157D3DEB489@DM6PR11MB2796.namprd11.prod.outlook.com> References: <20210411232338.4005-1-cristian.dumitrescu@intel.com> <20210411232338.4005-2-cristian.dumitrescu@intel.com> <1799475.riq6yjk0ZW@thomas> In-Reply-To: <1799475.riq6yjk0ZW@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=intel.com; x-originating-ip: [51.37.10.125] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 14c20ea5-de64-47c0-46d4-08d903e3bb9b x-ms-traffictypediagnostic: DM4PR11MB5504: x-microsoft-antispam-prvs: <DM4PR11MB550410B75511DD078B2DE647EB489@DM4PR11MB5504.namprd11.prod.outlook.com> x-ms-oob-tlc-oobclassifiers: OLM:849; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: wcoIAPLVtTNAT4lLubZDFF21/NMEV9MgZVsBb/b6OMbzyFgWJPzQW7SX4FdVWNxcL55TrhA5OFZtSzMmDFBQImNzkiqXGuZVtMtR/fWqqC5vkO01zrjGwU+xTmuSOr32Dc+jVJwSNTcQvVu2xwXgJ59P8sIMpLP73sDQ7unNLX+6f1Qa4TE9jhBRc/dSiKwcu+kYPItXK2g8p17xsmut5OcrDqpZJPe7MEdikfY0wul5Sf4gD2FZEL2BFB21QscpvlnVhxeNBGbxMD5EeSRwAgQ/wqlclVzpJJUziLi/zr7OCcTHg7meAfdhfcZsryXJZeQO51raKLnQjePHyoQSsQH0Ad7w37Fs/EESno8c6uY9P1RQGH7F2Pi9m22NvSuLnmZ0HF8fhV7Hv9/hz6evtpRopQhW/ih/nsm059NSlZvtHg/UmU/5QIPlyeigT1+U+D3734pSuwvWslMlNQ3DYai3Gc4M/SgZtkwNJhQp5GOrx40dKkYUPDrTgGDv68XFC3oVt+0k4MXJpBezN4y2zN2GZoYqm5TtONaKGcjPiVURLvhzvBLUpsq+GOJETXFE4EM/3dJ5LADmyIJapfIhE1jcrKkX+bEEze7O/ySfszJDRAf7iJH1xT2NfckIWk0CidvxG1k7xGNkKk7ehNZkve5imwvTRTRZdJKV9uS+p9e36PXnTDHPbbDDo0zXdbod x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB2796.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(396003)(346002)(366004)(136003)(39850400004)(376002)(76116006)(8676002)(122000001)(966005)(6506007)(33656002)(38100700002)(8936002)(86362001)(478600001)(2906002)(7696005)(6916009)(53546011)(71200400001)(55016002)(26005)(316002)(9686003)(186003)(4326008)(66556008)(66946007)(66446008)(66476007)(64756008)(52536014)(83380400001)(5660300002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?ydqRkVQLmE5dO/a7hMiIW8WRk3vpcZf6TBi7TYnWo4zXymMToelswp1WemJW?= =?us-ascii?Q?ek4zlhXcj1cgChP1qhxZmMfTbXWJUxbRFZjo7FyLukwXLJxa+SGRWRwrDPFn?= =?us-ascii?Q?YDJTbNIMd2ve1AVH/wbe95H8OXnptr30TZES2H70hhhfdIuQdOJsIujTuR8f?= =?us-ascii?Q?x3dLZtVeIEBtn/vaim8TRU0ujr38J3az6FR3z7r7wmpfTR2ABgH5VXwThMy7?= =?us-ascii?Q?6TMSeyQ9bp2Ol7CY9j/R8/y1dT41+g5Susj3TvTQiOqtkJng2Ve+8dpoKaee?= =?us-ascii?Q?3y35znHDCuimQjkXt658SF6QttlWRh78FzPzivguFrcQ88HQzOg711zGwsep?= =?us-ascii?Q?2AvVCEhFcUv3WyFkS40kHP4sOVEQcvPBUshgrC/w93gaEQwKgchRQ7bcPo61?= =?us-ascii?Q?+tcO4a56w+xm+napvb9PA8TX3cKFWfQb2vI6EopED4Ja6oLyFtlJCxFSyHak?= =?us-ascii?Q?KPGQwRDLNfvkKYFBHwwjMG065Qr8V8VhXMJneccRId4CE3owY/Z898juBDJL?= =?us-ascii?Q?S4MYjwtA/BMKR1xsjReKOp7k6eaTIODhtdDTkQNH3SOh10zKRKNY09FE6tl4?= =?us-ascii?Q?RVYHmcOaQ5uqrp3zhC3JMg5WjmIRWSsnfIO4Ki/nGhN1GtEXK/E6eZ3qiKA8?= =?us-ascii?Q?MP7FpdymJjktdKEJt7jb4b5udNwmc3fN8rmLgch+5qvatV1SK23Yb9cUGEYc?= =?us-ascii?Q?iRhjz1hvjOkacPAciBYy6riHzOYbzcnmTJmbtwZtzVocVBnqRo/sPuLFRIpy?= =?us-ascii?Q?g51MP9N8mB3X0AesclAASGvA9IL0cMychu6CQpAeEfEwa10qxYGiYgtxZ9qC?= =?us-ascii?Q?4Ctc+GQAWQhPis6EX6dpAZwzlfaRKPa7mVBAZdhre81TwLHi71vJFs1lO+S+?= =?us-ascii?Q?7+zFMg//2eu3e2fWzzldbK3+iKxhLWDlpoJXgfx4/7yYAHNnB/HFLpQ5PlTN?= =?us-ascii?Q?O78UcKboiyoAYMDUNbfbdGrlp3NccFQhDH8HzUDfRsmhvuf63gDrVE08bjry?= =?us-ascii?Q?fFMcb9OVp8zgwTNqbE0e3Fj0iaxVHSqi/Wz2LQNGC6RXe1eja/jaVH62Q7d9?= =?us-ascii?Q?ZiGjtNYw4nHmETnHgirdhMrQp8Z0gjKMuLqrklUBPIgRPHahZRFkqjqCoRzn?= =?us-ascii?Q?jmll3RL1crhWyjK/vsFNhj1ipOSk8vpCr5jrIkOTF56aaigmYNBxS6WgwjxI?= =?us-ascii?Q?gtO0XbUBp88hk/K07GAsnUcnDnSHeMx5XtVl+ogjLlf2FDd5j4fbodhgc7R5?= =?us-ascii?Q?tNzk2b8CpbAQflD7BHLEprdDnJUdSvtL2drdJ/6HiSqET6BernHjc/bdQu+/?= =?us-ascii?Q?MLY=3D?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB2796.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 14c20ea5-de64-47c0-46d4-08d903e3bb9b X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Apr 2021 10:04:48.8691 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 72BFw5/u0WxIp7MLeDAYd9Tx+FAFRwczHluPI99P0Ex3SkBAAsJ/fX5s7cNfCYOCClc2TY2JM7ekH7OS8HKqlYWj13bT9QJz4qHA1bySBYc= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5504 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH 2/2] pipeline: autodetect endianness of action args X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> > -----Original Message----- > From: Thomas Monjalon <thomas@monjalon.net> > Sent: Tuesday, April 20, 2021 1:48 AM > To: Dumitrescu, Cristian <cristian.dumitrescu@intel.com> > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 2/2] pipeline: autodetect endianness of > action args >=20 > 12/04/2021 01:23, Cristian Dumitrescu: > > Each table entry is made up of match fields and action data, with the > > latter made up of the action ID and the action arguments. The approach > > of having the user specify explicitly the endianness of the action > > arguments is difficult to be picked up by P4 compilers, as the P4 > > compiler is generally unaware about this aspect. > > > > This commit introduces the auto-detection of the endianness of the > > action arguments by examining the endianness of the their destination: > > network byte order (NBO) when they get copied to headers and host byte > > order (HBO) when they get copied to packet meta-data or mailboxes. > > > > The endianness specification of each action argument as part of the > > rule specification, e.g. H(...) and N(...) is removed from the rule > > file and auto-detected based on their destination. The DMA instruction > > scope is made internal, so mov instructions need to be used. The > > pattern of transferring complete headers from table entry action args > > to headers is detected, and the associated set of mov instructions > > plus header validate is internally detected and replaced with the > > internal-only DMA instruction to preserve performance. > > > > Signed-off-by: Cristian Dumitrescu <cristian.dumitrescu@intel.com> > > --- > > examples/pipeline/examples/vxlan.spec | 41 ++- > > examples/pipeline/examples/vxlan_table.py | 44 ++-- > > examples/pipeline/examples/vxlan_table.txt | 32 +-- > > lib/librte_pipeline/rte_swx_ctl.c | 15 +- > > lib/librte_pipeline/rte_swx_ctl.h | 6 + > > lib/librte_pipeline/rte_swx_pipeline.c | 282 ++++++++++++++++++--- > > lib/librte_pipeline/rte_swx_pipeline.h | 4 - >=20 > There are compilation issues in the CI: > https://patches.dpdk.org/project/dpdk/patch/20210411232338.4005-2- > cristian.dumitrescu@intel.com/ >=20 Hi Thomas, The reason for the CI issues is because this patch set has dependencies on = the previous patches that were pending, but now already applied by you (tha= nk you!), so there should not be any real issues? Regards, Cristian