From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 372C9A0547; Wed, 21 Apr 2021 17:12:30 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A3A1241AC8; Wed, 21 Apr 2021 17:12:29 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id 3D180410F9 for ; Wed, 21 Apr 2021 17:12:25 +0200 (CEST) IronPort-SDR: wz1T7JNZInUN0Vb8HBa0GD3vujQQE+CE0RoE6PZMv/gSym5hheRjTprGGXYj88+L+7WVCIIosx 3J9RustPsUJg== X-IronPort-AV: E=McAfee;i="6200,9189,9961"; a="195271805" X-IronPort-AV: E=Sophos;i="5.82,240,1613462400"; d="scan'208";a="195271805" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Apr 2021 08:10:50 -0700 IronPort-SDR: sxST39lPL3JKmF9qdcja2j03Kcw4Bo1QrDpL2ontWR2Rj6jQn008SWBCCmy8WYB20uSar+5Kw2 C+g6ALrFXXzg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,240,1613462400"; d="scan'208";a="534900849" Received: from orsmsx604.amr.corp.intel.com ([10.22.229.17]) by orsmga004.jf.intel.com with ESMTP; 21 Apr 2021 08:10:50 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX604.amr.corp.intel.com (10.22.229.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Wed, 21 Apr 2021 08:10:50 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Wed, 21 Apr 2021 08:10:49 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Wed, 21 Apr 2021 08:10:49 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.107) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Wed, 21 Apr 2021 08:10:49 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=IYvclZigFa3fULoN+d+HZ5DuVx1SGYxqN3rgMzNf/sQ+4F8um26xRj+EZtpZYZzFFSlKd2zzY+sxurHzYBTVXtjtPbk3CcurfAl5QeMuhigH+fFI1IXEeuaBegVE5SeP3ExWHgxxwfoCE6WARqyXNR71NL+ZHHCJMnKIVDaLXqx63evrxn/H3t1wG+vtupCpt4jl6kgNaUqrLP100e60d9WochpPFDhz45Rf9rKbEX8ULBTBBTsC7LFTdwWyNsgFTlXjiZh9UfAjLa//0g7ObCQZTr9g+EudArVo0LVwJ9lxJLLi6Tx+P1wH6nSjzB0t463iX/4eP+871nimeIRcBA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UxuueXsyNLOww7Cykf56DNWnJHm5htngEGPgvchbDwM=; b=obcaGCdYKYe8z+GoquVog9uvEin1xgZf8A7aL+dKpOF/y9Zs+UHAokMtL5VPbbA2NjjBodQG8UBA0+izGI83NqGwbyqgPN9MUk+6swLyRhy6xiHYbJiY+opKDwsmLyDolzZTlHd90BoOX/AXWsML37Ux9NkRJGYNmveK0gy6HI5bf5EFcI+EjneufZgn3XthbVOYUUbQmz5giFmPswNp8CFGIwZH4jQ8XpE6KYznYIcnS3DSPd/gKH+7MEGIs2Oe1azEKPcDxgFbt1WuKw+l4LxQ02DQPWMt9bHGF1YCJsACeHzlSwwRGrl6cRhUYHRevZ8gyrMDwooUXyOlAtZnuA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UxuueXsyNLOww7Cykf56DNWnJHm5htngEGPgvchbDwM=; b=zb6Gcq+iT81x7QU/AkTnvFFlDCv2v6YLYY5V/BfhLW8rKttCAoaF51XU/prIb/rlSYcfT7NcosW3PImEsLw0B1U7s2bTAKZUBi/2iIi1b6mBhBR0TSgApxBNLpdqm6n0qr2kALlc6UU1MH097K3y0p7Tj6v7axM26TxzqbCHerI= Received: from DM6PR11MB2796.namprd11.prod.outlook.com (2603:10b6:5:c8::23) by DM4PR11MB5504.namprd11.prod.outlook.com (2603:10b6:5:39d::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4065.21; Wed, 21 Apr 2021 15:10:49 +0000 Received: from DM6PR11MB2796.namprd11.prod.outlook.com ([fe80::d099:834d:f5ad:39c9]) by DM6PR11MB2796.namprd11.prod.outlook.com ([fe80::d099:834d:f5ad:39c9%3]) with mapi id 15.20.4042.024; Wed, 21 Apr 2021 15:10:48 +0000 From: "Dumitrescu, Cristian" To: Ali Alnubani CC: "dev@dpdk.org" , NBU-Contact-Thomas Monjalon , Aaron Conole Thread-Topic: [dpdk-dev] [PATCH 2/2] pipeline: autodetect endianness of action args Thread-Index: AQHXLyneEQreL0SXuESXCf4XuBA+W6q94I+AgADG4ICAAGIVMIAADEWAgAAHHeA= Date: Wed, 21 Apr 2021 15:10:48 +0000 Message-ID: References: <20210411232338.4005-1-cristian.dumitrescu@intel.com> <20210411232338.4005-2-cristian.dumitrescu@intel.com> <2003889.D9zfWNbQnx@thomas> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: nvidia.com; dkim=none (message not signed) header.d=none;nvidia.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [51.37.10.125] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: b2bcb95f-b829-4c39-9a39-08d904d7a56a x-ms-traffictypediagnostic: DM4PR11MB5504: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: /GwpQFAove+P7WPPaHPYlfz4G9YYMwKng6XJPPfmTTgsaiFzJP2ct3XIDT4hsWWIWOJAjVHRFXTBxy+jFwMb4a8gPVYwcKC0UKAgC/WaC7En4kDCUQDoufR4rbEkUJLwp/tX0WWMOQaHyNW0h/3m6/71H0pq/oIt7b6U3sUlb5yjcGhRa6dO/AfFMhaRTyoE4KfNarb4JGFirAAW47QeUdkcoCi6hOJijEAtT/bfGtFYW01FP+1wDybH87jjLm6OkJJ6fCEYM7EHqPMZRd3v+p9IrvXmILOAzAJ4ZKBT+dcgA6IGZfHwkN/1Xb8r+S9WAPN+62fU+SdWT7V7RRo4n1HS8FNLJlh9znRm2FHg2Qs+H1pCcpxLdam5Q3YMswlqsskEYD/R7JbH1PMdMQ4NBq5hry+u1EtelIDeJzGmIuo6IRUVFA98CubsOiibrcPEoKDXhXHKTvTc5ZELARge4yiYGri6Dw0B9MBPzBNBBjDq9NEhQ+M+h5h6Rv5g5XaCSUc/GBrCfS1n2v6yMqnQEn/qQvxlujbvNRYsdkDMg8rHvmC9SE7hF/nYPtaimDuX+CmQ74+XjQS/7C45dra1TQE1wjO19YaV16X/87UFrSBK68t8gxQY4CuZ6hQgyt06NazOq8NmKLJaN9ZdnHzBfOnTzVkU2Fj24Slk41cw0is5tJ2nZXizrAHdixBdvOLD x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB2796.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(136003)(396003)(39860400002)(346002)(376002)(83380400001)(122000001)(38100700002)(52536014)(86362001)(8936002)(66476007)(76116006)(66946007)(55016002)(64756008)(66446008)(66556008)(9686003)(8676002)(5660300002)(53546011)(71200400001)(316002)(478600001)(4326008)(54906003)(186003)(966005)(26005)(33656002)(6916009)(2906002)(7696005)(6506007); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?zGxQJzrKuQw/AbyCNDH2V+vp6Nig7hGO4EddkrLpvm/1SpURAV41S1/eIQfG?= =?us-ascii?Q?STJAnsdF4W2w+YPqh47vz+atoV29gvrnojc+1jT0oAoCpz56EVhdSOQW96Nz?= =?us-ascii?Q?1Em+RvuQnhqw2e6DNP0MmhOoFcZxwtBf8XYx1Cy1r3qKDzADt1SJ0R7BFhAr?= =?us-ascii?Q?4MN+oYPMZ48CJte4PWrG5Z7wWsHueJ2Mum6W2qrgeiKMbbuB6JVstB7D1LcG?= =?us-ascii?Q?dpKgxwlGmfGY+jVH2akrg6DikSmC0KFj7fd9NiUYfqWJWiYJNmOey8/+ZVT/?= =?us-ascii?Q?UKLjs/+Z9VsnQ02m/jIvW8LTqZnF2kP1u48pkZ2VdEV2uwIoJ9jCcNeZCuoY?= =?us-ascii?Q?Mq5nXfMhVZ3ZtrscDBg+ZFg7dj3POqaeWgVYc+IFyjZZicbpQRWIbF/2539j?= =?us-ascii?Q?a9Z9g9VnaBBWpOHdhFz7pf6cxEiCq5JpPrhD53ZN0tXRU3mzgRpsOiQ7mrwf?= =?us-ascii?Q?pZrpK3M55sH5HaFXwa/9hnw6pPsUzL9ApMbgwzwKiixlp/q8VZDrrw43GATP?= =?us-ascii?Q?hcrQBGvZ5usctKizMrhmWRJOOQGxApss95grvif0YiVWDR+B8OaL1lPS6NrI?= =?us-ascii?Q?hovmEyUafMrapkkCm38sMKWK0Rqtn0hz5/6eJZv6Ks8RGkUQwvuFWu5cajQ+?= =?us-ascii?Q?lJsGXBOoq2pET4v27gZkNud4Uc/XPAjxTn5isRUARyTxMMDkZZ5Kzb8x8bIO?= =?us-ascii?Q?vMKy48rOTLXcSToqbzUCVWNbiFHZlDd6M9HKpgGUXesmb3NOXRUnwczSsbMf?= =?us-ascii?Q?PIUKT8jVcndSkn+LBiMZBp9nCjah7ti7OfFhzXM+cm5HZGfCM61oqpJz3G8t?= =?us-ascii?Q?yytkhJl/0hT7+aFlC4AO/ObUFfv5DZ0lwTAtk88KHRz5keRBvD6Svri8d1GF?= =?us-ascii?Q?QOQ41cSvatNn6FEFNDZhrgFd1NULwvOEbU6XUj++OAyweYWfyIGD4yT9YWt9?= =?us-ascii?Q?8xCKcFq5ndQc14GDtjFcgw4VL2kjOr/Zu4ZUIYNoSccmIzV5hPo2Tq5eZFdj?= =?us-ascii?Q?HspCMDdHsOF6HBhzYbtcBlyCgTjkAa7PuO5sk7Hn+AXKwIpyWl17hlaRKtR9?= =?us-ascii?Q?brhSpqn6niYxGectEWzcNK73WMv0hlKIxDtgOjKuC2Btmt6d345x/8IdZo4S?= =?us-ascii?Q?s3Dp30bw9tsiyyL7+TECuCVBvBmJIgv1XrjdccNR4IXor/VYuo+6e61w0q7i?= =?us-ascii?Q?W6oVRDMZvtVnv7P78Wbwvvmd7ZTUn4sWApIzQT9CdReXcvEvYUkyk1wPaWYW?= =?us-ascii?Q?7jz8R20TIE8c4ksU6M5ofccy4mRX4bt+oCAVnLZrTck42w4Ru2B42xxeF0F8?= =?us-ascii?Q?yYw=3D?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB2796.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: b2bcb95f-b829-4c39-9a39-08d904d7a56a X-MS-Exchange-CrossTenant-originalarrivaltime: 21 Apr 2021 15:10:48.8123 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 1ntBM1V0xUsbxWEYGXha1TmpKv3qajeOypDTHUkKVpy4NY2wStF/bENhxLqz+NsSEe9WqB7+Yd9J0yGyG1zOcIg7Vcq27WDVurrNPjp4Aso= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5504 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH 2/2] pipeline: autodetect endianness of action args X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Ali, > -----Original Message----- > From: Ali Alnubani > Sent: Wednesday, April 21, 2021 3:25 PM > To: Dumitrescu, Cristian > Cc: dev@dpdk.org; NBU-Contact-Thomas Monjalon > ; Aaron Conole > Subject: RE: [dpdk-dev] [PATCH 2/2] pipeline: autodetect endianness of > action args >=20 > Hi Cristian, >=20 > > -----Original Message----- > > From: Dumitrescu, Cristian > > Sent: Wednesday, April 21, 2021 4:58 PM > > To: Ali Alnubani ; NBU-Contact-Thomas Monjalon > > ; Aaron Conole > > Cc: dev@dpdk.org > > Subject: RE: [dpdk-dev] [PATCH 2/2] pipeline: autodetect endianness of > > action args > > > > > > > > > -----Original Message----- > > > From: Ali Alnubani > > > Sent: Wednesday, April 21, 2021 8:50 AM > > > To: NBU-Contact-Thomas Monjalon ; > Dumitrescu, > > > Cristian ; Aaron Conole > > > > > > Cc: dev@dpdk.org > > > Subject: RE: [dpdk-dev] [PATCH 2/2] pipeline: autodetect endianness o= f > > > action args > > > > > > Hi, > > > > > > > -----Original Message----- > > > > From: dev On Behalf Of Thomas Monjalon > > > > Sent: Tuesday, April 20, 2021 10:58 PM > > > > To: Cristian Dumitrescu > > > > Cc: dev@dpdk.org > > > > Subject: Re: [dpdk-dev] [PATCH 2/2] pipeline: autodetect endianness > of > > > > action args > > > > > > > > 12/04/2021 01:23, Cristian Dumitrescu: > > > > > Each table entry is made up of match fields and action data, with= the > > > > > latter made up of the action ID and the action arguments. The > approach > > > > > of having the user specify explicitly the endianness of the actio= n > > > > > arguments is difficult to be picked up by P4 compilers, as the P4 > > > > > compiler is generally unaware about this aspect. > > > > > > > > > > This commit introduces the auto-detection of the endianness of th= e > > > > > action arguments by examining the endianness of the their > destination: > > > > > network byte order (NBO) when they get copied to headers and host > > > byte > > > > > order (HBO) when they get copied to packet meta-data or mailboxes= . > > > > > > > > > > The endianness specification of each action argument as part of t= he > > > > > rule specification, e.g. H(...) and N(...) is removed from the ru= le > > > > > file and auto-detected based on their destination. The DMA > instruction > > > > > scope is made internal, so mov instructions need to be used. The > > > > > pattern of transferring complete headers from table entry action = args > > > > > to headers is detected, and the associated set of mov instruction= s > > > > > plus header validate is internally detected and replaced with the > > > > > internal-only DMA instruction to preserve performance. > > > > > > > > > > Signed-off-by: Cristian Dumitrescu > > > > > > > > Series applied, thanks > > > > > > > > > > > > > > I believe this patchset is causing the build failures in > > > https://bugs.dpdk.org/show_bug.cgi?id=3D683. > > > > > > Regards, > > > Ali > > > > Hi Ali, > > > > I checked this issue and here are my findings: > > > > 1. The compiler warnings are NOT caused by this patch, all of them are > > triggered by older code. >=20 > Git-bisect pointed to this patch. The errors didn't reproduce without it. This is strange, as code that your patch (as well as mine) "fixed" was not = modified by this "pipeline: autodetect endianness ..." patch (easy to check= ). Likely this patch triggered some bad memories in the "mind" of the compiler= , but TBH I don't think we need to debug it at this point :) >=20 > > 2. Why were they not triggered before? Either this is the first time Ce= ntOS > 7 > > is run or the compiler has a mind of its own (my vote goes to the forme= r). >=20 > The check ci/iol-testing contains an image with gcc 4.8.5 (RHEL 7), and I= see > now that it reproduced the errors in recent patches. See the failing buil= d > check in https://lab.dpdk.org/results/dashboard/patchsets/16682/ (under > dpdk_meson_compile). >=20 > > 3. These are all 100% fake issues that are probably triggered by the ol= d GCC > > version from CentOS 7. > > > > I just sent a patch now (you are copied on it) with some harmless local > > variable initializations in the hope it will stop these warnings on Cen= tOS 7. > As I > > don't have access to a CentOS 7 machine, can you please confirm whether > > the warnings are fixed? > > >=20 > I submitted a patch and updated the status of the Bugzilla ticket a few h= ours > ago. See https://bugs.dpdk.org/show_bug.cgi?id=3D683#c4. >=20 Cool, thank you for looking at this issue and doing the work to fix it. I did not see your patch in time, as for some reasons it landed in the bin = folder as opposed to my usual DPDK folder. > > As the warnings are triggered selectively for just more occurrences of = a > > common pattern as opposed to all occurrences, I am trying to fix all > > occurrences of this pattern in order to prevent the same warnings showi= ng > > up again. > > >=20 > I only initialized occurrences of dst_struct_id and src_struct_id to reso= lve it > though, maybe rebase and update your patch if you think initializing the = rest > is necessary? >=20 There are a few others that might be triggered at some point, but difficult= to have a full list now, maybe it is better to wait for now. > Thanks, > Ali Thanks, Cristian