From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3096DA0548; Tue, 20 Apr 2021 12:20:52 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id EF8B6412B0; Tue, 20 Apr 2021 12:20:51 +0200 (CEST) Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by mails.dpdk.org (Postfix) with ESMTP id CE867411A5 for ; Tue, 20 Apr 2021 12:20:50 +0200 (CEST) IronPort-SDR: QkjqB3d7ua5fWdZXL/VaR5vkTVPJsWV+5upo7SlI0Syvd7fq5LkRqwYkcLciXoqTm4c7yfVyMf RdNnryvZTkBw== X-IronPort-AV: E=McAfee;i="6200,9189,9959"; a="192294397" X-IronPort-AV: E=Sophos;i="5.82,236,1613462400"; d="scan'208";a="192294397" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 20 Apr 2021 03:20:49 -0700 IronPort-SDR: Z6QlQ9yXCTE2DYdhKEu3G5M8cHVlf99NLdJThfUOuNtCkG5AC+pKsiXp8ve0LwClSgHcGD6ze6 1H3be1HZ9W7g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,236,1613462400"; d="scan'208";a="385267832" Received: from fmsmsx604.amr.corp.intel.com ([10.18.126.84]) by orsmga006.jf.intel.com with ESMTP; 20 Apr 2021 03:20:49 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Tue, 20 Apr 2021 03:20:49 -0700 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Tue, 20 Apr 2021 03:20:48 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Tue, 20 Apr 2021 03:20:48 -0700 Received: from NAM10-DM6-obe.outbound.protection.outlook.com (104.47.58.100) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Tue, 20 Apr 2021 03:20:29 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=L5Cq36l7/G9SAkS2od/79QSbU8Hm8s9FU7iYsheZWSMGTAw76W/hpWPCRy4YztknHj0oSggOS5M8UO4+tuphNGo3Jb+H3V5fTXx9KoRxBH5WsaSBjPENDKCGn/DHfKXhp9KFbu+ZNhq1qOqKetolCL7r9PWvTca/g3oIBrek3MstKBpOBsSBHc8DZF1LNkc+NEyKBb6MEpGA9Ip12KiUXinEgHsAv1HmwGx6Yg9/5yfOtWFetPaFuRvpf5nnpWmMpsBAVCiJOe7H51NN78w8pn2w7D5ixrRM7AdQk/WAHy5gbJgLTgTwlkD/xXcOQfm2XSvYrXZpUS6b506CTR3dTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oCL+c701Fskq4zwH1dPcXK2FlJwYETKisyxbCqq+X0s=; b=BC0JvvkDhT56ZTwUSSiCb3xhuf8aVpAGVOYQwWUtgnr0ROVeJLEaWHiOfE3FVLLcIAfkym8P+s8TOqAKuP/BhkXK+LTkiOuSMdTjI0y6M7mMUWWPvYHQSqFdqw2lC09UHo11f5H+WVEzEHjExcO6/OtLQT8zmMTUv4GNYCcEcM2XxbfgsFO8RHcmu6Kd0/6UkvAZLT3CMrMtwJBT4YO9blz+AMyhkVz+OKuZzAAEewbOh+1vd24N2LZiRmu5nj0TzH/9Rf/Feq5kdn86yuxrOCMuyQyAhqSK4kW6zbLp0nPD+GDLnhc6cX6EKgQVRKcu6YM8M3efatK0OBWb7B/HsA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oCL+c701Fskq4zwH1dPcXK2FlJwYETKisyxbCqq+X0s=; b=Bj65NXOKRshekgnl64sYfbfBY7fqPRK53EtSbOJPwHFzhXBlRoRiwMB7NzjCNKPTjrxcvNIw4RlZJKDHa03pIThdQURYmhFaZ52iw0XejpuzHRsdf1AWzY7FCub72wi9Hk858vRRKSY9udHI+gH35fggnTQlaLKhJX2KZen4W0M= Received: from DM6PR11MB2796.namprd11.prod.outlook.com (2603:10b6:5:c8::23) by DM6PR11MB2908.namprd11.prod.outlook.com (2603:10b6:5:70::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4042.16; Tue, 20 Apr 2021 10:20:28 +0000 Received: from DM6PR11MB2796.namprd11.prod.outlook.com ([fe80::d099:834d:f5ad:39c9]) by DM6PR11MB2796.namprd11.prod.outlook.com ([fe80::d099:834d:f5ad:39c9%3]) with mapi id 15.20.4042.024; Tue, 20 Apr 2021 10:20:28 +0000 From: "Dumitrescu, Cristian" To: Thomas Monjalon CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH 2/2] pipeline: autodetect endianness of action args Thread-Index: AQHXLyneEQreL0SXuESXCf4XuBA+W6q8n0sAgACaFYCAAAH7AIAAA2xQ Date: Tue, 20 Apr 2021 10:20:28 +0000 Message-ID: References: <20210411232338.4005-1-cristian.dumitrescu@intel.com> <1799475.riq6yjk0ZW@thomas> <1649627.coH7sy9KVI@thomas> In-Reply-To: <1649627.coH7sy9KVI@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-version: 11.5.1.3 dlp-reaction: no-action dlp-product: dlpe-windows authentication-results: monjalon.net; dkim=none (message not signed) header.d=none;monjalon.net; dmarc=none action=none header.from=intel.com; x-originating-ip: [51.37.10.125] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: e76f3fba-50ad-4c67-3dbf-08d903e5eb6e x-ms-traffictypediagnostic: DM6PR11MB2908: x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1824; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: QzokYJKoS9xNKgshrFTxSs/rRCw66mgnLLKSpz8TtMfQT8TT/Xsl6pbCgxynMBfLSfPGkfhtnx1oHD7I3yMCTz9HyeDNyjM3MVPbR3IneWwSgnnZony67bGcVuAmdP1DiuQo1N0avhWOHWjXQOGXwZQsfzJVt4pQU0uafdvRT9ywmqxqGI+GkP6/o8LUavhwUaNLL+QCY+DRdo4eC+iuJN9gPLfj1v+wwW9oOE6UZjsHOTmBlA8EH/BQNlh6rYjnB3oEKK6Z5RcjlDnok+ssZDkqF9ZKMnlVEajtTvPl4GOo0StHlXO628C2iK3mywRnC80V+J55OjgftcGi6FrZvCwCSD3hrF/g46qq0EPPq6GxZOvMs//7p5GN5IprsVDZuAyoHG1CIrFu3QHNSe50CFv9ehW3K9dCltP9FGvt6/1lxwiHlOih6vxIrDMUkKKVaPDh4i6tnKDJekr7xRJjuFO7IJ56lQM5erkoC+UULsnVQ6XsKsrjBBDz0+543Ei4POIEBxsqDdAidc5r+y23rIuQq46LKaqSm8dfYRbVy+C8YDnV6UcnlxfYQlhXNSrnd2BgqKR/mgvMXXCLlSSWCuPRNi2Kz8sr5KUmgBl2ZcaPpaSJ2q5XNusnyHI/MW3ZdW3VvmwMtHT3l4KlaUv5N5RWvpOWC94Ey0KIbbgD04pzCJxEOgjZ+/6kJJCe7EP6 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB2796.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(346002)(396003)(136003)(39860400002)(376002)(366004)(66946007)(52536014)(66556008)(122000001)(66446008)(478600001)(76116006)(64756008)(66476007)(9686003)(71200400001)(966005)(83380400001)(7696005)(38100700002)(316002)(53546011)(8676002)(2906002)(4326008)(26005)(186003)(6506007)(5660300002)(55016002)(33656002)(6916009)(86362001)(8936002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?X0OiXK8UvU+VIWIurCDCyLf2YZ7Jx504IlHk64T8Jd4IEoF9ts3EqJ0jDyVD?= =?us-ascii?Q?VglYeoXtV+/MP77nkfASCar/SUvuG/Eh++rMtLG1PscKnej2YAcnLqVRTGo4?= =?us-ascii?Q?BB7Th1SXWYZx2QzfWGDo9bUd3VF0SFpy/V9/s4/BlmtyBIbp9d+J3283RkeP?= =?us-ascii?Q?iCFg/i9E0W2DNd8QrVozkUpD/JtG0pJheMjBV8/Ct8YgdZhPAFNTfIW62G/i?= =?us-ascii?Q?XVys1KJX3jTcmXwpv0ENJAgru8l2jD7jSn9Fnk4xgZAqPaTNXyTrLcSBjVSq?= =?us-ascii?Q?FUv1TSBdgpvUxjt+SWq6wxxinweivVl7Vmt4dupWeNnATJbEmNvFz9v/eslH?= =?us-ascii?Q?rOdVxK7x5JSTJSZya3N8u5/p4ETjrwd8+0XoxfrvXay2wzN85NcTTX0JCuRy?= =?us-ascii?Q?UcYU0xJYOLy+97YP60nQvQ8HfPPRuDBnkSxfJTu4wUS6dxcCtkIkEJBr8S+z?= =?us-ascii?Q?bKwq+tO8hFEZb6P8YDRzUkC+4brPoT5mOeRbwtvy7hivR/NQ8tlQal1ZKhhg?= =?us-ascii?Q?jUNNKCIBSEs9xLynx7IaGRDafCgAXTSSH1JTNgtYUOCH9wxGQZyUyq9lzYHz?= =?us-ascii?Q?q9JMFNMKn4T0vXbKTgFpD2V3pc+lJ0qHvLWO9fRy0H2df/ZqCCGlEYKV4AfK?= =?us-ascii?Q?uYqLhdD+gekPhTMg/8SWG9xw5s1dun+N3mkRj3eZiG3lWFWVq0BDS8H8myN1?= =?us-ascii?Q?UdMLgmJKMMIIjh+emOb2yJmMTlhx40NN1Pm32BDGvTDMYP0N8PT8etsav6W0?= =?us-ascii?Q?0+P99HV8T+8ch++kGV70T8q3xiVzqlyUYwS+pDjnTAQ//FcrsCdjPTe1uw9Z?= =?us-ascii?Q?ogd/mPBuM7m12l7l9J+4nlyUGk9pJnZQydyMG/11GHAOM68kFZY5Z/o0r0ml?= =?us-ascii?Q?hApJjzalWyBaKytLgoRelTlfXnL20VwbuhumiZw/MGgLxwENiMv/t3tZhuHa?= =?us-ascii?Q?GT/Ra+88mHv4YvEdmcx/G2jpX6Wn9qYwz948xJw9FYZZDbYN/oiQTNpVlITT?= =?us-ascii?Q?5w0Z4ZDhpIBV71eDGgMzEsTEvlqxeWlFbq94rmlfvwJt8S9VOlpybeRFGn0h?= =?us-ascii?Q?/DqQew31J0mHJKa/2Y+YGYR3KuulUSr8R1bIMIHBiiDq9qIrBq6swaHrxHDo?= =?us-ascii?Q?pkkVReffv8oNaEFlAcPeba3xM01OPp6s29q/51y9aGCfL67eaht3sT6OizHS?= =?us-ascii?Q?7BL9dxBQLFvB4BLEjSjo8lu4fWhfoIBb8kf8lPdam1i2zfBXKOSIEE0z4Xnv?= =?us-ascii?Q?Xf1er7xnMTiVFGPDOyr+k8+jEzRli41EifGpDqEdp4Snh160Phq0lzNnvWdS?= =?us-ascii?Q?NAk=3D?= x-ms-exchange-transport-forked: True Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB2796.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: e76f3fba-50ad-4c67-3dbf-08d903e5eb6e X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Apr 2021 10:20:28.0951 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: Ni0zsHLZp48v3KC7tvaA/gy7c5OilLhpCZSaTprbB00hPwuXuNt4qKZChmp5G3ziZ2pirC1706zt/m0UjImr0hSFI7/CL61ehI9M+R1Ds30= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB2908 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH 2/2] pipeline: autodetect endianness of action args X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: Thomas Monjalon > Sent: Tuesday, April 20, 2021 11:07 AM > To: Dumitrescu, Cristian > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH 2/2] pipeline: autodetect endianness of > action args >=20 > 20/04/2021 12:04, Dumitrescu, Cristian: > > From: Thomas Monjalon > > > 12/04/2021 01:23, Cristian Dumitrescu: > > > > Each table entry is made up of match fields and action data, with t= he > > > > latter made up of the action ID and the action arguments. The appro= ach > > > > of having the user specify explicitly the endianness of the action > > > > arguments is difficult to be picked up by P4 compilers, as the P4 > > > > compiler is generally unaware about this aspect. > > > > > > > > This commit introduces the auto-detection of the endianness of the > > > > action arguments by examining the endianness of the their destinati= on: > > > > network byte order (NBO) when they get copied to headers and host > byte > > > > order (HBO) when they get copied to packet meta-data or mailboxes. > > > > > > > > The endianness specification of each action argument as part of the > > > > rule specification, e.g. H(...) and N(...) is removed from the rule > > > > file and auto-detected based on their destination. The DMA instruct= ion > > > > scope is made internal, so mov instructions need to be used. The > > > > pattern of transferring complete headers from table entry action ar= gs > > > > to headers is detected, and the associated set of mov instructions > > > > plus header validate is internally detected and replaced with the > > > > internal-only DMA instruction to preserve performance. > > > > > > > > Signed-off-by: Cristian Dumitrescu > > > > --- > > > > examples/pipeline/examples/vxlan.spec | 41 ++- > > > > examples/pipeline/examples/vxlan_table.py | 44 ++-- > > > > examples/pipeline/examples/vxlan_table.txt | 32 +-- > > > > lib/librte_pipeline/rte_swx_ctl.c | 15 +- > > > > lib/librte_pipeline/rte_swx_ctl.h | 6 + > > > > lib/librte_pipeline/rte_swx_pipeline.c | 282 +++++++++++++++++= +- > -- > > > > lib/librte_pipeline/rte_swx_pipeline.h | 4 - > > > > > > There are compilation issues in the CI: > > > https://patches.dpdk.org/project/dpdk/patch/20210411232338.4005-2- > > > cristian.dumitrescu@intel.com/ > > > > > > > Hi Thomas, > > > > The reason for the CI issues is because this patch set has dependencies= on > the previous patches that were pending, but now already applied by you > (thank you!), so there should not be any real issues? >=20 > Yes I didn't see any issue locally, just wanted to confirm. >=20 Thanks, Thomas. I just double checked by applying this set on the main late= st, and I could not see any apply or build issues.