From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BF09EA0C43; Wed, 12 May 2021 16:16:11 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 886374003F; Wed, 12 May 2021 16:16:11 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by mails.dpdk.org (Postfix) with ESMTP id DA05A4003E for ; Wed, 12 May 2021 16:16:09 +0200 (CEST) IronPort-SDR: Ykj7TuqFXlzLt+gXpd9ombZiuRi6dXjN82Msl33kSTcr74qgRipqPNSHFl+jQSMeru7PakMgsh Mf9SqoKB+AIQ== X-IronPort-AV: E=McAfee;i="6200,9189,9982"; a="187140457" X-IronPort-AV: E=Sophos;i="5.82,293,1613462400"; d="scan'208";a="187140457" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 12 May 2021 07:16:08 -0700 IronPort-SDR: UJBhWEU1McqxECL3ZGwi/xaRZzBOAcjoWiyZM1jWe6OEkOWzmBBxXZknX+yxYN6lkFYAtK2+ud fBA4pBB/0gCw== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.82,293,1613462400"; d="scan'208";a="400125150" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by fmsmga007.fm.intel.com with ESMTP; 12 May 2021 07:16:08 -0700 Received: from orsmsx611.amr.corp.intel.com (10.22.229.24) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Wed, 12 May 2021 07:16:07 -0700 Received: from orsmsx603.amr.corp.intel.com (10.22.229.16) by ORSMSX611.amr.corp.intel.com (10.22.229.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2; Wed, 12 May 2021 07:16:07 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2106.2 via Frontend Transport; Wed, 12 May 2021 07:16:07 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.106) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2106.2; Wed, 12 May 2021 07:16:05 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kOK+RtOkBRuz8bO8fD6RSr3nuGc5eCpkq1me9yaJfAkhty1jZnRvYXW+2fjVD0VnJtiBPLIWIN1RU6tXFryJN8xyGDn2uey7be2nrJBNZracjlZkMjO3h6GWLNbyzNcN/k2oxeMb63pcDLqHvucKDifRgPbRz/7S/ZmVjCeJI2HLFzAtHbYNa79+g5YjCV0/o2gm/pjH4AfeCViYta4R2TvxRUlq1fGAnTraotIzC2SaoirVFqeB3+jKjyxHIkNAbbdFMVrJa4Gx7/YESaZHSNrRqKhM4nKhM9ZawUSR7xv8ZdbUPA/OnDNhVLv2AMtOtpBe0QZUaf5mQRzoQemi7A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VuGMwSeU46C97iuO6CkRl3nsP14qoAGD0YphbGtQU20=; b=gD6E5Kkr/a2U/uZNMOqaKkhrbAs1aNDV+oUCQ59wLJvbHCGoYLhT6NuCX/ZmVXFsnGqzZkGK4PRytqcuJ3wQ9QUBqtP+s4HHhc2cd3uxNeHEM891L4KQFawrEffxyrIFwSYS3vunx0sf+5R8Qx0HveIng6BJWNAQgvRcsh3xu99dQTajiiSh8Wh95TyF4xXSEZl1pdg4ecAAbASXyxeKjYAIOnCbCl1vllw69FmDCD0ANkanAAXF4NJJZrWY7sbvVj5AXjmOhGmWxFm30KstdhNS2oiPgnV/8zpt+AcJNeSLpJXzQow9BE/938M5RlTa4LWVDScMMdpvrKb6k7HQ0A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VuGMwSeU46C97iuO6CkRl3nsP14qoAGD0YphbGtQU20=; b=yIysAdMBSeTb0KJd/XNSXsndadF+rvbthx8k9zsp3YmbMSbQAkL+XqW1DdFr6TmenV1avtw9A/vS4dPr6f0eZGxQ8D+/b82FJE9n/VFuiqcWVVI4LWBlq5osHug9rKYIm17racCcv9i1Qu2kctAMn5A6nlFLxpbrUtf9KOn5RRY= Received: from DM6PR11MB2890.namprd11.prod.outlook.com (2603:10b6:5:63::20) by DM4PR11MB5487.namprd11.prod.outlook.com (2603:10b6:5:39f::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4129.25; Wed, 12 May 2021 14:16:04 +0000 Received: from DM6PR11MB2890.namprd11.prod.outlook.com ([fe80::c448:f9a0:c163:8a6c]) by DM6PR11MB2890.namprd11.prod.outlook.com ([fe80::c448:f9a0:c163:8a6c%7]) with mapi id 15.20.4129.025; Wed, 12 May 2021 14:16:04 +0000 From: "Iremonger, Bernard" To: "Zhang, Roy Fan" , "Dybkowski, AdamX" , "dev@dpdk.org" , "Kusztal, ArkadiuszX" , "gakhil@marvell.com" Thread-Topic: [PATCH] crypto/qat: fix NULL authentication request Thread-Index: AQHXRZGOJrmR26rbtkWJ5BmD6nf+n6rf5uWg Date: Wed, 12 May 2021 14:16:04 +0000 Message-ID: References: <20210510102011.44343-1-adamx.dybkowski@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.5.1.3 authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [86.45.108.187] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: edd8311e-f689-4fba-83e7-08d915507a9a x-ms-traffictypediagnostic: DM4PR11MB5487: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2150; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: VgXS+QIOiekp1qwkdiHr5HEoFXDk1cbgBUESrxlaQdRC7u7bi4SSD8fTcKznp0hMyf0UwhL//CfdgwuqulzDNfKoyszCWWTxBl7zA/pwPiwRO/U0O7N6xz5IJh6a6BT7DsdGurcmPP+UOckMqaPGaSzjsF4v7kP+ixTfbgmXHqKC6B4tZ9FMkEm49chjowuPjZft6w09ZXXr0ZgeEi7RmcxD4RHikHuHtrzWdfZgVIXatIARIlhamTD6IyleMlqjmAx6XtDYyqWfvDCCG6LD1mengG9SnrY1oJF5m4NCbi+lokT+vcrTog1wOq6qpboHHqGX00tFQ2G0Es7/CDhHp9cHriILYOCnB9dfD4ZZSERv4xt0855KOhNnovzvBgQrUqCrYT9PcOPhOtEx85xhB4i60OG35uuPNkygyUzKE0NuKur7WdwANntyvBD6JDvl/haQHe1+2g4Gm9ds73XXNaxcpECdIs0SkDmZQNFAzBFzKZBNxzeaZHQ2HK2tdN8imYpmf2sr0omvbpy/gwOn/y1miVnMDRhWME2zBI4d66GW+zGGrsxKE13sXuCa3eR/o7ShU8wLUBs/Akn4ja/W/irqnQ4WgkEgo2e8ZmkhKuE= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB2890.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(346002)(39860400002)(396003)(136003)(376002)(66446008)(7696005)(66556008)(66476007)(66946007)(76116006)(186003)(64756008)(52536014)(2906002)(122000001)(9686003)(83380400001)(316002)(478600001)(8676002)(5660300002)(55016002)(38100700002)(33656002)(110136005)(6506007)(86362001)(53546011)(8936002)(71200400001)(26005); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?T+/DakP2MUAouFyWwUbvZOAk98hhnLIVQmRYPsHN5ILZXtDaI0eoHRBWHPiv?= =?us-ascii?Q?CoqZzFWhgMk2hKpnYXITXT1KRe2XIgRR2OjxkqvabSd650xgvC1SzzQvvSmT?= =?us-ascii?Q?6nuL0nR0JckxGCFneBexk1vVDleFRkXqITYwUa8usQoA1aggcVIngHea1a9b?= =?us-ascii?Q?Wm1p6PJmpItM3LYd0nxw6gEluanzBCZwjBtWULEJdMZPtASYu/Cb+AJpTVkD?= =?us-ascii?Q?AzClR41LuDsPvGHn8qhFL9sQYwYUh/zohrlD4EeFzolcHXjxvfWZcE+uj16m?= =?us-ascii?Q?QivK0C44IHCCSuDM7z2PuSP6XCFujpJuM+ZX9gakMv8h4qcYYKIZHn+5Vdg7?= =?us-ascii?Q?Jekf5EsgQRyz0shv83kRdzp4IkBsWSZwuCeo+U4B90zLHCSOJV9OiRn+P8VO?= =?us-ascii?Q?SqA3zQ3cRWowjHWrkqp1A9VRxAMRPFvM1k/fyQn6/EpbmrCimZUwEtCcy2GF?= =?us-ascii?Q?JrjTiyGvHh+2gLWdI1sH5CZl+t9AjHWT4fS5gTAA+i2u5d9ZI7F1Y1xH0ChD?= =?us-ascii?Q?oKkTV9HRcieX/WpCtQdFvM5Teubebrbcyozeci7AXitA4HQ0hEsSaBMYl3wi?= =?us-ascii?Q?eiBQXBIkAhUhCmCJPuxleqxqR/Czuv9mP60ySDIQiyn39vu4qdI47/8LD0Sc?= =?us-ascii?Q?acMF+J8nYOiS7jH688Ms4xHph5DtRnzZZ48zrNy4u+vtJqm9kAHgURhTqFuA?= =?us-ascii?Q?kQWIFkIn5CqgPCmHfrcfauIjPgGmq8fi+qDGMS3/V3cWLb35XWlHg1TgeiTa?= =?us-ascii?Q?Iqmt5WPLjSTOjmfklKQ8G0VIfjKb+CgW2qfOfkLwLD/4xqj2uxuspA3nJMcN?= =?us-ascii?Q?9+TrqrW0tHc/yp4jiMMwqcltSZYJAipVvLNt8fPLzPClOSRKWTbSNCXhqXhf?= =?us-ascii?Q?/spqBB/AK4lzZfSExPQdiOg88D0rB4d642WP6RlVLh/8SBCLZH8ulWTHHmf2?= =?us-ascii?Q?3S9z6EUAInimLB3qvFkIpMpXAyZRlYBxMziHu2rlmJxBSQeyLLYSjJFA7UfU?= =?us-ascii?Q?UM10SGTDKt/wTGc2onmIANhpMGrjmaPkww8sGxnpjNbD64Qjgs2PT1PjCgZM?= =?us-ascii?Q?DzsW5khEtDaj6sI2uhNZwl7ZJmMP2O++Aut0jWUHSzijk6HP1X5YcmPaaMad?= =?us-ascii?Q?RBptkk5EdnoIrs2ixgYnZEa3ODjyTgD7nOkV4XX4+PcFe1GdvGsKDVUrGbBr?= =?us-ascii?Q?eZkjhkBhowZLWklMesmi3z4imISZ+P8M4yYKf7c41Y1VQkQAMLCBICCwlY6M?= =?us-ascii?Q?17SkSebg94JOkyIIZfyVTbAz60dUbiKM9qlN5SFk9yjLcAiYbCRxDoPV7w88?= =?us-ascii?Q?FWoWBQi66qUlIkQOONwTbl+H?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB2890.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: edd8311e-f689-4fba-83e7-08d915507a9a X-MS-Exchange-CrossTenant-originalarrivaltime: 12 May 2021 14:16:04.6990 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: U19jOV6mq1YPzGjYQTzP6dBHMtfm9QtpSs4i9Irt4DiSCycM28f8ieEKVzwhW7Tokzy3AXowW1rExpL6ogYublUiVSYRLf533cuMhVTntcI= X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR11MB5487 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] crypto/qat: fix NULL authentication request X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi Adam, > -----Original Message----- > From: dev On Behalf Of Zhang, Roy Fan > Sent: Monday, May 10, 2021 12:42 PM > To: Dybkowski, AdamX ; dev@dpdk.org; > Kusztal, ArkadiuszX ; gakhil@marvell.com > Subject: Re: [dpdk-dev] [PATCH] crypto/qat: fix NULL authentication reque= st >=20 > > -----Original Message----- > > From: Dybkowski, AdamX > > Sent: Monday, May 10, 2021 11:20 AM > > To: dev@dpdk.org; Zhang, Roy Fan ; Kusztal, > > ArkadiuszX ; gakhil@marvell.com > > Cc: Dybkowski, AdamX > > Subject: [PATCH] crypto/qat: fix NULL authentication request > > > > This patch fixes the NULL auth generation case where the request > > shouldn't contain the authentication result address. Allows to run > > ipsec_autotest with a QAT device. > > > > Fixes: 65beb9abca6d ("crypto/qat: fix null auth when using VFIO") > > > > Signed-off-by: Adam Dybkowski > > --- > > drivers/crypto/qat/qat_sym.c | 6 ++++-- > > 1 file changed, 4 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/crypto/qat/qat_sym.c > > b/drivers/crypto/qat/qat_sym.c index a1f5676c04..9415ec7d32 100644 > > --- a/drivers/crypto/qat/qat_sym.c > > +++ b/drivers/crypto/qat/qat_sym.c > > @@ -399,8 +399,10 @@ qat_sym_build_request(void *in_op, uint8_t > > *out_msg, > > } > > min_ofs =3D auth_ofs; > > > > - auth_param->auth_res_addr =3D > > - op->sym->auth.digest.phys_addr; > > + if (ctx->qat_hash_alg !=3D ICP_QAT_HW_AUTH_ALGO_NULL > || > > + ctx->auth_op =3D=3D > > ICP_QAT_HW_AUTH_VERIFY) > > + auth_param->auth_res_addr =3D > > + op->sym->auth.digest.phys_addr; > > > > } > > > > -- > > 2.25.1 >=20 > Acked-by: Fan Zhang This patch should be backported, the following line should be added after t= he Fixes line: Cc: stable@dpdk.org Regards, Bernard.