From: "Iremonger, Bernard" <bernard.iremonger@intel.com>
To: Sowmini Varadhan <sovaradh@linux.microsoft.com>
Cc: "sowmini05@gmail.com" <sowmini05@gmail.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"thomas@monjalon.net" <thomas@monjalon.net>
Subject: Re: [dpdk-dev] [PATCH v2 2/2] examples/flow_classify: add an ACL table for tcp
Date: Thu, 19 Aug 2021 16:21:14 +0000 [thread overview]
Message-ID: <DM6PR11MB2890C519EE9304FE612A8830EFC09@DM6PR11MB2890.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20210819152009.GA24347@microsoft.com>
Hi Sowmini,
Looking closer at this patchset, I am not sure that a second ACL table is needed.
The existing ACL table handles UDP, TCP and SCP, however it is not processing the TCP flags.
I think it just needs to be modified to process the TCP flags.
Could you take another look to see if the above proposed solution will work for you.
Regards,
Bernard.
> -----Original Message-----
> From: Sowmini Varadhan <sovaradh@linux.microsoft.com>
> Sent: Thursday, August 19, 2021 4:21 PM
> To: Iremonger, Bernard <bernard.iremonger@intel.com>
> Cc: sowmini05@gmail.com; dev@dpdk.org; thomas@monjalon.net
> Subject: Re: [PATCH v2 2/2] examples/flow_classify: add an ACL table for tcp
>
> On (08/19/21 15:06), Iremonger, Bernard wrote:
> > > v2 updates: typo fixes for checkpatch, bernard.iremonger comments
> >
> > The above line should not be added to the commit message.
> > ~/dpdk/devtools/check-git-log.sh -1
> > Wrong tag:
> > v2 fixes: typo fixes, get_tcp_flags returns -EINVAL
> >
> > The check-git-log.sh script is in your dpdk checkout, best to run this script
> before sending patches
>
> apologies, I was not aware of this, I will fix and send out v3.
> I did run check-git-log.sh but before editing the vX updates.
>
> thanks for your patience.
>
> --Sowmini
next prev parent reply other threads:[~2021-08-19 16:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-18 15:01 [dpdk-dev] [PATCH v2 0/2] TCP flow classification using 4-tuple and flags Sowmini Varadhan
2021-08-18 15:01 ` [dpdk-dev] [PATCH v2 1/2] examples/flow_classify: hooks for filters on tcp flags Sowmini Varadhan
2021-08-19 16:08 ` Iremonger, Bernard
2021-08-18 15:01 ` [dpdk-dev] [PATCH v2 2/2] examples/flow_classify: add an ACL table for tcp Sowmini Varadhan
2021-08-19 15:06 ` Iremonger, Bernard
2021-08-19 15:20 ` Sowmini Varadhan
2021-08-19 16:21 ` Iremonger, Bernard [this message]
2021-08-19 19:34 ` Sowmini Varadhan
2023-07-03 23:38 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DM6PR11MB2890C519EE9304FE612A8830EFC09@DM6PR11MB2890.namprd11.prod.outlook.com \
--to=bernard.iremonger@intel.com \
--cc=dev@dpdk.org \
--cc=sovaradh@linux.microsoft.com \
--cc=sowmini05@gmail.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).