From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id A49AAA0C5B;
	Fri,  5 Nov 2021 04:18:58 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 8B33341100;
	Fri,  5 Nov 2021 04:18:58 +0100 (CET)
Received: from mga14.intel.com (mga14.intel.com [192.55.52.115])
 by mails.dpdk.org (Postfix) with ESMTP id 0ACE4410FD;
 Fri,  5 Nov 2021 04:18:56 +0100 (CET)
X-IronPort-AV: E=McAfee;i="6200,9189,10158"; a="232085947"
X-IronPort-AV: E=Sophos;i="5.87,210,1631602800"; d="scan'208";a="232085947"
Received: from orsmga007.jf.intel.com ([10.7.209.58])
 by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 04 Nov 2021 20:18:56 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.87,210,1631602800"; d="scan'208";a="490195484"
Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86])
 by orsmga007.jf.intel.com with ESMTP; 04 Nov 2021 20:18:55 -0700
Received: from fmsmsx606.amr.corp.intel.com (10.18.126.86) by
 fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2242.12; Thu, 4 Nov 2021 20:18:55 -0700
Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by
 fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id
 15.1.2242.12 via Frontend Transport; Thu, 4 Nov 2021 20:18:55 -0700
Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.175)
 by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server
 (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.1.2242.12; Thu, 4 Nov 2021 20:18:55 -0700
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=M5idP4Ffox1W6AOhUtRK8RRgMgNsz9piG7x22V6x2BfvuPiPOJJHfrLUeSuvQAZuCWy1XT37UdZD6j2w05UwhRVZI6avVlYkyZ497bsOEptJlqVW9HEkMvKjQhAE2iPCz3Fi05SxARbpnqEzIMVw42Bf+Sb1IrzJemiCAkhXclqN1qgXe+pKrD0xs/2nuT5djcJffPBZ0/1a1TJI283Q6QskM/xRNYX+qfsYHdDcPfxsUzEb5HiKuX6ESMKhuAs52fZus+pSjKeH7RiVbRiLSf1VOfypux/23bf57mQTUj+J7DEWLTOf+0HHXe+9b+ZZPCdqheNEUdYcefBDn4v9qQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; 
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=BB3VLxMYbr5rxpcqC/GqmZKYJWXXRo9alBvOOvoLkcc=;
 b=j0udxP4ckUHDOk6jwomayI5MFcoqbgFVGvpTmrTaIiLmSGnbq6u0f/kLnL7qk9YS5Qm2YyLtG30RSzrnPITiwrTPkDwcEYDNC+D2F/V+OU8B7Cibhnoggq1YSlo+low1+fTXB2sEXiGBYZc74eyfWURNSZp61i99a3ShsR/UeWMfy/3MEhnJrW82SLeWSL0N4F5CtwZ11QEq9RD9qPKr8cQSeP2/JXNI5jThu99fsscmbXWwjOYi89lOxbmuUx2C/Zs9IlDuUPMzBo8D6hwsuQ+W8RYeYVy5pKoB2SlUDj9TvyclZZeVGEbl8Vn+BvdAmzgFvvr/yBdUqEH1OtL+IA==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com;
 dkim=pass header.d=intel.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; 
 s=selector2-intel-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=BB3VLxMYbr5rxpcqC/GqmZKYJWXXRo9alBvOOvoLkcc=;
 b=faZFEOmqmWaLutvyUJU/reixuhQ3cwdp5OlDSFI6XEZUBnXNCOiYdA3vIcjYItwLpHARHlumZ4OxhJGuS2GkZt/+x+w7FtrJwVKAPap6R+bynv8ZZ5FlGHsmBY1cYmh43Y3+HaRZIEqPdMMAiDkitmcBgXAvj6Z4U6LVDKK+Ymk=
Received: from DM6PR11MB3098.namprd11.prod.outlook.com (2603:10b6:5:70::11) by
 DM6PR11MB4313.namprd11.prod.outlook.com (2603:10b6:5:203::32) with
 Microsoft
 SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 15.20.4649.15; Fri, 5 Nov 2021 03:18:52 +0000
Received: from DM6PR11MB3098.namprd11.prod.outlook.com
 ([fe80::c10c:fb75:6745:a2bc]) by DM6PR11MB3098.namprd11.prod.outlook.com
 ([fe80::c10c:fb75:6745:a2bc%3]) with mapi id 15.20.4669.011; Fri, 5 Nov 2021
 03:18:52 +0000
From: "Xing, Beilei" <beilei.xing@intel.com>
To: "Wang, Jie1X" <jie1x.wang@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
CC: "Zhang, Yuying" <yuying.zhang@intel.com>, "Li, Xiaoyun"
 <xiaoyun.li@intel.com>, "Yang, SteveX" <stevex.yang@intel.com>, "Zhang, Qi Z"
 <qi.z.zhang@intel.com>, "stable@dpdk.org" <stable@dpdk.org>
Thread-Topic: [PATCH] net/i40e: fix forward outer IPv6 VXLAN packets
Thread-Index: AQHXz7hz+MNxaF5+VkGg4AneuTsPwKv0R1iQ
Date: Fri, 5 Nov 2021 03:18:52 +0000
Message-ID: <DM6PR11MB30985782B70E5E58C4DFAD88F78E9@DM6PR11MB3098.namprd11.prod.outlook.com>
References: <20211102070827.141162-1-jie1x.wang@intel.com>
In-Reply-To: <20211102070827.141162-1-jie1x.wang@intel.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
dlp-version: 11.6.200.16
dlp-product: dlpe-windows
dlp-reaction: no-action
authentication-results: intel.com; dkim=none (message not signed)
 header.d=none;intel.com; dmarc=none action=none header.from=intel.com;
x-ms-publictraffictype: Email
x-ms-office365-filtering-correlation-id: 66d2b6f2-0a1b-4e1e-e5c1-08d9a00afe7c
x-ms-traffictypediagnostic: DM6PR11MB4313:
x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr
x-microsoft-antispam-prvs: <DM6PR11MB4313335004DB2D5EB5CC328BF78E9@DM6PR11MB4313.namprd11.prod.outlook.com>
x-ms-oob-tlc-oobclassifiers: OLM:8273;
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: noMTWA5Jfla0X6HzLTwoa8ftGQilZth0GxZPP4sPac2JwxFFYblCNm51IVeE8i+9adHW6SiUFMD384kO87jqarTrVmLz1qKBx05gB5BkbhccJ8/HSerlKUMLQkcvwYaINFyaLUSNi8urErFuSNp8JJD8ePeFUulMvfvqan2OwNgIPG0y4rvucxbnZx1sC3uWb9rLk9U03ROvfBdtJLaETuKeNcOdIcLazIIi0VmF5KbEh8nrwFlUTNFm1Cs+Xi1AhQgFR4ydEsFds9Zb7TvnX7eS8Ysz0NyYKfFJiUEbDK6KBr4xDEg+KxU87JHIveUurI2Y1o/sEIUnooom8fuM66IWCbiW8aJA+JOLXtUYxiBSkdMDfdmTdRAMJRrEpjImEaimaGasCycfY4Rx9oxPZtvqolQB8ujMb9ZqSxvVpKjlVCaAk7u6oV3TdeYXye+oAydSz7+QGgUi8PFF6x6hbZbxXvf6O0XndOtpOOFhhDrh6GNG0t5SAHKOoEPhsXPAJXEoINiJgDrE0Y7REQhrRysNSWhIFPpPwa75VpCuBTa0mZEWs5J+XdY6MGw7ERdV71mYjnT//NVEyhNwUtPpo35b2WUD6QO3TyCHjy1A+jP+c7B4KGyQGisY2LrWqKLhMXzAIGOw7EcY8DYZSlykU6a3u6TEp4hzT0rSPd7vXjUsw5XcnA+SG4I7IkgmB0GRmDtuU0mBLKI2X2Lv0nbfXQ==
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
 IPV:NLI; SFV:NSPM; H:DM6PR11MB3098.namprd11.prod.outlook.com; PTR:; CAT:NONE;
 SFS:(366004)(2906002)(64756008)(66556008)(26005)(8676002)(38100700002)(66946007)(66476007)(76116006)(6506007)(9686003)(66446008)(53546011)(8936002)(33656002)(5660300002)(86362001)(186003)(508600001)(83380400001)(4326008)(7696005)(55016002)(110136005)(82960400001)(54906003)(316002)(450100002)(122000001)(52536014)(71200400001)(38070700005);
 DIR:OUT; SFP:1102; 
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?wv0iTnoBVANaOB4mpsFZdwCZrLfR5cv1K9LXzzn3uYvEJHpkLpEXKcdDZiWx?=
 =?us-ascii?Q?fl0309WRv1qqHhJois+KJ3wehttSK2Yr5ec/cD9o5Ai+hke6bV9VJCdAEJ96?=
 =?us-ascii?Q?Xr6vBgkExn2VWRDeet3yTcQlEVxGtwF1w6SFOHIIEHb3jp98+8WMCMYh24Se?=
 =?us-ascii?Q?j6o+9DcjBSOZk3sYTDlrSGBpvKt5hnEyohqrXjLdzBAK1Ca2CKb+In6H3tuV?=
 =?us-ascii?Q?FIFsu3yH1Nw0cbV3j9ttTNRQSMuIyGVcdC0LdeEwjtgeM75hm/qVOjoEc043?=
 =?us-ascii?Q?66EjRlE3DKj7viDZoT8o3LjQAsFxZ+qr2IZF5CRvs9CSRtq/x7unAmf3rln9?=
 =?us-ascii?Q?2EOMXi+56ciX79+tr7vdGwo/WyNtVsvklopBqxKtZshq4nljxk/9LbC0t6xJ?=
 =?us-ascii?Q?d6Wuv5Tc6iD4bWogzPkrHX38Wf6MjygmbTv79YRztQAt4YRYPni+vplaJ4oh?=
 =?us-ascii?Q?J3X7C3wWooa9fBIQRTOxNpDfmagkJH0pIrvrIxnkcT1GwV8IaCwUCJacqcuv?=
 =?us-ascii?Q?bHn+nR6cy653MMyzOFiRtN3oBEGA7GYx/8TvXb4whfXcoGcrlS+TJR7eVX7o?=
 =?us-ascii?Q?7Z/TWpd76oUimdtGFr8rgjtseM3CbsS+KM3gY1OcLdqzK0zmY6JYzzSX8JRE?=
 =?us-ascii?Q?5Fe2yKRxUCc4yGbqsdoxO7GOMaBb7P3K87k4varAMHRsd/sMC3VsT5pUjm8O?=
 =?us-ascii?Q?7TiuqFNZ8DLEYSGq7IVmFifDqW7W5tLSzbQ3jG3cBdnQbzFTgCkC/P0tzAzN?=
 =?us-ascii?Q?MbrZ1u8euUC9kM7mzUo/DkQxPWrvpDwj1sOfX7KHNAw4bIyuaFDqo4AKV4h4?=
 =?us-ascii?Q?/uA+Iah2Fir2SjenXiBtqi6w35b8KipIUR/TR5SQdus7/n+S4tpAjdxbSJV5?=
 =?us-ascii?Q?2wJbgYuRdnWxBWSLl5Ih4LL8dcvRDuUrUFuna8t5xVv/tyNDuMfCaB4P01Fz?=
 =?us-ascii?Q?hLaW1V4N2MKz0OUearPGHiCjyVwK2fcMkd+z1YI8AcuOojCkOKmxXHlt5rin?=
 =?us-ascii?Q?vJ8OeCItwKt4lGJ96EimSCxMBHRfj4N3L6XPqMT/LQZZD8k9rqN8l5eGGE1l?=
 =?us-ascii?Q?WUyKPAuNk4ZWQEDlQaF1svZcmlTk0Z3AX22juIeIuEeCvxi/tClMHvH8c7iy?=
 =?us-ascii?Q?mYua+Lv8yPLKjhR9Q/AurTh3eMeZz1Wy2R3s+RuVi/AChjshCrYk6WNEVYdH?=
 =?us-ascii?Q?KVFWdXKR4Fx0GiVvOkRFd8iF4XPSOTiuYPq08/u+eD5xaBO1ekIxuHdZgSan?=
 =?us-ascii?Q?YFZIc00kVIx/61j2lrhy8OlRcR71rZW72kzndY0J5c5+xwpd56bzatz+IOrR?=
 =?us-ascii?Q?cHcoQ7Qp43w0C1/7sBn9qikMLjm/IMfgBAL5AmuBa0UqJc9ovK3IwpDVxKIG?=
 =?us-ascii?Q?H2JdT0wK+8KigmlkmWz8k0BmkAH3vQrt8xJyFEaKvm3QHGInjWAiX3GFrQ0U?=
 =?us-ascii?Q?Eet2MySEg3YtabsdcRiAinVszvBVw7TgBJE8qWr8iCFBu/0RPKNMuddlZ50s?=
 =?us-ascii?Q?y+lNO0iO1okzJ38LRi5BCdyyeMZkNN2kDaN8IMTU+FOiWJIJL2OuBtvGVL1A?=
 =?us-ascii?Q?ShokJd2R2yHIa3STue9g6RfLkL83skZ62MI9maT3dQMU38G+ZSmW/WfsLqPs?=
 =?us-ascii?Q?hTRgimq9rTrN8/dJBaTyFWc=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3098.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 66d2b6f2-0a1b-4e1e-e5c1-08d9a00afe7c
X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Nov 2021 03:18:52.8571 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 9Dp2FxjCD9zzelX3GhhYTsGwVXFjXRIbhRRTZy/pXFjDDNDiRqfJ7d0gA1UBVLhifNA9ZIRVM3MFS8Jwv3w2ZQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4313
X-OriginatorOrg: intel.com
Subject: Re: [dpdk-dev] [PATCH] net/i40e: fix forward outer IPv6 VXLAN
 packets
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>



> -----Original Message-----
> From: Wang, Jie1X <jie1x.wang@intel.com>
> Sent: Tuesday, November 2, 2021 3:08 PM
> To: dev@dpdk.org
> Cc: Zhang, Yuying <yuying.zhang@intel.com>; Li, Xiaoyun
> <xiaoyun.li@intel.com>; Yang, SteveX <stevex.yang@intel.com>; Xing, Beile=
i
> <beilei.xing@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>; Wang, Jie1X
> <jie1x.wang@intel.com>; stable@dpdk.org
> Subject: [PATCH] net/i40e: fix forward outer IPv6 VXLAN packets
>=20
> Testpmd forwards packets in checksum mode that it need to calculate the
> checksum of each layer's protocol. Then it will fill flags and header len=
gth into
> mbuf.
>=20
> In process_outer_cksums, HW calculates the outer checksum if tx_offloads
> contains outer UDP checksum otherwise SW calculates the outer checksum.
>=20
> When tx_offloads contains outer UDP checksum or outer IPv4 checksum,
> mbuf will be filled with correct header length.
>=20
> This patch added outer UDP checksum in tx_offload_capa and
> I40E_TX_OFFLOAD_MASK, when we set csum hw outer-udp on that the
> engine can forward outer IPv6 VXLAN packets.
>=20
> Fixes: 399421100e08 ("net/i40e: fix missing mbuf fast free offload")
Seems it's not the right fix line. Could you check if it should be 7497d3e2=
f777 ("net/i40e: convert to new Tx offloads API").

> Cc: stable@dpdk.org
>=20
> Signed-off-by: Jie Wang <jie1x.wang@intel.com>
> ---
>  drivers/net/i40e/i40e_ethdev.c | 1 +
>  drivers/net/i40e/i40e_rxtx.c   | 1 +
>  2 files changed, 2 insertions(+)
>=20
> diff --git a/drivers/net/i40e/i40e_ethdev.c b/drivers/net/i40e/i40e_ethde=
v.c
> index 62e374d19e..faf6391350 100644
> --- a/drivers/net/i40e/i40e_ethdev.c
> +++ b/drivers/net/i40e/i40e_ethdev.c
> @@ -3746,6 +3746,7 @@ i40e_dev_info_get(struct rte_eth_dev *dev, struct
> rte_eth_dev_info *dev_info)
>  		RTE_ETH_TX_OFFLOAD_IPIP_TNL_TSO |
>  		RTE_ETH_TX_OFFLOAD_GENEVE_TNL_TSO |
>  		RTE_ETH_TX_OFFLOAD_MULTI_SEGS |
> +		RTE_ETH_TX_OFFLOAD_OUTER_UDP_CKSUM |
>  		dev_info->tx_queue_offload_capa;
>  	dev_info->dev_capa =3D
>  		RTE_ETH_DEV_CAPA_RUNTIME_RX_QUEUE_SETUP | diff --git
> a/drivers/net/i40e/i40e_rxtx.c b/drivers/net/i40e/i40e_rxtx.c index
> 6ccb598677..41fe3bf481 100644
> --- a/drivers/net/i40e/i40e_rxtx.c
> +++ b/drivers/net/i40e/i40e_rxtx.c
> @@ -65,6 +65,7 @@
>  		RTE_MBUF_F_TX_QINQ |       \
>  		RTE_MBUF_F_TX_VLAN |	\
>  		RTE_MBUF_F_TX_TUNNEL_MASK |	\
> +		RTE_MBUF_F_TX_OUTER_UDP_CKSUM |	\
>  		I40E_TX_IEEE1588_TMST)
>=20
>  #define I40E_TX_OFFLOAD_NOTSUP_MASK \
> --
> 2.25.1