RE: [PATCH v4 5/6] net/iavf: support L2TPv2 for AVF HASH

["Xing, Beilei" <beilei.xing@intel.com>]

> -----Original Message-----
> From: Wang, Jie1X <jie1x.wang@intel.com>
> Sent: Tuesday, February 8, 2022 4:39 PM
> To: dev@dpdk.org
> Cc: Yang, SteveX <stevex.yang@intel.com>; orika@nvidia.com; Singh, Aman
> Deep <aman.deep.singh@intel.com>; Yigit, Ferruh <ferruh.yigit@intel.com>;
> thomas@monjalon.net; andrew.rybchenko@oktetlabs.ru; Wu, Jingjing
> <jingjing.wu@intel.com>; Xing, Beilei <beilei.xing@intel.com>; Zhang, Qi Z
> <qi.z.zhang@intel.com>; olivier.matz@6wind.com; Wang, Jie1X
> <jie1x.wang@intel.com>
> Subject: [PATCH v4 5/6] net/iavf: support L2TPv2 for AVF HASH
> 
> Add support for PPP over L2TPv2 over UDP protocol and L2TPv2 protocol RSS
> hash based on outer MAC src address and L2TPv2 session ID.
> 
> Patterns are listed below:
> eth/ipv4/udp/l2tpv2
> eth/ipv4/udp/l2tpv2/ppp
> eth/ipv6/udp/l2tpv2
> eth/ipv6/udp/l2tpv2/ppp
> 
> Signed-off-by: Jie Wang <jie1x.wang@intel.com>
> ---
>  doc/guides/rel_notes/release_22_03.rst |  6 ++
>  drivers/net/iavf/iavf.h                |  2 +
>  drivers/net/iavf/iavf_generic_flow.c   | 34 +++++++++++
>  drivers/net/iavf/iavf_generic_flow.h   |  6 ++
>  drivers/net/iavf/iavf_hash.c           | 83 ++++++++++++++++++++++++--
>  5 files changed, 127 insertions(+), 4 deletions(-)
> 
> diff --git a/doc/guides/rel_notes/release_22_03.rst
> b/doc/guides/rel_notes/release_22_03.rst
> index 9a507ab9ea..0d1e4a0b61 100644
> --- a/doc/guides/rel_notes/release_22_03.rst
> +++ b/doc/guides/rel_notes/release_22_03.rst
> @@ -64,6 +64,12 @@ New Features
> 
>    * Added rte_flow support for matching GENEVE packets.
> 
> +* **Updated Intel iavf driver.**
> +
> +  Added L2TPv2(include PPP over L2TPv2) RSS hash distribute packets
> + based on outer MAC src address and L2TPv2 session ID.

Add * on the front.

> +
> +
>  Removed Items
>  -------------
> 
> diff --git a/drivers/net/iavf/iavf.h b/drivers/net/iavf/iavf.h index
> 0bb5698583..a01d18e61b 100644
> --- a/drivers/net/iavf/iavf.h
> +++ b/drivers/net/iavf/iavf.h
> @@ -93,6 +93,8 @@
> 
>  #define IAVF_VLAN_TAG_PCP_OFFSET 13
> 


<...>

> +/* L2TPv2 */
> +#define IAVF_RSS_TYPE_ETH_L2TPV2	(RTE_ETH_RSS_L2TPV2 | \
> +					 RTE_ETH_RSS_ETH | \
> +					 RTE_ETH_RSS_L2_SRC_ONLY)

Should we limit with L2_SRC_ONLY?

> +
>  /**
>   * Supported pattern for hash.
>   * The first member is pattern item type, @@ -547,6 +589,8 @@ static struct
> iavf_pattern_match_item iavf_hash_pattern_list[] = {


<...>


> --
> 2.25.1