From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E1EAAA09F0; Thu, 17 Dec 2020 10:06:26 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6E7DBCA0A; Thu, 17 Dec 2020 10:06:19 +0100 (CET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id 33A80CA0A for ; Thu, 17 Dec 2020 10:06:17 +0100 (CET) IronPort-SDR: YnrRUqZr13yugil/XqKrcWfm1TVnLNqkv6cScp7DTIbRYspMD2SlslRsxXIPaiIbPCdoxnUZQ0 leubmu3qx5/g== X-IronPort-AV: E=McAfee;i="6000,8403,9837"; a="175321649" X-IronPort-AV: E=Sophos;i="5.78,426,1599548400"; d="scan'208";a="175321649" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Dec 2020 01:06:15 -0800 IronPort-SDR: n3Irfsu+DpmjrT96Zfsi7QBi+g5h8pH+DHoJnsxZZOasjohdXGooLCN+ylNYntQjC4Jh79geSU Oynxg2p0WUmQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.78,426,1599548400"; d="scan'208";a="385318454" Received: from orsmsx605.amr.corp.intel.com ([10.22.229.18]) by fmsmga004.fm.intel.com with ESMTP; 17 Dec 2020 01:06:14 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX605.amr.corp.intel.com (10.22.229.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 17 Dec 2020 01:06:14 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Thu, 17 Dec 2020 01:06:14 -0800 Received: from NAM12-MW2-obe.outbound.protection.outlook.com (104.47.66.47) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Thu, 17 Dec 2020 01:06:14 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=n4WP+GFby6/EkPnFbd4lQBuWLDlggAkVP8amicQjWWW/VmJ859MUbrasSKaEtJwuHTq5oaO3ElkaAhVXO/ljEzkToBnbcURmxGdPDTnW/roWd9qsbiBsXd/qNZxULzAo3pI0vL2va4jr4YfcyQdWKwRS1hYNcp2O8kodfYg08Kk5Ycb/LwpFum1dC9H28UCUmWdo2C5lV69PBZYjTIwGq7t3UwLkTS2Svt3cd7hLbsDmtILQKSt5REZp1dPXv3opVMpA576eFO0lcXy1E/HWdo37rVpJXS+4XY4/Wckp74lGtejBQD79+m97TEWHFOkwkzW304XdyDSGXZgMW1TlLw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LeB+L9KOgH88j1FzAed0FpXOEFTZGwaUNQuJoLBNqdk=; b=d9dce038UlyyOq4FbWEyuDyGgQkwjxllYLa1QOzGmf52No1hFvJGpfEC8JlbyfOS5tOsG3uonIZ9VIAQWH+ehFCVg2ijPLomyEJwOKg7h2bSBIwvwAlGUeRN6rE9ynvbJqRTKGPWKQHTevDHsXkNZYO//hil2Zx3F4QGLNBi3sDQTXYnOz4Kpq4H0A8SJ/UJQ9LNtLFkG+k3KeqxxcgANKpXR9XkMzmh8k7sUVK4YbMhUgWT6BdjoC45DkD8KUwL4SCop5FK4o7s3pbHmt8LhnS6X1g1rcy13khFPnAY7VKE4ns35WT1l3Z6BM2BhVH7zb+js8LIYPlOohV/Uinlhw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LeB+L9KOgH88j1FzAed0FpXOEFTZGwaUNQuJoLBNqdk=; b=cfxK/ynkZKUE4G007h7fUx7sNgf/ojIwOW5e/crXeJsmjW5sMaEn3A4kasNYhbpVo+1PEn7znl5qGloVutLMIKMT49MlnpRCLu46/aj5aA+8RDNT3IZZaPMnlGYfGAbUhDEX91H5AwLgWt4VBL/XfEOnROUgxnPr0Hee7DyioXo= Received: from DM6PR11MB3099.namprd11.prod.outlook.com (2603:10b6:5:6c::16) by DM6PR11MB3788.namprd11.prod.outlook.com (2603:10b6:5:13a::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3654.17; Thu, 17 Dec 2020 09:06:13 +0000 Received: from DM6PR11MB3099.namprd11.prod.outlook.com ([fe80::ed5e:7ba1:3c86:69ff]) by DM6PR11MB3099.namprd11.prod.outlook.com ([fe80::ed5e:7ba1:3c86:69ff%5]) with mapi id 15.20.3654.025; Thu, 17 Dec 2020 09:06:13 +0000 From: "Chen, BoX C" To: "Xing, Beilei" , "Amber, Kumar" , "dev@dpdk.org" CC: "Zhao1, Wei" Thread-Topic: [dpdk-dev] [PATCH v2] net/i40e: fix argument in RSS action Thread-Index: AQHWuBPd/JPUxnB9l0qrAV9cMUhVeqn61vCAgABfRuA= Date: Thu, 17 Dec 2020 09:06:13 +0000 Message-ID: References: <20201110180409.42133-1-kumar.amber@intel.com> <20201111101031.52758-1-kumar.amber@intel.com> In-Reply-To: Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.46.46] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: fb1d43da-136a-4164-843b-08d8a26b010d x-ms-traffictypediagnostic: DM6PR11MB3788: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: +MtbPMdl1T0w5nQspaVVxPwlB6aJOwyj2Kcj3URyyWZP5PWyuF1C2NX8RGqomlSwClHxs4hcFktNotG7x6gVxf5l/J1cGgsFJRvT6ZxJlG8Qzw5cUFjk/sNQwbu+UODD7Nr8p3iuPKqrm6Jd85bHXqBFY0rOFrAIko3I4kHeaO568BEbVCoIwuQwFKMKtAcFlx7P/aEFNQZHxEIejPb7+r5otN/Tk3dp4tS1Kri1R998R/dxX1RVRNgX60nSQeLPNSbC3g2Gg7ww6nVnnFjOU1rMpVoEJqd9SZ1k0cSRWvXqG9zdMosaP8R816hluZlBk9fx3coM0+FqPLb2DCls0Q== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB3099.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(376002)(366004)(136003)(396003)(39860400002)(9686003)(6506007)(66446008)(64756008)(26005)(4326008)(107886003)(55016002)(8936002)(83380400001)(71200400001)(33656002)(316002)(5660300002)(2906002)(52536014)(53546011)(86362001)(76116006)(8676002)(186003)(66476007)(110136005)(66556008)(7696005)(66946007)(478600001); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?SwQrTTYgnGz7G5brYOasAimy+VcAxEY3MayaORbsE8x516WEdL4xjzzA1yGa?= =?us-ascii?Q?I6skvywrhXNg0lvmgQ7wo5/DPWdVPF4BJwbzL5N+KCUKtUuTUzN3j1oM6+AV?= =?us-ascii?Q?+ebBrxc9TQ18kZI2bNiOssiexdB5P9NSvbcTkREMnH/BLRc0M2T8HV0lSZyF?= =?us-ascii?Q?QwunyU6YOgILOOPlWzC2MFBd1+URBmWDs13WHK7mV0IRe0ZzJaTGz/ryRJ30?= =?us-ascii?Q?KkYla7fmCQPmIfctm80MQvc7np67cFkfhYWPqY5FEsxjdIGu+zGT9I3TzcfJ?= =?us-ascii?Q?PrFkQf3fhMPBMBvHf1I5KDThD9KYnL0ts/vM7g/1vK/6Hww88OKlnCFu/9ZL?= =?us-ascii?Q?UBYoD2Tt8+Ks9SEh73NRiEOd3fc4sfGxi+DA5i5YB5tMklywO48TjujJkpaM?= =?us-ascii?Q?pBDyLEis4Ik2tiXtD0Mhwej41tVd7w2xMej81lqJzyi5RYq2Z6KXTcE9+JS/?= =?us-ascii?Q?4m5Q8QcSz1uvE1tcwslWVFGP47G68m5vzMBA7BOqeY66fB0NSQGW92HpV5wc?= =?us-ascii?Q?t02IpN53Q4OwQQyK75n2n5D8mSccaiaA1hiJu32mxwKapyw2ga6ofrncKMP/?= =?us-ascii?Q?HhxpukSJrCkqD3b+vfb+s36ICIYnUetzqNpFJLwjA7NmiqRxRmLFY/PIicHo?= =?us-ascii?Q?IMed9f1SDagYrrHmD5ySi9bC9J7HF8xJCHiaYEbLdB5rou00X31pMVfiIjok?= =?us-ascii?Q?FOMzAq91GDA0KCJ2Bi1rIN4Xpxm/oDE0kOZ4nBRxpZSgsYOOpTcWIl81QSCZ?= =?us-ascii?Q?Tq6mrRWH/buqtTNwbi3Y0POdOTw5q7vZIk68cvxcLP65X1vVAV12mjJyka2x?= =?us-ascii?Q?FIZSb5oMbzi5wISd5YDec/pdhyzri3C52KW8hQ0RowN/pEqTqcMmLWBRKETa?= =?us-ascii?Q?tAENPBFO0tiANLuYQuiv2rYSg+rSmfw09g7kRPXQGV43lbR/cJPJWl8YU9qc?= =?us-ascii?Q?x8b552vUfa/2aq/IFTEnhGFnmbIRBG4VV6iVPbXMC88=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3099.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: fb1d43da-136a-4164-843b-08d8a26b010d X-MS-Exchange-CrossTenant-originalarrivaltime: 17 Dec 2020 09:06:13.4299 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: lx/G7JrGzW9QIAFwjR4VdOOC9VZnp6FihIClDv4b9YkSY/AueH1lBTsy+xfTn376jfDAeMIeUXQkbFljgM/wCw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB3788 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2] net/i40e: fix argument in RSS action X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Hi, Beilei If you merge this patch, some common rules will fail to set on fvl, such as= : flow create 0 ingress pattern eth / ipv4 / udp / end actions rss types ipv4= -udp end queues end / end Regards, Chen Bo > -----Original Message----- > From: Xing, Beilei > Sent: December 17, 2020 11:20 > To: Amber, Kumar ; dev@dpdk.org; Chen, BoX C > > Cc: Zhao1, Wei > Subject: RE: [dpdk-dev] [PATCH v2] net/i40e: fix argument in RSS action >=20 > Hi, >=20 > According to Bo's test, this fix patch will cause other cases fail, so NA= CK. > @Bo, could you please detail which cases will FAIL, thanks. >=20 > BR, > Beilei >=20 > > -----Original Message----- > > From: dev On Behalf Of Kumar Amber > > Sent: Wednesday, November 11, 2020 6:11 PM > > To: dev@dpdk.org > > Cc: Zhao1, Wei > > Subject: [dpdk-dev] [PATCH v2] net/i40e: fix argument in RSS action > > > > The driver must check for the queue number in the RSS action list and > > if not should return with a proper error message to user. > > > > Bugzilla ID: 573 > > Fixes: 9486d60b94b5 ("net/i40e: fix flow RSS queue index check") > > Cc: wei.zhao1@intel.com > > > > Signed-off-by: Kumar Amber > > --- > > drivers/net/i40e/i40e_flow.c | 11 +++++++++++ > > 1 file changed, 11 insertions(+) > > > > diff --git a/drivers/net/i40e/i40e_flow.c > > b/drivers/net/i40e/i40e_flow.c index 5bec0c7a84..975340cb1a 100644 > > --- a/drivers/net/i40e/i40e_flow.c > > +++ b/drivers/net/i40e/i40e_flow.c > > @@ -4917,6 +4917,17 @@ i40e_flow_parse_rss_action(struct rte_eth_dev > > *dev, > > NEXT_ITEM_OF_ACTION(act, actions, index); > > rss =3D act->conf; > > > > + /** > > + * Check if Queue number is specified > > + * in argument else throw an error. > > + */ > > + if (rss->queue =3D=3D NULL) { > > + rte_flow_error_set(error, EINVAL, > > + RTE_FLOW_ERROR_TYPE_ACTION, > > + act, "Queue numbers not given."); > > + return -rte_errno; > > + } > > + > > /** > > * RSS only supports forwarding, > > * check if the first not void action is RSS. > > -- > > 2.17.1