From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 28C6CA04B5; Wed, 13 Jan 2021 09:13:27 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 93047140E61; Wed, 13 Jan 2021 09:13:26 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 4DF45140E59 for ; Wed, 13 Jan 2021 09:13:24 +0100 (CET) IronPort-SDR: /o/zahemRfCE1ErH71qBRy3SAJl34dis+MFBzKPg78VqD3fClgwYVyc5aAINzvPJQ3bXYrryCd gNHVov4gWAkQ== X-IronPort-AV: E=McAfee;i="6000,8403,9862"; a="242242560" X-IronPort-AV: E=Sophos;i="5.79,343,1602572400"; d="scan'208";a="242242560" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Jan 2021 00:13:20 -0800 IronPort-SDR: GXC3j9HB4akR/3Z0W0b3nUtk1XoAbN4YD8jaaPeNDfHQquNfNed0SIaZIRBenQ60DIdr/vFYPx C0YN1m3Id1cg== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.79,343,1602572400"; d="scan'208";a="389422859" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga007.jf.intel.com with ESMTP; 13 Jan 2021 00:13:19 -0800 Received: from fmsmsx609.amr.corp.intel.com (10.18.126.89) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Wed, 13 Jan 2021 00:13:16 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx609.amr.corp.intel.com (10.18.126.89) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Wed, 13 Jan 2021 00:13:16 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.175) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Wed, 13 Jan 2021 00:13:15 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=RqQcQV2kQxHg3DICR5OScCUFuu6OP35c5HHl8Dh6SOSauKYUeHiD7agLKaRP2g3+EvV28RMAa0oTlEhMDt2XYK30BKZmmOWUqIgMmQ7GngapCLHWxZgpCLtHltSvELApe5HMaYrua7cov1J8PLC06PaIp0MLkuQJ/qIw40mf+fWWfx/Yf3V3KqPz267+4BFMvyYDLzPvvITmmTXqwOdqeU7rLLWFtnglvVUHyQonb9yJdL9/Ve6JUdsamGXlc2TQ26SBBQkKYxQykqA1mGpbImXQoaLQncd7dRUcmP5laEpcMJRlGnqaTWczxv2y/hLvOsVpoQFnv3xMn85VzM3vaw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GJKAVHoLdbmbJ7ATI8Kqpf5G3uAX1j8C+PMVl8i9rRk=; b=ZWfc4ZlgAavkWIQtXYUnprVLuQsOHzopXrxW6Y5275alKj5h6VGETw63+mI0X+FE9MN5HOFwhv2t6AveAQCfBguvJZTWAOynG30p8BWQOeUWNn8q0sFJ82b7jyfqsEvU63htazo6OSaOgrJaLjYRkpMm8LYGIRT6SaOKq94ZWobHM50vtmZsgfbimPO+SLfA8l8WHWLCy71awbrw6nHiBFI1Y3bGQcoFdiTG8+2fGQ8oPq2yddPNstmgOuwFU0MSkkIkjC0qV+Kk3xo6Bd3Rdkebl7C+K+ChTv9BO7yMR8lLSjX+xHjd0jEhZHMg6dJO1deCmIAHviIpDmHFx9dl+Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=GJKAVHoLdbmbJ7ATI8Kqpf5G3uAX1j8C+PMVl8i9rRk=; b=Y0W9uzsp2bMxyQQC+pjTbCvnhSrbECCvHC3BRrU7phjg+l6x9CYPqfESNexekGJRY6A0FtC5E4uk0YIOFytMvduE/FrDhZuWc9s6XPHzeRfxID5yin+eEtIr0eNyU8IFDBBeqg/4INm7H0+3OIiB3TN7BNn8k6+eyI59f7U3ySw= Received: from DM6PR11MB3099.namprd11.prod.outlook.com (2603:10b6:5:6c::16) by DM6PR11MB4313.namprd11.prod.outlook.com (2603:10b6:5:203::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3763.9; Wed, 13 Jan 2021 08:13:14 +0000 Received: from DM6PR11MB3099.namprd11.prod.outlook.com ([fe80::b04e:3b0e:296a:bfa1]) by DM6PR11MB3099.namprd11.prod.outlook.com ([fe80::b04e:3b0e:296a:bfa1%6]) with mapi id 15.20.3742.012; Wed, 13 Jan 2021 08:13:14 +0000 From: "Chen, BoX C" To: "Yang, SteveX" , "dev@dpdk.org" CC: "Lu, Wenzhuo" , "Xing, Beilei" , "Iremonger, Bernard" , "Li, Xiaoyun" , "Yang, Qiming" , "Yang, SteveX" Thread-Topic: [dpdk-dev] [PATCH v2] app/testpmd: fix dynamic config error Thread-Index: AQHW2QlvQ3kGOakzSkuHIKbEkHB4KaolVbSQ Date: Wed, 13 Jan 2021 08:13:13 +0000 Message-ID: References: <20201222081335.17419-1-stevex.yang@intel.com> <20201223085152.20866-1-stevex.yang@intel.com> In-Reply-To: <20201223085152.20866-1-stevex.yang@intel.com> Accept-Language: zh-CN, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.55.46.46] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 819f72d4-bead-4322-2c7d-08d8b79b1314 x-ms-traffictypediagnostic: DM6PR11MB4313: x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:7691; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: BFaCLEkJvKSNLBdoy2WIhDGlAYydYllSOyT4hZ9c52XPQ+OMMfSB2dVvW4TiPS9zaQ8tIT6fC2qo3n/MD2lNY78bVpeCT36o6JHIXPwqOI5eA7lwTCH1hmWT+bGc/KdeV5oACHU4D3YQw2JKpAmr5BB61YwTD/HHd6PeJVzDL86eoK/OY8CCWdnqSjT1FA9dD44dawzYOdkQcXmZxHiOm8fNR7oEK0YjfwquVnkjCICgUqd7O/Xe58AQxu0uus2/VOoLeZiAhp04PHtPTeSoBui5jRUWWPzFw3AUzBEiQhKupVx3Zsnw9BK9+SaJu4q8b8cFMK/D4rfOmBJrsyH+rXgrp7z7nqEW+FuOgnoJifxDhnDRZN0nttmMlruHbEazpc17Ppdu8wQbXLTf6JysaQ== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB3099.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(366004)(39860400002)(136003)(376002)(396003)(52536014)(55016002)(66556008)(64756008)(66446008)(54906003)(316002)(66946007)(66476007)(8676002)(186003)(86362001)(76116006)(110136005)(4326008)(71200400001)(9686003)(107886003)(6506007)(53546011)(7696005)(83380400001)(33656002)(2906002)(478600001)(8936002)(26005)(5660300002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: =?us-ascii?Q?xSsQBR47F1j9a7p6wS0zJPpxIXmKm0EE7kPmZJO46DLewWlF7MDtLQB55sYV?= =?us-ascii?Q?QF1MZuHNbDgwEZdias6kuS4WstgyZwF5wRvs/00McMswV253+D160SgWK9wi?= =?us-ascii?Q?3XIhOjxS+dwowzpyVt4joZC1hidlk97uPieoVcqzc20Szi7Qxjnm4s0mHejD?= =?us-ascii?Q?uFayWbK0Uu30U35mcAP/Bxin7DKpX6l1mfRgp9jW+vv1jwRSg+n6arjrMTh7?= =?us-ascii?Q?YOVnihQYluYwtW6mpv6BUk9WeQri04k4a29y8TAcBasn0nojU9/pZPK6fgXZ?= =?us-ascii?Q?NVoxmTOPi47UtAq2hF8B2W4o/N52c0qDfdQPL5MmkNm8/mwpj5/vbvj1TM4Z?= =?us-ascii?Q?EqGZyv0r1nGbhuAj8BJtBcOs4naLn7RbIVUa8hKGxVXADzGqdKCxeZlNNk/K?= =?us-ascii?Q?Wc7J5wavVa3Jd1XvA2CLutLon//Lvzr+QkNkLhImTTVqjnJUmCzSdLEWAxPU?= =?us-ascii?Q?xcchyIfYojol2CRx5P42opw7JnFmWTGMM/WJ08+weS4pp+L11S6jM4gSrpq6?= =?us-ascii?Q?NqzAbJDF92W3EfHmNQkTcW8rmW+Ba3Blplmopgz6R2zsuiZbdiFGHyTJdFpT?= =?us-ascii?Q?u1WDZGEcPPf090XsaV748oQsBVCnwkO6hl1vpv6+23N58LtGKMKtvR9LF1Pe?= =?us-ascii?Q?+Tu2Er8ooangYqVlHTU/eiwAnm3+jR6Q9bXu8LL+0BQ3ZH8Xj3BNCyXXSIJx?= =?us-ascii?Q?VcVS668zkgo3snnyAeRRJul+4Z/EtuMFTSeXlJSquq8KZ+gx0NmfBQrteMYl?= =?us-ascii?Q?pFWXxDGcP5OZ18/Q9iKPpOERRwlGkM69CSWH5We1ApDoB4DudGUXOeSNEwCe?= =?us-ascii?Q?iday+3DBTG/yU4d9x3D3tRATAR7CE4hpdjhgayCw2iHp/csg/Gi/nxmYxyPZ?= =?us-ascii?Q?WAKKIgIlwrhEhIlQ3ZhmLecFGxRnXO6pqKSVIxGzjERSmXO58XhkrncnADBJ?= =?us-ascii?Q?jq5NLWSPV4bIlNH1ljHC9VHu4NB50G6L0R1ftH0HW4U=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3099.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 819f72d4-bead-4322-2c7d-08d8b79b1314 X-MS-Exchange-CrossTenant-originalarrivaltime: 13 Jan 2021 08:13:13.9629 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: +jqbWYUD7fNGtgf/p3V+Gco3SHyDGrSXdDeO8P2u3vwqe1K3bfn/uqQj5adDXG1pputMay1bsTl2CWZon2c3KQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4313 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2] app/testpmd: fix dynamic config error X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Tested-by: Chen, BoX C Regards, Chen Bo > -----Original Message----- > From: dev On Behalf Of Steve Yang > Sent: December 23, 2020 16:52 > To: dev@dpdk.org > Cc: Lu, Wenzhuo ; Xing, Beilei > ; Iremonger, Bernard > ; Li, Xiaoyun ; Yang, > Qiming ; Yang, SteveX > Subject: [dpdk-dev] [PATCH v2] app/testpmd: fix dynamic config error >=20 > The offloads of 'tx/rx_conf' didn't keep up with the corresponding offloa= ds > of 'dev_conf', it would cause the configuration invalid. >=20 > For example: > Configuring 'max-pkt-len' would change 'rx_offloads' in dev_conf while > rx_conf.offloads of each queue still kept the old value. > It would cause the failure of offloads check in 'rte_eth_rx_queue_setup'. >=20 > This patch applied tx/rx offloads configuration for each queue once it > changed. >=20 > Fixes: 5e91aeef218c ("app/testpmd: fix offload flags after port config") >=20 > Signed-off-by: Steve Yang > --- > v2: > * moved the update logic to 'rxtx_port_config'; > * added the 'tx_conf' part; > * optimized the 'default' assignment; > --- > app/test-pmd/testpmd.c | 16 ++++++++++------ > 1 file changed, 10 insertions(+), 6 deletions(-) >=20 > diff --git a/app/test-pmd/testpmd.c b/app/test-pmd/testpmd.c index > 33a060dffd..6ee28e3797 100644 > --- a/app/test-pmd/testpmd.c > +++ b/app/test-pmd/testpmd.c > @@ -3288,9 +3288,11 @@ rxtx_port_config(struct rte_port *port) >=20 > for (qid =3D 0; qid < nb_rxq; qid++) { > offloads =3D port->rx_conf[qid].offloads; > - port->rx_conf[qid] =3D port->dev_info.default_rxconf; > - if (offloads !=3D 0) > - port->rx_conf[qid].offloads =3D offloads; > + if (offloads !=3D port->dev_conf.rxmode.offloads) > + port->rx_conf[qid].offloads =3D > + port->dev_conf.rxmode.offloads; > + if (!offloads) > + port->rx_conf[qid] =3D port->dev_info.default_rxconf; >=20 > /* Check if any Rx parameters have been passed */ > if (rx_pthresh !=3D RTE_PMD_PARAM_UNSET) @@ -3313,9 > +3315,11 @@ rxtx_port_config(struct rte_port *port) >=20 > for (qid =3D 0; qid < nb_txq; qid++) { > offloads =3D port->tx_conf[qid].offloads; > - port->tx_conf[qid] =3D port->dev_info.default_txconf; > - if (offloads !=3D 0) > - port->tx_conf[qid].offloads =3D offloads; > + if (offloads !=3D port->dev_conf.txmode.offloads) > + port->tx_conf[qid].offloads =3D > + port->dev_conf.txmode.offloads; > + if (!offloads) > + port->tx_conf[qid] =3D port->dev_info.default_txconf; >=20 > /* Check if any Tx parameters have been passed */ > if (tx_pthresh !=3D RTE_PMD_PARAM_UNSET) > -- > 2.17.1