From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 986C6A04DD; Fri, 30 Oct 2020 07:56:18 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E011B5AB9; Fri, 30 Oct 2020 07:56:15 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id C3E5D5913 for ; Fri, 30 Oct 2020 07:56:12 +0100 (CET) IronPort-SDR: Ht6DH0g5+DmVD+OzIDt/lryMKIUuAQwDTVv+W+H2tDhfDEWiGybjIuBeajDlArVnY6GxtcGKfQ pWGml0KnUiHw== X-IronPort-AV: E=McAfee;i="6000,8403,9789"; a="147852793" X-IronPort-AV: E=Sophos;i="5.77,432,1596524400"; d="scan'208";a="147852793" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Oct 2020 23:56:10 -0700 IronPort-SDR: rRkwMfaxv40QvcmLvAeDZNlCnE3JbWfL60pMxknyFTJMvy1668rL719KVzCdcXiRav3PY59TVr flNvz98hu7kQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,432,1596524400"; d="scan'208";a="335348346" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga002.jf.intel.com with ESMTP; 29 Oct 2020 23:56:10 -0700 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 29 Oct 2020 23:56:09 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Thu, 29 Oct 2020 23:56:09 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.107) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Thu, 29 Oct 2020 23:56:09 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=MV0hBY4WWvHLEhAuLewns4NxA8eoiFI60gTujJvQzdTlnShMQMSUvzqul8KWnTCsphAH3NYsi1Ydw29ZBIE3kiM6VgLqLw/rKf1u98wlezZIP1RLEsV48LALGqgIUPfVmmI6mRBar5TLd3zkAlq5Zvpd9egctlPWNsH66TS8ML5yheen8HQiczl4j1+o3iQmEYfp4PBxTH/b2u6mMhgXkUI+hl0RLeDqSa1tB6/pKC+ozmzy2a7QdQm8LbTqniq7FYIinFCU4zBb728N10/a4O1NkcCn8NbhF9sqAzwRA3hQFqyeDvN8WKjMVWCZujdDB20z48qyW8RoqDyU/shwIQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=18p6zIW2Dh3mMzr8U6ISbhSe14pSt00LLu0fzwbO5Js=; b=d5kfCf/K1OYN22CzdQcB56HPZ7G4AZYI1TitVGK0lvUKV5Wp8cpyKBm4ifiE8w4BN0IJooT3Y21CiL2DA1kilx5jGmBw4F0z6xB77wNEprzge9Voln99F7bjy3q2hPpVk5To+as2fHQJp7x8xJu44DqaC7wqv9hkv/U6Nhq7I7K/BlDKc4tHUOnUdYEZtrJy9lGGkkWuQX0V459pbwSBnFvFs/EB5wArSDK9d+o6xlFbY7TpTvdYCuiiXlURXL9WjysW6+kgC3x6OgHcSRFuQiJUGubQV6SJjP+QP1gEgojMzXUgUZr83NDtJKLLUw57xLA+n29H9N2RgjHI4WIq6w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=18p6zIW2Dh3mMzr8U6ISbhSe14pSt00LLu0fzwbO5Js=; b=j8AmcN1OnjPs+BRLS2r940iaoIgr5qehiSbdyOFghQCLpQhg4WK3Uo15GX2A86vLNJRioi5F0wICPQEv6C10t8oi/PLGEUKqwII0cGzFYz2KAwMsfGHNzO+XxQ4QaD/LVCMkAUH6N/qIa9j+XatIuOywnyAVYrfJpaNvuZ7jnDI= Received: from DM6PR11MB3131.namprd11.prod.outlook.com (2603:10b6:5:6d::32) by DM6PR11MB4298.namprd11.prod.outlook.com (2603:10b6:5:204::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.18; Fri, 30 Oct 2020 06:56:06 +0000 Received: from DM6PR11MB3131.namprd11.prod.outlook.com ([fe80::559e:3d25:c361:c5e6]) by DM6PR11MB3131.namprd11.prod.outlook.com ([fe80::559e:3d25:c361:c5e6%5]) with mapi id 15.20.3477.024; Fri, 30 Oct 2020 06:56:06 +0000 From: "Zhang, Tianfei" To: "Huang, Wei" , "dev@dpdk.org" , "Xu, Rosen" , "Zhang, Qi Z" CC: "Huang, Wei" Thread-Topic: [dpdk-dev] [PATCH v2 1/2] raw/ifpga: terminate string filled by readlink with null Thread-Index: AQHWrlsn9Bz1mPfMrEOMSyncTpSiLqmvtTfw Date: Fri, 30 Oct 2020 06:56:06 +0000 Message-ID: References: <1604017294-23479-1-git-send-email-wei.huang@intel.com> <1604017294-23479-2-git-send-email-wei.huang@intel.com> In-Reply-To: <1604017294-23479-2-git-send-email-wei.huang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.5.1.3 dlp-reaction: no-action authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.206] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 105ee715-3004-4307-9a25-08d87ca0dfd1 x-ms-traffictypediagnostic: DM6PR11MB4298: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:2582; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: 014oafhw7IEdOFWcjKpx6DmZJKIXpyc3lcIlns9MpXSBtSOtUurnRpHQjzCVoFAdRnVCEAoGtDceO0htMBZ+bOQs2F2En8M8kt17zfAS2DGfG95r3vveuEpleVWI9A4dHoN3kc+48SOcYBxUj+von4VBUxX34kgEvEe5mqpFOOS8ToF7oB40AejZpAnX+R7Sx6sWAichFi0l5SjRFGiTm4P16tItoy7AptswXnjdD2AuOpGh3MSwhKLJUuaO520Xy3bf1ugKzxvE283NfbskXg/aVEfkbhmiyPSe5lrRuNdXWTcJYC65K6bkQYetCmw6 x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB3131.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(366004)(136003)(376002)(396003)(346002)(7696005)(52536014)(8936002)(71200400001)(478600001)(9686003)(6636002)(86362001)(53546011)(33656002)(6506007)(5660300002)(26005)(83380400001)(2906002)(107886003)(186003)(66946007)(4326008)(110136005)(316002)(66476007)(64756008)(66446008)(66556008)(55016002)(76116006); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: IxdeYu1hCezgBNGGLmB7tPrE/aVsn3KDC9MmHvtpjkrbKW4JTpzAiILSrRuIfXPkWrIXn3a/MddU12p6n+m+3D8AR55zOWrcJJY7GKWH6ft9/1lIvU+5wsDvU+ooi7CrS1rSGM0OlQp2n9y8qDfvlFczHNIjQ4lGfPNNqzimRjyjZWYuloT6ZnfRM0x9XogSHP0t4fP7AQ0uc/W57ovKb+Wn7GGVM+5U92Fv4AVbbXNe9ZgDAO6RFin79LcJmzccihJlOpXtVCJnDf6Si7rbjYlKrjm0o7dY1li5Dgw1NkiJC8cde2AXmUGXyX/Rrz7VQptevm4+ybhV70CQbaIKPaeXe6O97795JHquideD1RxoIRHsc8XIhs7NOxZ48lWUCJN11TU7xYux51stOQWgp1wpWtWMdzYYoMX+rXSvziEJQU5sqjUykmwxfRFlp9QjXWjQhF68PJQqMumOoZiDlx+UKNYdaY0Cz1I0wv6THgMbLJEahbXEzpFA6fSkQznZuQw0IAinCGf7iT5wvlyDISaapUKn3LPAUAPDCbZHo8FKyZeEtZqlBQPwfrlcj5U0PM08C5fUR2Z7axwj5H+TRZ5VibRxc3deiJ+IwVa2rTreoeN0/Vf9UWHEqqfTUpf2XYtS4dDzWJvbLg1/e/TApA== Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3131.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 105ee715-3004-4307-9a25-08d87ca0dfd1 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Oct 2020 06:56:06.3433 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: CFBSQ9X+ekdBEvB07d0MPgRp/7nFgOY/QBkZDvEyr1lFRMb7sSZYVLQAGyGKgt9jQjwNsBxFhYR7N916GyUHFA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4298 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2 1/2] raw/ifpga: terminate string filled by readlink with null X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: dev On Behalf Of Wei Huang > Sent: 2020=1B$BG/=1B(B10=1B$B7n=1B(B30=1B$BF|=1B(B 8:22 > To: dev@dpdk.org; Xu, Rosen ; Zhang, Qi Z > > Cc: Huang, Wei > Subject: [dpdk-dev] [PATCH v2 1/2] raw/ifpga: terminate string filled by > readlink with null >=20 > readlink() does not terminate string, add a null character at the end of = the > string if readlink() succeeds. >=20 > Fixes: 9c006c45d0c5 ("raw/ifpga: scan PCIe BDF device tree") It is better add Coverity issue number , like "Coverity issue: xxxx ". Missing =1B$B!H=1B(BCc: stable@dpdk.org=1B$B!I=1B(B >=20 > Signed-off-by: Wei Huang > --- > v2: fix coding style issue > --- > drivers/raw/ifpga/ifpga_rawdev.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >=20 > diff --git a/drivers/raw/ifpga/ifpga_rawdev.c > b/drivers/raw/ifpga/ifpga_rawdev.c > index 0385514..f9de167 100644 > --- a/drivers/raw/ifpga/ifpga_rawdev.c > +++ b/drivers/raw/ifpga/ifpga_rawdev.c > @@ -230,8 +230,9 @@ static int ifpga_rawdev_fill_info(struct ifpga_rawdev > *ifpga_dev, > memset(link, 0, sizeof(link)); > memset(link1, 0, sizeof(link1)); > ret =3D readlink(path, link, (sizeof(link)-1)); > - if (ret =3D=3D -1) > + if ((ret < 0) || ((unsigned int)ret > (sizeof(link)-1))) > return -1; > + link[ret] =3D 0; /* terminate string with null character */ link[ret] =3D '\0'; > strlcpy(link1, link, sizeof(link1)); > memset(ifpga_dev->parent_bdf, 0, 16); > point =3D strlen(link); > -- > 2.7.3