From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 44214A04DD; Fri, 30 Oct 2020 07:56:58 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 223F66A12; Fri, 30 Oct 2020 07:56:57 +0100 (CET) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 2B4445F13 for ; Fri, 30 Oct 2020 07:56:55 +0100 (CET) IronPort-SDR: z6IOjTA7BEH8uRyV6XLR+Wfin/MbtUuFyyyaSfDEoPSpP0vy4Y1L079BKZL9pgwoKGm32ZsE6G tykK7lv3en1g== X-IronPort-AV: E=McAfee;i="6000,8403,9789"; a="168698640" X-IronPort-AV: E=Sophos;i="5.77,432,1596524400"; d="scan'208";a="168698640" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Oct 2020 23:56:54 -0700 IronPort-SDR: XSJzRCbtEjsDJRy7GY7cI0DS86YgAXcg8Z95Cdm9a8IQJK1UHxKu6wimU09UCGHa7mxg4FlmiO C6cZ55X0T0OQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,432,1596524400"; d="scan'208";a="351768346" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga004.fm.intel.com with ESMTP; 29 Oct 2020 23:56:53 -0700 Received: from fmsmsx606.amr.corp.intel.com (10.18.126.86) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 29 Oct 2020 23:56:53 -0700 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Thu, 29 Oct 2020 23:56:53 -0700 Received: from NAM10-BN7-obe.outbound.protection.outlook.com (104.47.70.101) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Thu, 29 Oct 2020 23:56:51 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WF1IpgsUWN/METm0uPMDO6utUk58sS6dGFVU2s//td1bNDESABVyz+61WJcI6IPYUnRqXExiiYm1p4Kv9v33OcgKUIqA/BPa0JZJB0VZGku0FvHShAh2o1Rs5A6xhUGNeFML5I9T2+1TSa/JpSy7CC2AEz+EFov0Xim7mq4nt0AJrzPYofvSGGCfqpSokuPN4ZeUtwkSvPAixsWeS/b1SABlrL/fkJzLo3GsbazoPHalzNFkSwWG2ijPpxpcfgLEwnqDrBhh0h4i7ZwMC0SYaguqyUou8Hut/H66hRl4L6HZdUCSS7D2yRrdZH0In2vgqQ7mcSYZtca6g3Q5XFnM3g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=b/lKUXh8OdNv2iPce/P3m8ARS0E0sqgM7SZaOxTUwS0=; b=JEUzsdoMYk/TUgf+RNFUbx3yyGbNYdOABCB+oW221ji1W3lJUW1JstCAVAEtbGsqnSysLsABZ8L/C2FdGdbLaEsKBELLhKBNhNU5kgkUAzuIk8mNsUz60gm30m+oKp59whDkptx3s40T+TmrW/00bErfmZ/6rusGcZfZZ9Ul2HkFDP1NyAdl47W69c42pprFnQppweCidTb1COg8Lx4Lmykrlbwu/nutP2yfNnS5mtSpBBaf6qvu0pmMTQhFE1RDkhHevjs+bV9csUD1KnJ4nnKK/0ES3X82N71mFKHP4sP7NDOGrlQUDAI/xMHyuTfMPTtfEWNyvoFIMd1gLantNQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=b/lKUXh8OdNv2iPce/P3m8ARS0E0sqgM7SZaOxTUwS0=; b=glVmdtcGb9Dd3wxFiAd7P2pVKe8nd3ao+gWF2wWNP0mSLvqrjXC+7CKjtDuv+fuqka+Vlbf4V4eRUqRCXPR61CmSvoXKszv5KIuDa/GJP6YFRndS3Y05NXPRimnRPe2ahlUWFNkfjbTqcf+gPknB5s+XruI0QalVGxVFe5n0dpQ= Received: from DM6PR11MB3131.namprd11.prod.outlook.com (2603:10b6:5:6d::32) by DM6PR11MB4298.namprd11.prod.outlook.com (2603:10b6:5:204::21) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.18; Fri, 30 Oct 2020 06:56:47 +0000 Received: from DM6PR11MB3131.namprd11.prod.outlook.com ([fe80::559e:3d25:c361:c5e6]) by DM6PR11MB3131.namprd11.prod.outlook.com ([fe80::559e:3d25:c361:c5e6%5]) with mapi id 15.20.3477.024; Fri, 30 Oct 2020 06:56:47 +0000 From: "Zhang, Tianfei" To: "Huang, Wei" , "dev@dpdk.org" , "Xu, Rosen" , "Zhang, Qi Z" CC: "Huang, Wei" Thread-Topic: [dpdk-dev] [PATCH v2 2/2] raw/ifpga: use trusted buffer to free Thread-Index: AQHWrlsxFPQFpItVDUaiq/GrBre3LKmvttjA Date: Fri, 30 Oct 2020 06:56:47 +0000 Message-ID: References: <1604017294-23479-1-git-send-email-wei.huang@intel.com> <1604017294-23479-3-git-send-email-wei.huang@intel.com> In-Reply-To: <1604017294-23479-3-git-send-email-wei.huang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.5.1.3 dlp-reaction: no-action authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.206] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 55161cfa-6581-47f1-584c-08d87ca0f865 x-ms-traffictypediagnostic: DM6PR11MB4298: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:1923; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: PXxQ4fVUtgtNdf+WFkkM6t4tGMJ20rELUYkRiuDG/G2mUm3DWwpSYqBNILKzsofymnode8VEZ+ClMyYHwXWbgCXmJKNMcerjfDd1+36KCKgH9rL6HaX9pH+oJfeT23OMK/GhaPpgScslSYRrD3x21LKt3wqGyazKyxoeTJc8xHn3drWQGbsse5wNMw1XoKhQvG9EDrXZByDDmS/eolfEgFAqwdIBuNYc55wtbjsEPbiWII2RhbQ4nAgZ7z/t2tNDYbBghX0ILncCanTk3BiIh9sCx5jUuo76OQTR/erCmsD5zTCdrW1TCXjiIIOOCuii x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB3131.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(366004)(136003)(376002)(396003)(346002)(7696005)(52536014)(8936002)(71200400001)(478600001)(9686003)(6636002)(86362001)(53546011)(33656002)(6506007)(5660300002)(26005)(83380400001)(2906002)(107886003)(186003)(66946007)(4326008)(110136005)(316002)(66476007)(64756008)(66446008)(66556008)(55016002)(76116006)(8676002); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: 3otSpf2wLryBISom1Elw0FurwR2sK+FS5H2cJ6bwtiiyEsliF+JuxNNEjO46+qzZZDXtC+nqpOS0XdjcBlPc2bBVZR4OXiDBIOHRaYA2vEM3ypoQZbTVVaO8n4DDuY09iY57H3mE0hiXAKAsvCRdQ+hDoNgn1tKxzwKJWqg+M8ODah5POKZDec7nOfaskJhYAgmxD+95KVOiFNgCWNdUz1SxI7M+tUlAm2czqfidYXG2F54Eq8u4hzHOcmAgXOTLizsgLhKzOOEVFaQWRRHfB9QOcexApc0UPz3SGvIJuouppObSIQGgJJfkGoa7dG8DD7VijKM7sBNs6j0MDRq2i3gcDy7cwQTQms6hKX5RPGV4INI9S3SMDiO0FDqY5o7oZ7JTscnK9/cn7HwfqMDcWM6Zn06dlpOCDyuK51A2eOff1yd7sf9pesEN/O+BBErVVk95XBvzLH2yHRJtRNXhpbbBiDPL4djnIeDJhki1piQMp8w/4XHxt+nwsdUgUxUPKN3v0nmtYGFUtQOM7f7hU1iFYwA88YbvI28fIAv7VYJFLr3ymzxz611u+uD2ieBOC9ZQUR9arGMFytFvPox9iWK3wqQGSwEmfRVxuS3pE9jHynJCKEv6lLNXRRu0E4lnjrsDHtJiDHPqC0iPDo/yWA== Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3131.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 55161cfa-6581-47f1-584c-08d87ca0f865 X-MS-Exchange-CrossTenant-originalarrivaltime: 30 Oct 2020 06:56:47.5758 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: KFikKpLzMXtLPiHyaU173La+5I1kp6GHPr7/1HgBvGXBNJK/MepKzfGcZhgTcfWe/10uYah5pIPuAgppcKZ9sg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4298 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v2 2/2] raw/ifpga: use trusted buffer to free X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: dev On Behalf Of Wei Huang > Sent: 2020=1B$BG/=1B(B10=1B$B7n=1B(B30=1B$BF|=1B(B 8:22 > To: dev@dpdk.org; Xu, Rosen ; Zhang, Qi Z > > Cc: Huang, Wei > Subject: [dpdk-dev] [PATCH v2 2/2] raw/ifpga: use trusted buffer to free >=20 > In rte_fpga_do_pr, calling function read() may taints argument buffer whi= ch > turn to an untrusted value as argumen of rte_free(). >=20 > Fixes: ef1e8ede3da5 ("raw/ifpga: add Intel FPGA bus rawdev driver") It is better add Coverity issue number , like "Coverity issue: xxxx ". Missing =1B$B!H=1B(BCc: stable@dpdk.org=1B$B!I=1B(B. >=20 > Signed-off-by: Wei Huang > --- > v2: add fixes information to log > --- > drivers/raw/ifpga/ifpga_rawdev.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) >=20 > diff --git a/drivers/raw/ifpga/ifpga_rawdev.c > b/drivers/raw/ifpga/ifpga_rawdev.c > index f9de167..27129b1 100644 > --- a/drivers/raw/ifpga/ifpga_rawdev.c > +++ b/drivers/raw/ifpga/ifpga_rawdev.c > @@ -786,7 +786,7 @@ rte_fpga_do_pr(struct rte_rawdev *rawdev, int > port_id, > int file_fd; > int ret =3D 0; > ssize_t buffer_size; > - void *buffer; > + void *buffer, *buf_to_free; > u64 pr_error; >=20 > if (!file_name) > @@ -818,6 +818,7 @@ rte_fpga_do_pr(struct rte_rawdev *rawdev, int > port_id, > ret =3D -ENOMEM; > goto close_fd; > } > + buf_to_free =3D buffer; >=20 > /*read the raw data*/ > if (buffer_size !=3D read(file_fd, (void *)buffer, buffer_size)) { @@ -= 835,8 > +836,8 @@ rte_fpga_do_pr(struct rte_rawdev *rawdev, int port_id, > } >=20 > free_buffer: > - if (buffer) > - rte_free(buffer); > + if (buf_to_free) > + rte_free(buf_to_free); > close_fd: > close(file_fd); > file_fd =3D 0; > -- > 2.7.3