From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 81F3BA04B1; Thu, 5 Nov 2020 10:36:13 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1BFC8BE47; Thu, 5 Nov 2020 10:36:00 +0100 (CET) Received: from mga03.intel.com (mga03.intel.com [134.134.136.65]) by dpdk.org (Postfix) with ESMTP id E7DB8BC66; Thu, 5 Nov 2020 10:35:56 +0100 (CET) IronPort-SDR: uNvqxuRJfM5dsQyt1574YuueKTYpeCExfKGVtLQ8DHfiRiZpghHpOpwCPHBl6BSEFVFdy71Vj0 +9hTo3ROsdlg== X-IronPort-AV: E=McAfee;i="6000,8403,9795"; a="169463953" X-IronPort-AV: E=Sophos;i="5.77,453,1596524400"; d="scan'208";a="169463953" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Nov 2020 01:35:55 -0800 IronPort-SDR: 5mximfjDjq31dOgocJwtLpT6ajPvU7tl2qW7FMzjkb0EDXixARi7lznFGnGtmXSrjza783ML/A fyYZCI9uy6AQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,453,1596524400"; d="scan'208";a="364285662" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by orsmga007.jf.intel.com with ESMTP; 05 Nov 2020 01:35:55 -0800 Received: from fmsmsx603.amr.corp.intel.com (10.18.126.83) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 5 Nov 2020 01:35:54 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx603.amr.corp.intel.com (10.18.126.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5 via Frontend Transport; Thu, 5 Nov 2020 01:35:54 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.175) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.1713.5; Thu, 5 Nov 2020 01:35:51 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=I2benQEdKiUv8rCVrQDMHbS7UZxT/6tmHHtzE7rcXoreaxPjnayRk0JBkCHZiLy35YSq5AYnkxeOVQZz2m+i4UMuF0OYP5FyztnjcVWljZgpegHunduRYIhaaluBT6wDYXznaDS6X9d6Sd/UCzOx9riJdY2SjIwa2n5QJl8KLEGYyjufQ0KemF3+kmblOjOqMsZ+g1mg7IbqY5amAdHzRYAGiz99Nn9HEINfKE6+onFDueHaltHeNpnves1jgRAcBmjpbYGz+viIeif/qW35HObtrJiDBFOfR2JCb5YiyyPBt80JkQE8WDaJOCciUoLIv9tIE3trX3tBizQsri5n0g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UQVfoq7UF7gxFAdpEJF1kL7HvPYvuPuSJdK15WJU4tc=; b=FG3N0BxAVt64QVMa6H4ectTihbIIgs2ceYArm7n+RQsugWAOgMBo0Ip2AAcowX8ciJMd/wDuzPKGKEgZ1gA8tAYITACy/ksZcME86bJV/8gofS9UpPBcK7GT3CEgdeAR+1NNWeZCdhEzPf3kBS/Sc9McwOchdFhfrp/E3UH5v7/jiKiMY/gE9e8uf2Kp8VfM3o89JMSXvcpdpS5FKQaXW7Lzym0Kz/zsSoqbsYnVDj4qhmOmqaWad1FNGw5KjF+DwIKSnwu7A8kCPZp+2rtXFqUUlfi+UEDYCgU/byI8MdDWCM/iC6p5sfeM3hW44/msI+FJfnwEfrxaXRZRL39lRQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=UQVfoq7UF7gxFAdpEJF1kL7HvPYvuPuSJdK15WJU4tc=; b=an5h9Bb8HOLWc5mWGCjTYdjCUfAPVEmiUiOl/R70Fka1rH51GR56B7RkALJ66T6laUD170Tn5b4xoBSXsFqRb631FF7Hwha6lwH/v8555J4uBU7rLgKTHaKUhaAJr9S+bZQJ9Z5erI44EQMj5gZULOs0Z4+g9F5E+k/wjo2Djuo= Received: from DM6PR11MB3131.namprd11.prod.outlook.com (2603:10b6:5:6d::32) by DM6PR11MB4578.namprd11.prod.outlook.com (2603:10b6:5:2a7::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3541.21; Thu, 5 Nov 2020 09:35:47 +0000 Received: from DM6PR11MB3131.namprd11.prod.outlook.com ([fe80::559e:3d25:c361:c5e6]) by DM6PR11MB3131.namprd11.prod.outlook.com ([fe80::559e:3d25:c361:c5e6%5]) with mapi id 15.20.3477.038; Thu, 5 Nov 2020 09:35:47 +0000 From: "Zhang, Tianfei" To: "Huang, Wei" , "dev@dpdk.org" , "Xu, Rosen" , "Zhang, Qi Z" CC: "stable@dpdk.org" , "Huang, Wei" Thread-Topic: [dpdk-dev] [PATCH v1 2/2] raw/ifpga/base: check pointer adapter before derefence Thread-Index: AQHWsx59aNUYXWz7FUCMtPk8zwde7Km5R5xA Date: Thu, 5 Nov 2020 09:35:47 +0000 Message-ID: References: <1604540969-5503-1-git-send-email-wei.huang@intel.com> <1604540969-5503-3-git-send-email-wei.huang@intel.com> In-Reply-To: <1604540969-5503-3-git-send-email-wei.huang@intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-version: 11.5.1.3 dlp-reaction: no-action authentication-results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; x-originating-ip: [192.198.147.204] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 4da27c01-77c0-40f3-1f99-08d8816e2cec x-ms-traffictypediagnostic: DM6PR11MB4578: x-ld-processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr x-ms-exchange-transport-forked: True x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:854; x-ms-exchange-senderadcheck: 1 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: qluFtOOFVkA+J6ij9loJXcoMr0y279QUZPBEF+6aANhsmd8OcxlGgn45MPE0mWiztTdBf4hh8F5HRwNgtUrZdKJLZAiJ6g97w/58bGSSiY8T128r5KJkbEgHWaFjm3FUqjQax4IKH0FU6Ag0XLITSSmrHzhYiNdurDWxToOeoKwu/hJ3W/VSLz1Iq881ZB7d14fXbgTX3MdDCCGSKyFjTffI78myVHU4N96Rdjy27tNHHRLI56pR4YX4JNy5G6Ms/R4FTETK4+rTipbVLlQ/TSGiL0DGwtbVii/yJ2Tb7dQysi3FKc1sGZf0zKMTFIRS/NSfgjGr4eq2ikttKwCh/w== x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB3131.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(136003)(39860400002)(366004)(346002)(376002)(396003)(71200400001)(8936002)(6636002)(26005)(54906003)(110136005)(478600001)(186003)(33656002)(4326008)(450100002)(7696005)(6506007)(316002)(53546011)(5660300002)(66476007)(76116006)(86362001)(9686003)(2906002)(52536014)(66946007)(64756008)(66446008)(83380400001)(107886003)(55016002)(66556008); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata: zcKU1JjUIJzyV3zL5mZPbXaOXhwvy9/PHlskftGPQR+7jbEedehnXjVBUtWOFcRq5dSIQERg+YrjHwHPul59apSUtvO7xIt2GlCcMxXLTKteHQeWj3ztm9PIpOrfDP58538RBlQlDR4PNU2EM4OAcDIlz4DnM9MCgNG/S8mWcALezk3tbftJo9avad4e4bl0gVPqSatliN46kiyGkSLt9TJU5Vk7KV0zajHU66NyUK0EFGEXpM4MaG5S0JlqdxHhrJ2s8k7SzJ1+r0UFTxBQaBG4Pee5CvZFOVaYhDINAo66iwkF/a/agYX2xpTj7MBsbyhwyBBLO7lqVrILbb8xUkdyLn7VnVIeaHq81dpkwBqzTKPjnhj2znOpSMXJvmUNpxTeil7SKcGHVMQAASMexBTohXY8XakC9PgpwDvoOW6LmFmoOaLOSFs81PVTi8RQTB7EX8WvdJqOai3yEquf62sLiqnMrqZkRYkChnPi/dGStdWncijnVm7LvWSV3hm7e5P2gSByGdUn171mp7EbFaRLODi4ejzYjNsLiEqUagfC1uEzbEdoHkoZx8zJdn1idT7NFAFipAQcz/ucGamZeSaaIYNE2SS6YYVtH5dstmMi37jM4i9moEZJbi41nm13DbHhJWr7A8SnnY3mQ1qUZA== Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3131.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4da27c01-77c0-40f3-1f99-08d8816e2cec X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Nov 2020 09:35:47.1963 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 2hjMt/2qaaZNrKyGKZQmUKNZN69cdAJA8f3dFDHLc5uK2HdWSkgVnkOQz1hW7+TzlyQqITbTuSUmjDflr5fCOg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR11MB4578 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v1 2/2] raw/ifpga/base: check pointer adapter before derefence X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: dev On Behalf Of Wei Huang > Sent: 2020=1B$BG/=1B(B11=1B$B7n=1B(B5=1B$BF|=1B(B 9:49 > To: dev@dpdk.org; Xu, Rosen ; Zhang, Qi Z > > Cc: stable@dpdk.org; Huang, Wei > Subject: [dpdk-dev] [PATCH v1 2/2] raw/ifpga/base: check pointer adapter > before derefence >=20 > In opae_adapter_destroy(), pointer "adapter" is not validated before pass= ing > it to opae_adapter_shm_free() and opae_adapter_mutex_close() which > derefence it. >=20 > Fixes: e41856b515ce ("raw/ifpga/base: enhance driver reliability in > multi-process") Coverity issue: 363752 >=20 > Signed-off-by: Wei Huang > --- > drivers/raw/ifpga/base/opae_hw_api.c | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) >=20 > diff --git a/drivers/raw/ifpga/base/opae_hw_api.c > b/drivers/raw/ifpga/base/opae_hw_api.c > index 600afdea1..d5cd5fe60 100644 > --- a/drivers/raw/ifpga/base/opae_hw_api.c > +++ b/drivers/raw/ifpga/base/opae_hw_api.c > @@ -605,10 +605,12 @@ int opae_adapter_enumerate(struct opae_adapter > *adapter) > */ > void opae_adapter_destroy(struct opae_adapter *adapter) { > - if (adapter && adapter->ops && adapter->ops->destroy) > - adapter->ops->destroy(adapter); > - opae_adapter_shm_free(adapter); > - opae_adapter_mutex_close(adapter); > + if (adapter) { > + if (adapter->ops && adapter->ops->destroy) > + adapter->ops->destroy(adapter); > + opae_adapter_shm_free(adapter); > + opae_adapter_mutex_close(adapter); > + } > } Acked-by: Tianfei zhang