From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0BAEFA0540; Wed, 8 Jun 2022 10:35:52 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9471C40689; Wed, 8 Jun 2022 10:35:51 +0200 (CEST) Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by mails.dpdk.org (Postfix) with ESMTP id 3BC6B4021D for <dev@dpdk.org>; Wed, 8 Jun 2022 10:35:49 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1654677349; x=1686213349; h=from:to:cc:subject:date:message-id:references: in-reply-to:content-transfer-encoding:mime-version; bh=8LXuRbmg451EN1pLpcb2Ap6DdwoYotMxdYnX5vyN3Ek=; b=lAossXHM28oal0OfNu62Lpez5lo/uCGY7F7vjoc3Xx1HtzaElVUYR+V8 aqBvWbmRKNxp1x0O1ZBzyZV8JppJGF077fY6dUKac+a5rDqFgw75yaGcu 12SiN4crDRNEJH8/rkah/6o9D16apeCTN3F0gB6xtN6rl+9bRYE3pPib3 wHwBzye+GUqHza3DJwGzDYLJz0/XK/ofs5yZ4RvxvBrlSuAvlnsmYcufy a9IwzLDyqwFtxXDsfVdgEPCIPCF3SeRynICWJH1T74mOKH6OcwU7bU8HV 43i0zR02Ygw8VM8tIk0ygsh7k02I554rXXIvf9uC1TisLC1hhE2ZV9Y9y Q==; X-IronPort-AV: E=McAfee;i="6400,9594,10371"; a="275580919" X-IronPort-AV: E=Sophos;i="5.91,285,1647327600"; d="scan'208";a="275580919" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jun 2022 01:35:47 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.91,285,1647327600"; d="scan'208";a="648486265" Received: from orsmsx606.amr.corp.intel.com ([10.22.229.19]) by fmsmga004.fm.intel.com with ESMTP; 08 Jun 2022 01:35:47 -0700 Received: from orsmsx609.amr.corp.intel.com (10.22.229.22) by ORSMSX606.amr.corp.intel.com (10.22.229.19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Wed, 8 Jun 2022 01:35:47 -0700 Received: from orsmsx612.amr.corp.intel.com (10.22.229.25) by ORSMSX609.amr.corp.intel.com (10.22.229.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27; Wed, 8 Jun 2022 01:35:46 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx612.amr.corp.intel.com (10.22.229.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.27 via Frontend Transport; Wed, 8 Jun 2022 01:35:46 -0700 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.171) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.27; Wed, 8 Jun 2022 01:35:46 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fKAbBSvBc/FTCzGm3Y1IuxRIsQAAfT4qcanOceXqknVkmmGcKa05TpX5EvtrOD/5XPyKbVtVFcBrJ3RPqnViz6S+V3/tM9iqi8y09REQUu+Iu3BCV/nyZirE8deQKFICqkDBhqpW9Y8T9RbnfZ+F1x1u7qWdpe8JCbpCcyzOxmoDCT7+TpLeXvlC/RFSYDXrpIWL8o6lqqpXKQoyglZy35i/sW8Hcb9p/7EnPj46OoM1kwZF+BUA4cxVI/ijJX6P0Vi7AAUXV9HuLelkLoKjzOtNj8TdbDVgnwlJIuWj48cLEsV3RtqGeHQWROAkmP3Yy9kV+ZGifJ5bJi/sdtMY8Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Y97hyzP9TFE58qfp3j+hdLr384px5okwjXGoGwkBR0w=; b=lNbZqyvYOwfN5VhPqDccTd5GCaYMRL0l7Oo0mZiYYYkusW8kazhJJPIGkDnIxE2+rkaz3Cn5gCw8B2y++Ux5OnFMbIw5tyK/kxURbC5U86XFVLwhceZ92VWyg95g577l7gguaJ1K6aUMldaUEkbdy/xGfxz+A0aaEg15nWgydCUA1+baY/vgRCPGCzxgTpuQpU1bOAeXjxK0DIrYB8ZnBRgbJCj7LyMgw5FzVGCZYTbWs+l4sTjYoIg3W5u4CXLFmsRDZ4otxTWFbXaf922LUM/R2fFSYH6YIJsiACnc4OzfUGE6Xe9+EOr5YWc1c0tSJ+OvgIozoz8eWWMEuwU5Fw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Received: from DM6PR11MB3227.namprd11.prod.outlook.com (2603:10b6:5:5d::16) by MWHPR1101MB2077.namprd11.prod.outlook.com (2603:10b6:301:4d::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5314.13; Wed, 8 Jun 2022 08:35:45 +0000 Received: from DM6PR11MB3227.namprd11.prod.outlook.com ([fe80::d03f:ee8e:a5ac:6817]) by DM6PR11MB3227.namprd11.prod.outlook.com ([fe80::d03f:ee8e:a5ac:6817%7]) with mapi id 15.20.5314.019; Wed, 8 Jun 2022 08:35:45 +0000 From: "Mcnamara, John" <john.mcnamara@intel.com> To: Thomas Monjalon <thomas@monjalon.net>, Stephen Hemminger <stephen@networkplumber.org> CC: "dev@dpdk.org" <dev@dpdk.org>, "david.marchand@redhat.com" <david.marchand@redhat.com> Subject: RE: Lgtm scan of DPDK Thread-Topic: Lgtm scan of DPDK Thread-Index: AQHYch9GUIOHUYDezkq7oa58km6nCq1FPZIAgAABhhA= Date: Wed, 8 Jun 2022 08:35:45 +0000 Message-ID: <DM6PR11MB32273B3A40B7777BE6280609FCA49@DM6PR11MB3227.namprd11.prod.outlook.com> References: <20220527161210.77212d0b@hermes.local> <5572850.DvuYhMxLoT@thomas> In-Reply-To: <5572850.DvuYhMxLoT@thomas> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-product: dlpe-windows dlp-reaction: no-action dlp-version: 11.6.500.17 authentication-results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 67b947ff-01a7-47f7-38ce-08da4929e183 x-ms-traffictypediagnostic: MWHPR1101MB2077:EE_ x-microsoft-antispam-prvs: <MWHPR1101MB20776D393B607F80F4422EE8FCA49@MWHPR1101MB2077.namprd11.prod.outlook.com> x-ms-exchange-senderadcheck: 1 x-ms-exchange-antispam-relay: 0 x-microsoft-antispam: BCL:0; x-microsoft-antispam-message-info: q3GaHQI/g4SPnMU8w9mqKM+7ruKwzqkS3B7v0KcP8HWC8rSGypa8xF/WuMbcvcR80zQ8VI5xYqOIyopSL1+oBRwC/vndtAEbvtEoJw/wwWicc9DJiDttYyhD++mRU/YYf0MqR2/xIHItTV3xibHQhiqZRnN5jVlHBywOeWSVYKQTIjbwCcCdPUhm6Rk60y17tUcgJDlgbmnbvERa6A8DW9fm0Ab5ADd+ATqTfG/OAbsYu0kaVgeTGqzcvHZGJyLQJqFyXYRY9qZKKgSTESmVGW1n7NUYeQWY9q0l2Kzr0QGNvnOP8Gkp645H28s/UCpLjDJOeuvgg2pYaLmDDoQ1XaqV8ruxxG0OctVtLGmd55/lngnlfhObf93wQ3foYAtvRBoarEtCo59uwR8Tu4HYE3bpYejduPowbjoX7y8wvAjlt0wnaeZAaJ8ed/Iork5pSJVUGuf3addJw9M2MeijnhQohWMak5e0oOevYExKhI5nIBPBpkyeNLf9jDbXn4ueeilsCLXNU1iah3QkGN8M3XDnZH+7PezAw/OSkiM/Bi4C4N94yNrCFoIOe7PSzAQUVPlc0718wH6HCYrolPdpKq0lI+kE6hehqrZ1Iy+6zLG32qvfYN6beVha374XtE596Ebg1nWZ0u1QbcSmYo/sG4UxUgSuuBM5rzv6kBejXsrDseK2LC16NAFhenaPL/mkai1WRidxtj78Eudwz2pMoUStAf586Wf4blwt80/HnXmWa91Ne9Yz5TwyzHQ/7gO2c07rBg6bmYgHlaTTaG3k+ec+t3Y2Z1pb95ij1OCimMU= x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR11MB3227.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(54906003)(53546011)(7696005)(3480700007)(71200400001)(38070700005)(966005)(186003)(76116006)(66946007)(8936002)(66556008)(5660300002)(52536014)(508600001)(66446008)(66476007)(4326008)(64756008)(8676002)(110136005)(6506007)(55016003)(82960400001)(26005)(122000001)(33656002)(38100700002)(2906002)(316002)(83380400001)(86362001)(9686003); DIR:OUT; SFP:1102; x-ms-exchange-antispam-messagedata-chunkcount: 1 x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?dchTi1MvmJ1QDv3F68cgukM7NgtJ+HUNk1WnqsVH4R6jLMQPmNzAly2g25x1?= =?us-ascii?Q?9nUgQ3ALwAUJIjpPLaS46CoWCbI4fuRL5/ChKQ6VG7fmbEgU8lTa4l8QLBBc?= =?us-ascii?Q?pyf6thxQX+jZ6my3xPW6IynvL39z5PxRyEdsXoG4ZDr0t5vxFeXzIo16i0I2?= =?us-ascii?Q?GEzDLJnZZmfPShFQvAU8dLXaqjuGQPZjZWrCXWPy0tQhHKxEM+gOJfkt6WLk?= =?us-ascii?Q?vuWfK3LasenXsfzYFCt7z9RvLhjkkA1Cd7ijOZzlTEDLRSlg9svxWjQuvF9w?= =?us-ascii?Q?nWLgzoUaLUy6/suILncszb1f/Xydozi4c0VQjVm1R8vq/kRE+Sir0Au4pdLG?= =?us-ascii?Q?Z4PKfzTlDDFVnjsJYOvNbY6KarbwlZ3s7uF7668IxU0WDYvqeaCndS0w8YF0?= =?us-ascii?Q?KiFvyk2jjEW8c3wCoEmUds/YtquodYJ83w9LmUBNGepaT8HOULH+fOi6IWWA?= =?us-ascii?Q?7DuAeJ4Qvmw99TDpfdBN3IfAiohfP9x8KbsuwVxfiqOUP7ekmW9M6k1lSB45?= =?us-ascii?Q?uCay31gR56QmJmM2VwbNyz3xv2FwoI9SQMP7zWPcAaMIAZeu+OGAR9t1HGEd?= =?us-ascii?Q?r7nEq5bHNg0QbZLJuTpgLxoDXCIzleWyzOoanya0/slKP1mcqZYQeQaekV/t?= =?us-ascii?Q?Lh1XxB1qXOIV++LQB5RJjhkPlnnOSR6OJgQaTb9tiVBFEWbNXdnTi2rdcmmZ?= =?us-ascii?Q?Yy5nig116JwrE2KzsHlg5+adkxbEW3Cc5/x39gfjGtBAyFTGk5zEWlIMuAoy?= =?us-ascii?Q?Os1a1hFvb2FpjJFHMtOJeqlsBclfm+fgWDrGUC7UwRludZkXVW8fjP7oOVdf?= =?us-ascii?Q?ZdFz9cWIHm56RKx0Va8LXa6uqwtHsb4OpsuY8O4P675YfECjm3oRY6p0PGLJ?= =?us-ascii?Q?lCeWwDsrTgY3yipjXf2o0LpoVRj7ctm1web9e8+TTc+SRGb+QxWV8KqSYlr/?= =?us-ascii?Q?UE6PhlxDVQBa2ym+6EAQEwfp0xNuz8rOAH6Fq4F8EsjSYPws8MwOblni/ko3?= =?us-ascii?Q?0K7GNjCjymUl5Zsnm9bPU9Po7ELOJvw2ZnsxbwLbgPWCL5jPjt7stF2fYi1W?= =?us-ascii?Q?s59+XRHDVcNeuLHubZL+BOSs75+5D2OlUsR50DwCZ4ogFsPSfCo3gTzCOiBt?= =?us-ascii?Q?XR0z+KctVqlVSDz01UUdezmrCVXUzy7F4I2fbpmb4YF/yiT5sgPOhiwFek65?= =?us-ascii?Q?skuGlJYtXU/H/W2SgQsVfNP9YKc5QNR7w9aIZbxUYLyYsneRrxPSSs5PmcK7?= =?us-ascii?Q?HnI9TXJmTMHJ+HRIJflaEVsqoX6s9aMB3lfU5lYjbbpltYQL/NxjFtNqkJa4?= =?us-ascii?Q?n1/zANSIW6rsah9sRx2pKr751NYT50oGZHqceTh/d0OeJFZrguIW1BHO/DST?= =?us-ascii?Q?4p43VCejViVi1Mdc0SoAL7swxQoth131/L7lenC5Yj+7aJxM0B8kOxtNhFtK?= =?us-ascii?Q?fRUc0a01YeFjOnhA98LOpIEOxqdU1pUYWGkTR0VGpn7kGgehEmJyzC+kD91B?= =?us-ascii?Q?1HKm9z5EVU74FDAL9CQXa6TXm8ttqv5VPuXC8UCaCiLgL0uDpUTHY28CYki7?= =?us-ascii?Q?mpO6Y6oT2Ygsq/rxz/CHk9ZG2lCy8zxW2QCBfipPIkC/UD81Jk3CHs745l5R?= =?us-ascii?Q?98D/trvorhSP2T6uPii1u5D1psnn9yk17E44XCyzBG2bGIqKW1cZfj4BcJ3P?= =?us-ascii?Q?8H3cdiJhJxqaswWpNOsPx0ZQyQUWO23VJenJP/Wj8DaOKnjf6ET+j5Oi+V5d?= =?us-ascii?Q?sDDuitdaonIKT25VoX5BI0uXRe251q0=3D?= Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-AuthSource: DM6PR11MB3227.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 67b947ff-01a7-47f7-38ce-08da4929e183 X-MS-Exchange-CrossTenant-originalarrivaltime: 08 Jun 2022 08:35:45.1837 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: 2y8KRS5a5lqMi8wWU+lLIcS/nXSYiquXdLAAgGeMV62WDx95gRvs47OjKMrSixwdV1uYw1cbCpkICTimV58HEQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1101MB2077 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org > -----Original Message----- > From: Thomas Monjalon <thomas@monjalon.net> > Sent: Wednesday, June 8, 2022 9:23 AM > To: Stephen Hemminger <stephen@networkplumber.org> > Cc: dev@dpdk.org; Mcnamara, John <john.mcnamara@intel.com>; > david.marchand@redhat.com > Subject: Re: Lgtm scan of DPDK >=20 > 28/05/2022 01:12, Stephen Hemminger: > > I just discovered that there is another tool similar to Coverity for > scanning. > > It gives different results, and might be useful. > > The scans of github open source projects is already done. > > > > See: https://lgtm.com/projects/g/DPDK/dpdk > > > > Shows 19 errors, 263 warnings and 111 recommendations. > > > > Of course, some of these are bogus. For example, tool thinks are script= s > are Python 2. >=20 > The problem is that we already invest some time in Coverity triage to mar= k > false positives. > Can you check whether this tool has some false positives? We looked at this tool a few years ago.=20 Some of the good points were: * It is automatic and runs independently=20 * It did find some genuine issues * Issues have the commit ID associated with them so you could assign them= to=20 One of the main disadvantages was: * False positives can only be marked with a comment in the code Nevertheless it is probably worth folks evaluating the issues in their own = areas of code and in particular any of the Errors. John